From owner-freebsd-net@freebsd.org Sun Aug 16 09:11:19 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A5E373B6122 for ; Sun, 16 Aug 2020 09:11:19 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BTryH28PWz45VJ for ; Sun, 16 Aug 2020 09:11:19 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: by mailman.nyi.freebsd.org (Postfix) id 49BA03B5F6E; Sun, 16 Aug 2020 09:11:19 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 485063B5DB1; Sun, 16 Aug 2020 09:11:19 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward100p.mail.yandex.net (forward100p.mail.yandex.net [77.88.28.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BTryF1JHhz45K0; Sun, 16 Aug 2020 09:11:16 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mxback5o.mail.yandex.net (mxback5o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1f]) by forward100p.mail.yandex.net (Yandex) with ESMTP id 60F0E5980AA0; Sun, 16 Aug 2020 12:11:13 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback5o.mail.yandex.net (mxback/Yandex) with ESMTP id vVkjuFWMb4-BC1CTeWA; Sun, 16 Aug 2020 12:11:12 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1597569072; bh=o/z/5CHexTyLBP4oABBLEnXWERyC9STzRW0zzwHcgoY=; h=Message-Id:Date:Subject:To:From; b=oisyVs954X7jSXpIWaHdLhWtTIqbQ7gZGCdGF2b2eEWFxejrGHUkKP8Dgqj6Rf+UN LO0cAA0MYyMZ9DIj4WVZ83E0JdrHziwWA0gVqYBpuAk47JAHbfjRhG8cWVFUrUVnGJ 6+mccpGwa7/RZKN8/iQmPxxLi94QTb9N4wa3vqmM= Received: by sas1-6059effbd848.qloud-c.yandex.net with HTTP; Sun, 16 Aug 2020 12:11:11 +0300 From: Alexander V. Chernikov To: net , freebsd-hackers Subject: ip(8) in base MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sun, 16 Aug 2020 10:11:11 +0100 Message-Id: <1634721597568903@mail.yandex.ru> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597569078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=o/z/5CHexTyLBP4oABBLEnXWERyC9STzRW0zzwHcgoY=; b=Yhnu03SG5DqUDkmnlBTl2GGbx0PDFfxtPyBEndJ+OxK7bv4qm01D6RirMveSdW7GNHJZMU MvTY3AuTmv9TmcaZz4Zfh0cYhiU4Tv8XEwRxSd72XQj5HSuE28WUltKfV76iiwbJwsDAjQ QS7LVKN5LKZT7bJUkvfKMpZfM12UFNMYxjBpVOWcsoJ77G5wcjIpgwUjtBgxlEWONPf+H+ zyO7ZmWeh66ZcaQoR+V199iJ1N8UGZbOy6vdkanXOA+bj092sC2JiZxf9NlEV9hePXDcuU VRgr/ZwGmMNxnJT+9MP8SUH/9rvMmPNMkVJY5OciBTWkja5pAeHzUP5dSkh2vQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597569078; a=rsa-sha256; cv=none; b=nOAf8wJw1HF7O2T+KIl5SBnRuvZEGbV1JmkT+fXmfmM/1ozzxuEGqqp4LB3WQQ2QRTZYhH 8xiU+YYnkxqZb7WVT1CCoDuB6oIaMflVZ2R5sVg263TdAKAoyOIhzKXcIM6phHs3JyMAwp hQ1Sv1kfCGrnaa9DGM8lEMpSACpApisdzK5ZfG6p+Sz04NOVEvzc4rnKgj0ED+p0saczl4 M34ocPnPW4HhJXVkaw5CiKd7p8v4tPcWOG65bpUjQ2wOQryZHNXoI4Pa1dbD7ewwsaeAjS ffh3cSUpwmNIK5k0icSCHtYR9qn+TVe/Eqmhh1VK9wmsYYcsGQ3aiQC18zvkZA== ARC-Authentication-Results: i=1; mxback5o.mail.yandex.net; dkim=pass header.i=@ipfw.ru X-Rspamd-Queue-Id: 4BTryF1JHhz45K0 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ipfw.ru header.s=mail header.b=oisyVs95; dmarc=none; spf=pass (mx1.freebsd.org: domain of melifaro@ipfw.ru designates 77.88.28.100 as permitted sender) smtp.mailfrom=melifaro@ipfw.ru X-Spamd-Result: default: False [-2.93 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.07)[-1.073]; R_DKIM_ALLOW(-0.20)[ipfw.ru:s=mail]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:77.88.0.0/18]; MIME_GOOD(-0.10)[text/plain]; ARC_SIGNED(0.00)[i=1]; DMARC_NA(0.00)[ipfw.ru]; NEURAL_HAM_LONG(-0.99)[-0.995]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[ipfw.ru:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[77.88.28.100:from]; NEURAL_HAM_SHORT(-0.36)[-0.362]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13238, ipnet:77.88.0.0/18, country:RU]; RWL_MAILSPIKE_POSSIBLE(0.00)[77.88.28.100:from] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 09:11:19 -0000 I want to introduce ip(8) or something similar in base. Basically, I need some userland tool to explicitly operates on nexthops, nexthop groups and fib lookup algorithms. The existing tools are not well suited for the job: route(8) may be a candidate, but (a) it would either add another bunch of options or drastically change the tool by introducing [route nhop add], [route nhgroup add] and (b) listing is traditionally done by netstat(8). I feel like there is a need of some cli tool that provides the ability to easily extend it by having separate namespaces for each sub-command (hello, ifconfig). Naming is hard. I can, for example, use "rt" as a name to address my use cases. However, given the kernel interfaces for managing nexthops/nexhop groups are the same as with routes/arp/ndp, why not spending some additional time and support operating on routes and neighbors and name it ip? Though, that arises multiple questions. Are we comfortable with ip(8) as a name in general? If we are, what’s our take on having the compatible interface with Linux ip(8)? Any comments/feedback is welcome :-) Appendix List of commands I need implemented cmd [-46m] nhop create [gw XX] [iface YYY] [mtu YYY] [reject] [proxyfib Y] [fib X][ipv4] [ipv6] cmd [-46m] nhop delete nhop_id cmd -46m nhop list cmd -j nhop list # json cmd -46m nhgroup create nhops 1,2,3,4,5,6 [fib X] cmd -46 nhgroup create nhops 1=100,2=100,3=200,4=100 [proxyfib Y][fib X] cmd -46 nhroup list cmd -46 nhgroup delete nhgroup_id cmd -46 fib algo list cmd -46 fib algo set algo dpdk_lpm6 fib 0 cmd -46 fib algo set algo auto fib 0 /Alexander From owner-freebsd-net@freebsd.org Sun Aug 16 09:18:00 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 17E7A3B6595 for ; Sun, 16 Aug 2020 09:18:00 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BTs5z6bz3z45x5 for ; Sun, 16 Aug 2020 09:17:59 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id E0E6E3B6526; Sun, 16 Aug 2020 09:17:59 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E09733B6525; Sun, 16 Aug 2020 09:17:59 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BTs5y6CHmz45x4; Sun, 16 Aug 2020 09:17:58 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x341.google.com with SMTP id t14so11466424wmi.3; Sun, 16 Aug 2020 02:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Tvor/pJI0NFiTATQB+TzIhr9DMnWd54hn7dpbR1vUBQ=; b=thECqJ1t9S9c9YZdkzI9X7fW2Ayvf4LtvfJcN0tZQ8BdDpNeh4Lyp8ile5V1v6gxiX PFLB+H76qpblpNm/T01VMdUjRcV4wnofD/hfRLKJ/JEJRBs8b9H7hN10BA12huBSdQrT sXCRuFDJG75CjoG+S1SmtMInF459vgbZzBdHIcb/I/VNtPUZQB4Sl/QmfXIuBjUrWUF/ QylLxjHWpd0gcDc24A+uxAw5WkBw6FwGkPPfEU81Ea6OkvOBzNmx5PPxpT0nGDr5HqDB x5W/89jpB7gj8EeYOY5YV8T+Vsi3Rbr7o0M9pdfPwl9s9uwEB4ybMwm1FGNC4WYgPHb8 sRrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Tvor/pJI0NFiTATQB+TzIhr9DMnWd54hn7dpbR1vUBQ=; b=iGNSDleBDtr74P+/B6ZFAfhrpVTy8a8IfXRBrlC1BcdME88roAlZGdzI1889RNe3Lv vRhYxGfB/Qt+v1hYFDqllzXx0ErErUg+4s4VKr2qnBmdaFreOvwzI4bAEPBAZKgUyJze Vfm7rAihCk2ienWFTP5x1NsnANg9lamT12PJMRFhKQv6HBFyzw2NmUnljM9W+x75XMft net7BLARyixwxyLL3mowMdf/ijG5YYvrthALVya5oFgf1PqttVVBh3opl4WiNVv/tDei VITr/B2NVyKr2vV7ErdmAl5klJAOpOOeCs3dzqGNdgHU0cF4s4XQaM3vhSrj4oiVNOoP jaUQ== X-Gm-Message-State: AOAM531+BeoE5j2GVgLb+RxmGsn1W4T+d7EzJnaTzVsDgIPdCTnh8mh/ oM+Iw4HZXeCmp5ZiGFGRtS5pN5h2zhfgsAbSzAKmgY66 X-Google-Smtp-Source: ABdhPJyB9m2KxTPwhHjgK5SjV4LPca0PmJpgraGDsGgp3iZOAOTdh61ASCp/PeO/2bWCDPy/85/SezIM9sBOMZg+QcE= X-Received: by 2002:a1c:790b:: with SMTP id l11mr10313957wme.127.1597569476808; Sun, 16 Aug 2020 02:17:56 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5d:614c:0:0:0:0:0 with HTTP; Sun, 16 Aug 2020 02:17:55 -0700 (PDT) In-Reply-To: <1634721597568903@mail.yandex.ru> References: <1634721597568903@mail.yandex.ru> From: Mateusz Guzik Date: Sun, 16 Aug 2020 11:17:55 +0200 Message-ID: Subject: Re: ip(8) in base To: "Alexander V. Chernikov" Cc: net , freebsd-hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597569479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tvor/pJI0NFiTATQB+TzIhr9DMnWd54hn7dpbR1vUBQ=; b=vO2Gj18iTvYnYxkwgN70p9xtdLh1P9xPoo5TSEwv9ufDw66qrsp4JlrQ/NBY4Pb+BDoEgc OMCe8SkWdl22YvlbJ654uFz/c2JH6jqqLcN3fcVr+UhFxJB71KikWVNpDNsXzgcZhaPwir sLLQIgdpY2cDPStObQmj1uQwvRa7j/T1Qqn7DgLht38pRuRGzGmYdlDkGdt1wzxnXafDTX AsV0bXjXE5k3xzouxheHCRHsu2R+7kiWV81wVd+zZx653x8qYwShkNNW3lP7mER5w0EpPQ 7uDMEoH34C6QgHwpm2COv/oM/m9C5GpJ27vDIKR7wDwBONxsJeX1cTZlZmE6eA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597569479; a=rsa-sha256; cv=none; b=AwFsKelL95/0+TvLh+WFoTiZg46S2aYQylCvA3nIRAhC8bukFohKRWzA1X1wbvU0OPj/fX fHGUE5onnYV77Y2j9HmCA3PYkQcC35tXRypA550Fs3loSkNdBzlVFyfmSTS/J7XZ4w7Zlu 07eSMfm5IHBduFuv06rl9aRarVPPN1oJe7xTEVPUeLEN7tXGzBN5N4qDmNJnlnDPWx4FJJ B3J1UPqwvu1HWdkK3xf0OBmOKu8S9IzfSLpQGHEZWXddfKkuVU/QcDtyOMHsrHVTFszbbW enTAhaLWxD2wF2CHd2msaof4GTNhpwfAOkqUgvgNYg6OwHx03hXF4BJtJjCwNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=thECqJ1t; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Rspamd-Queue-Id: 4BTs5y6CHmz45x4 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=thECqJ1t; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.48 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.07)[-1.069]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; ARC_SIGNED(0.00)[i=1]; NEURAL_HAM_LONG(-1.02)[-1.024]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::341:from]; NEURAL_HAM_SHORT(-0.39)[-0.389]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 09:18:00 -0000 If you are not going to be compatible, use a different name. I don't have good ideas, but something in the lines of "netctl" or similar should do the trick. On 8/16/20, Alexander V. Chernikov wrote: > I want to introduce ip(8) or something similar in base. > Basically, I need some userland tool to explicitly operates on nexthops, > nexthop groups and fib lookup algorithms. > > The existing tools are not well suited for the job: route(8) may be a > candidate, but (a) it would either add another bunch of options or > drastically change the tool by introducing [route nhop add], [route nhgro= up > add] and (b) listing is traditionally done by netstat(8). > > I feel like there is a need of some cli tool that provides the ability to > easily extend it by having separate namespaces for each sub-command (hell= o, > ifconfig). > > Naming is hard. I can, for example, use "rt" as a name to address my use > cases. > However, given the kernel interfaces for managing nexthops/nexhop groups = are > the same as with routes/arp/ndp, why not spending some additional time an= d > support operating on routes and neighbors and name it ip? > > Though, that arises multiple questions. > Are we comfortable with ip(8) as a name in general? > If we are, what=E2=80=99s our take on having the compatible interface wit= h Linux > ip(8)? > > Any comments/feedback is welcome :-) > > > Appendix > List of commands I need implemented > > cmd [-46m] nhop create [gw XX] [iface YYY] [mtu YYY] [reject] [proxyfib Y= ] > [fib X][ipv4] [ipv6] > cmd [-46m] nhop delete nhop_id > cmd -46m nhop list > cmd -j nhop list # json > > cmd -46m nhgroup create nhops 1,2,3,4,5,6 [fib X] > cmd -46 nhgroup create nhops 1=3D100,2=3D100,3=3D200,4=3D100 [proxyfib Y]= [fib X] > cmd -46 nhroup list > cmd -46 nhgroup delete nhgroup_id > > cmd -46 fib algo list > cmd -46 fib algo set algo dpdk_lpm6 fib 0 > cmd -46 fib algo set algo auto fib 0 > > > /Alexander > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " > --=20 Mateusz Guzik From owner-freebsd-net@freebsd.org Sun Aug 16 09:21:27 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D56C3B664C for ; Sun, 16 Aug 2020 09:21:27 +0000 (UTC) (envelope-from andrnils@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BTs9z0YFwz46ZF for ; Sun, 16 Aug 2020 09:21:27 +0000 (UTC) (envelope-from andrnils@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 12BE13B6894; Sun, 16 Aug 2020 09:21:27 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 127263B67E1; Sun, 16 Aug 2020 09:21:27 +0000 (UTC) (envelope-from andrnils@gmail.com) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BTs9y1bG6z46lY; Sun, 16 Aug 2020 09:21:26 +0000 (UTC) (envelope-from andrnils@gmail.com) Received: by mail-lj1-x22b.google.com with SMTP id h19so14257571ljg.13; Sun, 16 Aug 2020 02:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bMZNoq39ct+BuitStudbsOsM1LKKdAny0o1ObONH2fA=; b=ii35ywf8tjNiJ5v+Aer8yg58H6M4ApkDknejFkIenmty/dTQK16czqIOEgIR4OS2Ta IalEPXHMIa/xDUkPSmEJL6y3D9kMy0HGzYclzN3qgMRtKxBAPTcvbwookBTHJdcBdDgV fTjPPNyZR+3lKZClX9mCeuCFwbfW+VVeAvnODxiPHcjyS0xE+9GKSkKF3q6P5EGUpr5o IdGcnvh2QBQm5dkB9GIa42eVEQFIOllj4FtduGOJY9bevJuXDD5e0ikie1NiH+oPMv6B pzcDA+Z96z7GOiGJeGk8LSW+NGQ78CsM3e/+SdfyBPoJQ1GdE7G9WGL7ibUD8wZUZeN/ ALKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bMZNoq39ct+BuitStudbsOsM1LKKdAny0o1ObONH2fA=; b=qF+BGVwg1LqCAXKxpD3yTw0QRXjp+WFeoq+223mgGifVtYOhLQrczygLnbhzRXQT1T tu/Ruk8gveMWpMZ3CmEiGfdSoW255oRg3rXUz9imS8HEUdN5X04EHYZ0ojDhjs6w3oOm IPXpMcjYykHXXn5xKLrHfD1HQYNnE8OTE+p9tZIskpm5An9keKHvfYS9KXTbZyXzf7cP hU9V+y2HxIh5XyzKlHn0Hp7Unqjq0uuWrXfFI+PJeL0tLyhrifwMGLq3GnKp7yOyfd9F cTL/436l3LbcPyuB+Eyewcn2WeO0gVFjt1lh+dCBhyIgs5DJzwJGxxBghKjuThvO/q90 goIw== X-Gm-Message-State: AOAM533z+zDCrEMV7lU4Y1Vt5/o3/Jr7ojSwL5Ay0PSGkU6R1CIU6w6c FK0zXSPBA/WBLWA8dUg4rLPfvCXO545k9/uh8jc= X-Google-Smtp-Source: ABdhPJy3joFX0k+CTTMOsgLQ2l70e2Z3zp6rjIQwqe58ma4Z72CQXcn8N36LPDo75y7CbEb03lBxqHTn7z1Mv8Y+e8A= X-Received: by 2002:a2e:900d:: with SMTP id h13mr5343911ljg.426.1597569684308; Sun, 16 Aug 2020 02:21:24 -0700 (PDT) MIME-Version: 1.0 References: <1634721597568903@mail.yandex.ru> In-Reply-To: <1634721597568903@mail.yandex.ru> From: Andreas Nilsson Date: Sun, 16 Aug 2020 11:21:14 +0200 Message-ID: Subject: Re: ip(8) in base To: "Alexander V. Chernikov" Cc: net , freebsd-hackers ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597569686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bMZNoq39ct+BuitStudbsOsM1LKKdAny0o1ObONH2fA=; b=T7/UK3HqJz1KvyQUdpsMDhYq3HLEnnpPF8F70Hn1+FRVbf+T/z5p1dtRWFNg1J5aD9rgmn GKOn6Si1f2HjSuHi/YniWVbqB7uA2Tsruk6Kr1JjneNppfJIsAdmnRx8NUp5nhTUcl81xm aK6P7j600GiaAqhQAKVtTvV9e15vJThfHzeATodmResknY+a0f0EXTv+1AASa1kjeXGq34 r5SgFrNcVq0Ep+JQSKSAdkcL9bYaLWyYEnFVkJtDjwprgjR2UnLDMNkGo+Y1C9NKwggoiJ IKmC9jVZbefSA/1fG91kb/ZoDHDmi8cw9dYHd0FXfBuhGR6d81IbkqAyqFAEgg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597569686; a=rsa-sha256; cv=none; b=oTIf/k5whbHCtu9nD2cqHTm5+zOqqaOd+KTuVb6rUfUXOFo+wBUK3wF0u1tmQpJfjpiZ2P cRGqbB5Ccl4rwp+hnwhAmwdBPr45Br0HyCMxts+yISjuIhG4O7yYOpu3ioN/JJBbXYKjpP 3S2gX1geanbOgq2wOMJOMQZEpIgZG47BcMoTxSFR9wt9Jn5ys/i6iTBBPiEOz0nORLmGiS 6lBsZ/IMGIQChMt9vbf8TCD0v7hz4JC6eJAeIj/lk+gjHvaJcDW0FGL3H4cIMqZG6n1fVt mJnAHreba8Wsp6YZuzrOGE6+utqT1vmj2eEDhEJ0YxQmyD5hDKXz+txDfPceUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ii35ywf8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of andrnils@gmail.com designates 2a00:1450:4864:20::22b as permitted sender) smtp.mailfrom=andrnils@gmail.com X-Rspamd-Queue-Id: 4BTs9y1bG6z46lY X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ii35ywf8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of andrnils@gmail.com designates 2a00:1450:4864:20::22b as permitted sender) smtp.mailfrom=andrnils@gmail.com X-Spamd-Result: default: False [-3.55 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.08)[-1.080]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_SIGNED(0.00)[i=1]; NEURAL_HAM_LONG(-1.02)[-1.025]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::22b:from]; NEURAL_HAM_SHORT(-0.44)[-0.444]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 09:21:27 -0000 On Sun, Aug 16, 2020 at 11:11 AM Alexander V. Chernikov wrote: > I want to introduce ip(8) or something similar in base. > Basically, I need some userland tool to explicitly operates on nexthops, > nexthop groups and fib lookup algorithms. > > The existing tools are not well suited for the job: route(8) may be a > candidate, but (a) it would either add another bunch of options or > drastically change the tool by introducing [route nhop add], [route nhgro= up > add] and (b) listing is traditionally done by netstat(8). > > I feel like there is a need of some cli tool that provides the ability to > easily extend it by having separate namespaces for each sub-command (hell= o, > ifconfig). > > Naming is hard. I can, for example, use "rt" as a name to address my use > cases. > However, given the kernel interfaces for managing nexthops/nexhop groups > are the same as with routes/arp/ndp, why not spending some additional tim= e > and support operating on routes and neighbors and name it ip? > > Though, that arises multiple questions. > Are we comfortable with ip(8) as a name in general? > If we are, what=E2=80=99s our take on having the compatible interface wit= h Linux > ip(8)? > > Any comments/feedback is welcome :-) > > > Appendix > List of commands I need implemented > > cmd [-46m] nhop create [gw XX] [iface YYY] [mtu YYY] [reject] [proxyfib Y= ] > [fib X][ipv4] [ipv6] > cmd [-46m] nhop delete nhop_id > cmd -46m nhop list > cmd -j nhop list # json > > cmd -46m nhgroup create nhops 1,2,3,4,5,6 [fib X] > cmd -46 nhgroup create nhops 1=3D100,2=3D100,3=3D200,4=3D100 [proxyfib Y]= [fib X] > cmd -46 nhroup list > cmd -46 nhgroup delete nhgroup_id > > cmd -46 fib algo list > cmd -46 fib algo set algo dpdk_lpm6 fib 0 > cmd -46 fib algo set algo auto fib 0 > > > /Alexander > > Seems like a good cli util to have. I personally don't like the name ip, to generic, and conflict with ip in linux. I think a somewhat more appropriate name would be ipctl. One might also look to naming and perhaps functionality like opensolaris had, with dladm, ipadm and so on. Best regards Andreas From owner-freebsd-net@freebsd.org Sun Aug 16 13:30:30 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5CC3C3BC027 for ; Sun, 16 Aug 2020 13:30:30 +0000 (UTC) (envelope-from peter@libassi.se) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BTyjK23hHz4MkY for ; Sun, 16 Aug 2020 13:30:29 +0000 (UTC) (envelope-from peter@libassi.se) Received: by mailman.nyi.freebsd.org (Postfix) id 44ED13BBFD7; Sun, 16 Aug 2020 13:30:29 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 44AA33BC085 for ; Sun, 16 Aug 2020 13:30:29 +0000 (UTC) (envelope-from peter@libassi.se) Received: from smtp.outgoing.loopia.se (smtp.outgoing.loopia.se [93.188.3.37]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BTyjH0rlyz4Mm8 for ; Sun, 16 Aug 2020 13:30:26 +0000 (UTC) (envelope-from peter@libassi.se) Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 795C910C8E24 for ; Sun, 16 Aug 2020 15:30:19 +0200 (CEST) Received: from s500.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 5A36D2E34C8A; Sun, 16 Aug 2020 15:30:19 +0200 (CEST) Received: from s475.loopia.se (unknown [172.22.191.6]) by s500.loopia.se (Postfix) with ESMTP id 554B41E1461D; Sun, 16 Aug 2020 15:30:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s498.loopia.se ([172.22.191.5]) by s475.loopia.se (s475.loopia.se [172.22.190.15]) (amavisd-new, port 10024) with LMTP id ZOyhxJozMuWl; Sun, 16 Aug 2020 15:30:18 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: peter@libassi.se X-Loopia-Originating-IP: 78.82.159.46 Received: from [10.79.0.17] (c-2e9f524e.03-77-73746f30.bbcust.telenor.se [78.82.159.46]) (Authenticated sender: peter@libassi.se) by s498.loopia.se (Postfix) with ESMTPSA id 9074F4708DB; Sun, 16 Aug 2020 15:30:18 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: ip(8) in base From: Peter Libassi In-Reply-To: <1634721597568903@mail.yandex.ru> Date: Sun, 16 Aug 2020 15:30:18 +0200 Cc: net , freebsd-hackers Content-Transfer-Encoding: quoted-printable Message-Id: <3FFD7C38-8B9B-4A91-BFA9-79B4D639782F@libassi.se> References: <1634721597568903@mail.yandex.ru> To: "Alexander V. Chernikov" X-Mailer: Apple Mail (2.3608.120.23.2.1) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597584627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b2pVIIaw+/27TAt4QNMrAHMIKiD14MxjcAn6uHbpQk4=; b=oMCyZsCecuXuemGlzh/lKwgpz7/ly4YmvkKTLRQNo6SbnGRX6jb5WxT/mj0SeFm1JW5zKO +Zj4rMlEC8hKJKtkZ8wMsDqxZp/n9G9rly34HjnPXbJzCusuHdKW6l84hZse69Ep2Y2YJD HRPjfb55UEYFB3P3oCj2QJpz5Sj7SGzjAT+qiNJmTh0M9G8pNL+VUOzV8dTcqgjceUUuHL o+kFeVNZHut16uu0X4HyoqSHQ67mFFtTDBBSpGL47Qcnd7Y09NP24iafIQpXdLUupxmtK7 HmRyKfG9rTo0hZ+F/jRuNpp8AK5EVp+pYoSoI4AvLj9uenL+NMXgwfy0YJlEEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597584627; a=rsa-sha256; cv=none; b=kR9AqedM/zAFk9E2snuRKsJpVDyYWzpaZrAKW6by78L2ITmlVDTK4YZqsHNgINRcFncNV7 Y8tCPIxgQRXdLnx4n4hM5innIlRNm9MgZBRz4JRN+b9hnGjmG5BeF5QFDXdL62TGlf4Qjf xRRkNcuZSFzoiS5RGynvgEtiuUIiCVi8VwFQm+CBVlSXCIWmMdOCbDGqPmRHXLrcVOtxel N25vOzhjVe1guS3iAknkhN2ObKZujiU8fBJxvOee1pSgNWj7NP0Wp3HnYCMjskmSH5M8JM N6+KuLKDDQNJMe6wo3Qty+FdVLsQJUJKndpJSMMA0oiAPQ04Bzwd9H9P7pQ8AA== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of peter@libassi.se has no SPF policy when checking 93.188.3.37) smtp.mailfrom=peter@libassi.se X-Rspamd-Queue-Id: 4BTyjH0rlyz4Mm8 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of peter@libassi.se has no SPF policy when checking 93.188.3.37) smtp.mailfrom=peter@libassi.se X-Spamd-Result: default: False [-0.77 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; NEURAL_HAM_MEDIUM(-0.87)[-0.873]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-0.90)[-0.898]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[net@freebsd.org]; ARC_SIGNED(0.00)[i=1]; RWL_MAILSPIKE_GOOD(0.00)[93.188.3.37:from]; DMARC_NA(0.00)[libassi.se]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.40)[-0.399]; RCVD_IN_DNSWL_NONE(0.00)[93.188.3.37:from]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:39570, ipnet:93.188.2.0/23, country:SE]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 13:30:30 -0000 =46rom a consumer view I think we should be conservative and not add any = additional commands that operates in an area where there already exists = well known commands. Not sure i understand what new features you are = contributing, but the sound of it i guess it has to do with IP routing = and fib=E2=80=99s. If this is the case i would like to see this = introduced in to route(8) and netstat(1) /Peter > 16 aug. 2020 kl. 11:11 skrev Alexander V. Chernikov = : >=20 > I want to introduce ip(8) or something similar in base. > Basically, I need some userland tool to explicitly operates on = nexthops, nexthop groups and fib lookup algorithms. >=20 > The existing tools are not well suited for the job: route(8) may be a = candidate, but (a) it would either add another bunch of options or = drastically change the tool by introducing [route nhop add], [route = nhgroup add] and (b) listing is traditionally done by netstat(8). >=20 > I feel like there is a need of some cli tool that provides the ability = to easily extend it by having separate namespaces for each sub-command = (hello, ifconfig). >=20 > Naming is hard. I can, for example, use "rt" as a name to address my = use cases. > However, given the kernel interfaces for managing nexthops/nexhop = groups are the same as with routes/arp/ndp, why not spending some = additional time and support operating on routes and neighbors and name = it ip? >=20 > Though, that arises multiple questions. > Are we comfortable with ip(8) as a name in general? > If we are, what=E2=80=99s our take on having the compatible interface = with Linux ip(8)?=20 >=20 > Any comments/feedback is welcome :-) >=20 >=20 > Appendix=20 > List of commands I need implemented >=20 > cmd [-46m] nhop create [gw XX] [iface YYY] [mtu YYY] [reject] = [proxyfib Y] [fib X][ipv4] [ipv6] > cmd [-46m] nhop delete nhop_id > cmd -46m nhop list=20 > cmd -j nhop list # json=20 >=20 > cmd -46m nhgroup create nhops 1,2,3,4,5,6 [fib X] > cmd -46 nhgroup create nhops 1=3D100,2=3D100,3=3D200,4=3D100 [proxyfib = Y][fib X] > cmd -46 nhroup list > cmd -46 nhgroup delete nhgroup_id >=20 > cmd -46 fib algo list > cmd -46 fib algo set algo dpdk_lpm6 fib 0 > cmd -46 fib algo set algo auto fib 0 >=20 >=20 > /Alexander > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Sun Aug 16 15:05:31 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB8BA3BECB5 for ; Sun, 16 Aug 2020 15:05:31 +0000 (UTC) (envelope-from mike@karels.net) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BV0pz3SFwz4SpT for ; Sun, 16 Aug 2020 15:05:31 +0000 (UTC) (envelope-from mike@karels.net) Received: by mailman.nyi.freebsd.org (Postfix) id 7687C3BEB5E; Sun, 16 Aug 2020 15:05:31 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 763DF3BEAFB; Sun, 16 Aug 2020 15:05:31 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (mail.karels.net [216.160.39.52]) by mx1.freebsd.org (Postfix) with ESMTP id 4BV0py1k20z4T6h; Sun, 16 Aug 2020 15:05:29 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.15.2/8.15.2) with ESMTP id 07GF5MMU054548; Sun, 16 Aug 2020 10:05:22 -0500 (CDT) (envelope-from mike@karels.net) Message-Id: <202008161505.07GF5MMU054548@mail.karels.net> To: "Alexander V. Chernikov" cc: net , freebsd-hackers From: Mike Karels Reply-to: mike@karels.net Subject: Re: ip(8) in base In-reply-to: Your message of Sun, 16 Aug 2020 10:11:11 +0100. <1634721597568903@mail.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <54546.1597590322.1@mail.karels.net> Content-Transfer-Encoding: quoted-printable Date: Sun, 16 Aug 2020 10:05:22 -0500 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597590330; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=oH51bWk4UNbMzjcCOgeiWfNZY3Eo5xjLmibWMm0oCBM=; b=ut4DOSZqlvO/8MC2WGIJ2ZoRDiG5FVNtEl+v8xbqRkGNLXCS0ogtIAUxwlxSfQaA78YVUv drK7OovcYSo4si+KzwpWxFCQcxPp2b7mVDgpt4NJSCOF9n5pBezlT62YgE5hI3m0gi5Bob e0gYt2DTLAWeP5u93FOgFuy0fWGYcRHJaE1HJ+YkTBRNeyUVox1Jxm8HUYjg92mHeEuMSM IRedC07gmKlz/L7WLnJdbe9uQ6l3eU9KLO1ddsLxsZle4cczYgf3KxYflRZdPGbXHUpCGb agj2leqhTrOEjAOMci9cA5n2HjJHMrPDsNfiN9F9DtvWusl147IopqjJggx0Tw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597590330; a=rsa-sha256; cv=none; b=btp7uz6uLR7G00yvQCQ9QV3z53vhF/PGhxWL4qXYeHXshkOIskPt6eRWu3rmyzYUwBC+MQ rqeSqA+u3tFCFMXxsPNMFXGxEo0TSYOvYXTmxCbDYoxmvl1VpZMT44Niul/6KtDU6kE4/9 HovLQyd5Vhw0H0HU4sSfhVen/D5eneJe9VPO+T9v7Crjog6wqQJOBIHEO5jQr++4LQi4tZ Kps5GgvQR/bKmDgTxe3Ac58OnGunTpVKOHVeSrK35IP2wHGYy0zWRlW0A8/cNDAJXpbCEa /lcA69gM1cU4u/ABUbO2xuHql1ceo/RlKxX+pA9GAwjhxWDAkrv7aHQjeWjrBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of mike@karels.net designates 216.160.39.52 as permitted sender) smtp.mailfrom=mike@karels.net X-Rspamd-Queue-Id: 4BV0py1k20z4T6h X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mike@karels.net designates 216.160.39.52 as permitted sender) smtp.mailfrom=mike@karels.net X-Spamd-Result: default: False [-2.38 / 15.00]; HAS_REPLYTO(0.00)[mike@karels.net]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.988]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:216.160.39.52]; NEURAL_HAM_LONG(-0.99)[-0.985]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; ARC_SIGNED(0.00)[i=1]; DMARC_NA(0.00)[karels.net]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.21)[-0.209]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:209, ipnet:216.160.36.0/22, country:US]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 15:05:31 -0000 > From: "Alexander V. Chernikov" > To: net , freebsd-hackers > Subject: ip(8) in base > Date: Sun, 16 Aug 2020 10:11:11 +0100 > I want to introduce ip(8) or something similar in base. > Basically, I need some userland tool to explicitly operates on nexthops,= nexthop groups and fib lookup algorithms. > The existing tools are not well suited for the job: route(8) may be a ca= ndidate, but (a) it would either add another bunch of options or drastica= lly change the tool by introducing [route nhop add], [route nhgroup add] a= nd (b) listing is traditionally done by netstat(8). I agree with the others who said not to use ip(8) if the tool is not compatible with the Linux ip. Also, routing is (at least in theory) independent of address family, and that makes the name "ip" too specific. However, I think that route and netstat are sufficiently extensible to add additional facilities, as they have been so far. One suggestion, though, would be to preserve the general strategy of using "route verb ...= ", e.g. "route add nhop ..." rather than "route nhop add ...". These seem sufficiently similar to existing functionality to share a tool. Similarly, if possible I would prefer to see --libxo json rather than -j. Mike > I feel like there is a need of some cli tool that provides the ability t= o easily extend it by having separate namespaces for each sub-command (hel= lo, ifconfig). > Naming is hard. I can, for example, use "rt" as a name to address my use= cases. > However, given the kernel interfaces for managing nexthops/nexhop groups= are the same as with routes/arp/ndp, why not spending some additional tim= e and support operating on routes and neighbors and name it ip? > Though, that arises multiple questions. > Are we comfortable with ip(8) as a name in general? > If we are, what's our take on having the compatible interface with Linux= ip(8)? = > Any comments/feedback is welcome :-) > Appendix = > List of commands I need implemented > cmd [-46m] nhop create [gw XX] [iface YYY] [mtu YYY] [reject] [proxyfib = Y] [fib X][ipv4] [ipv6] > cmd [-46m] nhop delete nhop_id > cmd -46m nhop list = > cmd -j nhop list # json = > cmd -46m nhgroup create nhops 1,2,3,4,5,6 [fib X] > cmd -46 nhgroup create nhops 1=3D100,2=3D100,3=3D200,4=3D100 [proxyfib Y= ][fib X] > cmd -46 nhroup list > cmd -46 nhgroup delete nhgroup_id > cmd -46 fib algo list > cmd -46 fib algo set algo dpdk_lpm6 fib 0 > cmd -46 fib algo set algo auto fib 0 > /Alexander > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Sun Aug 16 15:47:45 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5941A3BFC3E for ; Sun, 16 Aug 2020 15:47:45 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BV1lj1jvwz4VsN for ; Sun, 16 Aug 2020 15:47:45 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3ADAF3BFC3D; Sun, 16 Aug 2020 15:47:45 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 397FB3BFA71; Sun, 16 Aug 2020 15:47:45 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BV1lh1Dwgz4W1c; Sun, 16 Aug 2020 15:47:43 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: from [174.126.78.63] (port=31715 helo=localhost) by balrog.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1k7Ksi-0007DD-QB; Sun, 16 Aug 2020 16:47:41 +0100 Date: Sun, 16 Aug 2020 15:47:31 +0000 From: Teran McKinney To: Mateusz Guzik Cc: "Alexander V. Chernikov" , net , freebsd-hackers Subject: Re: ip(8) in base Message-ID: <20200816154731.GB79904@daemon> References: <1634721597568903@mail.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BlackCat-Spam-Score: 4 X-Spam-Status: No, score=0.4 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597592864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hfk1icJoFHc6IXkZYvZEUXtIfLYWzDo7ePUrgrbefpA=; b=GK35u1pPQRMV092oA0tWrclHVf7VeqUhE3N0OMj7P4l6UQn7IDrhzY+PLhEtglELpo7poq q9iQeHyglAWUTMvAx2y8IzZ3mbXdWcOF0XrGGxTvTn7jovAsAZR4QR56lHF/oJFwdKt+KF qkrcdGdL3MtmjQo3ETFhdTENn41RKW7DQwItS6AVErVO4xyNGLOWsHB5HexApLAFPF53A0 fKT6a5rTuQI3yXdFsiUR9TqdNi/Al6R1ctcztQ05xQpDmvvFcmZAOohI7q2BExaX5Cf4op nufdUAPPitYwnn+v4u7CCCIJYx0XBHN1Yj/Rq5y6dUHww4dyiJFlfprmitqx6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597592864; a=rsa-sha256; cv=none; b=s58R+5sUnMlScxjnprq/I0geZfPoCUnRWgqQc0Iby01efoStsu6kaWhWojCrTBcsJhMfbr cBpVEKTPy94WkycMuD4RO1otQL+unLzv+cAnNPlbwLeCUBDexFSLfDOFE47od3T5VbQpKt OMOvjXRUvWdrt+1MVXBu9eE9FdLIrek9Dzu8IoUChjEyUdddKazVh+pF2n8p9sTDrgAtwH i+ex4970pudyltk4KOCG3auOpGrAiTjP8cbjdqTiUm/86WI+c9bDHEiDOkdLrDnA527JsU zaKgfD5sBKIJxnF0EsgG3rcSMiiknFzfRxYMIm2uLPSJ7pPMNjSm04BVeJsukw== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of sega01@go-beyond.org designates 2a00:1098:0:82:1000:0:2:1 as permitted sender) smtp.mailfrom=sega01@go-beyond.org X-Rspamd-Queue-Id: 4BV1lh1Dwgz4W1c X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sega01@go-beyond.org designates 2a00:1098:0:82:1000:0:2:1 as permitted sender) smtp.mailfrom=sega01@go-beyond.org X-Spamd-Result: default: False [-3.23 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.004]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1098::82:1000:0:2:1]; NEURAL_HAM_LONG(-0.98)[-0.979]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; ARC_SIGNED(0.00)[i=1]; DMARC_NA(0.00)[go-beyond.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.35)[-1.349]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:44684, ipnet:2a00:1098::/32, country:GB]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[2a00:1098:0:82:1000:0:2:1:from] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 15:47:45 -0000 I completely agree with Mateus, if this isn't going to be the same as Linux's iproute2's `ip`, it should have a different name. Too similar in purpose and could be very confusing for many people. Other than that, sounds good with me. -Teran From owner-freebsd-net@freebsd.org Sun Aug 16 16:38:59 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2D1E03C0BDC for ; Sun, 16 Aug 2020 16:38:59 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BV2tq0R03z4Y64 for ; Sun, 16 Aug 2020 16:38:59 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: by mailman.nyi.freebsd.org (Postfix) id 0CE373C0BDB; Sun, 16 Aug 2020 16:38:59 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0A68D3C08EE; Sun, 16 Aug 2020 16:38:59 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BV2tn5lp4z4XnH; Sun, 16 Aug 2020 16:38:57 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 07GGcmDr056885; Sun, 16 Aug 2020 09:38:48 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 07GGclX4056884; Sun, 16 Aug 2020 09:38:47 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <202008161638.07GGclX4056884@gndrsh.dnsmgr.net> Subject: Re: ip(8) in base In-Reply-To: <202008161505.07GF5MMU054548@mail.karels.net> To: mike@karels.net Date: Sun, 16 Aug 2020 09:38:47 -0700 (PDT) CC: "Alexander V. Chernikov" , net , freebsd-hackers X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597595938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=Qve2p6dLbjM6S+nWEf+TbIblFLrrZTr5QIO+eKfZHyw=; b=rVeWSL0hX16fjr0P31GhrZDEzzsr0Dvkh9vccoiNOBK1RO0+HBcG8yH9Qq8LC55fnZC8PO 2EaMOnJSw/1fLpWfF5tIH45QsskMyCl87PYbmdkItL8Z5XhbFDqKPgY6+YOr8cGaWrASP6 8PJDvvzjSdI0FJGyxigT8oyemJIm1JAwcC+3nqLOGYw5ctA4kAagXezxgkg4chZJWyzxT9 9TcH3BBtV0e1YwGYtzcEeuE8WW8XMwaruP2/oN5HIYUebANzD6ud4vDSxnS8xmuX6VkdHE a8luVR+8gZWkvFz9O2yzS2oAgSSPpEMFq2udINOW7P28pugR4X95HMls1+9SZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597595938; a=rsa-sha256; cv=none; b=oU4Fu6H6fmGfdwUQBQJdL8aPNihm24TqhE+NLmMMOiAKmuMcdWl7T2KwpDz5OugjVkuvTH qGDt3SS//0N3KDip/eLNW7e32QMfiiRBI6NY2eN1Ahzgh+p+ceweFsmwqqkXnlvMh+ulNI rS+ACRwv70FSn9BDGj5Pz/Di7kRTXSMtfhhDi4A6GVw/Gf9wNgeel3IOPhDTBZV/s9LKal Hhbc/PUPA4sFTyBKBUHLvYynPZq//dTwKlxIYbgMcHFgeOLf+9OITnaalVWLhmVOTB0vLS lEV2ayUz+xpodsrvc5JZYcyeoSJqcqal3nmk89WlFVapyUuYLQ7Qkw7A0NPCyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Rspamd-Queue-Id: 4BV2tn5lp4z4XnH X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [0.04 / 15.00]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.52)[-0.523]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.15)[-0.151]; MIME_GOOD(-0.10)[text/plain]; ARC_SIGNED(0.00)[i=1]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.18)[-0.182]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 16:38:59 -0000 > > From: "Alexander V. Chernikov" > > To: net , freebsd-hackers > > Subject: ip(8) in base > > Date: Sun, 16 Aug 2020 10:11:11 +0100 > > > I want to introduce ip(8) or something similar in base. > > Basically, I need some userland tool to explicitly operates on nexthops, nexthop groups and fib lookup algorithms. > > > The existing tools are not well suited for the job: route(8) may be a candidate, but (a) it would either add another bunch of options or drastically change the tool by introducing [route nhop add], [route nhgroup add] and (b) listing is traditionally done by netstat(8). > > I agree with the others who said not to use ip(8) if the tool is not > compatible with the Linux ip. Also, routing is (at least in theory) > independent of address family, and that makes the name "ip" too specific. I strongly agree with this. > However, I think that route and netstat are sufficiently extensible to > add additional facilities, as they have been so far. One suggestion, > though, would be to preserve the general strategy of using "route verb ...", > e.g. "route add nhop ..." rather than "route nhop add ...". These seem > sufficiently similar to existing functionality to share a tool. Again, I agree with the above statement by Mike. The proposed commands are all in support of "route" features, and in BSD it is the route command that is used to maniplate these, please do not deviate from that. I have seen no strong reason given that route(8) and netstat(1) can not be extended to add the desired functionality. > Similarly, if possible I would prefer to see --libxo json rather than -j. I have no skin in this one, other than to state that iirc the route(8) command is currently without any long options so adding this --libxo would require adding long option support, which is probably not justifiable for 1 option. > Mike > > > I feel like there is a need of some cli tool that provides the ability to easily extend it by having separate namespaces for each sub-command (hello, ifconfig). > > > Naming is hard. I can, for example, use "rt" as a name to address my use cases. > > However, given the kernel interfaces for managing nexthops/nexhop groups are the same as with routes/arp/ndp, why not spending some additional time and support operating on routes and neighbors and name it ip? > > > Though, that arises multiple questions. > > Are we comfortable with ip(8) as a name in general? > > If we are, what's our take on having the compatible interface with Linux ip(8)? > > > Any comments/feedback is welcome :-) > > > > Appendix > > List of commands I need implemented > > > cmd [-46m] nhop create [gw XX] [iface YYY] [mtu YYY] [reject] [proxyfib Y] [fib X][ipv4] [ipv6] > > cmd [-46m] nhop delete nhop_id > > cmd -46m nhop list > > cmd -j nhop list # json What is special about these nhop routes that this is not just a route add? Could that not be handled as either a route flag ala -iface/-static/-reject/-blackhole or via a route modifier ala -osi/-xns/-inet/-inet6? I am actually a bit confused in that all routes are really just an expression of the "next hop" as far as the kernel goes, or are we now doing lsdb type routing in the kernel? > > > cmd -46m nhgroup create nhops 1,2,3,4,5,6 [fib X] > > cmd -46 nhgroup create nhops 1=100,2=100,3=200,4=100 [proxyfib Y][fib X] > > cmd -46 nhroup list ^ nhgroup? > > cmd -46 nhgroup delete nhgroup_id > > > cmd -46 fib algo list > > cmd -46 fib algo set algo dpdk_lpm6 fib 0 > > cmd -46 fib algo set algo auto fib 0 > > > > /Alexander -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-net@freebsd.org Sun Aug 16 18:21:21 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2B633C2F24 for ; Sun, 16 Aug 2020 18:21:21 +0000 (UTC) (envelope-from mike@karels.net) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BV58x5Rz5z4dbx for ; Sun, 16 Aug 2020 18:21:21 +0000 (UTC) (envelope-from mike@karels.net) Received: by mailman.nyi.freebsd.org (Postfix) id BB0D13C2DD6; Sun, 16 Aug 2020 18:21:21 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BAD113C2CD4 for ; Sun, 16 Aug 2020 18:21:21 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (mail.karels.net [216.160.39.52]) by mx1.freebsd.org (Postfix) with ESMTP id 4BV58w5pN7z4dWW for ; Sun, 16 Aug 2020 18:21:20 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.15.2/8.15.2) with ESMTP id 07GILJH3055045; Sun, 16 Aug 2020 13:21:19 -0500 (CDT) (envelope-from mike@karels.net) Message-Id: <202008161821.07GILJH3055045@mail.karels.net> To: "Rodney W. Grimes" cc: "Alexander V. Chernikov" , net From: Mike Karels Reply-to: mike@karels.net Subject: Re: ip(8) in base In-reply-to: Your message of Sun, 16 Aug 2020 09:38:47 -0700. <202008161638.07GGclX4056884@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <55043.1597602079.1@mail.karels.net> Content-Transfer-Encoding: quoted-printable Date: Sun, 16 Aug 2020 13:21:19 -0500 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597602081; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=uAMLNjsLvhAHi69ppF4QPAn+z3A/BjKQHMgeEWRGW+U=; b=quezFEGQxnZEXlFwJYkb1lSigFD5rXKIP4nUL4S7qHZ3SGiSD3JTpcYnzTzpwq79lkRYRo IpFYP+/Tb+0jeaJ4J0nMDQbM5g1auIUNZecUkv0E21D+sIbGOHluROg9tH5huRSIKaJ7zu VnMFPce6nef5CtwtnU4Bj/qHnQRyeysnTP5QICR9gBh68ltIyIv8nXnvWnW+SO2OcRs5Qp GXMpMtxCilS5bqyshLpSiGUCfZZtrvC4zKChOHYuHrN6AZF/E48LA8rVpOh/GWgaEhtVgf 5ILYN885F25F6aBIADZOIYlwCTS6Y2lCOFgXCDE5hczn+IGBXZNQhHfKdml2tQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597602081; a=rsa-sha256; cv=none; b=Hxi2hV5JrhOjzoRdHk7L88ZWzUL2NdKDs5Mq/+7WL4MS3rDbrgrk+Q7qM/dZpfxTd2bPbe 19YEuHEwOmvDFWwILmSlrQJN4xLu/hdtERYk3fkRiyV5y9W6cQPJxPBRVDAxnZDw1RPu1k qcS6L319evzMANtZ9+gRPK/CcbHvXSL6zQN4cX8NM9pcuv7QAy3W+1aXn9C1IMjDRQBJmg KqO4OI+4UfMS58RYTPyotv6iHf6CIFc5DOcYHLv5+h93XwYpBV/OHApdmlluKK13d71QyK 0hHmaqHUlY6HAwaaEgr405dGzt/ppUmdZxy4ASLR9VVPrTyiBd1UMqKtc6IFPw== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of mike@karels.net designates 216.160.39.52 as permitted sender) smtp.mailfrom=mike@karels.net X-Rspamd-Queue-Id: 4BV58w5pN7z4dWW X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mike@karels.net designates 216.160.39.52 as permitted sender) smtp.mailfrom=mike@karels.net X-Spamd-Result: default: False [-3.02 / 15.00]; HAS_REPLYTO(0.00)[mike@karels.net]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.986]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:216.160.39.52]; NEURAL_HAM_LONG(-0.99)[-0.990]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; ARC_SIGNED(0.00)[i=1]; DMARC_NA(0.00)[karels.net]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.85)[-0.847]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:209, ipnet:216.160.36.0/22, country:US]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 18:21:22 -0000 > From: "Rodney W. Grimes" > Subject: Re: ip(8) in base > Date: Sun, 16 Aug 2020 09:38:47 -0700 (PDT) > > > From: "Alexander V. Chernikov" > > > To: net , freebsd-hackers > > > Subject: ip(8) in base > > > Date: Sun, 16 Aug 2020 10:11:11 +0100 > > = > > > I want to introduce ip(8) or something similar in base. > > > Basically, I need some userland tool to explicitly operates on nexth= ops, nexthop groups and fib lookup algorithms. > > = > > > The existing tools are not well suited for the job: route(8) may be = a candidate, but (a) it would either add another bunch of options or dras= tically change the tool by introducing [route nhop add], [route nhgroup ad= d] and (b) listing is traditionally done by netstat(8). > > = > > I agree with the others who said not to use ip(8) if the tool is not > > compatible with the Linux ip. Also, routing is (at least in theory) > > independent of address family, and that makes the name "ip" too specif= ic. > I strongly agree with this. > > However, I think that route and netstat are sufficiently extensible to > > add additional facilities, as they have been so far. One suggestion, > > though, would be to preserve the general strategy of using "route verb= ...", > > e.g. "route add nhop ..." rather than "route nhop add ...". These see= m > > sufficiently similar to existing functionality to share a tool. > Again, I agree with the above statement by Mike. > The proposed commands are all in support of "route" features, > and in BSD it is the route command that is used to maniplate > these, please do not deviate from that. I have seen no strong > reason given that route(8) and netstat(1) can not be extended > to add the desired functionality. > > Similarly, if possible I would prefer to see --libxo json rather than = -j. > I have no skin in this one, other than to state that iirc the > route(8) command is currently without any long options so > adding this --libxo would require adding long option support, > which is probably not justifiable for 1 option. I think the reporting ("list") should be in netstat rather than route, with the possible exception of enhancements to "route get". Of course, netstat already uses libxo. > > > I feel like there is a need of some cli tool that provides the abili= ty to easily extend it by having separate namespaces for each sub-command = (hello, ifconfig). > > = > > > Naming is hard. I can, for example, use "rt" as a name to address my= use cases. > > > However, given the kernel interfaces for managing nexthops/nexhop gr= oups are the same as with routes/arp/ndp, why not spending some additional= time and support operating on routes and neighbors and name it ip? > > = > > > Though, that arises multiple questions. > > > Are we comfortable with ip(8) as a name in general? > > > If we are, what's our take on having the compatible interface with L= inux ip(8)? = > > = > > > Any comments/feedback is welcome :-) > > = > > = > > > Appendix = > > > List of commands I need implemented > > = > > > cmd [-46m] nhop create [gw XX] [iface YYY] [mtu YYY] [reject] [proxy= fib Y] [fib X][ipv4] [ipv6] > > > cmd [-46m] nhop delete nhop_id > > > cmd -46m nhop list = > > > cmd -j nhop list # json = > What is special about these nhop routes that this is not just a route ad= d? > Could that not be handled as either a route flag ala -iface/-static/-rej= ect/-blackhole > or via a route modifier ala -osi/-xns/-inet/-inet6? > I am actually a bit confused in that all routes are really just an expre= ssion > of the "next hop" as far as the kernel goes, or are we now doing lsdb ty= pe > routing in the kernel? > > = > > > cmd -46m nhgroup create nhops 1,2,3,4,5,6 [fib X] > > > cmd -46 nhgroup create nhops 1=3D100,2=3D100,3=3D200,4=3D100 [proxyf= ib Y][fib X] > > > cmd -46 nhroup list > ^ nhgroup? > > > cmd -46 nhgroup delete nhgroup_id > > = > > > cmd -46 fib algo list > > > cmd -46 fib algo set algo dpdk_lpm6 fib 0 > > > cmd -46 fib algo set algo auto fib 0 > > = > > = > > > /Alexander > -- = > Rod Grimes rgrimes@freeb= sd.org > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Sun Aug 16 21:01:02 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E5DCC3C6241 for ; Sun, 16 Aug 2020 21:01:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BV8jB5ljQz3Ykn for ; Sun, 16 Aug 2020 21:01:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id C51FC3C6387; Sun, 16 Aug 2020 21:01:02 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C4E233C6343 for ; Sun, 16 Aug 2020 21:01:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BV8jB4dPJz3Z6D for ; Sun, 16 Aug 2020 21:01:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7240C161A1 for ; Sun, 16 Aug 2020 21:01:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07GL12FP098477 for ; Sun, 16 Aug 2020 21:01:02 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07GL12Kq098474 for net@FreeBSD.org; Sun, 16 Aug 2020 21:01:02 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202008162101.07GL12Kq098474@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: net@FreeBSD.org Subject: Problem reports for net@FreeBSD.org that need special attention Date: Sun, 16 Aug 2020 21:01:02 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 21:01:03 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 221146 | [ixgbe] Problem with second laggport In Progress | 235700 | oce(4) driver causes fatal trap 12 on boot with e New | 204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New | 213410 | [carp] service netif restart causes hang only whe Open | 7556 | ppp: sl_compress_init() will fail if called anyth Open | 187835 | ngctl(8) strange behavior when adding more than 5 Open | 193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc Open | 194453 | dummynet(4): pipe config bw parameter limited to Open | 200319 | Bridge+CARP crashes/freezes Open | 202510 | [CARP] advertisements sourced from CARP IP cause Open | 207261 | netmap: Doesn't do TX sync with kqueue Open | 217978 | dhclient: Support supersede statement for option Open | 222273 | igb(4): Kernel panic (fatal trap 12) due to netwo Open | 225438 | panic in6_unlink_ifa() due to race Open | 227720 | Kernel panic in ppp server Open | 230807 | if_alc(4): Driver not working for Killer Networki Open | 235524 | igb(4): Ethernet interface loses active link stat Open | 236888 | ppp daemon: Allow MTU to be overridden for PPPoE Open | 236983 | bnxt(4) VLAN not operational unless explicit "ifc Open | 237072 | netgraph(4): performance issue [on HardenedBSD]? Open | 237840 | Removed dummynet dependency on ipfw Open | 240530 | netgraph/ng_source: Allow ng_source to inject int Open | 240944 | em(4): Crash with Intel 82571EB NIC with AMD Pile Open | 240969 | netinet6: Neighbour reachability detection broken Open | 241106 | tun/ppp: panic: vm_fault: fault on nofault entry Open | 241162 | Panic in closefp() triggered by nginx (uwsgi with Open | 243463 | ix0: Watchdog timeout Open | 244066 | divert: Add sysctls for divert socket send and re Open | 244706 | panic: NULL dereference inside __mtx_lock_sleep() Open | 248306 | if_mvneta: Corrupts TX packets when TXCSUM is not Open | 118111 | rc: network.subr Add MAC address based interface 31 problems total for which you should take action. From owner-freebsd-net@freebsd.org Mon Aug 17 11:02:31 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F311F3AEDE7 for ; Mon, 17 Aug 2020 11:02:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BVWN76GFlz4XQY for ; Mon, 17 Aug 2020 11:02:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D6F343AED74; Mon, 17 Aug 2020 11:02:31 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6B5F3AEF29 for ; Mon, 17 Aug 2020 11:02:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BVWN75Rl0z4XL3 for ; Mon, 17 Aug 2020 11:02:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9FBFB1FAE0 for ; Mon, 17 Aug 2020 11:02:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07HB2VF0017564 for ; Mon, 17 Aug 2020 11:02:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07HB2VHw017563 for net@FreeBSD.org; Mon, 17 Aug 2020 11:02:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 248698] Too many duplicate ipv6 addresses panics system Date: Mon, 17 Aug 2020 11:02:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Security X-Bugzilla-Component: Base X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 11:02:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248698 Bjoern A. Zeeb changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|secteam@FreeBSD.org |net@FreeBSD.org --- Comment #1 from Bjoern A. Zeeb --- Given this needs local root this is not a security issue but a self-inflict= ed DoS on maybe a bug? What's the panic message? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Aug 17 11:38:29 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BBAF13AF917 for ; Mon, 17 Aug 2020 11:38:29 +0000 (UTC) (envelope-from preventivi@nuoviclienti.eu) Received: from mailer75.gate177.sl.smtp.com (mailer75.gate177.sl.smtp.com [192.40.177.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BVX9c4Dsjz4Yj7 for ; Mon, 17 Aug 2020 11:38:27 +0000 (UTC) (envelope-from preventivi@nuoviclienti.eu) X-MSFBL: 6PpKkcRhf+TdQ4lgjzFH2gxXjEeYjYYbIpspraqfmFc=|eyJyIjoiZnJlZWJzZC1 uZXRAZnJlZWJzZC5vcmciLCJiIjoiYWZmYXJpbmV3c19kZWRpY2F0ZWRfcG9vbF8 xOTJfNDBfMTc3Xzc1IiwiZyI6ImFmZmFyaW5ld3NfZGVkaWNhdGVkX3Bvb2wifQ= = Received: from [10.137.129.35] ([10.137.129.35:56038] helo=[10.0.0.112]) by mtl-mtsp-mta01-out2.smtp.com (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTP id D9/94-24169-B2C6A3F5; Mon, 17 Aug 2020 11:38:19 +0000 Received: Received from 10.137.11.94 by Caffeine (mtl-mtsp-c02-3) with SMTP id a7e1b292-c651-40d9-b0e7-00c5e7d0c8ad for freebsd-net@freebsd.org; Mon, 17 Aug 2020 11:38:16 +0000 (UTC) Received: from [79.1.85.14] ([79.1.85.14:59244] helo=[192.168.1.79]) by mtl-mtsp-mta05-in2 (envelope-from ) (ecelerity 4.1.0.46749 r(Core:4.1.0.4)) with ESMTPA id 35/79-21223-62C6A3F5; Mon, 17 Aug 2020 11:38:16 +0000 Message-Id: Mime-Version: 1.0 From: SpotAziendali To: freebsd-net Subject: Realizziamo il tuo videospot o Videocartoon da 599 euro incluso doppiaggio Date: Mon, 17 Aug 2020 13:38:23 +0200 Feedback-ID: 9026526:SMTPCOM X-SMTPCOM-Sender-ID: 9026526 X-SMTPCOM-Tracking-Number: a7e1b292-c651-40d9-b0e7-00c5e7d0c8ad X-SMTPCOM-Message-ID: f6ae666f-2c86-4381-81d6-f2674f9e15c2 X-SMTPCOM-Payload: BlMSUR9PXUIWglcA7qtOIICt-dtmhUnOIi5cabjWc7PwahFfARXof4ceHbKSMmkPpJLa9dubcZU-qeLogFEwN7uVR7wvCIfJJsI_6qWcA68Z3TC5VZ8HKzv5fxJto859Y0OTTXK4p_QRBmHtJstsmZAGRfW1-I_KFQF57NiTumXUFCCU2kZHzk4LPxzdZs-v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=smtpsendemail.com; i=@smtpsendemail.com; q=dns/txt; s=smtpcustomer; t=1597664297; h=message-id : mime-version : from : to : subject : date : content-type : list-unsubscribe : from; bh=Gd3BlYbn2tSSyp+gct/9Z2QmVwCgT4FNvBD/4czxpAw=; b=m5Pk1uhfSDUOztF7xF1BbBv3oz0SjJ2vWuuyKFrIUGf4urTY3W6F8U7g4vfD6DFXQWhwF g0VGa2zeVk3U4foWZ4v+giN6r+hu6gJHa4QoAZ29ThGVqaFeLq8xcYrOo1b9iWSzR9yjNcC TqOJ0iY936cwyIWqWQxIrMdlNSIAC/ihSNEepr2ca97b/GSX4s4NqyZsH+hffvx35cyGBfU zgDObNx3G/a1ILRrtazSouVEr0WaANbOL56plW+ukHAY2rAnhI7r95QZ+O1fHUN/TaEQnbP v/X1z/W9wgrq/sb+oXeFNSCV5qsdWXjoKE+aC/qayTK3Z5EieWg5Zz7U7bCg== X-Report-Abuse: SMTP.com is an email service provider. Our abuse team cares about your feedback. Please contact abuse@smtp.com for further investigation. ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597664309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: list-unsubscribe:dkim-signature; bh=Gd3BlYbn2tSSyp+gct/9Z2QmVwCgT4FNvBD/4czxpAw=; b=h45cYdWdF6Lqk7dLZe0n2xv+N4GSMGJxoE2McY0EG/u1f7/WakZePxxbcsO27+DinEtWuS u0ijbQHM9fK3sVYR40Rclh7nP3IvpoyRw/thR/LJzvuL+pN/DrC3pQeUnjtYrMNVoEEFp8 iAFoTY4rRJn0QUqJab/b0jqlMxTAJW+4qZTXwudvSJ0175oz2PdqDgt8ZUi3gBf6Uj0+By wgHg28JY8HonVP1vV+xFZUN1rlB5l8TVIF9n7r+o5BWYbYsPnEJyUbRQb862NS9fKwgRLs moQ44l2zfLwu/iYL/OmY6PaQyvul/WIS83mRzXDpJr71VspFKTyyl2BD0g24lg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597664309; a=rsa-sha256; cv=none; b=ZzoEi0/p/jgsZllV2T7iHBSgOd46p1XAQiYwPSueEa7YGGK775q4fnyeeQrQUUSXtvVFU/ UE41PE9n5HQGsViezg61nrvuM0lV8N9AJXFL4kV4YgJC1+2/xqNOU5+2gUvHkYivbxOkGA DTiJmncnhmpxrkuRH+c3rFci6FofojpSyTm5+04Ia4dF70HZvGHv/MMOFTDeKuDKpUuJ0V EC35HvUd51+E7mCJ7xTfAiisBfmunnalLU7qi8P/SabK+FqtIusf6azZXhew78WrE9g1U5 sA+l+vTk6JQqgMSn1gVSf815IexZYPdZjKkjODNWeF6rna71CoqCtkkcDgV3Wg== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=pass header.d=smtpsendemail.com header.s=smtpcustomer header.b=m5Pk1uhf; spf=pass (mx1.freebsd.org: domain of preventivi@nuoviclienti.eu designates 192.40.177.75 as permitted sender) smtp.mailfrom=preventivi@nuoviclienti.eu X-Rspamd-Queue-Id: 4BVX9c4Dsjz4Yj7 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=smtpsendemail.com header.s=smtpcustomer header.b=m5Pk1uhf; dmarc=none; spf=pass (mx1.freebsd.org: domain of preventivi@nuoviclienti.eu designates 192.40.177.75 as permitted sender) smtp.mailfrom=preventivi@nuoviclienti.eu X-Spamd-Result: default: False [-2.01 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:192.40.160.0/19]; ARC_SIGNED(0.00)[i=1]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[smtpsendemail.com:+]; MIME_BASE64_TEXT(0.10)[]; NEURAL_HAM_SHORT(-0.06)[-0.056]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:19005, ipnet:192.40.176.0/20, country:CA]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[79.1.85.14:received]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.05)[-1.045]; R_DKIM_ALLOW(-0.20)[smtpsendemail.com:s=smtpcustomer]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.001]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[nuoviclienti.eu]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[192.40.177.75:from] Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 11:38:29 -0000 Buongiorno, con SpotAziendali =2Eit puoi realizzare Videospot o Videocartoo= n Animati da 599 euro con incluso doppiaggio professionale=2E Su SpotAziendali =2Eit, moltissimi esempi di Video gi=C3=A0 realizzati per = nostri clienti, che hanno permesso di aumentare fatturato, % di click, aume= ntato interazioni sui Social e sul proprio sito=2E In 60 secondi potete spiegare quello che non basterebbe con una pubblicit= =C3=A0 tradizionale=2E Ed =C3=A8 tutto incluso chiavi in mano consegnato in= 7 giorni=2E Altrove costerebbe oltre 2=2E000 euro! E con un piccolo extra price il Vostro Video pu=C3=B2 diventare Videomail p= er stupire 10=2E000 clienti profilati e geo-localizzati via email=2E Sul no= stro sito SpotAziendali =2Eit, informazioni, portfolio clienti e molto alto= =2E SpotAziendali =C3=A8 un servizio Certificato ISO9001 ISO27001, agenzia iscr= itta AGCOM=2E Resto a disposizione anche tramite chat sul nostro sito o al numero 393-931= 6379=2E PIERLUIGI PRENCIPE ISO9001 - ISO27001 Tel=2E (+39) 393-9316379 Tel=2E (+39) 02 87168036 SpotAziendali Milano Ti interessa la Lead Generation? > vai su www=2E Leadqualificati =2Eit Vuoi Inviare Email Promozionali? > vai su www=2E Mailtarget =2Eit Ti interessano Videospot Animati? > vai su www=2E Spotaziendali =2Eit Vuoi un nuovo sito web Interattivo? > vai su www=2E Parasponsive =2Eit Vuoi arrivare in Prima Pagina Google? > vai su www=2E seometrics =2Eit Vuoi lanciare contenuti Virali + su Google? > vai su www=2E Trasmesso =2Eit Vuoi essere aggiornato sui nostri Clienti? > vai su www=2E Affari =2Enews =E2=80=A6 Affidati alla migliore agenzia in Italia! From owner-freebsd-net@freebsd.org Mon Aug 17 12:32:18 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 433E53B188A for ; Mon, 17 Aug 2020 12:32:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BVYMk17cDz4cgt for ; Mon, 17 Aug 2020 12:32:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 26EB83B16C9; Mon, 17 Aug 2020 12:32:18 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 26B943B16C8 for ; Mon, 17 Aug 2020 12:32:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BVYMk0Ft1z4cwG for ; Mon, 17 Aug 2020 12:32:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E03BC20CB5 for ; Mon, 17 Aug 2020 12:32:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07HCWH0s016531 for ; Mon, 17 Aug 2020 12:32:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07HCWHqY016511 for net@FreeBSD.org; Mon, 17 Aug 2020 12:32:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240818] igb(4) vlanhwfilter feature generate link UP/DOWN for each new vlan created Date: Mon, 17 Aug 2020 12:32:14 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: lev@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: erj@freebsd.org X-Bugzilla-Flags: mfc-stable12+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 12:32:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240818 --- Comment #23 from Lev A. Serebryakov --- (In reply to commit-hook from comment #22) Why is it closed as "FIXED"? Re-init interface on each VLAN setting change = is only work-around, as old pre-iflib driver was able to re-confgure VLANs wit= hout interface up/down cycle! --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Aug 17 12:37:02 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA5DF3B1862 for ; Mon, 17 Aug 2020 12:37:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BVYTB5XSBz4d3r for ; Mon, 17 Aug 2020 12:37:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id BE0333B1861; Mon, 17 Aug 2020 12:37:02 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BDCDC3B1B08 for ; Mon, 17 Aug 2020 12:37:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BVYTB4ktJz4dFW for ; Mon, 17 Aug 2020 12:37:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8368A20F08 for ; Mon, 17 Aug 2020 12:37:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07HCb20f020714 for ; Mon, 17 Aug 2020 12:37:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07HCb214020713 for net@FreeBSD.org; Mon, 17 Aug 2020 12:37:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240818] igb(4) vlanhwfilter feature generate link UP/DOWN for each new vlan created Date: Mon, 17 Aug 2020 12:37:02 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: pi@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: erj@freebsd.org X-Bugzilla-Flags: mfc-stable12+ X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 12:37:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240818 Kurt Jaeger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|Closed |Open --- Comment #24 from Kurt Jaeger --- See comment 23 --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Aug 17 20:47:01 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E81BD3BBE0D for ; Mon, 17 Aug 2020 20:47:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BVmLY5x2mz4Fvy for ; Mon, 17 Aug 2020 20:47:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C92E73BBE0B; Mon, 17 Aug 2020 20:47:01 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C7CE43BBB5B for ; Mon, 17 Aug 2020 20:47:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BVmLY4ftqz4GBq for ; Mon, 17 Aug 2020 20:47:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 83294266C9 for ; Mon, 17 Aug 2020 20:47:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07HKl1LK013918 for ; Mon, 17 Aug 2020 20:47:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07HKl1Od013917 for net@FreeBSD.org; Mon, 17 Aug 2020 20:47:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 247912] IPv6 ndp does not work across local bridge members Date: Mon, 17 Aug 2020 20:47:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: qingli@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 20:47:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247912 Qing Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |qingli@FreeBSD.org --- Comment #1 from Qing Li --- (In reply to Martin Birgmeier from comment #0) Just to be sure, could you please provide the "ndp -a" output for both befo= re and after the bridge0 creation? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Aug 18 00:12:18 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D27D53BF623 for ; Tue, 18 Aug 2020 00:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BVrvQ5Jbyz4RWG for ; Tue, 18 Aug 2020 00:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B63023BEAF5; Tue, 18 Aug 2020 00:12:18 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B5F323BF3A1 for ; Tue, 18 Aug 2020 00:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BVrvQ4SYKz4RXZ for ; Tue, 18 Aug 2020 00:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7CE118E55 for ; Tue, 18 Aug 2020 00:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07I0CI5g048962 for ; Tue, 18 Aug 2020 00:12:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07I0CIHd048961 for net@FreeBSD.org; Tue, 18 Aug 2020 00:12:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 248698] Too many duplicate ipv6 addresses panics system Date: Tue, 18 Aug 2020 00:12:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Security X-Bugzilla-Component: Base X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: thogard@abnormal.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 00:12:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248698 --- Comment #2 from Tim Hogard --- I'm not sure this must have local root. What if a corrupted DHPCv6 or other network ip address assignment problem causes the same issue? I can allocate 100,000+ unique IPv6 addresses without crashing but it gets = very slow and there are warning about not being able to allocate memory and gets very slow.=20=20 It seems to be the duplicate addresses that case the panic. I don't have a panic message, it goes by way too fast and I couldn't find it logged anywhere. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Aug 18 07:54:21 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6C11C3B2AC1 for ; Tue, 18 Aug 2020 07:54:21 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BW38X6pkfz4t6h for ; Tue, 18 Aug 2020 07:54:20 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (c-73-92-37-32.hsd1.ca.comcast.net [73.92.37.32]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id 07I7sDMM001943 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 18 Aug 2020 00:54:13 -0700 (PDT) (envelope-from julian@freebsd.org) Subject: Re: net.add_addr_allfibs=1 behaviour deprecation To: freebsd-net@freebsd.org References: <236161595078191@mail.yandex.ru> <348771597489519@mail.yandex.ru> From: Julian Elischer Message-ID: <0f321bdc-240e-0f85-915b-c9bdd7daa01b@freebsd.org> Date: Tue, 18 Aug 2020 00:54:08 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <348771597489519@mail.yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4BW38X6pkfz4t6h X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:36236, ipnet:204.109.60.0/22, country:US] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 07:54:21 -0000 The reason for the two behaviours is that there are two ways that the previous behaviour of  "add addresses to the only FIB" could be interpreted and extended once multiple fibs became available. The single fib case could be interpreted as either of: "Add to All N fibs where N == 1"    or     "add to the first (of 1) fibs". I decided to do both :-) At Ironport where I wrote it we had a scenario where I didn't want to have wrong entries in all the fibs when a new interface was brought up. Even for a moment. An other scenarios where  for example a tunnel uses fib 1 but the rest of the system uses fib0 (which points through the tunnel) The addition of new routes into the tunnel's route when a new virtual interface is brought up pointing through the tunnel to the same address, leads in the tunnel immediately redirecting packets through itself which ends in tears.     SO the obvious thing to do was to make it possible to only add the entry in the fib that was the default fib or in the case of Ironport, the fib that was the default fib of the process adding the interface. If you had to make a choice I think the '0' choice is the way to go. All other fibs need to be populated deliberately.. On 8/15/20 4:24 AM, Alexander V. Chernikov wrote: > 18.07.2020, 14:22, "Alexander V. Chernikov" : >> Dear FreeBSD users, >> >> I would like to make net.add_addr_allfibs=0 as the default system behaviour and remove net.add_addr_allfibs. >> To do so, I would like to collect use cases with net.add_addr_allfibs=1 and multiple fibs, to ensure they can still be supported after removal. >> >> Background: >> >> Multi-fib support was added in r178888 [1], 12 years ago. Addition of interface addresses to all fibs was a feature from day 1. >> The `net.add_addr_allfibs` sysctl  was added in r180840 [2], 12 years ago. >> >> Problem: >> The goal of the fib support is to provide multiple independent routing tables, isolated from each other. >> `net.add_addr_allfibs` default tries to shift gears in the opposite direction, unconditionally inserting all addresses to all of the fibs. >> >> It complicates the logic, kernel code and makes control plane performance decrease with the number of fibs. >> It make impossible to use the same prefixes in multiple fibs, which may be desired given shortage of IPv4 address space. >> >> I do understand that there are some cases where such behaviour is desired. >> For example, it can be used to achieve VRF route leaking or binding on address from different fibs. >> I would like to collect such cases to consider supporting them in a different way. >> >> The goal is to make net.add_addr_allfibs=0 default behaviour and remove net.add_addr_allfibs. >> It will simplify kernel fib-related code and allow bringing more fib-related features. It will also improve fib scaling. > No objections has been received. > Next steps: > * Switch net.add_addr_allfibs to 0 ( https://reviews.freebsd.org/D26076 ) > * Provide an ability to use nexthops from different fibs > * Remove net.add_addr_allfibs >> Timeline: >> Aug 1: summarising feedback and the usecases, decision on proceeding further >> Aug 20 (tentative):  patches for supported usecases >> Sep 15 (tentative):  net.add_addr_allfibs removal. >> >> [1]: [base Contents of /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?revision=178888&view=markup) >> [2]: [base Diff of /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?r1=180839&r2=180840&) >> >> /Alexander > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@freebsd.org Tue Aug 18 08:17:05 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 348F63B3555 for ; Tue, 18 Aug 2020 08:17:05 +0000 (UTC) (envelope-from list1@gjunka.com) Received: from msa1.earth.yoonka.com (yoonka.com [88.98.225.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "msa1.earth.yoonka.com", Issuer "msa1.earth.yoonka.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BW3fm0Cp7z4v5r for ; Tue, 18 Aug 2020 08:17:03 +0000 (UTC) (envelope-from list1@gjunka.com) Received: from venus.yoonka.com (venus.yoonka.com [10.70.7.24]) (authenticated bits=0) by msa1.earth.yoonka.com (8.15.2/8.15.2) with ESMTPSA id 07I8GuKu019297 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 18 Aug 2020 08:16:56 GMT (envelope-from list1@gjunka.com) Subject: Re: net.add_addr_allfibs=1 behaviour deprecation To: freebsd-net@freebsd.org References: <236161595078191@mail.yandex.ru> <348771597489519@mail.yandex.ru> <0f321bdc-240e-0f85-915b-c9bdd7daa01b@freebsd.org> From: Grzegorz Junka Message-ID: Date: Tue, 18 Aug 2020 08:16:55 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <0f321bdc-240e-0f85-915b-c9bdd7daa01b@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597738624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Vgx+VBqHX/JMrDRiCmXpnHjkHf4thGd119XqLF8E70=; b=kyII+0O2I+T09vfhPUSfdEvYsWxtflUzAHMZhmp8PoYgigCfsj6eQeUZBt9hZgY9nL/mXK 1RGpcou3Juio/5ET7gnHi8kSlIM/w0ogsB7XBapFfbFMR6oOhkG6amE68Q9WgBY0V1uyuL yF99nXRpHdWnNpn+y/+BchTikZ4NTJMLqj/4oxSkwr7NppOgE7TLrGkNemC0gharW5Z+O6 FYFwZKnFkNohzlDvNhYK4f+C4hCiDLZPiVsKUE1wHFbtyU5JAYoP1ZZNj+yyCWfekigLBR bk3Ut0g/cY0rDY/HP8GuHnBUVfirVs6cNoaj0Rgk659iGIIIYAWpwstZpFDB+w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1597738624; a=rsa-sha256; cv=none; b=nsjwCd8cHAIhqCRdmJxmknOYMaRhQV/pLoBveFy8u2t1oFBB7iWBfkgkqXpygMHphus/UQ XyvAwcU1JmIyRlv9ILFsom9ewSMgfgddL0SIo7Fjku3QgX6gYH2fegNnXkbpmImeHsYFgH R7x775Yp3CYD4H3DmeZtv4xKfamw8u8OXZp9OUeDYFFvaLThv4VJ8dg6imp7ztfauJZE/f bFJu2YBautEiIDcjOavf91zVqYYD6W5RxuYRQn3WpGoeBrX8+EOBeEZ3E7Kb7CA0ilcjx8 AM6Ou8tZQBU1w2Aw8hIVdKYA5WryHqRMVddtDg6LGR8/5KUHUQ3VeQWvHQTEsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of list1@gjunka.com designates 88.98.225.149 as permitted sender) smtp.mailfrom=list1@gjunka.com X-Rspamd-Queue-Id: 4BW3fm0Cp7z4v5r X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of list1@gjunka.com designates 88.98.225.149 as permitted sender) smtp.mailfrom=list1@gjunka.com X-Spamd-Result: default: False [-2.14 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:88.98.225.149]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.02)[-1.021]; ARC_SIGNED(0.00)[i=1]; NEURAL_HAM_SHORT(-0.03)[-0.034]; DMARC_NA(0.00)[gjunka.com]; NEURAL_HAM_MEDIUM(-0.78)[-0.783]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:56478, ipnet:88.98.192.0/18, country:GB]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 08:17:05 -0000 On 18/08/2020 07:54, Julian Elischer wrote: > The reason for the two behaviours is that there are two ways that the > previous behaviour of  "add addresses to the only FIB" could be > interpreted and extended once multiple fibs became available. The > single fib case could be interpreted as either of: > > "Add to All N fibs where N == 1"    or     "add to the first (of 1) > fibs". > I decided to do both :-) > > At Ironport where I wrote it we had a scenario where I didn't want to > have wrong entries in all the fibs when a new interface was brought > up. Even for a moment. An other scenarios where  for example a tunnel > uses fib 1 but the rest of the system uses fib0 (which points through > the tunnel) The addition of new routes into the tunnel's route when a > new virtual interface is brought up pointing through the tunnel to the > same address, leads in the tunnel immediately redirecting packets > through itself which ends in tears.     SO the obvious thing to do was > to make it possible to only add the entry in the fib that was the > default fib or in the case of Ironport, the fib that was the default > fib of the process adding the interface. > > If you had to make a choice I think the '0' choice is the way to go. > All other fibs need to be populated deliberately.. > > On 8/15/20 4:24 AM, Alexander V. Chernikov wrote: >> 18.07.2020, 14:22, "Alexander V. Chernikov" : >>> Dear FreeBSD users, >>> >>> I would like to make net.add_addr_allfibs=0 as the default system >>> behaviour and remove net.add_addr_allfibs. >>> To do so, I would like to collect use cases with >>> net.add_addr_allfibs=1 and multiple fibs, to ensure they can still >>> be supported after removal. >>> >>> Background: >>> >>> Multi-fib support was added in r178888 [1], 12 years ago. Addition >>> of interface addresses to all fibs was a feature from day 1. >>> The `net.add_addr_allfibs` sysctl  was added in r180840 [2], 12 >>> years ago. >>> >>> Problem: >>> The goal of the fib support is to provide multiple independent >>> routing tables, isolated from each other. >>> `net.add_addr_allfibs` default tries to shift gears in the opposite >>> direction, unconditionally inserting all addresses to all of the fibs. >>> >>> It complicates the logic, kernel code and makes control plane >>> performance decrease with the number of fibs. >>> It make impossible to use the same prefixes in multiple fibs, which >>> may be desired given shortage of IPv4 address space. >>> >>> I do understand that there are some cases where such behaviour is >>> desired. >>> For example, it can be used to achieve VRF route leaking or binding >>> on address from different fibs. >>> I would like to collect such cases to consider supporting them in a >>> different way. >>> >>> The goal is to make net.add_addr_allfibs=0 default behaviour and >>> remove net.add_addr_allfibs. >>> It will simplify kernel fib-related code and allow bringing more >>> fib-related features. It will also improve fib scaling. >> No objections has been received. >> Next steps: >> * Switch net.add_addr_allfibs to 0 ( >> https://reviews.freebsd.org/D26076 ) >> * Provide an ability to use nexthops from different fibs >> * Remove net.add_addr_allfibs >>> Timeline: >>> Aug 1: summarising feedback and the usecases, decision on proceeding >>> further >>> Aug 20 (tentative):  patches for supported usecases >>> Sep 15 (tentative):  net.add_addr_allfibs removal. >>> >>> [1]: [base Contents of >>> /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?revision=178888&view=markup) >>> [2]: [base Diff of >>> /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?r1=180839&r2=180840&) >>> >>> /Alexander >> Agree completely, defaulting "add_addr_allfibs" to 1 broke many existing installations, which goes against the least surprise principle so many times advocated on FreeBSD lists. This is just one example: https://forums.freebsd.org/threads/strange-behavior-of-setfib-since-freebsd-12-0.73348/ Now, changing the default again might again break existing installations, which shouldn't be a reason for not doing it, but might be a reason to better communicate it this time around. GrzegorzJ From owner-freebsd-net@freebsd.org Tue Aug 18 08:41:42 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C84393B3C5A for ; Tue, 18 Aug 2020 08:41:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BW4CB4wsRz3Srd for ; Tue, 18 Aug 2020 08:41:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id A92983B3D32; Tue, 18 Aug 2020 08:41:42 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8F3D3B3CE8 for ; Tue, 18 Aug 2020 08:41:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BW4CB3mH7z3T05 for ; Tue, 18 Aug 2020 08:41:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 64DF7EFBF for ; Tue, 18 Aug 2020 08:41:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07I8fgXR033021 for ; Tue, 18 Aug 2020 08:41:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07I8fghh033020 for net@FreeBSD.org; Tue, 18 Aug 2020 08:41:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 248652] netmap: pkt-gen TX huge pps difference between 11-STABLE and 12-STABLE/CURRENT on ix & ixl NIC Date: Tue, 18 Aug 2020 08:41:41 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: iflib, needs-qa, performance, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: vmaffione@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? mfc-stable12? mfc-stable11- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 08:41:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248652 --- Comment #7 from Vincenzo Maffione --- (In reply to Kubilay Kocak from comment #6) I would say ix/ixl and/or NIC driver & iflib because it's not something related to the netmap module itself, and it is an optimization which derives from ix/ixl netmap support code, which now is included within iflib. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Aug 18 15:34:49 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 520BA3BFBA2 for ; Tue, 18 Aug 2020 15:34:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BWFMs1Z21z4Fwq for ; Tue, 18 Aug 2020 15:34:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3407F3BFBA1; Tue, 18 Aug 2020 15:34:49 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 33CFF3BFCFC for ; Tue, 18 Aug 2020 15:34:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWFMs0hbFz4GHj for ; Tue, 18 Aug 2020 15:34:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F086F140A9 for ; Tue, 18 Aug 2020 15:34:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07IFYmmu015683 for ; Tue, 18 Aug 2020 15:34:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07IFYmPG015682 for net@FreeBSD.org; Tue, 18 Aug 2020 15:34:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 247912] IPv6 ndp does not work across local bridge members Date: Tue, 18 Aug 2020 15:34:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: d8zNeCFG@aon.at X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 15:34:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247912 --- Comment #2 from Martin Birgmeier --- Hi Li, Since you want it "before and after the creation of bridge0", the following= is from the host; but the issue actually occurs on the client - I'll provide t= he output for that, too. Host before "bridge0 create" and "tap904 create": [0]# ndp -a Neighbor Linklayer Address Netif Expire S F= lags 2002:b2bf:ee7e:4d42:22cf:30ff:fe55:5cb6 20:cf:30:55:5c:b6 re0 permanent R=20 fec0::4d42:22cf:30ff:fe55:5cb6 20:cf:30:55:5c:b6 re0 permanent R=20 fec0:0:0:4d42::e1 20:cf:30:55:5c:b6 re0 permanent R=20 fe80::22cf:30ff:fe55:5cb6%re0 20:cf:30:55:5c:b6 re0 permanent R=20 gandalf.xyzzy 00:03:0d:4f:f3:a7 re0 23h57m34s S R fe80::203:dff:fe4f:f3a7%re0 00:03:0d:4f:f3:a7 re0 23h55m33s S R fe80::218:e7ff:fee0:807b%re0 00:18:e7:e0:80:7b re0 23h55m33s S R hal.xyzzy 20:cf:30:55:5c:b6 re0 permanent R=20 mizar.xyzzy f0:de:f1:98:86:a9 re0 23h58m35s S=20 [0]#=20 After "ifconfig bridge0 create && ifconfig bridge0 addm re0 && ifconfig bri= dge0 up": [0]# ndp -a=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 Neighbor Linklayer Address Netif Expire S F= lags 2002:b2bf:ee7e:4d42:22cf:30ff:fe55:5cb6 20:cf:30:55:5c:b6 re0 permanent R=20 fec0::4d42:22cf:30ff:fe55:5cb6 20:cf:30:55:5c:b6 re0 permanent R=20 fec0:0:0:4d42::e1 20:cf:30:55:5c:b6 re0 permanent R=20 fe80::22cf:30ff:fe55:5cb6%re0 20:cf:30:55:5c:b6 re0 permanent R=20 gandalf.xyzzy 00:03:0d:4f:f3:a7 re0 23h58m48s S R fe80::203:dff:fe4f:f3a7%re0 00:03:0d:4f:f3:a7 re0 23h51m46s S R fe80::218:e7ff:fee0:807b%re0 00:18:e7:e0:80:7b re0 23h51m46s S R hal.xyzzy 20:cf:30:55:5c:b6 re0 permanent R=20 mizar.xyzzy f0:de:f1:98:86:a9 re0 23h59m48s S=20 [0]#=20 After "ifconfig tap904 create && ifconfig bridge0 addm tap904": [0]# ndp -a=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 Neighbor Linklayer Address Netif Expire S F= lags 2002:b2bf:ee7e:4d42:22cf:30ff:fe55:5cb6 20:cf:30:55:5c:b6 re0 permanent R=20 fec0::4d42:22cf:30ff:fe55:5cb6 20:cf:30:55:5c:b6 re0 permanent R=20 fec0:0:0:4d42::e1 20:cf:30:55:5c:b6 re0 permanent R=20 fe80::22cf:30ff:fe55:5cb6%re0 20:cf:30:55:5c:b6 re0 permanent R=20 gandalf.xyzzy 00:03:0d:4f:f3:a7 re0 23h58m2s S R fe80::203:dff:fe4f:f3a7%re0 00:03:0d:4f:f3:a7 re0 23h51m0s S R fe80::218:e7ff:fee0:807b%re0 00:18:e7:e0:80:7b re0 23h51m0s S R hal.xyzzy 20:cf:30:55:5c:b6 re0 permanent R=20 mizar.xyzzy f0:de:f1:98:86:a9 re0 23h59m2s S=20 [0]#=20 Now starting the bhyve VM; the rest is from inside the VM. Before manually added ndp entries: [0]# ndp -a Neighbor Linklayer Address Netif Expire S F= lags v904.xyzzy 00:a0:98:50:35:17 vtnet0 permanent R=20 gandalf.xyzzy 00:03:0d:4f:f3:a7 vtnet0 23h59m57s S R fe80::203:dff:fe4f:f3a7%vtnet0 00:03:0d:4f:f3:a7 vtnet0 23h59m2s S R fe80::218:e7ff:fee0:807b%vtnet0 00:18:e7:e0:80:7b vtnet0 23h59m2s S R 2002:b2bf:ee7e:4d42:2a0:98ff:fe50:3517 00:a0:98:50:35:17 vtnet0 permanent R= =20 fec0::4d42:2a0:98ff:fe50:3517 00:a0:98:50:35:17 vtnet0 permanent R=20 fe80::2a0:98ff:fe50:3517%vtnet0 00:a0:98:50:35:17 vtnet0 permanent R=20 mizar.xyzzy f0:de:f1:98:86:a9 vtnet0 23h59m57s S=20 [0]#=20 After "ndp -s fec0:0:0:4d42::e 20:cf:30:55:5c:b6 && ndp -s fec0:0:0:4d42::e1 20:cf:30:55:5c:b6" (the host has two IPv6 addresses assigned to its interfa= ce; fec0:0:0:4d42::e resolves to hal.xyzzy): [0]# ndp -a Neighbor Linklayer Address Netif Expire S F= lags fec0:0:0:4d42::e1 20:cf:30:55:5c:b6 vtnet0 permanent R=20 v904.xyzzy 00:a0:98:50:35:17 vtnet0 permanent R=20 gandalf.xyzzy 00:03:0d:4f:f3:a7 vtnet0 23h58m54s S R fe80::203:dff:fe4f:f3a7%vtnet0 00:03:0d:4f:f3:a7 vtnet0 23h57m59s S R fe80::218:e7ff:fee0:807b%vtnet0 00:18:e7:e0:80:7b vtnet0 23h57m59s S R 2002:b2bf:ee7e:4d42:2a0:98ff:fe50:3517 00:a0:98:50:35:17 vtnet0 permanent R= =20 fec0::4d42:2a0:98ff:fe50:3517 00:a0:98:50:35:17 vtnet0 permanent R=20 fe80::2a0:98ff:fe50:3517%vtnet0 00:a0:98:50:35:17 vtnet0 permanent R=20 hal.xyzzy 20:cf:30:55:5c:b6 vtnet0 permanent R=20 mizar.xyzzy f0:de:f1:98:86:a9 vtnet0 23h58m54s S=20 [0]#=20 -- Martin --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Aug 18 17:18:03 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B390C3C1D49 for ; Tue, 18 Aug 2020 17:18:03 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWHfy2cGpz4NV8 for ; Tue, 18 Aug 2020 17:18:02 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-ej1-x62e.google.com with SMTP id bo3so22959728ejb.11 for ; Tue, 18 Aug 2020 10:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=YzWZ73X+CajokrsfKNHVHGJavszrOmLtRBbvDYQsZ94=; b=VwSoPP6lUFChM8qXrwVdzTLl+iAgXJbMgvRXNFjjYbHi+Wag1+DSEZjiRFD/rJHjhT p2Mn+3cYL1fWpuEFeKZi3wX9m5G3oeyGGd5LTyADjIiMdzGB5Adqs4S6QotSREFBiq1k gg/T05jv481cecoxaZokh4EPjGUrv1SQikOr4xxfJtiuJHWx5AcWi5aBuP62QL84gmvM yRVDBZy/ZeNsinN9sWcV9+JmBTIrERHRfy2rS3Zdmwh4oZHr9XssKfhGbSGp+S9bjdrf KlT469wjR5I2A75Dwnj+j9S4b8GOIMl5wXTAPi4w2KzW0lEIvxQnAGgU/OCqufb5YMeB qYIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=YzWZ73X+CajokrsfKNHVHGJavszrOmLtRBbvDYQsZ94=; b=fTtYsmXLn7yMFY1+e9OPKC67HRVM/4Vc4EAyT0YGqhU4OuqJTBKQDQSJCXYqcP2KJt Rs90AkjhR5IJ7JlQQNfY6G3HadR5IBt5fL2vxqa1r/5waFikhL+LI0z3NaQUOn6VGhOv 5wUmRJ0tnCoEF73WLhJ0N9ZK9Zl8/U3I1JUtTaDcSPYazFJsVNy9aJkdjXiX0SAsZ3oF 3F28oczc8hxB8Putr0OoOmpGN8uJc6w1i9T894eQ4JIPNZLDMfuqds26fHHkItheCeKq 0bpSWgZ/vefzSpBAOGsHO6Tu83Okx9qsZhL83Qw9srs0m8NUzwazKkPDCUIW0sUZzgvp svcQ== X-Gm-Message-State: AOAM530cjKiUT1t17nFkkDglthGm8mj7evJGDQzYfFnJfpMVjHfphhrT Otzf6rp75sHddT0tqIuBy6Cym6K8QeQy2KdlKoIsOsGmK5A= X-Google-Smtp-Source: ABdhPJxCHrPFffIiDTqKIk2SMYaHxcMaQbGYxf3W1buibqFAo3LPbwYEX6aqh48pF1Wx5QFSWzsaFVQZoDhw0Qfz2B4= X-Received: by 2002:a17:906:a182:: with SMTP id s2mr20583804ejy.526.1597771079460; Tue, 18 Aug 2020 10:17:59 -0700 (PDT) MIME-Version: 1.0 From: Ryan Stone Date: Tue, 18 Aug 2020 13:17:48 -0400 Message-ID: Subject: Is anybody using ng_pipe? To: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWHfy2cGpz4NV8 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=VwSoPP6l; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2a00:1450:4864:20::62e as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-0.17 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62e:from]; NEURAL_HAM_SHORT(-0.17)[-0.174]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 17:18:03 -0000 I recently needed to be able to simulate a lossy, high-latency network in an environment where dummynet wasn't possible. I gave ng_pipe a try, and hit some major issues 1. Instead of configuring a packet drop rate, you configure a bit error rate, which I found significantly less intuitive 2. The use of BER makes for a very inconvenient implementation, as ng_pipe has to maintain a table of packet drop rates for every possible packet size 3. The table implementation isn't sized right for LRO or TSO, leading to ng_pipe going out of bounds of the array and panicking the system 4. The table calculation had two integer truncation bugs and used the wrong formula. I'm reasonably sure it would never calculate a probability other than 0 due a 64-bit constant being truncated to 32-bits. I'd like to dump all of this and just implement a packet loss rate, which would simplify all this immensely. Is anybody using ng_pipe with a non-zero BER who would object to this? Given this litany of issues I doubt it, but I thought that I'd be sure. From owner-freebsd-net@freebsd.org Tue Aug 18 17:28:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0DE7D3C24A3 for ; Tue, 18 Aug 2020 17:28:51 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWHvP6w8cz4P4C for ; Tue, 18 Aug 2020 17:28:49 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-ej1-x633.google.com with SMTP id g19so23008372ejc.9 for ; Tue, 18 Aug 2020 10:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=TxzeZiZTDI7ekkQ8ieEDHnmCAwnq0oHIylI1YY80hc4=; b=cwYERafzM3l4ak07RZqNtsTTVEShUB1uBapk36Sz9QQNfUXDMUSsD0OUF5OiuWgJcb yDSZ5ZJaRskq/FUxxyz7D3YIYvY1OH4PnzBRwzBI/DUZCvhUFKRXhdmshwQBsXhErphx OETeCKXw6C+x8ccgA6VJAbc5E8c2DjF77ZR3oo9diSrvV15LPB2GoITSQzyJijF2CJec PotOvAHB2ZAyMM2MrtO6Mfl/VlaZPpn6tggAo87w/K7MdH7zaKIRN/XfJlr1lUnCVkCv 60ypotTIaJI87ZpS7C7zbGhhlnJWa2j4rZ2NF/4Xu+047iDAeXgTSIN6MUS1mLnczmU1 mjEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=TxzeZiZTDI7ekkQ8ieEDHnmCAwnq0oHIylI1YY80hc4=; b=AyZPDV3T63+dyQ6SL4+w1WP4dH3AiOM6N9aGcZprHWmPyHNLD78gAS1p5Nzcd2meXK MJZ/q+965LAL5om1Zo5Y+C0OVwtNhd9sSUVz0r8r1CT9XZnHvl3A4p/XdgBylKECMo8r CpzurLw4+VC3NfvbJo/kbUf1PsjeRPn5mzu9yA0DFERG99WhHqHiaQ0Rly6PiBiKvRr1 301k0mtmf36Bo73Hk6zaH0yQBw0Zn+bL/EQjcTUIVCTmJUhWkJyiluSalttp3Xb/Z2N3 u38Em3lK3xJq/mo0hs1FGB+HSJP3Tkwd3YfAFmQH98WUaZsR2jkDQjgKug4dWcDOibSh dMvA== X-Gm-Message-State: AOAM531z3w/4XANm8+FQqaGcPiI4XEQOeJstmy+vMF52lFRyAa5eLWFz mb5S55s3aevyU8Hju3IR1KpF+ZpmbNDX15TnthlHwC8oRYs= X-Google-Smtp-Source: ABdhPJzvRqdzJhKFrmB20Ik94cvHFoCSIrLL++IP3mZVwq2pyDLUzuQCHUyUBuMDtMlVtS/lSAyydvAivhK9ccr6ZUs= X-Received: by 2002:a17:906:845:: with SMTP id f5mr327768ejd.34.1597771728196; Tue, 18 Aug 2020 10:28:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ryan Stone Date: Tue, 18 Aug 2020 13:28:37 -0400 Message-ID: Subject: Re: Is anybody using ng_pipe? To: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWHvP6w8cz4P4C X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cwYERafz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2a00:1450:4864:20::633 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [0.01 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_SHORT(0.01)[0.012]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::633:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 17:28:51 -0000 On Tue, Aug 18, 2020 at 1:17 PM Ryan Stone wrote: > 4. The table calculation had two integer truncation bugs and used the > wrong formula. I'm reasonably sure it would never calculate a > probability other than 0 due a 64-bit constant being truncated to > 32-bits. I've gone back and checked, and I was partially wrong on this point. I had gotten the idea that integer literals would be truncated to int, which is not true. The use of the wrong formula still means that packets are dropped at entirely the wrong rate, though. From owner-freebsd-net@freebsd.org Tue Aug 18 17:47:46 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 238203C2679 for ; Tue, 18 Aug 2020 17:47:46 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWJKC30Jsz4QZS for ; Tue, 18 Aug 2020 17:47:42 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 07IHle34066441; Tue, 18 Aug 2020 10:47:40 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 07IHldYZ066440; Tue, 18 Aug 2020 10:47:39 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <202008181747.07IHldYZ066440@gndrsh.dnsmgr.net> Subject: Re: Is anybody using ng_pipe? In-Reply-To: To: Ryan Stone Date: Tue, 18 Aug 2020 10:47:39 -0700 (PDT) CC: freebsd-net X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4BWJKC30Jsz4QZS X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [1.71 / 15.00]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.19)[-0.185]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 17:47:46 -0000 > I recently needed to be able to simulate a lossy, high-latency network > in an environment where dummynet wasn't possible. I gave ng_pipe a > try, and hit some major issues > > 1. Instead of configuring a packet drop rate, you configure a bit > error rate, which I found significantly less intuitive >From your background being packet network centric perhaps? Those of us who have line oriented, aka telecom, centric backgrounds BER is a very meaningful and useful metric. > 2. The use of BER makes for a very inconvenient implementation, as > ng_pipe has to maintain a table of packet drop rates for every > possible packet size Hum, that sounds like a poor implementation indeed. It seems like it would be easy to convert a BER into a packet drop probability based on bytes that have passed through the pipe. It should be easy to covert a BER into a packet drop rate, but doing the converse leads to quantization errors. I would rather see us keep the BER as the metric and fix what is broken rather than convert this to a packet drop rate.. > 3. The table implementation isn't sized right for LRO or TSO, leading > to ng_pipe going out of bounds of the array and panicking the system Code predates LRO and TSO, so not unexpected. > 4. The table calculation had two integer truncation bugs and used the > wrong formula. I'm reasonably sure it would never calculate a > probability other than 0 due a 64-bit constant being truncated to > 32-bits. You retracted this. > I'd like to dump all of this and just implement a packet loss rate, > which would simplify all this immensely. Is anybody using ng_pipe > with a non-zero BER who would object to this? Given this litany of > issues I doubt it, but I thought that I'd be sure. My gut instinc is that statistically BER leads to a more realistic model. -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-net@freebsd.org Tue Aug 18 18:37:59 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A95143C39DB for ; Tue, 18 Aug 2020 18:37:59 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWKRB2dk6z4TC9 for ; Tue, 18 Aug 2020 18:37:58 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 07IIbgRG036111 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Aug 2020 18:37:45 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: rysto32@gmail.com Received: from [10.58.0.10] (dadv@dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.16.1/8.16.1) with ESMTPS id 07IIbl4S048933 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 19 Aug 2020 01:37:47 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: Is anybody using ng_pipe? To: Ryan Stone , freebsd-net References: From: Eugene Grosbein Message-ID: <5410b88c-4b6c-c2ef-fa8d-4105bd923627@grosbein.net> Date: Wed, 19 Aug 2020 01:37:44 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,LOCAL_FROM, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 SPF_PASS SPF: sender matches SPF record * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * 2.6 LOCAL_FROM From my domains * -0.6 NICE_REPLY_A Looks like a legit reply (A) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 4BWKRB2dk6z4TC9 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [0.75 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[eugen]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; R_SPF_PERMFAIL(0.00)[empty SPF record]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.15)[-0.150]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 18:37:59 -0000 19.08.2020 0:17, Ryan Stone wrote: > I'd like to dump all of this and just implement a packet loss rate, > which would simplify all this immensely. Is anybody using ng_pipe > with a non-zero BER who would object to this? Given this litany of > issues I doubt it, but I thought that I'd be sure. Take a look at dummynet(4): kldload dummynet # adds (optional) queueing delay plus 10 ms additional delay ipfw pipe 1 config bw 100Mbit/s delay 10 # add packet drop probability ipfw add 3000 prob 0.05 deny ip from any to any in # apply bandwidth limit/delay ipfw add 3010 pipe 1 ip from any to any in From owner-freebsd-net@freebsd.org Tue Aug 18 18:43:13 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CF07E3C3AC4 for ; Tue, 18 Aug 2020 18:43:13 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWKYD6Kz3z4Tlt for ; Tue, 18 Aug 2020 18:43:12 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 07IIh0Sk036177 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Aug 2020 18:43:01 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: rysto32@gmail.com Received: from [10.58.0.10] (dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.16.1/8.16.1) with ESMTPS id 07IIh6pk049001 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 19 Aug 2020 01:43:06 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: Is anybody using ng_pipe? To: Ryan Stone , freebsd-net References: From: Eugene Grosbein Message-ID: <85991baf-675d-f76e-4bbd-6244794b1a26@grosbein.net> Date: Wed, 19 Aug 2020 01:42:58 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,LOCAL_FROM, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 SPF_PASS SPF: sender matches SPF record * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * 2.6 LOCAL_FROM From my domains * -0.6 NICE_REPLY_A Looks like a legit reply (A) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 4BWKYD6Kz3z4Tlt X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [0.77 / 15.00]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[eugen]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; R_SPF_PERMFAIL(0.00)[empty SPF record]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.13)[-0.125]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 18:43:13 -0000 19.08.2020 0:17, Ryan Stone wrote: > where dummynet wasn't possible Sorry, missed that. But why wasn't possible? If you could use ng_pipe, you could probably use ng_ipfw too, or maybe create small node ng_dummynet to connect NETGRAPH network with kernel-side dummynet directly. From owner-freebsd-net@freebsd.org Tue Aug 18 18:56:50 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C36BE3C4234 for ; Tue, 18 Aug 2020 18:56:50 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWKrx4WCKz4VHT for ; Tue, 18 Aug 2020 18:56:49 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ml6HJXGhliuNtI2tdeIKSA2RL0I9SaYxMOEmqxGDLEZM0HOt1BNOpVNn4dQjsXKGHD43zwpNgCAyA7ZQdaRjhjGoP3pbseApmVdDxQP/J3ZRUmhN26/+5/PMLu8wDNPdZzkN3C4P3kE5lU7SlKJx8JtEvgpoNAE9HSqUhywfFojBd3kWsxYOAdAK7uxA3Mqv+i9t8iKwrWF68y+9kbblKVJyH6ZPAU+3t82tf4sXNA755zpy1bcGFEjV6OLT5ekXrTh9GVEHigdCLjKvENFk1RgIwHF7DBVj+FhjP/f1v+65vYkLNQJzKyqfTl5UNBBdBsdc6lgDzgb/mW//b4JLvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4f4kes2ibck5oVuKhU2CHADCJ0HZYpDc0L37knNqX4A=; b=HrxrETtb38OpMVMbU+Hf3TcXrj0RsStnNa3F+7k0sibmyl5tAUezVvT5Bm4z/+NIiK+5DVSrhT+f69SiJOpujhKSMdJzmhqVGxj6UdCFB9R+0phkytOCuv/mGmh1EaRZGBoZaGL2xVfLvjE10bVS2JS58hPE5UiR2cIshMo1Khy+U4aNludk1WqzOr6y8E7lVJq2HIhAzHwN7tLZDV1k1xcybYVs3PrJ8rntKUUbbJ/m0QeYUtDUjisJe5ZAPXOB7QWY+UL3lSGTo+IKuldal0Gg3LSp9DDcmG/tvqzmndrIFHvcDPWqueTIkHcsG0kgxiivjmIxKidsDuAoKEePjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4f4kes2ibck5oVuKhU2CHADCJ0HZYpDc0L37knNqX4A=; b=BvBv4fNbT7ywpsnAY9NrMkE8gNhBVlAeXHJy5Iq9MGwPoPEzZBA2cSug9PhhPW+KeQ7crD3szauzTvkH6ubQj8w/xY/Lac/z3c2/e95kxEi78JavU/eUlEz6LYS+e1ZdEarXIXSmjq+TTUu8Tn4s7CcKf5gIcm16Z4MpMIWamss= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) by VE1PR08MB4685.eurprd08.prod.outlook.com (2603:10a6:802:ae::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.22; Tue, 18 Aug 2020 18:56:46 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647%6]) with mapi id 15.20.3283.026; Tue, 18 Aug 2020 18:56:46 +0000 Date: Tue, 18 Aug 2020 20:57:25 +0200 From: Marko Zec To: Ryan Stone Cc: freebsd-net Subject: Re: Is anybody using ng_pipe? Message-ID: <20200818205725.2e03c8cb@x23> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0602CA0004.eurprd06.prod.outlook.com (2603:10a6:800:bc::14) To VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (31.147.2.0) by VI1PR0602CA0004.eurprd06.prod.outlook.com (2603:10a6:800:bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16 via Frontend Transport; Tue, 18 Aug 2020 18:56:44 +0000 X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [31.147.2.0] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e93fcb33-41ad-45a5-0a6f-08d843a87485 X-MS-TrafficTypeDiagnostic: VE1PR08MB4685: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u1GHOM3scaGwa8+Dc3O618GrqnuWCFENUytJ4HaSlE1YU3Fm2+MKlLEt+pAB6vKnnvdyqopchIgdVkc4AbcwVaHn4EdRjP0ib2i7is4fPPbJ3Z92PIIG2w50zyJsyzxxXW+NU8Lfn14q8cyv6aqwgJtrB7OBjMu7ekeu54HPaTPCQ/zm1xpb2fp9uBqL6/L1X2HpMItA4ZrE0b9dhjg+8vPUSWqBkIY+DUkk79Z0LhCHeZT5w9g3qPS5azyDFGEHmOo0dsLCWbc5hIZZ4+TgBdyO2yh94+cM6QM4JvghVWBQOXo3Xq1QkFOfm42yV1iI1YIWnG2EY5suUIO+1uwvuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4783.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(39840400004)(346002)(376002)(396003)(366004)(136003)(186003)(86362001)(16526019)(53546011)(5660300002)(956004)(6666004)(6916009)(4326008)(8676002)(9576002)(316002)(2906002)(66476007)(786003)(55016002)(6496006)(33716001)(8936002)(66946007)(478600001)(26005)(52116002)(1076003)(9686003)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: NfFK8kCBoHrjjsrDKr6pbHEcuLvkuyrVshNdQfEYuXivE57zPMjLsOJAqiz8GucfyGa95K7VXjYYx5WvpJ9anjey2hJ1ODNHbrRKnj9OGCE/K4FmXjWwntWHtsskM5HGcQADZk7p9PePAPkmLiAuWKfHaWFVLHTHJW3v0vP+bXI/ZgElvdm3WNQJkYG6fP4e2s+VHN8amT8zVTHzuMvv68AwJe328wk5DfEkaR/6fUh/0iXjAJXXXWLXQH63GXwm3mK4OohvRdmVBMFbqsP2ikMMqLVintmrfW95pJD5C7Y7ZcEBblBkLJa026qPuEPo4LvsuBnQ7v90RLZRIp2vTG+/EdQNkpBl/70ZcAN8j6EIacKWu1Ns3T4JVJ1XI+hdkbrkwYzTxEItvd/q5m+ZI3CLXqDnTFwMxkiAMzqqPxmqZqvB21N15q11t3ZSCiC9LMJwmGQ6sIN3fVD2YQEN29RqkQ+FPgP4S+HlDzh2aZrVi3UC9QLmWhyiEDq0zSC8E0mgPn3lAximAu2vOlkCAFRpTAsAQdiL7CNAC8VyvWwLDvkM+sU2AmuGaiKD12biiqRWXqrTcl7lEoRkxzhQXCCD/fTYYHBMgfz0xV6rVDG6jHwe8+w7pob2Xsba7ChP X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: e93fcb33-41ad-45a5-0a6f-08d843a87485 X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4783.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2020 18:56:46.3616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rogZbC5pL4bUE/C8Dfk7iKx3WmEKScBlOqnFu4VkKemIUUAPgHf1MqP3wpE+TB0W X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4685 X-Rspamd-Queue-Id: 4BWKrx4WCKz4VHT X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ferhr.onmicrosoft.com header.s=selector2-ferhr-onmicrosoft-com header.b=BvBv4fNb; dmarc=none; spf=pass (mx1.freebsd.org: domain of zec@fer.hr designates 40.107.22.79 as permitted sender) smtp.mailfrom=zec@fer.hr X-Spamd-Result: default: False [-1.02 / 15.00]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[ferhr.onmicrosoft.com:s=selector2-ferhr-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[zec]; RECEIVED_SPAMHAUS_PBL(0.00)[31.147.2.0:received]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; DMARC_NA(0.00)[fer.hr]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[ferhr.onmicrosoft.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.92)[-0.916]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.22.79:from]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_IN_DNSWL_LOW(-0.10)[40.107.22.79:from] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 18:56:50 -0000 On Tue, 18 Aug 2020 13:17:48 -0400 Ryan Stone wrote: > I'd like to dump all of this and just implement a packet loss rate, > which would simplify all this immensely. Is anybody using ng_pipe > with a non-zero BER who would object to this? Given this litany of > issues I doubt it, but I thought that I'd be sure. Yes, the BER feature is being actively used, please don't nuke it. If you wish to supplement it with PER, which is less realistic but simpler to implement, by all means go ahead... > On Tue, Aug 18, 2020 at 1:17 PM Ryan Stone wrote: > > 4. The table calculation had two integer truncation bugs and used > > the wrong formula. I'm reasonably sure it would never calculate a > > probability other than 0 due a 64-bit constant being truncated to > > 32-bits. > > I've gone back and checked, and I was partially wrong on this point. > I had gotten the idea that integer literals would be truncated to int, > which is not true. The use of the wrong formula still means that > packets are dropped at entirely the wrong rate, though. The probability that a frame is completely unaffected by BER events, and thus shouldn't be dropped, is currently computed as Ppass(BER, plen) = Psingle_bit_unaffected(BER) ^ Nbits(plen) where Nbits(plen) = plen * 8 + user-configurable framing overhead. This is a crude model yet one which was fairly simple to implement. Could you elaborate why you consider it to be entirely wrong? Cheers, Marko From owner-freebsd-net@freebsd.org Tue Aug 18 19:21:16 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 101F53C4C0B for ; Tue, 18 Aug 2020 19:21:16 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward500o.mail.yandex.net (forward500o.mail.yandex.net [37.140.190.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWLP608jRz4X7P; Tue, 18 Aug 2020 19:21:13 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mxback5g.mail.yandex.net (mxback5g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:166]) by forward500o.mail.yandex.net (Yandex) with ESMTP id D96F7607FB; Tue, 18 Aug 2020 22:21:10 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback5g.mail.yandex.net (mxback/Yandex) with ESMTP id lRlwLzMoho-LAGuP2ut; Tue, 18 Aug 2020 22:21:10 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1597778470; bh=kxIIZbSjTTuG+oiBmAZM29tiONa9L/JVOgWpaFDBLF8=; h=References:Date:Message-Id:Subject:In-Reply-To:To:From; b=XnfnVt1BUleruuD/9OCWujZapkyDUseveDpP4IxjYLx4JpFxNMoNTcsl+wFKkEGG/ N3E3BRjWuTe351fKKZgha4y0y4ulz+Ee9VFJzJ3p+pNZOoTfUDYXXXGNzPQIiy5JTC 0LG/DXUWBbk4/tBHOOQTAU+e9n6xs9GDqG0yIptA= Received: by sas2-e76feb6221c0.qloud-c.yandex.net with HTTP; Tue, 18 Aug 2020 22:21:10 +0300 From: Alexander V. Chernikov To: Julian Elischer , "freebsd-net@freebsd.org" In-Reply-To: <0f321bdc-240e-0f85-915b-c9bdd7daa01b@freebsd.org> References: <236161595078191@mail.yandex.ru> <348771597489519@mail.yandex.ru> <0f321bdc-240e-0f85-915b-c9bdd7daa01b@freebsd.org> Subject: Re: net.add_addr_allfibs=1 behaviour deprecation X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 18 Aug 2020 20:21:10 +0100 Message-Id: <2070101597777959@mail.yandex.ru> X-Rspamd-Queue-Id: 4BWLP608jRz4X7P X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ipfw.ru header.s=mail header.b=XnfnVt1B; dmarc=none; spf=pass (mx1.freebsd.org: domain of melifaro@ipfw.ru designates 37.140.190.195 as permitted sender) smtp.mailfrom=melifaro@ipfw.ru X-Spamd-Result: default: False [-0.62 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[ipfw.ru:s=mail]; FREEFALL_USER(0.00)[melifaro]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:37.140.128.0/18]; RWL_MAILSPIKE_GOOD(0.00)[37.140.190.195:from]; DMARC_NA(0.00)[ipfw.ru]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[ipfw.ru:+]; MIME_BASE64_TEXT(0.10)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.42)[-0.423]; MIME_HTML_ONLY(0.20)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13238, ipnet:37.140.128.0/18, country:RU]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_IN_DNSWL_LOW(-0.10)[37.140.190.195:from] MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 19:21:16 -0000 From owner-freebsd-net@freebsd.org Tue Aug 18 19:27:27 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 24E893C52C7 for ; Tue, 18 Aug 2020 19:27:27 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward500p.mail.yandex.net (forward500p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWLXF1VdRz4Y3R for ; Tue, 18 Aug 2020 19:27:25 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mxback14g.mail.yandex.net (mxback14g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:93]) by forward500p.mail.yandex.net (Yandex) with ESMTP id A8CC494011D; Tue, 18 Aug 2020 22:27:20 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback14g.mail.yandex.net (mxback/Yandex) with ESMTP id w381f0sYOa-RJeWQAZ8; Tue, 18 Aug 2020 22:27:20 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1597778840; bh=Q4UMbHQWfsODTTkasgqno3FhSRI2NHmeFf9z7BpShZ0=; h=References:Date:Message-Id:Subject:In-Reply-To:To:From; b=TC2mBiqjn8zgXJos9s1fgWBWRW5tNLgKnNWX/eh6fdmJAFBSo/Q9JzjHceq3I0UTl O0mp3RNQUeoyK3xsDdlr6kmFzQYPX9MgeAI0X8er6EXafCVCL/XuBJ01LjVNJVPrDs RSKicTtbcBaehF+tATwNU4u85ID3NawK0aBm5s8k= Received: by sas8-da6d7485e0c7.qloud-c.yandex.net with HTTP; Tue, 18 Aug 2020 22:27:19 +0300 From: Alexander V. Chernikov To: Grzegorz Junka , "freebsd-net@freebsd.org" In-Reply-To: References: <236161595078191@mail.yandex.ru> <348771597489519@mail.yandex.ru> <0f321bdc-240e-0f85-915b-c9bdd7daa01b@freebsd.org> Subject: Re: net.add_addr_allfibs=1 behaviour deprecation MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 18 Aug 2020 20:27:19 +0100 Message-Id: <837391597778482@mail.yandex.ru> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 4BWLXF1VdRz4Y3R X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ipfw.ru header.s=mail header.b=TC2mBiqj; dmarc=none; spf=pass (mx1.freebsd.org: domain of melifaro@ipfw.ru designates 2a02:6b8:0:1472:2741:0:8b7:110 as permitted sender) smtp.mailfrom=melifaro@ipfw.ru X-Spamd-Result: default: False [-1.27 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[ipfw.ru:s=mail]; FREEFALL_USER(0.00)[melifaro]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a02:6b8:0:1000::/52:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[ipfw.ru]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ipfw.ru:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.67)[-0.666]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13238, ipnet:2a02:6b8::/32, country:RU]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_IN_DNSWL_LOW(-0.10)[2a02:6b8:0:1472:2741:0:8b7:110:from] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 19:27:27 -0000 18.08.2020, 09:17, "Grzegorz Junka" : > On 18/08/2020 07:54, Julian Elischer wrote: >>  The reason for the two behaviours is that there are two ways that the >>  previous behaviour of  "add addresses to the only FIB" could be >>  interpreted and extended once multiple fibs became available. The >>  single fib case could be interpreted as either of: >> >>  "Add to All N fibs where N == 1"    or     "add to the first (of 1) >>  fibs". >>  I decided to do both :-) >> >>  At Ironport where I wrote it we had a scenario where I didn't want to >>  have wrong entries in all the fibs when a new interface was brought >>  up. Even for a moment. An other scenarios where  for example a tunnel >>  uses fib 1 but the rest of the system uses fib0 (which points through >>  the tunnel) The addition of new routes into the tunnel's route when a >>  new virtual interface is brought up pointing through the tunnel to the >>  same address, leads in the tunnel immediately redirecting packets >>  through itself which ends in tears.     SO the obvious thing to do was >>  to make it possible to only add the entry in the fib that was the >>  default fib or in the case of Ironport, the fib that was the default >>  fib of the process adding the interface. >> >>  If you had to make a choice I think the '0' choice is the way to go. >>  All other fibs need to be populated deliberately.. >> >>  On 8/15/20 4:24 AM, Alexander V. Chernikov wrote: >>>  18.07.2020, 14:22, "Alexander V. Chernikov" : >>>>  Dear FreeBSD users, >>>> >>>>  I would like to make net.add_addr_allfibs=0 as the default system >>>>  behaviour and remove net.add_addr_allfibs. >>>>  To do so, I would like to collect use cases with >>>>  net.add_addr_allfibs=1 and multiple fibs, to ensure they can still >>>>  be supported after removal. >>>> >>>>  Background: >>>> >>>>  Multi-fib support was added in r178888 [1], 12 years ago. Addition >>>>  of interface addresses to all fibs was a feature from day 1. >>>>  The `net.add_addr_allfibs` sysctl  was added in r180840 [2], 12 >>>>  years ago. >>>> >>>>  Problem: >>>>  The goal of the fib support is to provide multiple independent >>>>  routing tables, isolated from each other. >>>>  `net.add_addr_allfibs` default tries to shift gears in the opposite >>>>  direction, unconditionally inserting all addresses to all of the fibs. >>>> >>>>  It complicates the logic, kernel code and makes control plane >>>>  performance decrease with the number of fibs. >>>>  It make impossible to use the same prefixes in multiple fibs, which >>>>  may be desired given shortage of IPv4 address space. >>>> >>>>  I do understand that there are some cases where such behaviour is >>>>  desired. >>>>  For example, it can be used to achieve VRF route leaking or binding >>>>  on address from different fibs. >>>>  I would like to collect such cases to consider supporting them in a >>>>  different way. >>>> >>>>  The goal is to make net.add_addr_allfibs=0 default behaviour and >>>>  remove net.add_addr_allfibs. >>>>  It will simplify kernel fib-related code and allow bringing more >>>>  fib-related features. It will also improve fib scaling. >>>  No objections has been received. >>>  Next steps: >>>  * Switch net.add_addr_allfibs to 0 ( >>>  https://reviews.freebsd.org/D26076 ) >>>  * Provide an ability to use nexthops from different fibs >>>  * Remove net.add_addr_allfibs >>>>  Timeline: >>>>  Aug 1: summarising feedback and the usecases, decision on proceeding >>>>  further >>>>  Aug 20 (tentative):  patches for supported usecases >>>>  Sep 15 (tentative):  net.add_addr_allfibs removal. >>>> >>>>  [1]: [base Contents of >>>>  /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?revision=178888&view=markup) >>>>  [2]: [base Diff of >>>>  /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?r1=180839&r2=180840&) >>>> >>>>  /Alexander > > Agree completely, defaulting "add_addr_allfibs" to 1 broke many existing > installations, which goes against the least surprise principle so many > times advocated on FreeBSD lists. > > This is just one example: > https://forums.freebsd.org/threads/strange-behavior-of-setfib-since-freebsd-12-0.73348/ > > Now, changing the default again might again break existing > installations, which shouldn't be a reason for not doing it, but might > be a reason to better communicate it this time around. I plan to communicate it the following way: 1) this thread 2) GONE_IN13 in the sysctl (which will print console message when set to 1) 3) Release notes Do you think there are other communication channels one should try to use? > > GrzegorzJ > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Tue Aug 18 21:01:52 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 21BD83C6FE1 for ; Tue, 18 Aug 2020 21:01:52 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWNdB4rx2z4fSv for ; Tue, 18 Aug 2020 21:01:50 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-ed1-x534.google.com with SMTP id v22so16384709edy.0 for ; Tue, 18 Aug 2020 14:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gYv0wU2plGZaHtWPcVAedk+GPQG8eI2bCJOlFi0vIRg=; b=TXFiQLuYeIIEwrYIe37ejR560l6LKVPUYgV9Y9HyUY5buQ4XD7WAGyA7mi7V8c2Uyd ggwQGLxezy0/Le65YnAK+5n2usKFcu49CdMjGu56IvoYK3Ffqby+WwJtg8CGEhI4WNbe iEV0qBO195pi7S7EVV/ZeQdwTvl6h38KLAYFakNvdkCrWiECaIbXwsb3WDhpKUKynJNS +jMpLWdMqFlGpKyIuqk2cK9KEmTTH/huBCiVByeyZ8/7R81QBoaXJr1LLdUGRN198pUD EvOtFORcguBX7BvFPnJwtDmp27kNcyjC9MonxhSMeIos1TsDYnvzipLT6lQRqtkPbnzH 6TjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gYv0wU2plGZaHtWPcVAedk+GPQG8eI2bCJOlFi0vIRg=; b=gSbxwTwArqPsfCujh0fyNxzTtsoXF6aGgtDGBx8lXpX1r0ZMZeDX6hzyWa9h2Y476X wP8x0k/zkafNewGhYtWg5g5tEZOLR4x/PV/t423HioEbZNRdmh9odY1kGkFgO2B++DG1 YuZrxqQLy+Hj1i+2hDR+2tuptpZ6UDxZTkOL55lQtmxoamssLzBpFX39bVRv02SePqnq sgE1q2IwdFiSxcGwtIWA4DXK8Mu17GGzMQmJh8CKy6BWDx9o2tbGfXoP5EvYtkRoG0vH Mb1HDpBoL6/cKqQ9s4ECSwlQyHk5NPcz+q+K0NAU/grWj8JmDtS5T60UQtd68EYxB82b cJzQ== X-Gm-Message-State: AOAM533Sv4IkITJqcHWRaf+oImysu/GJqt8qefZP0LY9yxqlWYm09dxJ MI4T18QzSoVD3pIuM76YiVgYtygo/HtFSVI7rCf/Gy4bi4119A== X-Google-Smtp-Source: ABdhPJwG8dtN49AtlXA8/hLUidacEEVF/dyFO0muHmhI9XjX7T99KwhSXtomU9Ac1xmT0Ei8WgBt8i0hnnETeY7a0hY= X-Received: by 2002:a50:f396:: with SMTP id g22mr21903451edm.220.1597784508216; Tue, 18 Aug 2020 14:01:48 -0700 (PDT) MIME-Version: 1.0 References: <20200818205725.2e03c8cb@x23> In-Reply-To: <20200818205725.2e03c8cb@x23> From: Ryan Stone Date: Tue, 18 Aug 2020 17:01:37 -0400 Message-ID: Subject: Re: Is anybody using ng_pipe? To: Marko Zec Cc: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWNdB4rx2z4fSv X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=TXFiQLuY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2a00:1450:4864:20::534 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-0.09 / 15.00]; SUBJECT_ENDS_QUESTION(1.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::534:from]; NEURAL_HAM_SHORT(-0.09)[-0.089]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MAILMAN_DEST(0.00)[freebsd-net]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 21:01:52 -0000 On Tue, Aug 18, 2020 at 2:43 PM Eugene Grosbein wrote: > Sorry, missed that. But why wasn't possible? There's a daemon running on the system that handles most network configuration. It's quite inflexible and will override any manual configuration changes. It manages firewall rules but is ignorant of netgraph, so it will remove any dummynet rules but leave netgraph configuration alone. It was significantly easier to just use ng_pipe, even after having to fix or work around the bugs, than it was to fight the daemon. On Tue, Aug 18, 2020 at 2:56 PM Marko Zec wrote: > The probability that a frame is completely unaffected by BER events, > and thus shouldn't be dropped, is currently computed as > > Ppass(BER, plen) = Psingle_bit_unaffected(BER) ^ Nbits(plen) The problem is in its calculation of Psingle_bit_unaffected(BER). The BER is the fraction of bits that are affected, therefore it is the probability that a bit is affected. But for some reason, Psingle_bit_unaffected(BER) is calculated as 1 - 1/BER rather than 1 - BER. This leads to the probability table being wrong. For example, given a BER of 23500000, the probability that a 1500-byte packet is not dropped is: (1 - 23500000/2**48)**(1500 * 8), which is approximately 99.00%. However, ng_pipe calculates a fixed-point probability value of 281460603879001. To calculate whether a frame should be dropped, ng_pipe takes this probability value and shifts it right by 17, yielding 2147373991. It then calls rand() to generate a random number in the range [0,2**31-1]; if the random number is larger than the probability value than it is dropped, otherwise it is kept. The chances that a packet is kept is therefore 2147373991/(2**31 - 1), or about 99.99%. It's easy enough to fix this one, but I wasn't sure that it would be so easy to fix the TSO/LRO issue without significantly increasing the memory usage, so I wanted to gauge whether it was worth pursuing that avenue or if a simpler model would be a better use of my time. The feedback is definitely that a simpler model is *not* warranted, so let's talk about fixing TSO/LRO. On Tue, Aug 18, 2020 at 1:47 PM Rodney W. Grimes wrote: > Hum, that sounds like a poor implementation indeed. It seems > like it would be easy to convert a BER into a packet drop > probability based on bytes that have passed through the pipe. I'm not quite following you; can you elaborate? Would this solution require us to update some shared state between each packet? One advantage of the current approach is that there is no mutable state (except, of course, when configuration changes). From owner-freebsd-net@freebsd.org Tue Aug 18 21:43:44 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30CFC3A85E4 for ; Tue, 18 Aug 2020 21:43:44 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062a.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::62a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWPYW0Jlsz3TqC for ; Tue, 18 Aug 2020 21:43:42 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PdbFbxoH8tYm/9YYF0H0yiWr1rBP4T0cyz0WAFgw0gfZwaymJuDRrHEQF2sbncEajIDVvIc0Nz/CYt2CFj7rRtZOEkIIcqyo0ihAp0vWT7+NMACVi3HAJP2BlZayWvmk0TwM3gUD85LoJ/hIaJslXrQ7Sv7QXNj9ehKkYjvJf6ZjLJeuiW6ypiON+MrjUZAXlZSsX2sKdhAQSBmfw3m7Y33MAR8qWcym6ChnJoXYUwBkz/quVdgK6KdmuFXbtsKRA/mkHMJi/MHW0iVxFL3+oZ0yb442BL873+HwWdyQWV/eKKjrmbT7rxVbglt9Kd9sr7NheiqwAaEjBg1ktjN9Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a7ZAmfSiluz+6JfR9mfKABpqh69CgBBvQb5ywEJuVWs=; b=aDo0vdfT+jpGQpb2ObQS0+F9BjC2b3T5i9MCruGit8jUrXoW014BoT54Rd/TeqSmPJhNPQ4KN6rmTN5cvK5u8I3Vq4SGn0VlQH7ZSMj8FXATTSIBoPNpyca7EqozGCrGq1kT5pvwgzh5rKobz98/HJQqf95hgLiVrG25FP+GhOBO8aoFzpzAzx0FNKdiIKO0J0BXAGs2fribsiqyJL/WpC5bujwjq1fccokHwcu+oEApAPj2fp2kUpGXCLMKCASycjD0fWgA8AXUN0BdzCvyRShvyiLQVP0AohTOlwK/5G9UTBfmb/3vOS0Z+e6CBtl7EzIvW51Ntuuzcpx6VGINoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a7ZAmfSiluz+6JfR9mfKABpqh69CgBBvQb5ywEJuVWs=; b=KMBhG+BDCNZVJTXetD6nWcj/qEGUAjcmhFN7po/E0uy9uzwDGrH2VaV0f+EH1mwE0s4fVjjlDW1Jkfs0lG3DFqnelKJ5iuPw2jp0yX+YpODdYxErq3LbUAsbAlYotZH80NOY+/DcHoHrXdkjW3fEIEfJkXd4Nq9opkER2Zqvw4c= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) by VE1PR08MB5646.eurprd08.prod.outlook.com (2603:10a6:800:1a9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Tue, 18 Aug 2020 21:43:39 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647%6]) with mapi id 15.20.3283.026; Tue, 18 Aug 2020 21:43:39 +0000 Date: Tue, 18 Aug 2020 23:44:16 +0200 From: Marko Zec To: Ryan Stone Cc: freebsd-net Subject: Re: Is anybody using ng_pipe? Message-ID: <20200818234416.5aec459c@x23> In-Reply-To: References: <20200818205725.2e03c8cb@x23> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR04CA0122.eurprd04.prod.outlook.com (2603:10a6:803:f0::20) To VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (31.147.2.0) by VI1PR04CA0122.eurprd04.prod.outlook.com (2603:10a6:803:f0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24 via Frontend Transport; Tue, 18 Aug 2020 21:43:36 +0000 X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [31.147.2.0] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fbb57606-c030-460b-d693-08d843bfc4ca X-MS-TrafficTypeDiagnostic: VE1PR08MB5646: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: beyHjUjNkSvD4Jmyjj+BLRDv7mcdk1vTUu6kQkwZa0SmReprW1RNOMTuWLKK8VngteCr8D9idBzmvQXpFeyLQLx7mnbgvdTiZlNbTdSwB0uLc1wHe9+V9DUCOMGxfAEkKQBZZxhD63fpCA5z4/vYNp6F69CK0ckxzP9lRci4PQgEO/IdKDR4Fh6Xy/+AV5woG/KEQ0rUikZuBkM2ltQq19s5b1MzjuYfW3xT9ssXkY/I/fQBrwVWcsTwOK5NKX8Lx4OBzoC01LJBcsi1msQ1dV9MVTyVzEqadDSBmFpMQsbJQ3Rgfcfy4rsSVfTkmIBDXafs8DKNbbR+VrETG/N4/w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4783.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(366004)(136003)(396003)(376002)(39840400004)(956004)(6496006)(9576002)(4326008)(26005)(83380400001)(55016002)(8676002)(9686003)(86362001)(8936002)(53546011)(478600001)(52116002)(6916009)(6666004)(1076003)(33716001)(2906002)(5660300002)(66946007)(186003)(66556008)(66476007)(16526019)(786003)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: UJSTILnjC+lJL/kIgv2wq3ds5HX0BhH3DGuYkGeu4KBAxxTybVsVJIPho8zTegyNHu14ppU34ikJIVodYpGMu5iRVMBmPK+hgPSHLVHSEUggdA88vmfo1uA2vTjJDN0Vgq9KUphOVh2eTr8yiW8uKRuxta1Srx/wem3hAkqLxagdwHTpcprCEqXq3OJa6my+oyl3k7hf5lY+GVHCvFNYLK0u+Md0eLGeDWcaxsGGH1RiwrNbaqwNjN6T9gWfql2UUtxyuXMIjq6llhVImU/dF9AGoAC5XEBS+7EPMp/4QYtMLLLffRNTQnBPRAdrIRQintZSrt19h1bxN1DqyDTWt9iQDz9MBSgZU8ySWlqJgJ6jpZIQ5vcOY86IN79YHVmJmrexYSV/BbBfS06ZA9GqTs/0XZu94ijYtbIHrsBz83JfSy3bB5okpl0dwaK7h90mLIra5R7mkoEO/7qEdx/X2zWe+TBdGjybh8ViD6+TJYdGIVGpKnuwcLwk3NKF/+Rv4xplYyCYGWXNwlwZrZXc1tOmEQkrCrk78hVCxfGkTRnn6etElG15JHzJjtS6HjpqH/UZ28K5RlOHXUvSsCtEzFucnwK1wYITza5RAjAaSAAQuuHuC6B/qiXmarTB7nET X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: fbb57606-c030-460b-d693-08d843bfc4ca X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4783.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2020 21:43:39.4575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64KqLPwnGXVs/W4YpSSq0EMq/91pRWonH7IT/EBp4bvo7Wftn6OH5O9jRhFxjAAU X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5646 X-Rspamd-Queue-Id: 4BWPYW0Jlsz3TqC X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ferhr.onmicrosoft.com header.s=selector2-ferhr-onmicrosoft-com header.b=KMBhG+BD; dmarc=none; spf=pass (mx1.freebsd.org: domain of zec@fer.hr designates 2a01:111:f400:7e1a::62a as permitted sender) smtp.mailfrom=zec@fer.hr X-Spamd-Result: default: False [-0.51 / 15.00]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[ferhr.onmicrosoft.com:s=selector2-ferhr-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[zec]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f400::/48]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[fer.hr]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[ferhr.onmicrosoft.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2a01:111:f400:7e1a::62a:from]; NEURAL_HAM_SHORT(-0.51)[-0.511]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RECEIVED_SPAMHAUS_PBL(0.00)[31.147.2.0:received] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 21:43:44 -0000 On Tue, 18 Aug 2020 17:01:37 -0400 Ryan Stone wrote: ... > On Tue, Aug 18, 2020 at 2:56 PM Marko Zec wrote: > > The probability that a frame is completely unaffected by BER events, > > and thus shouldn't be dropped, is currently computed as > > > > Ppass(BER, plen) = Psingle_bit_unaffected(BER) ^ Nbits(plen) > > The problem is in its calculation of Psingle_bit_unaffected(BER). The > BER is the fraction of bits that are affected, therefore it is the > probability that a bit is affected. But for some reason, > Psingle_bit_unaffected(BER) is calculated as 1 - 1/BER rather than 1 - > BER. Since in ng_pipe we define BER as an one error in BER bits (integer value), wouldn't your formula P = 1 - BER yield results less than or equal to zero for all non-zero values of BER? The domain of P is [0..1], so that won't fly. Your analysis seems to be based on an assumption that the BER parameter is given as a multiplier to 0.5**48, which it is not. The proper fix would be to clarify the current BER parameter semantics in ng_pipe(4), not to break bridges with the existing scripts / software which rely on ng_pipe. Cheers, Marko > This leads to the probability table being wrong. For example, > given a BER of 23500000, the probability that a 1500-byte packet is > not dropped is: > > (1 - 23500000/2**48)**(1500 * 8), which is approximately 99.00%. > > However, ng_pipe calculates a fixed-point probability value of > 281460603879001. To calculate whether a frame should be dropped, > ng_pipe takes this probability value and shifts it right by 17, > yielding 2147373991. It then calls rand() to generate a random number > in the range [0,2**31-1]; if the random number is larger than the > probability value than it is dropped, otherwise it is kept. The > chances that a packet is kept is therefore 2147373991/(2**31 - 1), or > about 99.99%. > > It's easy enough to fix this one, but I wasn't sure that it would be > so easy to fix the TSO/LRO issue without significantly increasing the > memory usage, so I wanted to gauge whether it was worth pursuing that > avenue or if a simpler model would be a better use of my time. The > feedback is definitely that a simpler model is *not* warranted, so > let's talk about fixing TSO/LRO. > > On Tue, Aug 18, 2020 at 1:47 PM Rodney W. Grimes > wrote: > > Hum, that sounds like a poor implementation indeed. It seems > > like it would be easy to convert a BER into a packet drop > > probability based on bytes that have passed through the pipe. > > I'm not quite following you; can you elaborate? Would this solution > require us to update some shared state between each packet? One > advantage of the current approach is that there is no mutable state > (except, of course, when configuration changes). From owner-freebsd-net@freebsd.org Tue Aug 18 22:04:39 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A07A13A8D2A for ; Tue, 18 Aug 2020 22:04:39 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWQ1f2Hqpz3W2X for ; Tue, 18 Aug 2020 22:04:38 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-ed1-x532.google.com with SMTP id t15so16448118edq.13 for ; Tue, 18 Aug 2020 15:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j2FG7v8DiqSYEiNGTDkqH3q4NcIQMIfjdYegBoMEDJ4=; b=mUyCVfio+mmUyIsiCv2GFf96rX6F1/iBv5tpiXCVTwEPzX8cZfLChnL6zh4eex5KWj wwLbAfypBD1ysRmLf75YiqeBoBbZSRhwtQOUcb1kLKSRSLpzeu5Mk3GOVzN11tzZh1Rf civVhbGpJ2CvG83x1C2CK1X26j3eaOJvh9u9AzAUxxIwQUKiynGXV/sdJE2nXNdV3OY9 Mkj2AxKMLcPUKhgI4fAAgjZJVSl6uNZpIotVnOjTRyYqxBD2N6oh+edOpjEf6wjzGVRI PBhzEhQTcf9OeRnJN/zd8EKIJFoQ25PFls0d6lumpPHyvVCQYE1603aRs1MbT7jyXZX7 ylTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j2FG7v8DiqSYEiNGTDkqH3q4NcIQMIfjdYegBoMEDJ4=; b=f+LkvQLzMhET1Kd/hpE33KwbDUHqjK/y0Mv3njRB99/1VVnVZhEtC4F4h2JpozBUR0 XSxQ5H56xYtsD4vNcYZRrxhCuQ8i9ZT0P+rCWpEds+O9SeAU/BlpagdsUc5fMsl+rt/P kAgfZXfhXroA0oopB33yOE93UVeT7qpGCgNEpXXfYnh4BjIaziT4i/r3sdotvyYlM5E1 y1nx3r90jmXQN5hqYMXMuxhWwY/Y+Gs6pf+Jlr4sCNNxis+xeezce4qGJ44UEVg9ViNZ eHaD8AXkPL7PYfK+I12qmUHuUeenXXRIDZ4sG4whmvgq0/y35WrV70Cb24YcL5E56Ktz PQDw== X-Gm-Message-State: AOAM532/izh5/Qjo+LG0ghANdm7b4nx19/FQYoSbvZnYKJ6bbrjHUDhi 2IETSL3mtoyO9RzVgI1UxX7YeOKWS8HPE+NkN2k= X-Google-Smtp-Source: ABdhPJwv4eRgXDvlc3wtu94wkd9Gi2KgPaOWEtxulSMHrRmtTlRV2j++/l9CvZOM2cyP3OvK4kn59ts4lJtNqpEba7Y= X-Received: by 2002:a05:6402:2206:: with SMTP id cq6mr22258022edb.349.1597788276423; Tue, 18 Aug 2020 15:04:36 -0700 (PDT) MIME-Version: 1.0 References: <20200818205725.2e03c8cb@x23> <20200818234416.5aec459c@x23> In-Reply-To: <20200818234416.5aec459c@x23> From: Ryan Stone Date: Tue, 18 Aug 2020 18:04:24 -0400 Message-ID: Subject: Re: Is anybody using ng_pipe? To: Marko Zec Cc: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWQ1f2Hqpz3W2X X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=mUyCVfio; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2a00:1450:4864:20::532 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [0.02 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_SHORT(0.02)[0.015]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::532:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 22:04:39 -0000 On Tue, Aug 18, 2020 at 5:43 PM Marko Zec wrote: > Since in ng_pipe we define BER as an one error in BER bits (integer > value), wouldn't your formula P = 1 - BER yield results less than or > equal to zero for all non-zero values of BER? The domain of P is > [0..1], so that won't fly. > > Your analysis seems to be based on an assumption that the BER > parameter is given as a multiplier to 0.5**48, which it is not. > > The proper fix would be to clarify the current BER parameter semantics > in ng_pipe(4), not to break bridges with the existing scripts / software > which rely on ng_pipe. > > Cheers, > > Marko The manpage defined the BER parameter as follows: u_int64_t ber; /* errors per 2^48 bits */ If we instead want to change the documentation to match the implementation, that's fine too. From owner-freebsd-net@freebsd.org Tue Aug 18 22:18:18 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC4773A9435 for ; Tue, 18 Aug 2020 22:18:18 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140089.outbound.protection.outlook.com [40.107.14.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWQKP5mvVz3WyG for ; Tue, 18 Aug 2020 22:18:17 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c3y1i3uZjQsDECXE5s0b5VNEdYRqGmzHf/IEVKYcMAayrC0HTlESSq7nXlyFh3I5m9vryl2J2d/O9xWW6nkKI89gwqqqgMYYoh/R8BPF9YA7+zfmIRn3cft7ETFcB6TSk9S2IphP/2iZ0L9gNFtduZAixi+98xYCGoIvhuztkUInwmvvdg0tuF+wMSDDeXkGMGPwbxlOAE+0wVFg5Q6uxjzlzm+fQzY2b95S9SmpKZtNsuFC93zz/TO9pcnNGMATgUguODlhncYla8haIpAVWXQ0xjYJQ+5ZMi0GrSQ4y99HpdcKYDLioWXFY0tGy1HKDhw2SzSX+QBSpMHkg/quaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObwOIMPAvc6+tDSmvGOS34Jc/Js1hf31KhAJ+cPpQX0=; b=nsZiEuLl8uvT800+ROA03+9fNs6zivTVzF7gKI6C6kjk3nPArLyAKfbmctg8x4cqJbfGnOVwPSLm11kADNDTuaqVKC+S/Zv24pRZoZaq/5feTlhlSZBHi5/bko23UledJUizCDoLOypCgMbfXkV8pPZ1n1bUUhl2kdTIHyDtP7GgPNM2Zzmr6b5MBP+7qARPNNmhzPSp/NUyxB0t2fM0h2nOZwAYw/wtlg3EiBXuL69O3P4xp3sZ9bjPUucK4JKo2pT5dv+xB40IWQRTJKZHHl6h9CkJD+P/OTJOg/ZzI0KiSXa4AxwSi+4DxVtcV1c7CgVOUtlYaWzxD88pSF517Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObwOIMPAvc6+tDSmvGOS34Jc/Js1hf31KhAJ+cPpQX0=; b=TI54qoW4dR6R+enQzuGRILUOnJkP8OdXqyyhCVLTnnA8Vvov998zAN48Pp0lVwQKAj0y0VhmlHWocPHh0ECx0cYA5uz2PZvlJYmzLDhNT3zPk8OqpKcXB7pMzTJ92h9GqaHl//jktq3BmG475yWHr8BSWkaLK2Fvoj8ZzP/SR34= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) by VI1PR08MB4208.eurprd08.prod.outlook.com (2603:10a6:803:ec::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.18; Tue, 18 Aug 2020 22:18:14 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647%6]) with mapi id 15.20.3283.026; Tue, 18 Aug 2020 22:18:14 +0000 Date: Wed, 19 Aug 2020 00:18:54 +0200 From: Marko Zec To: Ryan Stone Cc: freebsd-net Subject: Re: Is anybody using ng_pipe? Message-ID: <20200819001854.3c6887fa@x23> In-Reply-To: References: <20200818205725.2e03c8cb@x23> <20200818234416.5aec459c@x23> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0802CA0026.eurprd08.prod.outlook.com (2603:10a6:800:a9::12) To VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (31.147.11.0) by VI1PR0802CA0026.eurprd08.prod.outlook.com (2603:10a6:800:a9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16 via Frontend Transport; Tue, 18 Aug 2020 22:18:12 +0000 X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [31.147.11.0] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6d8a1f5-f8b4-4a39-cb6c-08d843c499c3 X-MS-TrafficTypeDiagnostic: VI1PR08MB4208: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pq5PABN0nkzKdDYtZ/grl2kre8Ugvps1hPY1RF1IsyLapBLWpDQ9yozTKVrYhnQXyDRoYOOFVs3sCjSWSLJK84qe/nxeXUCc+vFLB4tGjx05f8T53jZRjZbbYPjMSNByxWdhw9qfMCvro5EFtaoHtQKceno4F/Bjlzcx1MOLZwKh0ial1NjO0vUeuNb92gH/Tu75dQf7szCibCauxHAYPQljlVD7FlKyxpZvl3BkQ2JnwkviResJdPEeS307Z7IPcP/d8O/4sSKngjl2+FYkNlU+rX6iN7yQbAtctAPU2+5830BWVHXJAzLr+RfDuXqUj356sD28G1MZT9dj9lgZvA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4783.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39840400004)(366004)(396003)(136003)(376002)(66476007)(8676002)(8936002)(9576002)(6916009)(6666004)(66946007)(86362001)(4326008)(956004)(2906002)(33716001)(5660300002)(6496006)(9686003)(1076003)(316002)(66556008)(786003)(52116002)(55016002)(478600001)(26005)(186003)(16526019)(53546011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: o+IluUsiWJKgltfGvgAnJ+SAfOzvh5s2SWCEsR+0Oh621U86DtaNLi3jkize4/apYk2Ic8D8AEtxOU/5MDs7aj3JnC8XBrDc7p9i+raGvZeoXc211JF2yATjL2uG9tLe1RC/Z+JTdyIxO4NcWji5SVGhA59eB2S19aWNMI3dbv0lOM6yNeB+ZgpePFnaB/hAqwwMQAFjV+Jeaj9o3Pxm3KTl0tJyyNPfC7n018ZlKabKB5qBqU9CfyJVqPDVQM8Zh3TCcsLcblsQeeNyxTQWCUcOCFGm2H7FIWJIWcfbZ7BQOTRRPelwNl+2zcJPw3/mVq+qBsEwrU+73Qa5iIyzrIBJw7eeNvqWgex3nZszK1FCdkC6/piRtsWKAJPlJX1jY9WPqSXTqFG5qsskgTA+GFVl4gKJLhUDS40PRAQ3/9NKhOYOLMCKZ1IDZ5r8883lgnYu0DB3E4GjS4nMDziSUPLR4jhN66F0oox0WOC+H9VYm1xOOVyBfrIu1aRtw+RI1WDL6FbyLKgS7e3qJRj6SPZSIg0z1WEkZ9IwqtyRINaHq78khovqNaPTCm5YPshJ+apMFCTIkfppkNEMek2yxaM8WU4Q3ypPV/6I96WfoZx0rBsMeT36fJUf9pHFf5P38wNsOJiyJ0eExUPWriTD1g== X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: f6d8a1f5-f8b4-4a39-cb6c-08d843c499c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4783.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2020 22:18:14.6651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O4Rj1+Y6IagvmZgjIzpf3XCU/OHPo4ctd0M6B1lbPTNU/mRGOjoLjMCFHIUdUi1Q X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4208 X-Rspamd-Queue-Id: 4BWQKP5mvVz3WyG X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ferhr.onmicrosoft.com header.s=selector2-ferhr-onmicrosoft-com header.b=TI54qoW4; dmarc=none; spf=pass (mx1.freebsd.org: domain of zec@fer.hr designates 40.107.14.89 as permitted sender) smtp.mailfrom=zec@fer.hr X-Spamd-Result: default: False [-0.75 / 15.00]; MID_RHS_NOT_FQDN(0.50)[]; RECEIVED_SPAMHAUS_PBL(0.00)[31.147.11.0:received]; R_DKIM_ALLOW(-0.20)[ferhr.onmicrosoft.com:s=selector2-ferhr-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[zec]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[fer.hr]; NEURAL_HAM_SHORT(-0.65)[-0.651]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[ferhr.onmicrosoft.com:+]; RCPT_COUNT_TWO(0.00)[2]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.14.89:from]; RCVD_IN_DNSWL_LOW(-0.10)[40.107.14.89:from]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 22:18:18 -0000 On Tue, 18 Aug 2020 18:04:24 -0400 Ryan Stone wrote: > On Tue, Aug 18, 2020 at 5:43 PM Marko Zec wrote: > > Since in ng_pipe we define BER as an one error in BER bits (integer > > value), wouldn't your formula P = 1 - BER yield results less than or > > equal to zero for all non-zero values of BER? The domain of P is > > [0..1], so that won't fly. > > > > Your analysis seems to be based on an assumption that the BER > > parameter is given as a multiplier to 0.5**48, which it is not. > > > > The proper fix would be to clarify the current BER parameter > > semantics in ng_pipe(4), not to break bridges with the existing > > scripts / software which rely on ng_pipe. > > > > Cheers, > > > > Marko > > The manpage defined the BER parameter as follows: > > u_int64_t ber; /* errors per 2^48 bits */ > > If we instead want to change the documentation to match the > implementation, that's fine too. Yeah, I only saw that a few minutes ago... Fixed in r364367. Cheers Marko From owner-freebsd-net@freebsd.org Tue Aug 18 22:36:23 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE27D3A9B03 for ; Tue, 18 Aug 2020 22:36:23 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWQkG5H1cz3Xf7 for ; Tue, 18 Aug 2020 22:36:22 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 07IMaBvY067448; Tue, 18 Aug 2020 15:36:11 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 07IMaAo5067447; Tue, 18 Aug 2020 15:36:10 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <202008182236.07IMaAo5067447@gndrsh.dnsmgr.net> Subject: Re: Is anybody using ng_pipe? In-Reply-To: To: Ryan Stone Date: Tue, 18 Aug 2020 15:36:10 -0700 (PDT) CC: Marko Zec , freebsd-net X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4BWQkG5H1cz3Xf7 X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [2.05 / 15.00]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.15)[0.146]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 22:36:24 -0000 > On Tue, Aug 18, 2020 at 2:43 PM Eugene Grosbein wrote: > > Sorry, missed that. But why wasn't possible? > > There's a daemon running on the system that handles most network > configuration. It's quite inflexible and will override any manual > configuration changes. It manages firewall rules but is ignorant of > netgraph, so it will remove any dummynet rules but leave netgraph > configuration alone. It was significantly easier to just use ng_pipe, > even after having to fix or work around the bugs, than it was to fight > the daemon. > > On Tue, Aug 18, 2020 at 2:56 PM Marko Zec wrote: > > The probability that a frame is completely unaffected by BER events, > > and thus shouldn't be dropped, is currently computed as > > > > Ppass(BER, plen) = Psingle_bit_unaffected(BER) ^ Nbits(plen) > > The problem is in its calculation of Psingle_bit_unaffected(BER). The > BER is the fraction of bits that are affected, therefore it is the > probability that a bit is affected. But for some reason, > Psingle_bit_unaffected(BER) is calculated as 1 - 1/BER rather than 1 - > BER. This leads to the probability table being wrong. For example, > given a BER of 23500000, the probability that a 1500-byte packet is > not dropped is: Is this a confusion over Bit Error Rate vis Bit Error Ratio? A BER of 23500000 I must assume is 1 bit in 23500000 bits. 1 - 1/BER looks correct to me for a Bit Error Rate 1 - BER looks correct to me for a Bit Error Ratio (usually a percentage) > > (1 - 23500000/2**48)**(1500 * 8), which is approximately 99.00%. > > However, ng_pipe calculates a fixed-point probability value of > 281460603879001. To calculate whether a frame should be dropped, > ng_pipe takes this probability value and shifts it right by 17, > yielding 2147373991. It then calls rand() to generate a random number > in the range [0,2**31-1]; if the random number is larger than the > probability value than it is dropped, otherwise it is kept. The > chances that a packet is kept is therefore 2147373991/(2**31 - 1), or > about 99.99%. This looks like optimization to reduce calculation as it is done for every packet, why not do the calculation more accurately and only for each "error", see below. > It's easy enough to fix this one, but I wasn't sure that it would be > so easy to fix the TSO/LRO issue without significantly increasing the > memory usage, so I wanted to gauge whether it was worth pursuing that > avenue or if a simpler model would be a better use of my time. The > feedback is definitely that a simpler model is *not* warranted, so > let's talk about fixing TSO/LRO. I am not even sure how to deal with TSO/LRO and BER. Your not going to discard the whole segment are you? Are you going to try and packetize it, drop the packet(s) with errors, reassmble it? My method of calculating the future error point would at least allow you to just pass a whole segment without any of that hassle and only have to do that when an error is within some segment. > > On Tue, Aug 18, 2020 at 1:47 PM Rodney W. Grimes > wrote: > > Hum, that sounds like a poor implementation indeed. It seems > > like it would be easy to convert a BER into a packet drop > > probability based on bytes that have passed through the pipe. > > I'm not quite following you; can you elaborate? Would this solution > require us to update some shared state between each packet? One > advantage of the current approach is that there is no mutable state > (except, of course, when configuration changes). You would use the bytes transfered state that is already stored, and compute a "next error" point based on BER and some randomness such that your errors are not clocked at exact BER intervals. Compare the next error point to the bytes transfered + size of this packet/segment to decide if it needs dropped, if you drop then you must calculate a new "next error" point. This should considerable reduce the overhead for error rates that effect less than 50% of packets, and would be the same overhead for BER that effect every packet. And 100x more efficient for things that effect 1% of packets. -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-net@freebsd.org Wed Aug 19 02:37:49 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F8DD3AEF6C for ; Wed, 19 Aug 2020 02:37:49 +0000 (UTC) (envelope-from julianelischer@gmail.com) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWX4r2kZtz43Mh for ; Wed, 19 Aug 2020 02:37:48 +0000 (UTC) (envelope-from julianelischer@gmail.com) Received: by mail-io1-f48.google.com with SMTP id g13so8992602ioo.9 for ; Tue, 18 Aug 2020 19:37:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G2gtn1lWsDfdwvoH0LL+xYmYPlV6ICvR5jDMNU87MHM=; b=Bg6LhdUPuXIrjZ+LbO2AokrqNkjESsVkhC/qQ72QQtDcoG7aYPwBWFGxqdu6tkAU53 JyrT4YNdS0xtaTJFJjqGi6Eji5g3DN32QDTtwYw+zdoag9hifNCpq/ykbSkrdfwrW2YP yLXefLRJncuz6NodGw6Fpc55vl5IeJSmqhT70YvhBt+4oZjA+sa7e/COeoO3Xz42o2/3 jThJJBzHY9MTyDdb6AtXQim8pqP0vQOnC5k7qzu4LJzQhMWO+iat9lVWSVZpcrT1gBnj C5AYzzlMZ8ZfV51sibIUqZy6Ds8h6p5EcX0biPszN/rR9ti14S2n6ORt5sv9ObhN0Dn0 SKzA== X-Gm-Message-State: AOAM531jtvs6KJcbfEt00/TmmHr0DjsD+YJ50jSA5R26cExUt6t99EoD 844MdEOuogn+P/1aRxf6MgMHOnXzDEp30TztPJ75b9XG5p8= X-Google-Smtp-Source: ABdhPJx4prm10qncshDx/S+sMY6Yx04DM+TOiSUClVNqqySSMp/ZQF3DMMsqD+dRQ3Oxifsa0cmr5PAi6RGPjy3B6lU= X-Received: by 2002:a05:6602:2dd2:: with SMTP id l18mr18425170iow.81.1597804667021; Tue, 18 Aug 2020 19:37:47 -0700 (PDT) MIME-Version: 1.0 References: <202008182236.07IMaAo5067447@gndrsh.dnsmgr.net> In-Reply-To: <202008182236.07IMaAo5067447@gndrsh.dnsmgr.net> From: Julian Elischer Date: Tue, 18 Aug 2020 19:37:36 -0700 Message-ID: Subject: Re: Is anybody using ng_pipe? To: "Rodney W. Grimes" Cc: Ryan Stone , Marko Zec , freebsd-net X-Rspamd-Queue-Id: 4BWX4r2kZtz43Mh X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of julianelischer@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=julianelischer@gmail.com X-Spamd-Result: default: False [0.66 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[elischer.org]; MAILMAN_DEST(0.00)[freebsd-net]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.34)[-0.340]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.48:from]; FORGED_SENDER(0.30)[julian@elischer.org,julianelischer@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.48:from]; SUBJECT_ENDS_QUESTION(1.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[julian@elischer.org,julianelischer@gmail.com]; FREEMAIL_CC(0.00)[gmail.com,fer.hr,freebsd.org] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 02:37:49 -0000 Writing a new netgraph node is relatively simple. Take ng_sample.c and ng_sample.h and copy them. Change names to suit, and add your own code in the middle. use one of 50 other nodes as examples. No matter what you want to do one of them already does it. -- +----------------------------------\ ________ _ __ | __--_|\ Julian Elischer \ \\ U \/ / On assignment | / \ julian@elischer.org \ \ USA \ in a very strange | ( OZ ) \-->x____ ___ | country ! +- X_.---._/ Mountain View, California \_/ \\ v sp; \\ v From owner-freebsd-net@freebsd.org Wed Aug 19 04:51:56 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A9AF3B1934 for ; Wed, 19 Aug 2020 04:51:56 +0000 (UTC) (envelope-from l.tian.email@gmail.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWb3Y5Rchz4Bps for ; Wed, 19 Aug 2020 04:51:53 +0000 (UTC) (envelope-from l.tian.email@gmail.com) Received: by mail-ej1-x62f.google.com with SMTP id p24so24658808ejf.13 for ; Tue, 18 Aug 2020 21:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=rVsqpwySu/JZPhjzHdesB0EQrTO4OUPdokvHypoQwFI=; b=gR9F7a3gsY7B8Hzyod7b1wP/xyrm+azH+HKqAObQAvcpg2cwMkIecxjyFtHkcg43+2 NGj6ZJIbpdSVYG3jA21M1nyW6GGF2ChAV0izj2WrCbNKucRIPR8FHVGX5MNz0gxK170D tvIfznnf8fEVk9mhpY+z78j8gpwm0atJQiJ1tocwyyFoK4dvtJEXQJYQcbIJdeQZSrl+ 47qtubWuBtegFyQSl0K1ijQctWm1GIJWj6cShcdeIMRcbNdqHFj8zJspOGphElKAME5d WOr8w+SwJNGqIpi9WkU9HtE23Xj5AZpS5xZqJzOR8C6o0heK2YgdgZ1IxmnLgk6e3LbF FhAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rVsqpwySu/JZPhjzHdesB0EQrTO4OUPdokvHypoQwFI=; b=uNyZ5cLkdiW+uIS/zgjruIvhtxKevM8mj1wIiaWL2QFPSQ4a8ZFREnoULa3fWI38Lx cq5bb5JyKjExnKdbj/JhYicrdQMo6HcgtDFstXPkRaXjr5VCn6FO7HVuO5XyFgeXz/Bc 0ohe0fvLHVh/d3/s0ODqHYPwTWQbLHsyPWVe4/q5n3LB9ISH/BXPQiHU8hvpyjZHmMiA SXV4sX1NOUuioYAhBnsGGxJzI8xRC4ylvI6gps83dd/ij5lCn7HGd2HTxtkWH/xv/UY3 YPUvJKxIgtCM9AS8lcGm0mP8VZgjJnsH2KEIK36FPXR1+ysM5hFA6vN7At60PApoq5du 5sxw== X-Gm-Message-State: AOAM530MwDrsOerS8gtz3pLc0+dSXDG9wcqP0B7zabSlZluS+//Hi1ik eqyn6K+MV7hchioTFaiOkQ4A+1BBjVd+atYHGWZOB5GgfZM= X-Google-Smtp-Source: ABdhPJyDMXKOWPYKCyM4chbcNaHRqJVckXPfURS0FERedkb+1k1F12azlWuNNbnKR4rCL4gFRWTqaAl7mKW9kygoqEM= X-Received: by 2002:a17:906:1b04:: with SMTP id o4mr24659164ejg.332.1597812711399; Tue, 18 Aug 2020 21:51:51 -0700 (PDT) MIME-Version: 1.0 From: Liang Tian Date: Wed, 19 Aug 2020 00:51:40 -0400 Message-ID: Subject: Appropriate Byte Counting during Congestion Avoidance To: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWb3Y5Rchz4Bps X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=gR9F7a3g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ltianemail@gmail.com designates 2a00:1450:4864:20::62f as permitted sender) smtp.mailfrom=ltianemail@gmail.com X-Spamd-Result: default: False [-1.44 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62f:from]; NEURAL_HAM_SHORT(-0.44)[-0.442]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 04:51:56 -0000 Hi everyone, We noticed CWND is growing much slower than expected during congestion avoidance with new reno, and we came to this piece of code in cc_ack_received() at tcp_input.c:353 if (type == CC_ACK) { .... if (tp->snd_cwnd > tp->snd_ssthresh) { tp->t_bytes_acked += min(tp->ccv->bytes_this_ack, nsegs * V_tcp_abc_l_var * tcp_maxseg(tp)); if (tp->t_bytes_acked >= tp->snd_cwnd) { tp->t_bytes_acked -= tp->snd_cwnd; tp->ccv->flags |= CCF_ABC_SENTAWND; } The increment of t_bytes_acked is capped at 2*maxseg. The description of the sysctl variable tcp_abc_l_var(default value 2) is "Cap the max cwnd increment during slow-start to this number of segments" After reading RFC3465, it doesn't look like this cap should be applied here since this is clearly not during slow-start. We've seen in some cases the receiver is ACKing every 16 packets, and CWND is growing at 1/8 of the expected rate because of this. I would appreciate your opinion on this. Thanks a lot. Regards, Liang From owner-freebsd-net@freebsd.org Wed Aug 19 08:14:39 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 33FB83B689C for ; Wed, 19 Aug 2020 08:14:39 +0000 (UTC) (envelope-from Michael.Tuexen@lurchi.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWgYV44g3z4P6h for ; Wed, 19 Aug 2020 08:14:38 +0000 (UTC) (envelope-from Michael.Tuexen@lurchi.franken.de) Received: from [IPv6:2a02:8109:1140:c3d:8108:5ab5:4ce3:914d] (unknown [IPv6:2a02:8109:1140:c3d:8108:5ab5:4ce3:914d]) (Authenticated sender: lurchi) by mail-n.franken.de (Postfix) with ESMTPSA id C1756721BE014; Wed, 19 Aug 2020 10:14:35 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: Appropriate Byte Counting during Congestion Avoidance From: Michael Tuexen In-Reply-To: Date: Wed, 19 Aug 2020 10:14:32 +0200 Cc: freebsd-net Content-Transfer-Encoding: 7bit Message-Id: <51C01869-3FC2-43A8-AC9D-4A6F961F93B7@lurchi.franken.de> References: To: Liang Tian X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4BWgYV44g3z4P6h X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of Michael.Tuexen@lurchi.franken.de has no SPF policy when checking 193.175.24.27) smtp.mailfrom=Michael.Tuexen@lurchi.franken.de X-Spamd-Result: default: False [1.38 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; NEURAL_SPAM_SHORT(0.08)[0.082]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; AUTH_NA(1.00)[]; DMARC_NA(0.00)[franken.de]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_IN_DNSWL_LOW(-0.10)[193.175.24.27:from] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 08:14:39 -0000 > On 19. Aug 2020, at 06:51, Liang Tian wrote: > > Hi everyone, > > We noticed CWND is growing much slower than expected during congestion > avoidance with new reno, and we came to this piece of code in > cc_ack_received() at tcp_input.c:353 > > if (type == CC_ACK) { > .... > if (tp->snd_cwnd > tp->snd_ssthresh) { > tp->t_bytes_acked += min(tp->ccv->bytes_this_ack, > nsegs * V_tcp_abc_l_var * tcp_maxseg(tp)); > if (tp->t_bytes_acked >= tp->snd_cwnd) { > tp->t_bytes_acked -= tp->snd_cwnd; > tp->ccv->flags |= CCF_ABC_SENTAWND; > } > The increment of t_bytes_acked is capped at 2*maxseg. > The description of the sysctl variable tcp_abc_l_var(default value 2) is > "Cap the max cwnd increment during slow-start to this number of segments" > After reading RFC3465, it doesn't look like this cap should be applied > here since this is clearly not during slow-start. > We've seen in some cases the receiver is ACKing every 16 packets, and > CWND is growing at 1/8 of the expected rate because of this. > > I would appreciate your opinion on this. Thanks a lot. Hi Liang, thanks for bringing this up. I agree. A patch is under review: https://reviews.freebsd.org/D26120 Best regards Michael > > Regards, > Liang > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Wed Aug 19 08:27:33 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1BCAE3B6E04; Wed, 19 Aug 2020 08:27:33 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWgrM45Qdz4PpN; Wed, 19 Aug 2020 08:27:31 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: by mail-oi1-x22f.google.com with SMTP id l204so20312052oib.3; Wed, 19 Aug 2020 01:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=YeLNXkEWWaCaNFkwI2FLx9WtMT7ddiWBVWP7oVooA7k=; b=AdH/zxwzUFwjZ7OgBTkNH+0H3Q1NOAyW49cR4uENGDy1cBeT/kBXfFeqYSb7PeLgym K5s7SbFl+gIqx2Kr07yRryo8/DQL88HRYOY1Ags53Sja2jJb7SlQpBK1jXM/FQaf8ITP cDBcrN98UUIvXj77bqi2umqrzjgEE/LpmJ6vYkPocy/ed1vk0f8pFvIu8WxJfExLFlr5 JP0idGRE3VuEZzM4v/UcVDK8GUgzr3XDkf4VoSM+3KPW9lISLt6IezOlIqEpDsedfMcu oBtFBvR7QS8Rz9BHsPVuJ1lmlQ+7tVi9qdgaL+9gfJ8001zFxNax6ZurW4nMki3LxaE/ wpEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=YeLNXkEWWaCaNFkwI2FLx9WtMT7ddiWBVWP7oVooA7k=; b=f2Qo8zxSAqIRNchQbdS8RT7N9tSwtyTdMpUxseKvf8LMZqoesUWyuEOgirx+nnPkQ4 M3Fp8BCa2jInmelk+XDXHCIPDBtipPSk0rTpjRwndUryD6wlscx+/uA0j0GMMULhUoC/ v5mJRMqC/jj9v+iER1EulKwsmRs9T0z3rsUy6ib+/y23TOHmj05mHUZHRnKGBgfMUEI7 JrVWwL7fHLX5Rv4gKIH8P5rAYde3o5CTgPTAEhUZZE+hPwDDUXkgjtqlH30DGCfMQcFA zr7jFbYoV2G0339QGh2+Kz+BlI9Mjgkp66gs2Sk6PDmsDYASr1obv5PHSKpUw/RiyOad YoyQ== X-Gm-Message-State: AOAM5325e9yuvB2hsQ//e0j272dQZQ7OQ8PnpRxIrQ1Mia9/4w/TOPM2 km7+oTIc54JknWZfn+Uvoj0lia8DUPry25OUka0= X-Google-Smtp-Source: ABdhPJwDITG4eHzECc/n59gF4lpAYKo6AWlxkpGVUa+B5HUpZkpGZZ0kwlv+gV7W3Zt5U9RO117gwNYbqIW4abFDLOg= X-Received: by 2002:aca:ec02:: with SMTP id k2mr2448606oih.97.1597825650451; Wed, 19 Aug 2020 01:27:30 -0700 (PDT) MIME-Version: 1.0 References: <20200725231318.GO4213@funkthat.com> <20200726211447.GQ4213@funkthat.com> <20200727183503.GW4213@funkthat.com> In-Reply-To: <20200727183503.GW4213@funkthat.com> From: Ganbold Tsagaankhuu Date: Wed, 19 Aug 2020 16:27:19 +0800 Message-ID: Subject: Re: CFT: major update to if_ure To: Ganbold Tsagaankhuu , freebsd-net@freebsd.org, freebsd-current@freebsd.org X-Rspamd-Queue-Id: 4BWgrM45Qdz4PpN X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=AdH/zxwz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ganbold@gmail.com designates 2607:f8b0:4864:20::22f as permitted sender) smtp.mailfrom=ganbold@gmail.com X-Spamd-Result: default: False [-0.97 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FREEFALL_USER(0.00)[ganbold]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.03)[0.031]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::22f:from]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-net,freebsd-current]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 08:27:33 -0000 On Tue, Jul 28, 2020 at 2:35 AM John-Mark Gurney wrote: > Ganbold Tsagaankhuu wrote this message on Mon, Jul 27, 2020 at 18:29 +0800: > > On Mon, Jul 27, 2020 at 5:14 AM John-Mark Gurney > wrote: > > > > > Ganbold Tsagaankhuu wrote this message on Sun, Jul 26, 2020 at 11:05 > +0800: > > > > On Sun, Jul 26, 2020 at 7:13 AM John-Mark Gurney > > > wrote: > > > > > > > > > Hello, > > > > > > > > > > I'd like people who have ure (RealTek) based USB devices to test > > > > > review D25809[0]. > > > > > > > > > > This update adds support for: > > > > > - HW VLAN tagging > > > > > - HW checksum offload for IPv4 and IPv6 > > > > > - tx and rx aggreegation (for full gige speeds) > > > > > - multiple transactions > > > > > > > > > > In my testing, I am able to get 900-950Mbps depending upon > > > > > TCP or UDP, which is a significant improvement over the previous > > > > > 91Mbps (~8kint/sec*1500bytes/packet*1packet/int). > > > > > > > > Does performance improve for if_ure device on USB2? > > > > I will try to test it in a couple of days on NanoPI R1 and R1S > boards. > > > > > > Yes, it should. > > > > > > I never tested the before driver on USB2, but I'm now able to get > > > 211Mbps TX and 190Mbps RX TCP, and 227Mbps TX and 225Mbps RX UDP. > > > > > > I believe it is likely that the same 91Mbps speed limit applied to > > > USB2 as well. > > > > Couldn't find your iperf test scripts and I tested only tcp: > > My test script isn't performance, just features, and I'm thinking about > how/where to publish it... > > You can also test UDP using -u w/ iperf3 and adjust the bandwidth w/ > -b 300m (or other Mbps)... > > > root@nanopi-r1s-h5:~ # iperf3 -c 192.168.111.1 > > Connecting to host 192.168.111.1, port 5201 > > [ 5] local 192.168.111.10 port 28569 connected to 192.168.111.1 port > 5201 > > [ ID] Interval Transfer Bitrate Retr Cwnd > > [ 5] 0.00-1.00 sec 27.4 MBytes 230 Mbits/sec 0 95.4 KBytes > > [ 5] 1.00-2.00 sec 27.6 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 2.00-3.00 sec 27.7 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 3.00-4.00 sec 27.6 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 4.00-5.00 sec 27.6 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 5.00-6.00 sec 27.6 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 6.00-7.00 sec 27.7 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 7.00-8.00 sec 27.7 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 8.00-9.00 sec 27.6 MBytes 232 Mbits/sec 0 95.4 KBytes > > [ 5] 9.00-10.00 sec 27.6 MBytes 232 Mbits/sec 0 95.4 KBytes > > - - - - - - - - - - - - - - - - - - - - - - - - - > > [ ID] Interval Transfer Bitrate Retr > > [ 5] 0.00-10.00 sec 276 MBytes 232 Mbits/sec 0 > sender > > [ 5] 0.00-10.79 sec 276 MBytes 215 Mbits/sec > > receiver > > > > iperf Done. > > root@nanopi-r1s-h5:~ # iperf3 -c 192.168.111.1 -R > > Connecting to host 192.168.111.1, port 5201 > > Reverse mode, remote host 192.168.111.1 is sending > > [ 5] local 192.168.111.10 port 29384 connected to 192.168.111.1 port > 5201 > > [ ID] Interval Transfer Bitrate > > [ 5] 0.00-1.00 sec 12.1 MBytes 102 Mbits/sec > > [ 5] 1.00-2.00 sec 12.1 MBytes 102 Mbits/sec > > [ 5] 2.00-3.00 sec 12.1 MBytes 101 Mbits/sec > > [ 5] 3.00-4.00 sec 12.1 MBytes 102 Mbits/sec > > [ 5] 4.00-5.00 sec 12.1 MBytes 102 Mbits/sec > > [ 5] 5.00-6.00 sec 12.1 MBytes 102 Mbits/sec > > [ 5] 6.00-7.00 sec 12.1 MBytes 101 Mbits/sec > > [ 5] 7.00-8.00 sec 12.1 MBytes 102 Mbits/sec > > [ 5] 8.00-9.00 sec 12.1 MBytes 101 Mbits/sec > > [ 5] 9.00-10.00 sec 12.1 MBytes 102 Mbits/sec > > - - - - - - - - - - - - - - - - - - - - - - - - - > > [ ID] Interval Transfer Bitrate Retr > > [ 5] 0.00-11.25 sec 121 MBytes 90.3 Mbits/sec 2539 > > sender > > [ 5] 0.00-10.00 sec 121 MBytes 101 Mbits/sec > > receiver > > > > iperf Done. > > root@nanopi-r1s-h5:~ # sysctl -a | grep cpu.0.freq > > dev.cpu.0.freq_levels: 1248/-1 1008/-1 816/-1 624/-1 480/-1 > > dev.cpu.0.freq: 1248 > > Hmmm... The reverse seems slow, but I can't think of why it'd be that > slow though. When I did my tests on the USB2 ports, both directions > were about the same speed... > > Thanks for the test! Great to hear things are working... > When can you commit it? thanks, Ganbold > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not." > From owner-freebsd-net@freebsd.org Wed Aug 19 08:41:44 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 775F03B75CE for ; Wed, 19 Aug 2020 08:41:44 +0000 (UTC) (envelope-from list1@gjunka.com) Received: from msa1.earth.yoonka.com (yoonka.com [88.98.225.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "msa1.earth.yoonka.com", Issuer "msa1.earth.yoonka.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWh8l3DKlz4RMW for ; Wed, 19 Aug 2020 08:41:42 +0000 (UTC) (envelope-from list1@gjunka.com) Received: from venus.yoonka.com (venus.yoonka.com [10.70.7.24]) (authenticated bits=0) by msa1.earth.yoonka.com (8.15.2/8.15.2) with ESMTPSA id 07J8fZ6A038112 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Wed, 19 Aug 2020 08:41:35 GMT (envelope-from list1@gjunka.com) Subject: Re: net.add_addr_allfibs=1 behaviour deprecation To: freebsd-net@freebsd.org References: <236161595078191@mail.yandex.ru> <348771597489519@mail.yandex.ru> <0f321bdc-240e-0f85-915b-c9bdd7daa01b@freebsd.org> <837391597778482@mail.yandex.ru> From: Grzegorz Junka Message-ID: <84c582aa-11a0-a64c-4c4e-cfc39373a1d7@gjunka.com> Date: Wed, 19 Aug 2020 08:41:34 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <837391597778482@mail.yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4BWh8l3DKlz4RMW X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of list1@gjunka.com designates 88.98.225.149 as permitted sender) smtp.mailfrom=list1@gjunka.com X-Spamd-Result: default: False [0.30 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:88.98.225.149]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; NEURAL_SPAM_SHORT(0.60)[0.599]; DMARC_NA(0.00)[gjunka.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:56478, ipnet:88.98.192.0/18, country:GB]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 08:41:44 -0000 On 18/08/2020 19:27, Alexander V. Chernikov wrote: > 18.08.2020, 09:17, "Grzegorz Junka" : >> On 18/08/2020 07:54, Julian Elischer wrote: >>>> >>>>  No objections has been received. >>>>  Next steps: >>>>  * Switch net.add_addr_allfibs to 0 ( >>>>  https://reviews.freebsd.org/D26076 ) >>>>  * Provide an ability to use nexthops from different fibs >>>>  * Remove net.add_addr_allfibs >>>>>  Timeline: >>>>>  Aug 1: summarising feedback and the usecases, decision on proceeding >>>>>  further >>>>>  Aug 20 (tentative):  patches for supported usecases >>>>>  Sep 15 (tentative):  net.add_addr_allfibs removal. >>>>> >>>>>  [1]: [base Contents of >>>>>  /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?revision=178888&view=markup) >>>>>  [2]: [base Diff of >>>>>  /head/sys/net/route.c](https://svnweb.freebsd.org/base/head/sys/net/route.c?r1=180839&r2=180840&) >>>>> >>>>>  /Alexander >> Agree completely, defaulting "add_addr_allfibs" to 1 broke many existing >> installations, which goes against the least surprise principle so many >> times advocated on FreeBSD lists. >> >> This is just one example: >> https://forums.freebsd.org/threads/strange-behavior-of-setfib-since-freebsd-12-0.73348/ >> >> Now, changing the default again might again break existing >> installations, which shouldn't be a reason for not doing it, but might >> be a reason to better communicate it this time around. > I plan to communicate it the following way: > 1) this thread > 2) GONE_IN13 in the sysctl (which will print console message when set to 1) > 3) Release notes > Do you think there are other communication channels one should try to use? When I was looking for information about why the routing doesn't work as expected I didn't know about this settings but couldn't find anything relevant in the Handbook, so would really love to see this somehow mentioned and explained how to use it in the Handbook if possible. Thanks GrzegorzJ From owner-freebsd-net@freebsd.org Wed Aug 19 10:40:46 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 944733BA17D for ; Wed, 19 Aug 2020 10:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BWkp63Sgcz4Z9F for ; Wed, 19 Aug 2020 10:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 751893BA26E; Wed, 19 Aug 2020 10:40:46 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 74E133BA1BF for ; Wed, 19 Aug 2020 10:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWkp62Zj2z4ZG7 for ; Wed, 19 Aug 2020 10:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3BFB62176A for ; Wed, 19 Aug 2020 10:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07JAek1F014133 for ; Wed, 19 Aug 2020 10:40:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07JAekgx014132 for net@FreeBSD.org; Wed, 19 Aug 2020 10:40:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 238478] TCP Cubic code bug in cubic_ack_received Date: Wed, 19 Aug 2020 10:40:46 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rscheff@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 10:40:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238478 --- Comment #6 from commit-hook@FreeBSD.org --- A commit references this bug: Author: rscheff Date: Wed Aug 19 10:40:03 UTC 2020 New revision: 364378 URL: https://svnweb.freebsd.org/changeset/base/364378 Log: MFC r363397: Fix style and comment around concave/convex regions in TCP cubic. In cubic, the concave region is when snd_cwnd starts growing slower towards max_cwnd (cwnd at the time of the congestion event), and the convex region is when snd_cwnd starts to grow faster and eventually appearing like slow-start like growth. PR: 238478 Reviewed by: tuexen (mentor), rgrimes (mentor) Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D24657 Changes: _U stable/12/ stable/12/sys/netinet/cc/cc_cubic.c --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Aug 19 12:27:11 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B1D6B3BD1F2 for ; Wed, 19 Aug 2020 12:27:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BWn8v4KRYz3TMl for ; Wed, 19 Aug 2020 12:27:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 945423BD35E; Wed, 19 Aug 2020 12:27:11 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 941D93BD407 for ; Wed, 19 Aug 2020 12:27:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWn8v3Tfbz3TXK for ; Wed, 19 Aug 2020 12:27:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5BB7522C4C for ; Wed, 19 Aug 2020 12:27:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07JCRBHH024599 for ; Wed, 19 Aug 2020 12:27:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07JCRBXB024598 for net@FreeBSD.org; Wed, 19 Aug 2020 12:27:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 238478] TCP Cubic code bug in cubic_ack_received Date: Wed, 19 Aug 2020 12:27:11 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rscheff@freebsd.org X-Bugzilla-Flags: mfc-stable12+ X-Bugzilla-Changed-Fields: flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 12:27:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238478 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |mfc-stable12+ --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Aug 19 12:48:55 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7EAE83BD7FF for ; Wed, 19 Aug 2020 12:48:55 +0000 (UTC) (envelope-from l.tian.email@gmail.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWndy4v5xz3VvQ for ; Wed, 19 Aug 2020 12:48:54 +0000 (UTC) (envelope-from l.tian.email@gmail.com) Received: by mail-ed1-x52a.google.com with SMTP id cq28so17995290edb.10 for ; Wed, 19 Aug 2020 05:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SiEu3ZtKixmr/gvDHU0+bsY7cxeaXaMulNDZl0ukUc8=; b=Q8B/44A/5Wku38Os4ALvtC6UVC3yXAp81WlJuljkGxMWLUIiriaHdmnkAyfCPoxcdN xblP5EAOTM8vi17YSW32gGPOofo+wJVwoTzpv3FkEEX1rkRKp8pue52uTCh/sHzRQuSy FYgeXb35qp4tmBVY1epsMh7B4d+w4sNOabZwMKGXqm4ZD048c8K77HTtyv/5YvBuaXa1 rZkfEGUjOpliNFFdVzsq4p2KZYqOkEINrU3oP5z62GqX8U9Cn1SaGCi/HtSFNy/U5Hjc RGsSBpMIDsEnfEA12WFx7vLU37PRdkf8/eWpLzV9Qx9TbZkT7/WpSQDe1opXzZHX7WzY 7x8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SiEu3ZtKixmr/gvDHU0+bsY7cxeaXaMulNDZl0ukUc8=; b=hcikRV+TkkIE3HUsuoGQYG5E4f1+KI1zriIKGEgEXTrK36AhXN7/29RMwJzUKlYKY0 jI4j+E4y2akMFvlii5bikafYet56iJlF2tcwlOnucuXfgDSow82nTZU4sVUjJ3yM54bC rnHssytfls8Eba+ewly/cO3A9ov9zwvNExYWTOfqyDJA5mAC8WYwEG9EzUB/8zZV4Ffm Wi6ZiIeLkVD8cS5mE3My4PlOHAqibGBEOwYb2WJKCKR4aVh+nXlfBBQfzgi5OhjsvVJc JZT5ribmD8z3OddV1FYf5ZwCcmqVchQ5tItuB5PnHyzXHPiz7h7Y3zn924OpilvaIt83 XOTw== X-Gm-Message-State: AOAM532yYErbZm0VmMbZDD+eypiBdgSg9cLMTQu0wBxVEIFXXOMlQLZz P7wEOj9v9GuNbleiLed4ICAsjoq47bFkb/RbcSVVhnLt X-Google-Smtp-Source: ABdhPJxI9FBhlJc9Vfa04slT7AxNdafqa1W5V5+zBI8x5IS8RaSr174UhK1WzwOj7m2bEFCFsJ0RrTa1DVFoO5icKCA= X-Received: by 2002:aa7:cd46:: with SMTP id v6mr23231795edw.21.1597841332835; Wed, 19 Aug 2020 05:48:52 -0700 (PDT) MIME-Version: 1.0 References: <51C01869-3FC2-43A8-AC9D-4A6F961F93B7@lurchi.franken.de> In-Reply-To: <51C01869-3FC2-43A8-AC9D-4A6F961F93B7@lurchi.franken.de> From: Liang Tian Date: Wed, 19 Aug 2020 08:48:41 -0400 Message-ID: Subject: Re: Appropriate Byte Counting during Congestion Avoidance To: Michael Tuexen Cc: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWndy4v5xz3VvQ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Q8B/44A/; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ltianemail@gmail.com designates 2a00:1450:4864:20::52a as permitted sender) smtp.mailfrom=ltianemail@gmail.com X-Spamd-Result: default: False [-1.53 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::52a:from]; NEURAL_HAM_SHORT(-0.53)[-0.534]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 12:48:55 -0000 Great, thanks! On Wed, Aug 19, 2020 at 4:14 AM Michael Tuexen wrote: > > > On 19. Aug 2020, at 06:51, Liang Tian wrote: > > > > Hi everyone, > > > > We noticed CWND is growing much slower than expected during congestion > > avoidance with new reno, and we came to this piece of code in > > cc_ack_received() at tcp_input.c:353 > > > > if (type == CC_ACK) { > > .... > > if (tp->snd_cwnd > tp->snd_ssthresh) { > > tp->t_bytes_acked += min(tp->ccv->bytes_this_ack, > > nsegs * V_tcp_abc_l_var * tcp_maxseg(tp)); > > if (tp->t_bytes_acked >= tp->snd_cwnd) { > > tp->t_bytes_acked -= tp->snd_cwnd; > > tp->ccv->flags |= CCF_ABC_SENTAWND; > > } > > The increment of t_bytes_acked is capped at 2*maxseg. > > The description of the sysctl variable tcp_abc_l_var(default value 2) is > > "Cap the max cwnd increment during slow-start to this number of segments" > > After reading RFC3465, it doesn't look like this cap should be applied > > here since this is clearly not during slow-start. > > We've seen in some cases the receiver is ACKing every 16 packets, and > > CWND is growing at 1/8 of the expected rate because of this. > > > > I would appreciate your opinion on this. Thanks a lot. > Hi Liang, > > thanks for bringing this up. I agree. A patch is under review: > https://reviews.freebsd.org/D26120 > > Best regards > Michael > > > > Regards, > > Liang > > _______________________________________________ > > freebsd-net@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@freebsd.org Wed Aug 19 17:28:30 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20E333C5162 for ; Wed, 19 Aug 2020 17:28:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BWvrZ05rDz4KHH for ; Wed, 19 Aug 2020 17:28:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 01B0F3C5161; Wed, 19 Aug 2020 17:28:30 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 017703C5341 for ; Wed, 19 Aug 2020 17:28:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWvrY6K8dz4KVD for ; Wed, 19 Aug 2020 17:28:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BD1C7260E5 for ; Wed, 19 Aug 2020 17:28:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07JHSTHu066516 for ; Wed, 19 Aug 2020 17:28:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07JHSTUx066515 for net@FreeBSD.org; Wed, 19 Aug 2020 17:28:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 230465] ixl: not working in netmap mode Date: Wed, 19 Aug 2020 17:28:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-STABLE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: vmaffione@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: vmaffione@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 17:28:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230465 --- Comment #39 from Vincenzo Maffione --- (In reply to Kubilay Kocak from comment #38) This is not a suricata issue. There was a suricata issue mentioned in this thread, but it has been fixed upstream (suricata). Comment #37 seems unrelated, since it mentions netmap with ixl in 12.x, whe= re iflib is in use. There was an iflib/netmap bug (see https://reviews.freebsd.org/D25252) that may explain the problems briefly mentioned in #37. But that is now in HEAD and stable/12. This report is about a bug that apparently affects netmap TX over ixl in 11= .x (but not in 12.x and ahead). This change https://reviews.freebsd.org/D18984 does some cleanup but it does not fix the bug. As you can see in the discussion, I reported the issue to the Intel develop= ers, but as far as I know there have been no changes on their side (in stable/11= ). So I can assume that the bug is still there, and it's something that need t= he Intel developers attention, if someone is still interested in netmap+ixl in 11.x --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Aug 19 22:23:44 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 655543CA8CF; Wed, 19 Aug 2020 22:23:44 +0000 (UTC) (envelope-from neel@neelc.org) Received: from rainpuddle.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BX2PC1RVJz4cmn; Wed, 19 Aug 2020 22:23:43 +0000 (UTC) (envelope-from neel@neelc.org) Received: from mail.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) by rainpuddle.neelc.org (Postfix) with ESMTPSA id 9186BEB485; Wed, 19 Aug 2020 15:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neelc.org; s=mail; t=1597875815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=25H0xgXSZHROe3XH93sUYmTPXqA+nefwXJ4jyYS9ccU=; b=bE+CIu2va25CwI1T+R+22jUO0kUIF54DC7cuL7PzItVD1NryFE2afVKHBm8bZWQr5VO7gZ KM8mm2jJbx+V5BJst+upZgrK3AwHb8QUYslNWrokTd4kCI0pqhjA4ezso9rzirRZmFA09F 3D1T09E5fbwCSsZi6TIs6RA2oqI3tLZZ726dEGH40EGuJK9i8jk0TAVqQHaS0g2/62U86P GO+mgWzZDVoQqeg4y79VPBwsIRxpAgIAGN6cX/lsrGYGN/JjOKBnm1fP1fFU3LNMOrpM8J s+fDY1LsoStmK+VDOsHinlx9nOy/TPJ/I8jOsT/yoUh4DYJusaNA6M+HF/r0eA== MIME-Version: 1.0 Date: Wed, 19 Aug 2020 18:23:34 -0400 From: Neel Chauhan To: freebsd-hackers@freebsd.org, freebsd-net@freebsd.org Subject: Committing two ipfw/libalias/RFC6598 patches User-Agent: Roundcube Webmail/1.4.6 Message-ID: X-Sender: neel@neelc.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BX2PC1RVJz4cmn X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=neelc.org header.s=mail header.b=bE+CIu2v; dmarc=pass (policy=none) header.from=neelc.org; spf=pass (mx1.freebsd.org: domain of neel@neelc.org designates 2001:19f0:8001:fed:5400:2ff:fe73:c622 as permitted sender) smtp.mailfrom=neel@neelc.org X-Spamd-Result: default: False [-2.11 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[neelc.org:s=mail]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_MEDIUM(-0.92)[-0.920]; FREEFALL_USER(0.00)[neel]; DKIM_TRACE(0.00)[neelc.org:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[neelc.org,none]; NEURAL_HAM_SHORT(-0.29)[-0.291]; RCVD_COUNT_ONE(0.00)[1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:20473, ipnet:2001:19f0:8000::/38, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-hackers,freebsd-net]; ONCE_RECEIVED(0.10)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 22:23:44 -0000 Hi freebsd-hackers@, freebsd-net@, Could someone please commit these two patches for ipfw/libalias/RFC6598: URL: https://reviews.freebsd.org/D23356 Title: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias Description: Add support for RFC 6598/Carrier Grade NAT address ranges (100.64.0.0/10) in natd by adding a natd flag -unregistered_cgn and its short version -c. This is similar to the -unregistered_only option for RFC 1918, however those subnets will also be supported by this new option. This extends upon r357092 where we added support for RFC 6598 subnets in libalias and ipfw. URL: https://reviews.freebsd.org/D23461 Title: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat. This extends upon the RFC 6598 support to libalias/ipfw in r357092. These two patches add netgraph and userland support for RFC 6598 support in libalias. This continues on r357092/r357787 which added RFC 6598 to libalias and IPFW nat. I'm not a committer so I am unable to commit these. Best, Neel Chauhan === https://www.neelc.org/ From owner-freebsd-net@freebsd.org Sat Aug 22 16:24:46 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A11C73BF950 for ; Sat, 22 Aug 2020 16:24:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BYkHf3r9kz4pJg for ; Sat, 22 Aug 2020 16:24:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 83B8C3BF94F; Sat, 22 Aug 2020 16:24:46 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 837C83BF6E3 for ; Sat, 22 Aug 2020 16:24:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYkHf2wgWz4p76 for ; Sat, 22 Aug 2020 16:24:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 44B051939D for ; Sat, 22 Aug 2020 16:24:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07MGOkJ7060289 for ; Sat, 22 Aug 2020 16:24:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07MGOkFH060288 for net@FreeBSD.org; Sat, 22 Aug 2020 16:24:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 246660] Sporadic LACP Lagg Flap Date: Sat, 22 Aug 2020 16:24:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: b@enlnt.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 16:24:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246660 Aleks B changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |b@enlnt.com --- Comment #1 from Aleks B --- (In reply to nonesuch from comment #0) Were you able to narrow down this issue? I'm having similar issue with Free= BSD 12.1-RELEASE-p7 and Arista 7280 switches in a MLAGG setup. > The FreeBSD side sporadically stops setting the lacp distribution flag. How did you check this? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Aug 22 21:07:38 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9305E3C58A5 for ; Sat, 22 Aug 2020 21:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BYrZ23MpKz3ZTv for ; Sat, 22 Aug 2020 21:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 71C0D3C5921; Sat, 22 Aug 2020 21:07:38 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 706B33C58A4 for ; Sat, 22 Aug 2020 21:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYrZ22DKdz3ZnD for ; Sat, 22 Aug 2020 21:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 300EB1C3E0 for ; Sat, 22 Aug 2020 21:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07ML7cwb058968 for ; Sat, 22 Aug 2020 21:07:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07ML7cMi058967 for net@FreeBSD.org; Sat, 22 Aug 2020 21:07:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 241958] Enable option TCPHPTS in the kernel causes a large % of interruptions if there is no HPET eventtimer in the system Date: Sat, 22 Aug 2020 21:07:36 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: performance X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 21:07:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241958 Michael Tuexen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|rrs@FreeBSD.org |tuexen@freebsd.org --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sat Aug 22 21:15:09 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 657923C5BDA for ; Sat, 22 Aug 2020 21:15:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BYrkj266rz3Zvs for ; Sat, 22 Aug 2020 21:15:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 484A73C5AE3; Sat, 22 Aug 2020 21:15:09 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4816A3C5AE2 for ; Sat, 22 Aug 2020 21:15:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYrkj1FnBz3Zvq for ; Sat, 22 Aug 2020 21:15:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0D5921C737 for ; Sat, 22 Aug 2020 21:15:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 07MLF8uT069407 for ; Sat, 22 Aug 2020 21:15:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 07MLF8Ip069406 for net@FreeBSD.org; Sat, 22 Aug 2020 21:15:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 241958] Enable option TCPHPTS in the kernel causes a large % of interruptions if there is no HPET eventtimer in the system Date: Sat, 22 Aug 2020 21:15:08 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: performance X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 21:15:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241958 Michael Tuexen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Progress |Closed Resolution|--- |FIXED --- Comment #7 from Michael Tuexen --- I could reproduce the problem using the settings of tjh@. More precisely, r362879, in a bhyve VM using a GENERIC kernel with TCPHPTS added, I observe= a 5% to 6% interrupt load. Using r362880 this does not happen anymore. Also I don't observe an interrupt load on VBox with an up-to-date stable/12 machin= e. I think the issue is already solved by https://svnweb.freebsd.org/changeset/base/362880 and therefore I'm closing = this issue. If the problem can still be reproduced on a system with r362880 or higher, please reopen. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sat Aug 22 22:14:06 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A6A7D3C6C6C for ; Sat, 22 Aug 2020 22:14:06 +0000 (UTC) (envelope-from l.tian.email@gmail.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYt2j4Q9jz3dcX for ; Sat, 22 Aug 2020 22:14:05 +0000 (UTC) (envelope-from l.tian.email@gmail.com) Received: by mail-ej1-x62f.google.com with SMTP id oz20so2353713ejb.5 for ; Sat, 22 Aug 2020 15:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=7IU2jJcK4svw4ZTqmQzk+3Ny3QiiFPBP3lDQDeKBNNc=; b=lKd5ZKb67YTRjWzMiWcUrQNRktDjRjNaqngi/RhUcbZEEsqYm171/zNlO0QjqfG3Br tFCYqGMC47RrkCHhCMcCIpAdp1esdrZXGbLoXidJ77UbYVSB4EZWWd2odTh6Ylvuf2GP Xlq7i64+3OdZsvWz6p8Vjlr+Wm6OTSpO3VrU7LhXc8drMQ/NJngjjIzYYdAEvUEOMSnJ yjqj4BTxsf02pGDzszkVaK6n0XhdQBtbGbAAhkc44nNqyy7InbZQg7T724dg/hB4n9sm HtImp/XKE9h5N1cUdAhiCt1Jl+CJnfLOY50wPxDCw9rEMcMHaXbp6L8UEFTelnSabxKa P7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=7IU2jJcK4svw4ZTqmQzk+3Ny3QiiFPBP3lDQDeKBNNc=; b=pRaAKsxiXEHBqwcVxydqw2uYIIMABY6xder3Vo+RJtRBLjZzGAAxmtyt8DEKfys/zw txkdBUf/0xgJEY83lN6f0NYrWFCASprh6XZUDz5zsR+XPg9Y/MwkkAx8SxhoB30DSfso et68TV8SXDhBahgJShCu2Je8XYL0ogfSw4/QPC5JkGQx2yFnPNXxi4u4a3Yt6cVCa/no XEJq3ZntExq1eMTkWlNn6Gpz9mGCLUQhdp8DOEm1Aieg0hElWuXv3SjIpS3XhGeFd1QT ezGDIxrIijsnW+PxAJf8V8k4JdJUlJkUEv5nCQ3qcnQhaxFkWUgVelTs17R0iQe6KZJm tf6g== X-Gm-Message-State: AOAM531RS//4NW2Kz9UA/5DuT+NTo7kvlHO5k0n65MYS5Ra6vz25Yfoo 5+g0pg+C4Ooo4+ZCHAy0Sxt9xI/9jbnnYVSd7CdRXcz1pr0= X-Google-Smtp-Source: ABdhPJyYHefvNMONSC0wPfZOo0d+o8oMSxKFbV6lrbOv1HCqPGXDq72irx5J8tcm/n99L0ToY2LNqjKKghe5KpX6RsI= X-Received: by 2002:a17:906:680a:: with SMTP id k10mr8784742ejr.82.1598134442994; Sat, 22 Aug 2020 15:14:02 -0700 (PDT) MIME-Version: 1.0 From: Liang Tian Date: Sat, 22 Aug 2020 18:13:51 -0400 Message-ID: Subject: Fast recovery ssthresh value To: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BYt2j4Q9jz3dcX X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=lKd5ZKb6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ltianemail@gmail.com designates 2a00:1450:4864:20::62f as permitted sender) smtp.mailfrom=ltianemail@gmail.com X-Spamd-Result: default: False [-1.44 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62f:from]; NEURAL_HAM_SHORT(-0.44)[-0.445]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; TAGGED_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 22:14:06 -0000 Hi all, When 3 dupacks are received and TCP enter fast recovery, if SACK is used, the CWND is set to maxseg: 2593 if (tp->t_flags & TF_SACK_PERMIT) { 2594 TCPSTAT_INC( 2595 tcps_sack_recovery_episode); 2596 tp->snd_recover = tp->snd_nxt; 2597 tp->snd_cwnd = maxseg; 2598 (void) tp->t_fb->tfb_tcp_output(tp); 2599 goto drop; 2600 } Otherwise(SACK is not in use), CWND is set to maxseg before tcp_output() and then set back to snd_ssthresh+inflation 2601 tp->snd_nxt = th->th_ack; 2602 tp->snd_cwnd = maxseg; 2603 (void) tp->t_fb->tfb_tcp_output(tp); 2604 KASSERT(tp->snd_limited <= 2, 2605 ("%s: tp->snd_limited too big", 2606 __func__)); 2607 tp->snd_cwnd = tp->snd_ssthresh + 2608 maxseg * 2609 (tp->t_dupacks - tp->snd_limited); 2610 if (SEQ_GT(onxt, tp->snd_nxt)) 2611 tp->snd_nxt = onxt; 2612 goto drop; I'm wondering in the SACK case, should CWND be set back to ssthresh(which has been slashed in cc_cong_signal() a few lines above) before line 2599, like non-SACK case, instead of doing slow start from maxseg? I read rfc6675 and a few others, and it looks like that's the case. I appreciate your opinion, again. Thanks, Liang