Date: Sun, 29 Nov 2020 09:15:46 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 251412] [patch] math/py-pandas Update to 1.1.4 (Python 3.9 compatible) Message-ID: <bug-251412-21822-c73jWTkDmC@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-251412-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-251412-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251412 Rainer Hurling <rhurlin@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhurlin@FreeBSD.org --- Comment #3 from Rainer Hurling <rhurlin@FreeBSD.org> --- Hi,=20 Many thanks for the patch. There two issues with your patch (test with 'portlint -AC'): - Don't remove PORTEPOCH, once it exists [1] - Your files/patch-setup.py is not generated by 'make makepatch'. For a pro= per patch format it is recommended to use 'make makepatch' [2] [1] Section 5.2.3.2 from Porters Handbook https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html [2] Section 4.4 from Porters Handbook Another thought: The hint in pkg-message about two additional ports is only visible when the port is installed.=20 Wouldn't it be useful from the user's point of view to include these two po= rts math/py-statsmodels and devel/py-xarray as RUN_DEPENDS in the Makefile? I w= ould expect a much better user experience. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-251412-21822-c73jWTkDmC>