Date: Sun, 12 Apr 2020 20:24:02 +0000 From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall Message-ID: <bug-244290-28711-t7kYWJjoMx@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-244290-28711@https.bugs.freebsd.org/bugzilla/> References: <bug-244290-28711@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244290 --- Comment #24 from commit-hook@freebsd.org --- A commit references this bug: Author: cem Date: Sun Apr 12 20:23:56 UTC 2020 New revision: 531554 URL: https://svnweb.freebsd.org/changeset/ports/531554 Log: x11/libxfce4menu: Fix leaked keygrabs when layout changes As diagnosed by Jethro Nederhof, xfce-shortcuts-grabber.c attempts to upd= ate grabbed key shortcuts when xkeyboard layout changes. Unfortunately, it ha= d no memory of which keycodes it has actually grabbed. Instead, it attempted to ungrab the *new* keycode, which obviously doesn't actually ungrab those codes. This went unnoticed for some time, probably because nothing collided with important keys. Recently, a default PrintScreen shortcut was added to Xfc= e, which for whatever reason seems to collide with Up in initial layout. When the kbd layout changes, the shortcut ungrabs the *new* Printscreen keycode and then re-grabs the same keycode, leaving the Up keycode grabbed. Fix this by giving xfce-shortcuts-grabber some memory of which keycodes it has grabbed. When it grabs a key, it remembers the keycode it grabbed in the XfceKey object. When it ungrabs a key, it ungrabs the keycodes in the Xfc= eKey object, rather than those for the new keyboard layout. PR: 244290 Reported by: Aryeh Friedman <aryeh.friedman AT gmail.com>, many others Approved by: madpilot Differential Revision: https://reviews.freebsd.org/D24338 Changes: head/x11/libxfce4menu/Makefile head/x11/libxfce4menu/files/ =20 head/x11/libxfce4menu/files/patch-libxfce4kbd-private_xfce-shortcuts-grabbe= r.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-244290-28711-t7kYWJjoMx>