Date: Sat, 01 Apr 2023 23:34:37 +0000 From: Alastair Hogge <agh@riseup.net> To: Emmanuel Vadot <manu@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1d7ae31d4aa - main - linuxkpi: Add hdmi helpers Message-ID: <818d6db4dfaf420427d38f0491ec29b7@riseup.net> In-Reply-To: <202303280725.32S7P5eF036507@gitrepo.freebsd.org> References: <202303280725.32S7P5eF036507@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2023-03-28 07:25, Emmanuel Vadot wrote: Hello manu, > The branch main has been updated by manu: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=f1d7ae31d4aa7b352611c43a9fb3b04986cff622 > > commit f1d7ae31d4aa7b352611c43a9fb3b04986cff622 > Author: Emmanuel Vadot <manu@FreeBSD.org> > AuthorDate: 2023-03-16 15:12:12 +0000 > Commit: Emmanuel Vadot <manu@FreeBSD.org> > CommitDate: 2023-03-28 07:11:06 +0000 > > linuxkpi: Add hdmi helpers > > This is a direct port of the Linux code as the licence allows it, so > style(9) isn't respected to allow applying directly the upstream commits. > Do not add it to linuxkpi directly but add a new linuxkpi_hdmi module > that drm modules will require later, no need to bloat linuxkpi more. > > Sponsored by: Beckhoff Automation GmbH & Co. KG > Differential Revision: https://reviews.freebsd.org/D39122 > --- > sys/compat/linuxkpi/common/include/linux/hdmi.h | 440 ++++++ > sys/compat/linuxkpi/common/src/linux_hdmi.c | 1922 +++++++++++++++++++++++ > sys/modules/Makefile | 1 + > sys/modules/linuxkpi_hdmi/Makefile | 13 + > 4 files changed, 2376 insertions(+) [leading diff removed] diff --git a/sys/compat/linuxkpi/common/src/linux_hdmi.c b/sys/compat/linuxkpi/common/src/linux_hdmi.c new file mode 100644 index 000000000000..5a9b5c552e49 --- /dev/null +++ b/sys/compat/linuxkpi/common/src/linux_hdmi.c @@ -0,0 +1,1922 @@ [most of module removed] +} +EXPORT_SYMBOL(hdmi_infoframe_unpack); + + +MODULE_VERSION(linuxkpi_hdmi, 1); +MODULE_DEPEND(linuxkpi_hdmi, linuxkpi, 1, 1, 1); +MODULE_DEPEND(linuxkpi_hdmi, wlan, 1, 1, 1); Is this module meant to depend on wlan? I was unable to boot a working X after updating past this commit; upon booting the kernel, it did not load linuxkpi_hdmi because wlan was missing. I did not want to rebuild world and kernel WITH_WIRELESS and with the wlan device, so I removed the MODULE_DEPEND declaration on wlan. Not sure what is going on, and if linuxkpi will depend on the networking stack in future? Thanks for the amazing work on continuing FreeBSD work on the desktop for the 14 or so of us users ;-) Alastair
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?818d6db4dfaf420427d38f0491ec29b7>