From nobody Sun Feb 12 10:54:47 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PF49l2Dr3z3qbRC for ; Sun, 12 Feb 2023 10:54:51 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PF49l1dj3z3sDd for ; Sun, 12 Feb 2023 10:54:51 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676199291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=MsCpbC0i5ZXCRX4Y4CT4HiksM3W7wPCEElQ8nIw84Qc=; b=XCplZgUq6oI+zlYciOwvXcTdhhxwv/7M5UZarv9ugzM3HaMo9ZaqiejsULpLY5k0weQWMB 0NbcWqnrp95rHFP3wGQ8Ctq7OHH4UpAk1M+JA1Bq2ffTlTV3YvHwYrRxWQ3zggvz0dabk9 /X3ZFkN2Bud+E+ZWwWa3Pn7BWpKfwJ6Vhi44km2M1i+PybAAojz2fJ3DkMr1nSw5RmrX2Z Zo4dSVkzyUoNkr0lv2cF/grB7X5MBMrfxnvFQzKQ0KSJjkNJYilHVTDWWChkN8tTkkfcNJ fc01H1vgsUeQZr71oYkQApoFn7y8S7p3q+r4mP3JJ387SBufHj32+dCGEBN7Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676199291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=MsCpbC0i5ZXCRX4Y4CT4HiksM3W7wPCEElQ8nIw84Qc=; b=n8YwohgpffX0FqqouvKG/8RLdmD7CrihG4PL7B68mi+rVSnvg0awkETpB/UI8RIkL2Qfwn VqrsJjowiJXlbjcP9rVQwNCZhScN0dBfC8vn/Lu8jrEObLJ8bUO/rpOopUKYRh/LhbyoEy hOcIJW9jRDVmIUbgJsm1sI9vleSJYAgThLFgT72lZ2P2PeUTLmxL9ofp8Xdk06iDH7r9uE +7A/DLb+Sn/PvrwnP0XjQJYaaHp6iqJnEUbquLN1orvnnvbk68tlTBSPZoD8KrglcPEMHp iEj5hy6P6PI0X9Uf5hxUvtj2rRTkt9Gj9eUGviRTglI/0nZ83yGTF9k9Y2cl5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676199291; a=rsa-sha256; cv=none; b=PE7sm+aEzwl/5ESBCTsJTYlnvH6eQQszFzZvXIdA32nYNRwfH1bRu0bhiqxI9j66886xY3 2ZpoZeWMgU1/b9qMxB6L5MEHvGmJrw79OeKKT///zQ0m2FGwqdcRxZpU28UHgI/SYx5ssI j+9AN3qzYORHteoE/kGuw7wX4FbLREkRY2jnymPCsXMGqD96iHv2v1jOLFsFxpu9mipw0n hh6KsnLp16vxlBDECttnUUowjiWrulpD2T8Lj2ZRaE8HWxswHn7eYKfh1hBTjpzMgiQ7wk NLYEkRPnThnsWkvGFYAE5JorcEhqiEcsAYPI1H5mOyaRzmHSvlj+qzN57u6QbQ== Received: from localhost (p200300cb871a697a0cc2ad53a5c0e03b.dip0.t-ipconnect.de [IPv6:2003:cb:871a:697a:cc2:ad53:a5c0:e03b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PF49k54pszh4F for ; Sun, 12 Feb 2023 10:54:50 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Sun, 12 Feb 2023 11:54:47 +0100 From: Gordon Bergling To: freebsd-current@freebsd.org Subject: Build breakage with WITH_BEARSSL=1 Message-ID: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Url: X-Operating-System: FreeBSD 13.2-PRERELEASE amd64 X-Host-Uptime: 11:49AM up 2 days, 21:46, 2 users, load averages: 0.29, 0.81, 0.57 X-ThisMailContainsUnwantedMimeParts: N Hi, I am currently seeing a build breakage when building -CURRENT with WITH_BEARSSL=1. The error is the following make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.asc 2> /dev/null" returned non-zero status /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a function declaration without a prototype is deprecat ed in all versions of C [-Werror,-Wstrict-prototypes] br_rsa_i62_keygen_get() ^ void 1 error generated. --- rsa_i62_keygen.pico --- When disabling BEARSSL in the src.conf the build succeeds as usual. Has anyone also seen this build error. Sources are very recent and the src.conf is the following: WITH_EXTRA_TCP_STACKS=1 #WITH_BEARSSL=1 WITH_PIE=1 WITH_RETPOLINE=1 WITH_INIT_ALL_ZERO=1 WITH_OPENSSL_KTLS=1 WITHOUT_CLEAN=1 Any help is very appreciated. --Gordon From nobody Sun Feb 12 11:25:04 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PF4rt450hz3pB00 for ; Sun, 12 Feb 2023 11:25:18 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PF4rs6p9vz3wvQ; Sun, 12 Feb 2023 11:25:17 +0000 (UTC) (envelope-from garyj@gmx.de) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1676201116; bh=olviONB04YDSlYRV376opnhPxC4SwJ8R0ZB2qgU9dg4=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References: Reply-To; b=QOmWokt6QQfzXSsVs1M9f15HeRnshwceOh1yV8tDORQegf8MGz7Dk6rpjIjq5+VW2 owTMcw+c/7nvZTDci0bD1OA3t/Yj7TsQor3afk6Io9x/mJR7T8YtnaJFVkivY+6vdH 2AejLJfkTf+82k4VUwugtOlCtPNvF1Uw2iXxV3xfGLfs/FR6Jb4L0TGV22K0GxeoGD 4Gdr/pDNIADSqvP5ZCrcL+wfPi0yUu6HN48+7mo7ZN8M6kQjSIVAGg8wBM0zEnpMs5 EzMcXHMcxPR4s4cSUstTEW1wzAIVhat1BZ8nzwk/nGWzcs0wOM4FKNSSBHcOVpGeep GkYjHOw06X0HA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from ernst.home ([217.226.49.211]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MVeMA-1p1pbk1gJg-00RVB0; Sun, 12 Feb 2023 12:25:16 +0100 Date: Sun, 12 Feb 2023 11:25:04 +0000 From: Gary Jennejohn To: Gordon Bergling Cc: freebsd-current@freebsd.org Subject: Re: Build breakage with WITH_BEARSSL=1 Message-ID: <20230212122504.1ea67704@ernst.home> In-Reply-To: References: Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SBpMdjRiJMMah3BLotQCRajOr6zbo2XzcLia6e0vz5ZvB4TfzVh r8SFLnjSZj7MSKnff1LHlsJDsBwii6qScfYjLJzd9BgGzejKacXKtC+kcNJ6itF4wuf9QBS jTQ3PkclzzH9CZqL5yZEotKw9wP9XM4UBwqBwtxHLVaf1ih2jWWAhVNHmSwx15PZt9KEj6+ 6eBa9GY2uSA5h/nCXDVUA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Y7eV1epIKZg=;/Eh8Ls0ggl4J9n1IGxKnq0qAtIc DtcaNaJHm5BzvuukR/lwHwoAlmXCIM7iFRVs+Mdfq8Cfmg0yPeDHFcehWf6vyz11wn87KyTVc P39YbmLhi+M5hkOdJh3O2sCl2UhmWD7B3LCIDv3p01aDtNAogMj9nRZmSOwyu2WlzoyVlgnW8 o3GsntKYw8/0jyVi0Kohbv3CRVu+70bAPoC6U1oMLBzc0BeqhZbLcnIz9PjzFT/VqPY9j5J7B YPkJHiyrCRXVUB9aBsXDjxiB11m09GFgRIDtGJIMUOxp3zI/4oQtCVYVngEphwK7KT/0vGni2 UNBlEensS0xQ9zygPcajYFtQNmv3s96nHDZmZ+DRu4R5ZdXFB0WJ0UTty9aqitYyXaivewN0f Jm5LM0e9R+Ma11Lik/PWr2Pgt31+VQQyUmv0lRTndtFWzjnfIdUlmQuoePF5FgXujsam9V24R rhTy8Spiv1Z+1oZG9Dd3BqwwoatoDJDtccprtDCbDuAH4ov2z5NSSPBXJQ3DlLs6OQW7I4K/p ShcbRvY2Tp4B08XF+yPYlD9TTyiNrT9JafabS4j/xMDfxL4Fc1Kd2K9ylOQm4FwEFn2WKdMNJ 8rPiHo0eviL0F2KrQIJHHol1uPe3GTl1zDs7CaE4tX3LbiIW783GZUfO8U4QNhIruonXCJi1O v70cY/nBpnarw5mzNyFUhkJOfylsN8ey7CTQZarhrEXAsntJ2M6NZ7LSeK3IIr1XtUK4VJOXA zpVFEYkQQ839CvzMubmNSGK60GDfuOBZ7D/LwZOmko1sn0ZgxaQLjyB/nq7vkQXtMD4u2sVqX ayKOFX9/ATW2sUsdVofEzkG1yIaqN9+scu3mmsC/u2x805NTSiFYidy0wbyfiDA59r8TXLSUX p+KODCTuWjxfX5xSbugOX802ouE1iGHSf0UEBKma7XdCfCjqnnmLGu3wOJXzCZE3dG2Wi5dt3 sJXMqiRe8Aa71YODOyIF2wc+6Ho= X-Rspamd-Queue-Id: 4PF4rs6p9vz3wvQ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sun, 12 Feb 2023 11:54:47 +0100 Gordon Bergling wrote: > Hi, > > I am currently seeing a build breakage when building -CURRENT with WITH_= BEARSSL=3D1. > > The error is the following > > make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: = warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.asc 2= > /dev/null" returned non-zero status > /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error:= a function declaration without a prototype is deprecat ed in all version= s of C [-Werror,-Wstrict-prototypes] > br_rsa_i62_keygen_get() > ^ > void > 1 error generated. > --- rsa_i62_keygen.pico --- > > > When disabling BEARSSL in the src.conf the build succeeds as usual. > > Has anyone also seen this build error. Sources are very recent and the > src.conf is the following: > > WITH_EXTRA_TCP_STACKS=3D1 > #WITH_BEARSSL=3D1 > WITH_PIE=3D1 > WITH_RETPOLINE=3D1 > WITH_INIT_ALL_ZERO=3D1 > WITH_OPENSSL_KTLS=3D1 > WITHOUT_CLEAN=3D1 > > Any help is very appreciated. > The current clang wants to see br_rsa_i62_keygen_get(void), that's why void was emitted. The other routine in this file has the same error. Could be that this code has this problem in many places. There might a flag which one could pass to clang so that it would not choke on such an error, but I don't know clang well enough to figure that out. Maybe someone in the know could supply that info. =2D- Gary Jennejohn From nobody Sun Feb 12 17:28:33 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFDwG2vBkz3qPNS for ; Sun, 12 Feb 2023 17:28:46 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFDwF2wp0z3hMs for ; Sun, 12 Feb 2023 17:28:45 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b="o/Kb8+CA"; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2607:f8b0:4864:20::435 as permitted sender) smtp.mailfrom=rick.macklem@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x435.google.com with SMTP id t17so6547878pfj.0 for ; Sun, 12 Feb 2023 09:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=WgQ7XgNfNUzsbXuugvowfs6aXZ3VrZ6xW/stM6oDh1U=; b=o/Kb8+CAQkczGFKmGoV14J/MnL4sx3aXuXXnKEZYsRe8zeIS972TqChM/PTNXgWk3c kUQedMPdRsfCCD89GwfpeDQK++F8MUnD7YLv8sanb4vof2vHwyTx2L1VXsCn5oACjWfs yldTlYPiPnlUvoTLTDudu0bdj818bqVSOP4Ww/s/y0NHJd2h6t7yDd5oLJYvSaZQiRCF ejMlZl+hO1SzOKr4ZvcNRmU6ZMvO5Lu+PgUt1MbBPeFXhRvuVhEy/B8fT5BBm4I2YCls i0KSiscvyhFHSISDWgfkQCqFbaeQx0k3k2AV7DiRet50QpGdUpkEyVyFexfoOKv0FPGK +5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WgQ7XgNfNUzsbXuugvowfs6aXZ3VrZ6xW/stM6oDh1U=; b=m+ZmNFv3O3xDYJ+8A+Xp/HRMEX3Uk8VHtvxDgxGPmsTgv/vQoVB0gnzSdoScuTTybc Z4QN4MR5ZJWFO7YcWMpswasEgTsxQrRIR/VUGUHBFYGkCvYHm9e3SHlcVIz/0W665VEv BHZoPbxZA6+ST1tKBBXUeOnhJwxBuhYPFliFjaujEPLhakjk4thgT0ZZX5Ih3y0kfhvU fvpWRu7j5g0ygWYEFomOQ9CO+YTL5wBcxlrEabcXNgEQgdg+kv9Ko8yPZjjI7FRB76ED A+zJvSPUf9O1ivdICW2esDJMvANDLjnILOUI5pm/tfQ475/TFwQc5cB7luHnUpodVLyX Lujw== X-Gm-Message-State: AO0yUKW7wX7aLh3aj2lHopv12AENpTNr6cw2sESM9xpjYZLCeVCJy/bM OoqoDXjCH2Jcxdj3hr4ctQLjIFRauGwmsQGdJ/kuCzvsbw== X-Google-Smtp-Source: AK7set/ruYc/I183uX67qa0SSCIuEGDS6Uhggn/UlKzorcgInYSOqvfukB0nC5+5SZX4ebLH5cgjwXoDabigjhyhDSw= X-Received: by 2002:a62:1543:0:b0:5a8:b3c8:6676 with SMTP id 64-20020a621543000000b005a8b3c86676mr251209pfv.55.1676222923836; Sun, 12 Feb 2023 09:28:43 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 From: Rick Macklem Date: Sun, 12 Feb 2023 09:28:33 -0800 Message-ID: Subject: Belated Heads Up: commits to add vnet macros to nfsd To: FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-3.03 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_SHORT(-0.03)[-0.033]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::435:from]; ARC_NA(0.00)[]; TAGGED_FROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+]; TO_DN_ALL(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PFDwF2wp0z3hMs X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hi, Commit 7344856e3a6d was a large patch that added macros that will front end the vnet macros. These macros are null ops now, so they should not affect semantics. However, the code did change how things get initialized for the nfsd and that has already caused some breakage, that I think is now fixed. - The prison cleanup code snuck into the patch and that won't work until the macros actually front end the vnet ones. - oliver reported a crash during booting, that I think was caused by the one initialization function being called too late (by the nfsd server once it entered the kernel). Apologies for the breakage. I don't think the next patches should be problematic, but let me know if you see problems. rick From nobody Sun Feb 12 22:18:44 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFMM45twjz3pFyT for ; Sun, 12 Feb 2023 22:18:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFMM45SH0z4WXM for ; Sun, 12 Feb 2023 22:18:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id d40so9376728eda.8 for ; Sun, 12 Feb 2023 14:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=diR/hkwJG8qvHeiDy+9OLWvdzbOr7gj4G/Nv7DY84gI=; b=Sn6SDOc5PKR6/xsCpis4EiAFIH8Kgx74PvruxNhB5RsbXFVWGsw75hY83brrCcAn38 w1brQRPxyb6eQFIeXofhqFku59lJmNZ82R1JTtMONKeZtH/r/+m5S4ybM6wDIZC9eAvh w8FO3hkVsgUoxGt0m0+ZEwXdtt6JKDdKtM1h0HjroNWAkh43YqhktEwLpOJhxXRQeFZ1 VAYrxZ2voVGiG8YTvktuzRs8XpfW4Fw4a3J4LL7t3WrAIB0tlMM863qlQVOuyeDwWSwm fnt5ujANbBjC+h59BuZwLnQtUMEjv8E2w/4dBETg55ewN1r/GBnVQm/rBeO1ZabByX9c iYiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=diR/hkwJG8qvHeiDy+9OLWvdzbOr7gj4G/Nv7DY84gI=; b=dVhB3y87tD6dvO0nnICNqFo0doF57YFSQSoIJGptBPyFkKl2mMTuNz5ic4EJmJ9wud ZFoffU46RBQKXFXb3wPypEvp/+yrIRNEfvSp3qutYawZrAvpq0I6XgUe2aOZV1zIuODJ /eF9IL0h6COCDQ9sd/XJBjrWDdyXEe7ox7nPQoT4vlLZqNR71BwbpoNvic3d+/KXjpKr PbA+NN9WZNXKwwnVnApz6XI7ZyfZ86oLWmGO2HjdEk5ZMgefxCSKBdM6s/Vy/QqInV1s OmXzqQrZhtWSGmhzHENJ26ChCVo27WcFmnSkU3+9B/Y5qdc37y2LdXnvs4NV6DEBQewT vqPA== X-Gm-Message-State: AO0yUKXqssjSPvieGdrppbPxih2/bpakHRM6t9O4z1vWAqKTN6YXcEE5 QZ8Vqhy4jSukmfuUl24XUvgyEYWxLz96N1O9PD7PFpDMbJroFxpC X-Google-Smtp-Source: AK7set/c2xVFvOz/uZVwah3EONC6wNbj/PYFi/xmiQAsNFm9srzQVwPdJfAPLX/ETAM1LERC+JzI5Qbhi61t4eXZ+JE= X-Received: by 2002:a50:9e4b:0:b0:4a8:2436:4ed2 with SMTP id z69-20020a509e4b000000b004a824364ed2mr5915797ede.0.1676240335574; Sun, 12 Feb 2023 14:18:55 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sun, 12 Feb 2023 15:18:44 -0700 Message-ID: Subject: Re: Build breakage with WITH_BEARSSL=1 To: Gordon Bergling Cc: freebsd-current@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c2a6c005f4881dd2" X-Rspamd-Queue-Id: 4PFMM45SH0z4WXM X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000c2a6c005f4881dd2 Content-Type: text/plain; charset="UTF-8" On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: > Hi, > > I am currently seeing a build breakage when building -CURRENT with > WITH_BEARSSL=1. > > The error is the following > > make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: > warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.asc 2> > /dev/null" returned non-zero status > /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a > function declaration without a prototype is deprecat ed in all versions of > C [-Werror,-Wstrict-prototypes] > br_rsa_i62_keygen_get() > ^ > void > 1 error generated. > --- rsa_i62_keygen.pico --- > > > When disabling BEARSSL in the src.conf the build succeeds as usual. > > Has anyone also seen this build error. Sources are very recent and the > src.conf is the following: > > WITH_EXTRA_TCP_STACKS=1 > #WITH_BEARSSL=1 > WITH_PIE=1 > WITH_RETPOLINE=1 > WITH_INIT_ALL_ZERO=1 > WITH_OPENSSL_KTLS=1 > WITHOUT_CLEAN=1 > > Any help is very appreciated. > > What does the following do for you? It's a cut and pasted patch, but it should be clear enough what to do if the mailer mangles it. diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc index dd0e242c8ef0..2af4864d8441 100644 --- a/lib/libbearssl/Makefile.inc +++ b/lib/libbearssl/Makefile.inc @@ -4,4 +4,4 @@ BEARSSL?= ${SRCTOP}/contrib/bearssl BEARSSL_SRC= ${BEARSSL}/src CFLAGS+= -I${BEARSSL}/inc - +CFLAGS+= ${NO_WDEPRECATED_NON_PROTOTYPE} Warner --000000000000c2a6c005f4881dd2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Feb 12, 2023 at 3:54 AM Gordo= n Bergling <gbe@freebsd.org> w= rote:
Hi,

I am currently seeing a build breakage when building -CURRENT with WITH_BEA= RSSL=3D1.

The error is the following

=C2=A0 make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk"= ; line 109: warning: "cd /boiler/nfs/src/lib/libsecureboot && = 'ls'=C2=A0 =C2=A0-1 *.pem t*.asc 2> /dev/null" returned non= -zero status
=C2=A0 /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: a function declaration without a prototype is deprecat=C2=A0 ed in all v= ersions of C [-Werror,-Wstrict-prototypes]
=C2=A0 br_rsa_i62_keygen_get()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 void
=C2=A0 1 error generated.
=C2=A0 --- rsa_i62_keygen.pico ---


When disabling BEARSSL in the src.conf the build succeeds as usual.

Has anyone also seen this build error. Sources are very recent and the
src.conf is the following:

WITH_EXTRA_TCP_STACKS=3D1
#WITH_BEARSSL=3D1
WITH_PIE=3D1
WITH_RETPOLINE=3D1
WITH_INIT_ALL_ZERO=3D1
WITH_OPENSSL_KTLS=3D1
WITHOUT_CLEAN=3D1

Any help is very appreciated.


What does the following do for you? It= 's a cut and pasted patch, but it should be clear enough what to do if = the mailer mangles it.

diff --git a/lib/libbearssl= /Makefile.inc b/lib/libbearssl/Makefile.inc
index dd0e242c8ef0..2af4864d= 8441 100644
--- a/lib/libbearssl/Makefile.inc
+++ b/lib/libbearssl/Ma= kefile.inc
@@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
=C2= =A0BEARSSL_SRC=3D ${BEARSSL}/src

=C2=A0CFLAGS+=3D -I${BEARSSL}/inc-
+CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}

=
Warner

--000000000000c2a6c005f4881dd2-- From nobody Mon Feb 13 16:42:02 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFqrC4TQVz3rQXH for ; Mon, 13 Feb 2023 16:42:19 +0000 (UTC) (envelope-from Walter.von.Entferndt@posteo.net) Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFqrB4pTJz3RKJ for ; Mon, 13 Feb 2023 16:42:18 +0000 (UTC) (envelope-from Walter.von.Entferndt@posteo.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=posteo.net header.s=2017 header.b=meUc3xI1; spf=pass (mx1.freebsd.org: domain of Walter.von.Entferndt@posteo.net designates 185.67.36.66 as permitted sender) smtp.mailfrom=Walter.von.Entferndt@posteo.net; dmarc=pass (policy=none) header.from=posteo.net Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BE8E6240157 for ; Mon, 13 Feb 2023 17:42:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1676306537; bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=; h=From:To:Subject:Date:From; b=meUc3xI1F7yKapHi22PzUX8AHRLJq1PCzc40j6L5XfWQWGfAWsbDXGmJHAKi53J0e rqCwTDbHEbyF/BKV46Y/jrafxfPpXwWBGn4arAo7SAOnTpqQKMOfuKSSmrKXkmoBpc lq9rd9dWoEZsjZ2jecxJMIB9XE2LHOjbSUZ9K7NbsJkKpibTCZx9mC8GWDJyNcKaVV LmqumQ9R0uIAnyjj+q81OFfoAzvWmMkD4T6pWitZkg0juVxyoEAuwRBPNJ4Q9zry3P z6JefgA7McG3rFBMeot3RAuNr8nF/WSf4VMuHR2rAbXxUwx9gj1sVi1LwaAtGYxzHe tE/rdGf5/3gIQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PFqr92hPvz9rxF for ; Mon, 13 Feb 2023 17:42:17 +0100 (CET) From: Walter von Entferndt To: freebsd-current@freebsd.org Subject: unsubscribe Date: Mon, 13 Feb 2023 16:42:02 +0000 Message-ID: <38165835.bKIjKVBIMv@t450s.local.lan> X-Face: #$[hC+4[4W*mS3hB&izisyT_#E]^Aq+7Isv`2Tu5q*1~jR@&['74B>Ibyrk]GTJ!j$ NjX=#L2#k2X7OnaaRM_Pd5`>`8OJ3;+I2 References: <4PB3GF0Ljyz3mxDr@mlmmj.nyi.freebsd.org> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spamd-Result: default: False [-4.20 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; CTE_CASE(0.50)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; DMARC_POLICY_ALLOW(-0.50)[posteo.net,none]; R_DKIM_ALLOW(-0.20)[posteo.net:s=2017]; R_SPF_ALLOW(-0.20)[+ip4:185.67.36.0/23:c]; RCVD_IN_DNSWL_MED(-0.20)[185.67.36.66:from]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; ASN(0.00)[asn:8495, ipnet:185.67.36.0/23, country:DE]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[posteo.net:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; RWL_MAILSPIKE_POSSIBLE(0.00)[185.67.36.66:from] X-Rspamd-Queue-Id: 4PFqrB4pTJz3RKJ X-Spamd-Bar: ---- X-ThisMailContainsUnwantedMimeParts: N From nobody Tue Feb 14 22:19:02 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PGbGM3427z3q4jw for ; Tue, 14 Feb 2023 22:19:07 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PGbGL32fXz4H9s for ; Tue, 14 Feb 2023 22:19:06 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of dchagin@heemeyer.club has no SPF policy when checking 195.93.173.158) smtp.mailfrom=dchagin@heemeyer.club; dmarc=none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.1/8.16.1) with ESMTP id 31EMJ2Gf085838 for ; Wed, 15 Feb 2023 01:19:02 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.1/8.16.1/Submit) id 31EMJ25M085837 for freebsd-current@freebsd.org; Wed, 15 Feb 2023 01:19:02 +0300 (MSK) (envelope-from dchagin) Date: Wed, 15 Feb 2023 01:19:02 +0300 From: Dmitry Chagin To: freebsd-current@freebsd.org Subject: fresh world Message-ID: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spamd-Result: default: False [-1.73 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.63)[-0.628]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU]; DMARC_NA(0.00)[heemeyer.club]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[dchagin]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4PGbGL32fXz4H9s X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N Hi, fresh world, installed today, fails to builds: make[2]: "/home/dchagin/freebsd/Makefile.inc1" line 442: The src.conf WITHOUT_CLEAN option can now be used instead of NO_CLEAN. >>> Deleting stale dependencies... sh /home/dchagin/freebsd/tools/build/depend-cleanup.sh /home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64 0,17 real 0,06 user 0,11 sys -------------------------------------------------------------- >>> stage 2.3: build tools -------------------------------------------------------------- cd /home/dchagin/freebsd; time env INSTALL="sh /home/dchagin/freebsd/tools/install.sh" TOOLS_PREFIX=/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp PATH=/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp/legacy/usr/sbin:/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp/legacy/usr/bin:/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp/legacy/bin:/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp/legacy/usr/libexec:/sbin:/bin:/usr/sbin:/usr/bin WORLDTMP=/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp MAKEFLAGS="-m /home/dchagin/freebsd/tools/build/mk -D NO_CLEAN -j 1 -J 15,16 -m /home/dchagin/freebsd/share/mk" make -f Makefile.inc1 TARGET=amd64 TARGET_ARCH=amd64 DESTDIR= BOOTSTRAPPING=1400079 BWPHASE=build-tools -DNO_CPU_CFLAGS -DNO_LINT MK_ASAN=no MK_CTF=no MK_CLANG_EXTRAS=no MK_CLANG_FORMAT=no MK_CLANG_FULL=no MK_LLDB=no MK_RETPOLINE=no MK_SSP=no MK_TESTS=no MK_UBSAN=no MK_WERROR=no build-tools make[2]: "/home/dchagin/freebsd/Makefile.inc1" line 442: The src.conf WITHOUT_CLEAN option can now be used instead of NO_CLEAN. ===> bin/csh (obj,build-tools) cc -o gethost -Wl,-zrelro -pie -L/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp/legacy/usr/lib -ferror-limit=1 -g -fno-common -I. -I/home/dchagin/freebsd/bin/csh -I/home/dchagin/freebsd/contrib/tcsh -D_PATH_TCSHELL='"/bin/csh"' -fPIE -g -gz=zlib -MD -MF.depend.gethost -MTgethost -std=gnu99 -Wno-format-zero-length -Wsystem-headers -Wno-pointer-sign -Wdate-time -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-variable -Wno-error=array-parameter -Wno-error=deprecated-non-prototype -Wno-error=unused-but-set-parameter -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -I/home/dchagin/tmp/obj/home/dchagin/freebsd/amd64.amd64/tmp/legacy/usr/include /home/dchagin/freebsd/contrib/tcsh/gethost.c ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:314 (/home/dchagin/freebsd/lib/libc/gen/tls.c:314) >>> tls.o:(_rtld_free_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:314 (/home/dchagin/freebsd/lib/libc/gen/tls.c:314) >>> tls.o:(_rtld_free_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:315 (/home/dchagin/freebsd/lib/libc/gen/tls.c:315) >>> tls.o:(_rtld_free_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:335 (/home/dchagin/freebsd/lib/libc/gen/tls.c:335) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:335 (/home/dchagin/freebsd/lib/libc/gen/tls.c:335) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:336 (/home/dchagin/freebsd/lib/libc/gen/tls.c:336) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_64 cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:342 (/home/dchagin/freebsd/lib/libc/gen/tls.c:342) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_64 cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:348 (/home/dchagin/freebsd/lib/libc/gen/tls.c:348) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:358 (/home/dchagin/freebsd/lib/libc/gen/tls.c:358) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:365 (/home/dchagin/freebsd/lib/libc/gen/tls.c:365) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:366 (/home/dchagin/freebsd/lib/libc/gen/tls.c:366) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:367 (/home/dchagin/freebsd/lib/libc/gen/tls.c:367) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:375 (/home/dchagin/freebsd/lib/libc/gen/tls.c:375) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:376 (/home/dchagin/freebsd/lib/libc/gen/tls.c:376) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:376 (/home/dchagin/freebsd/lib/libc/gen/tls.c:376) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:377 (/home/dchagin/freebsd/lib/libc/gen/tls.c:377) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:377 (/home/dchagin/freebsd/lib/libc/gen/tls.c:377) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:379 (/home/dchagin/freebsd/lib/libc/gen/tls.c:379) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:379 (/home/dchagin/freebsd/lib/libc/gen/tls.c:379) >>> tls.o:(_rtld_allocate_tls) in archive /usr/lib/libc.a ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC >>> defined in /usr/lib/libc.a(tls.o) >>> referenced by tls.c:443 (/home/dchagin/freebsd/lib/libc/gen/tls.c:443) >>> tls.o:(_init_tls) in archive /usr/lib/libc.a ld: error: too many errors emitted, stopping now (use --error-limit=0 to see all errors) cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [gethost] Error code 1 make[3]: stopped in /home/dchagin/freebsd/bin/csh 1 error make[3]: stopped in /home/dchagin/freebsd/bin/csh *** [build-tools_bin/csh] Error code 2 make[2]: stopped in /home/dchagin/freebsd 1 error make[2]: stopped in /home/dchagin/freebsd 1,26 real 1,11 user 0,26 sys make[1]: stopped in /home/dchagin/freebsd make: stopped in /home/dchagin/freebsd From nobody Wed Feb 15 14:11:18 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH0P42vTmz3qMqt for ; Wed, 15 Feb 2023 14:11:20 +0000 (UTC) (envelope-from jamie@catflap.org) Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [IPv6:2001:19f0:300:2185:123::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4PH0P357LQz3C3B for ; Wed, 15 Feb 2023 14:11:19 +0000 (UTC) (envelope-from jamie@catflap.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jamie@catflap.org designates 2001:19f0:300:2185:123::1 as permitted sender) smtp.mailfrom=jamie@catflap.org; dmarc=pass (policy=none) header.from=catflap.org X-Catflap-Envelope-From: Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [104.207.135.49]) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5) with ESMTP id 31FEBJLf024308; Wed, 15 Feb 2023 14:11:19 GMT (envelope-from jamie@donotpassgo.dyslexicfish.net) Received: (from jamie@localhost) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5/Submit) id 31FEBJhh024307; Wed, 15 Feb 2023 14:11:19 GMT (envelope-from jamie) From: Jamie Landeg-Jones Message-Id: <202302151411.31FEBJhh024307@donotpassgo.dyslexicfish.net> Date: Wed, 15 Feb 2023 14:11:18 +0000 Organization: Dyslexic Fish To: mjguzik@gmail.com, jamie@catflap.org Cc: freebsd-current@freebsd.org Subject: Re: 1 year src-patch anniversary! References: <202301292218.30TMIQmM020883@donotpassgo.dyslexicfish.net> In-Reply-To: User-Agent: Heirloom mailx 12.4 7/29/08 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (donotpassgo.dyslexicfish.net [104.207.135.49]); Wed, 15 Feb 2023 14:11:19 +0000 (GMT) X-Spamd-Result: default: False [-3.68 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.981]; DMARC_POLICY_ALLOW(-0.50)[catflap.org,none]; R_SPF_ALLOW(-0.20)[+mx:dyslexicfish.net:c]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; SUBJECT_ENDS_EXCLAIM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,catflap.org]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[jamie]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; HAS_ORG_HEADER(0.00)[]; TO_DN_NONE(0.00)[]; ASN(0.00)[asn:20473, ipnet:2001:19f0::/38, country:US] X-Rspamd-Queue-Id: 4PH0P357LQz3C3B X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Mateusz Guzik wrote: > Well I was not aware of it. Apologies for the delay in replying. Fair enough you weren't aware, but the thing is, how do we make people aware? If bugs.freebsd.org is no longer the way to go, what's the alternative? > mail me with git format-patch result and I'll commit. Thanks! However, in this case, "delphij" has already done it. Cheers, Jamie From nobody Wed Feb 15 14:21:50 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH0dT2r4Tz3qNQV for ; Wed, 15 Feb 2023 14:22:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH0dT0yTTz3FSf for ; Wed, 15 Feb 2023 14:22:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x533.google.com with SMTP id fi26so22299725edb.7 for ; Wed, 15 Feb 2023 06:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Jv4HIPgaAUm4oSgQJo21ATwvZZM5S+Trv1WCRuF4LA4=; b=4cXgWV7FtqPGzqcTWS9cKQ4NWJH8YO93vZZz8uGo2YP5hTR1+NayVYUUXGxkCUzQIr WewTUPCttiIF73qI06qFROyPBlOAXl8wtJ18vhIhxLPb8lTNxzTdZqEYx6a+5AgmK3Nb oUgNY7b+dm1Wb9FxT735sKiKE2ZWQRSujiSZJBxqgou4rGYatTeVYWeFB4TUlf5c/Zny 43dm7kCTL2+atFp7KhX2ZtjULoCpaRMifC7WJjDb2bFE7UEvO5gcrxG/YubrIXNaebFs C4nrNgD9h3IAlsyGLNX/CBjP4hyJD7BNEjJH8MIUTohv6Xs7qo/mKFme5vPBcWw8RDBl ADCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jv4HIPgaAUm4oSgQJo21ATwvZZM5S+Trv1WCRuF4LA4=; b=n9eGC8SjSeB2OFuR66idMn1+ARBd+LTk1sNNjL3QJdKy7DJ0xlqP0fwq9hokMVEMPH 5kEctzQwp4ye9OAa6R6zepts4MkXT+6QFpLwgCRvdxcHraP8dlvV4YlXydIatjBxf6RI oTwm2r5ZtVBtOgoBdTT+LUi3W2OvQoQrerlPXnRyX3hJr/YwT9xRBwaxEufoiwozlyII 8n7gTkDQ16OD6HSQxJYsrADLtnkNlFAVttDwi3WGXsDfbBPB3h4OAPteELOvy43VYYaN i8zQmfZRG2u7B/0GUufZwxUFazERsWHqixlk/ypCuKXzo1+m2DbKIj7VvQTKU7jGyWzJ ZTMA== X-Gm-Message-State: AO0yUKVj9FhGjJADWCND0MQpO6VxO+18rSzvPVeMW2ojJaKk3tbQbVs4 pVg1mT2s76odvzEj+LuVAbQrI/sX2R6BtbSgiXYBpGLnzQFSvg== X-Google-Smtp-Source: AK7set9/5v+YaL/IS5Kegp6IcgAWOda9Yg8pR4In+9523PC1UXFVt469lj7QDFMe/XPBIOEwSIfp6uuFt4ao84dgnb8= X-Received: by 2002:a50:cc9d:0:b0:4ab:44de:76ef with SMTP id q29-20020a50cc9d000000b004ab44de76efmr1202770edi.0.1676470922417; Wed, 15 Feb 2023 06:22:02 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <202301292218.30TMIQmM020883@donotpassgo.dyslexicfish.net> <202302151411.31FEBJhh024307@donotpassgo.dyslexicfish.net> In-Reply-To: <202302151411.31FEBJhh024307@donotpassgo.dyslexicfish.net> From: Warner Losh Date: Wed, 15 Feb 2023 07:21:50 -0700 Message-ID: Subject: Re: 1 year src-patch anniversary! To: Jamie Landeg-Jones Cc: Mateusz Guzik , FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000cea79a05f4bdcda8" X-Rspamd-Queue-Id: 4PH0dT0yTTz3FSf X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000cea79a05f4bdcda8 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 15, 2023, 7:11 AM Jamie Landeg-Jones wrote: > Mateusz Guzik wrote: > > > Well I was not aware of it. > > Apologies for the delay in replying. Fair enough you weren't aware, but the > thing is, how do we make people aware? > > If bugs.freebsd.org is no longer the way to go, what's the alternative? > Bugzilla is inefficient for small patches. I'm trying an experiment on github: any smallish, almost ready patches will be landed, redirected or rejected quickly Warner > mail me with git format-patch result and I'll commit. > > Thanks! However, in this case, "delphij" has already done it. > > Cheers, Jamie > > --000000000000cea79a05f4bdcda8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Feb 15, 2023, 7:11 AM Jamie Landeg-Jones <<= a href=3D"mailto:jamie@catflap.org">jamie@catflap.org> wrote:
Mateusz Guzik <mjguzik@gmail.com>= ; wrote:

> Well I was not aware of it.

Apologies for the delay in replying. Fair enough you weren't aware, but= the
thing is, how do we make people aware?

If bugs.freebsd.org is no longer the way to go, what's the= alternative?

Bugzilla is inefficient for small patches.

I'm trying an experiment on github: any= smallish, almost ready patches will be landed, redirected or rejected quic= kly=C2=A0

Warner

> mail me with git format-patch result and I'll commit.

Thanks! However, in this case, "delphij" has already done it.

Cheers, Jamie

--000000000000cea79a05f4bdcda8-- From nobody Wed Feb 15 14:39:47 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH11y4fgYz3qPVq for ; Wed, 15 Feb 2023 14:39:50 +0000 (UTC) (envelope-from jamie@catflap.org) Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [IPv6:2001:19f0:300:2185:123::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4PH11x5D6gz3H7S for ; Wed, 15 Feb 2023 14:39:49 +0000 (UTC) (envelope-from jamie@catflap.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jamie@catflap.org designates 2001:19f0:300:2185:123::1 as permitted sender) smtp.mailfrom=jamie@catflap.org; dmarc=pass (policy=none) header.from=catflap.org X-Catflap-Envelope-From: Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [104.207.135.49]) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5) with ESMTP id 31FEdlBc025599; Wed, 15 Feb 2023 14:39:47 GMT (envelope-from jamie@donotpassgo.dyslexicfish.net) Received: (from jamie@localhost) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5/Submit) id 31FEdlI5025598; Wed, 15 Feb 2023 14:39:47 GMT (envelope-from jamie) From: Jamie Landeg-Jones Message-Id: <202302151439.31FEdlI5025598@donotpassgo.dyslexicfish.net> Date: Wed, 15 Feb 2023 14:39:47 +0000 Organization: Dyslexic Fish To: jhs@berklix.com, jamie@catflap.org Cc: freebsd-current@freebsd.org Subject: Re: 1 year src-patch anniversary! References: <202301300254.30U2sm0k061914@dell.no.berklix.net> In-Reply-To: <202301300254.30U2sm0k061914@dell.no.berklix.net> User-Agent: Heirloom mailx 12.4 7/29/08 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (donotpassgo.dyslexicfish.net [104.207.135.49]); Wed, 15 Feb 2023 14:39:48 +0000 (GMT) X-Spamd-Result: default: False [-2.64 / 15.00]; URI_HIDDEN_PATH(1.00)[http://www.berklix.com/~jhs/bin/.csh/customise]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.94)[-0.940]; DMARC_POLICY_ALLOW(-0.50)[catflap.org,none]; R_SPF_ALLOW(-0.20)[+mx:dyslexicfish.net:c]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; SUBJECT_ENDS_EXCLAIM(0.00)[]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[jamie]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; ASN(0.00)[asn:20473, ipnet:2001:19f0::/38, country:US] X-Rspamd-Queue-Id: 4PH11x5D6gz3H7S X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N "Julian H. Stacey" wrote: Firstly, apolgies for the delay in replying. > I wrote a tool in 1993 I still use > http://www.berklix.com/~jhs/bin/.csh/customise > to apply trees of generic & personal diffs to src & ports, for multi releases > http://www.berklix.com/~jhs/src/ > to apply diffs, where some are submitted, some committed > for some versions, some diffs still needed for older versions, & > some not submitted or committed. Thanks, I'll look at that. > I guess many, especially non-commiters, maintain trees of uncommited > diffs & there's probably other applicator scripts, numerous > re-inventing of wheels for decades, 'cos send-pr / > https://bugs.freebsd.org/bugzilla/enter_bug.cgi & volunteer unpaid > commiters can't keep up with submissions. Yep :-( And to the committers: I'm not meaning to complain - I know it's a volunteer effort, but sometimes it can be frustrating. This particular bug I've highlighted is laughably trivial and inconsequential, but as Julian says, there must be many people who end up doing the same thing, and that all adds up to lots of wasted work that could be better channeled. What can we do to help? > FreeBSD hackers(especially non commiters who must wait for commits > to reduce their heap of candidate diffs) would benefit from a unified > set of tools & directory formats to allow individuals to maintain > & export trees of candidate diffs etc to some common standards. > > It wouldnt obviate / replace send-pr & > https://bugs.freebsd.org/bugzilla/enter_bug.cgi & git etc, but would > be an optional normalied convenience, especially beneficial to those > who are Not commiters but who have growing heaps of uncommited patches. > > Maybe a summer of code or other person might look at Jamie's & my > applicator scripts, & diff tree shapes, not for our actual current diffs, > but to design common unified standards to export trees of candidate diffs > that can be applied by one common applicator tool ? > > Hacker who are not committers presumably accumulate an an ever > growing heap of diffs, a burden best normalised & automated. That's a good idea. I'm happy to describe/publish my mechanisms - I've been meaning to publish all my tools in case they help anyone, but time keeps getting in the way! As for the patches, it's quite basic: for src, all patch-files in a common directory-tree (synced to my machines along with other common directories/tools) are applied after each git sync. The tree contains directories for "all versions" patches, and then directories for differing FreeBSD versions. For ports, I have 3 sets of common patch directories: 1) Patches to the port-templates (i.e. the build files under /usr/ports) 2) Patches to the ports source itself. 3) "Overrides" - directories containing the port-templates for a port that are installed after a port-sync. These are usually "deleted" ports that I actually still use, local-port hacks that no-one else would care about, and less-often complete overrides of ports for various reasons. There is glue code to ensure these are all automatically actioned. I'd love to get involved with anything that can help streamline this, whether src or ports. Cheers, Jamie From nobody Wed Feb 15 14:48:29 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH1D02p5Gz3qQ8N for ; Wed, 15 Feb 2023 14:48:32 +0000 (UTC) (envelope-from jamie@catflap.org) Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [IPv6:2001:19f0:300:2185:123::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4PH1D00XHDz3JrR for ; Wed, 15 Feb 2023 14:48:32 +0000 (UTC) (envelope-from jamie@catflap.org) Authentication-Results: mx1.freebsd.org; none X-Catflap-Envelope-From: Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [104.207.135.49]) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5) with ESMTP id 31FEmT4Y025970; Wed, 15 Feb 2023 14:48:29 GMT (envelope-from jamie@donotpassgo.dyslexicfish.net) Received: (from jamie@localhost) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5/Submit) id 31FEmT6s025969; Wed, 15 Feb 2023 14:48:29 GMT (envelope-from jamie) From: Jamie Landeg-Jones Message-Id: <202302151448.31FEmT6s025969@donotpassgo.dyslexicfish.net> Date: Wed, 15 Feb 2023 14:48:29 +0000 Organization: Dyslexic Fish To: jamie@catflap.org, imp@bsdimp.com Cc: mjguzik@gmail.com, freebsd-current@FreeBSD.org Subject: Re: 1 year src-patch anniversary! References: <202301292218.30TMIQmM020883@donotpassgo.dyslexicfish.net> <202302151411.31FEBJhh024307@donotpassgo.dyslexicfish.net> In-Reply-To: User-Agent: Heirloom mailx 12.4 7/29/08 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (donotpassgo.dyslexicfish.net [104.207.135.49]); Wed, 15 Feb 2023 14:48:29 +0000 (GMT) X-Rspamd-Queue-Id: 4PH1D00XHDz3JrR X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:2001:19f0::/38, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Warner Losh wrote: > Bugzilla is inefficient for small patches. Yes, I can see that bugzilla is unsuitable for things like that. > I'm trying an experiment on github: any smallish, almost ready patches will > be landed, redirected or rejected quickly Thanks Warner! That sounds great! - I'll be taking you up on that! Another thing - my last port maintainer update was converted to a phabricator post, as was the recent patch that delphij committed. Should I have posted them there instead to save the committers time? I always thought new phabricator posts were for committers only, as it seems to me to be a way for committers to get their code reviewed and passed prior to committing. Cheers, Jamie From nobody Wed Feb 15 17:07:08 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH4JB4MXRz3qZKV for ; Wed, 15 Feb 2023 17:07:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH4J94Z4Qz3v9L for ; Wed, 15 Feb 2023 17:07:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=hu8YVmDN; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::532) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ed1-x532.google.com with SMTP id n20so8427863edy.0 for ; Wed, 15 Feb 2023 09:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YQX8sml47RFjV0+UFD1g3dvbgVChVLgA+ZXVuKnEBDA=; b=hu8YVmDNq30Zab3c9XyXpOC5/4cfhG/+sBCvhLnbUnKt3tMua+NuAAqi/rAtvWJ9c9 eXuOHrpVBj/PjeQQJrLCfwP8UeNVoBOp/PEmKVdLeuHafmWA8PPcVlDbWXaupKntD4Gx flzKtXSiPso6IUtwxDu5tRIeGd6R6pubFFopS7QuvcCxgeSV8gvxhli534887FmeSEqG BAhqseQCeyzsP47n284OD64rvqaoditnHqRB3eoE3Ra85G8OItAbs5D37bnkZSRvxgTl InBgEUNwMUCVaqDU/G6v/mKhHw47fJji/Scu9ssHi31NTHxuFzE4BgG/xctTIzFAiOKj AgmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YQX8sml47RFjV0+UFD1g3dvbgVChVLgA+ZXVuKnEBDA=; b=WhECa0ZPcSWLFdy+bkr0ybdyZ8A0v95JymkGIdi6IebBUkEmm9ouX1qRu3evxqy2Or DdqUoSENhWDv8wifGSUG5nI2qBPcYEWRbEsgp1QJgVBjWDfhkEOjanpxvXBmYEHbbjJa P8jFUhj3fliJ+EbJbTrNY9UUhu38eiCnh3mTuhaqv3V5YWfCaXa5PuepD9DCONHz7VrW ByuMmG5ds6wSuO0DkCBFn448e/ORhlvgzPzHT+sEbkN/0GaSrsi2ELQdpiGhkVA4xa5k n/cJ8PQ/v0H53OSjcVYA6nU+y9pxbefhfxCWQP8Vuna38OKxPye61eMhDpJfcfull31Z 0r7A== X-Gm-Message-State: AO0yUKXQ7JFz4fva6YDGrjIjvKAJL2M9mNMA6LarWBZDRXJkVWWfbKPx TYEKdsEY7h/NhlgE8DpiS9PxNEbnxFZjzXm1LpPjDg== X-Google-Smtp-Source: AK7set+Azj58hJKWK/Ya8AP1bUvn+B4Q/Muje1+HBmI5yQDEOukhj6Yd4g0+wBXyrBrqOrmXwnU9FZ5aZyt49fskKpg= X-Received: by 2002:a17:906:a409:b0:8b1:2d36:a58e with SMTP id l9-20020a170906a40900b008b12d36a58emr1465222ejz.2.1676480839308; Wed, 15 Feb 2023 09:07:19 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Wed, 15 Feb 2023 10:07:08 -0700 Message-ID: Subject: Re: Build breakage with WITH_BEARSSL=1 To: Gordon Bergling Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000e66f1a05f4c01c6a" X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::532:from]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[bsdimp.com]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PH4J94Z4Qz3v9L X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000e66f1a05f4c01c6a Content-Type: text/plain; charset="UTF-8" On Sun, Feb 12, 2023, 3:18 PM Warner Losh wrote: > > > On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: > >> Hi, >> >> I am currently seeing a build breakage when building -CURRENT with >> WITH_BEARSSL=1. >> >> The error is the following >> >> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: >> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.asc 2> >> /dev/null" returned non-zero status >> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: >> a function declaration without a prototype is deprecat ed in all versions >> of C [-Werror,-Wstrict-prototypes] >> br_rsa_i62_keygen_get() >> ^ >> void >> 1 error generated. >> --- rsa_i62_keygen.pico --- >> >> >> When disabling BEARSSL in the src.conf the build succeeds as usual. >> >> Has anyone also seen this build error. Sources are very recent and the >> src.conf is the following: >> >> WITH_EXTRA_TCP_STACKS=1 >> #WITH_BEARSSL=1 >> WITH_PIE=1 >> WITH_RETPOLINE=1 >> WITH_INIT_ALL_ZERO=1 >> WITH_OPENSSL_KTLS=1 >> WITHOUT_CLEAN=1 >> >> Any help is very appreciated. >> >> > What does the following do for you? It's a cut and pasted patch, but it > should be clear enough what to do if the mailer mangles it. > > diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc > index dd0e242c8ef0..2af4864d8441 100644 > --- a/lib/libbearssl/Makefile.inc > +++ b/lib/libbearssl/Makefile.inc > @@ -4,4 +4,4 @@ BEARSSL?= ${SRCTOP}/contrib/bearssl > BEARSSL_SRC= ${BEARSSL}/src > > CFLAGS+= -I${BEARSSL}/inc > - > +CFLAGS+= ${NO_WDEPRECATED_NON_PROTOTYPE} > I went ahead and committed this. Please let me know if the problem persists. Warner > --000000000000e66f1a05f4c01c6a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Feb 12, 2023, 3:18 PM Warner Losh <= ;imp@bsdimp.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">

<= br>
On Sun,= Feb 12, 2023 at 3:54 AM Gordon Bergling <gbe@freebsd.org> wrote:
Hi,

I am currently seeing a build breakage when building -CURRENT with WITH_BEA= RSSL=3D1.

The error is the following

=C2=A0 make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.= mk" line 109: warning: "cd /boiler/nfs/src/lib/libsecureboot = && 'ls'=C2=A0 =C2=A0-1 *.pem t*.asc 2> /dev/null" r= eturned non-zero status
=C2=A0 /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: a function declaration without a prototype is deprecat=C2=A0 ed in all v= ersions of C [-Werror,-Wstrict-prototypes]
=C2=A0 br_rsa_i62_keygen_get()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 void
=C2=A0 1 error generated.
=C2=A0 --- rsa_i62_keygen.pico ---


When disabling BEARSSL in the src.conf the build succeeds as usual.

Has anyone also seen this build error. Sources are very recent and the
src.conf is the following:

WITH_EXTRA_TCP_STACKS=3D1
#WITH_BEARSSL=3D1
WITH_PIE=3D1
WITH_RETPOLINE=3D1
WITH_INIT_ALL_ZERO=3D1
WITH_OPENSSL_KTLS=3D1
WITHOUT_CLEAN=3D1

Any help is very appreciated.


What does the following do for you? It= 's a cut and pasted patch, but it should be clear enough what to do if = the mailer mangles it.

diff --git a/lib/libbearssl= /Makefile.inc b/lib/libbearssl/Makefile.inc
index dd0e242c8ef0..2af4864d= 8441 100644
--- a/lib/libbearssl/Makefile.inc
+++ b/lib/libbearssl/Ma= kefile.inc
@@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
=C2= =A0BEARSSL_SRC=3D ${BEARSSL}/src

=C2=A0CFLAGS+=3D -I${BEARSSL}/inc-
+CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}

I went ahead and = committed this. Please let me know if the problem persists.

Warner
--000000000000e66f1a05f4c01c6a-- From nobody Wed Feb 15 20:08:58 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH8Kz2Bq3z3rH7F for ; Wed, 15 Feb 2023 20:09:11 +0000 (UTC) (envelope-from freebsd@igalic.co) Received: from mail-4022.proton.ch (mail-4022.proton.ch [185.70.40.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH8Ky4xy5z4Q26; Wed, 15 Feb 2023 20:09:10 +0000 (UTC) (envelope-from freebsd@igalic.co) Authentication-Results: mx1.freebsd.org; none Date: Wed, 15 Feb 2023 20:08:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igalic.co; s=protonmail; t=1676491747; x=1676750947; bh=uZ2aTMYz3tnjpY5xOiyzshfPAtUvSrPztOcGvSvQHkM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ia33jbJV6ffyTA6ZM6oURv3tXNUlAnwELpFp9dw8YRfIc52dYnTSiIz6jI+58VfYA O1tgcego00ROoJADVb/kSHpdcP665CSpoFe6+VicsRgWX77YRdFkk1DtyYr/cHsgSb IGInl/AFdohuj/Wdk4PGyBz25c0CJoPjQa892vmlGhzhYvLja11IEIRpmUJ4GO0tss atN1f6DXtXjycws91eXk2ls8br1i4O2LipuIy1N15jIQCI9CQ2/wbFfyBGqhOeaymQ iPCq2bLDgv8YD9HdyzHACJBAaOESgi9ppqdfAFWVSOyJasFhfwM6sVqyM/XkrmnA7N 5Jx67r7E7CJmA== To: imp@bsdimp.com, gbe@freebsd.org From: =?utf-8?Q?Mina_Gali=C4=87?= Cc: freebsd-current@freebsd.org Subject: Re: Build breakage with WITH_BEARSSL=1 Message-ID: In-Reply-To: References: Feedback-ID: 66573723:user:proton List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_OULomWYKTl2A7iy2BZvtT8A9WCRoS6N8Gk6uABKAic" X-Rspamd-Queue-Id: 4PH8Ky4xy5z4Q26 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:62371, ipnet:185.70.40.0/24, country:CH] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --b1_OULomWYKTl2A7iy2BZvtT8A9WCRoS6N8Gk6uABKAic Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 V291bGQgYmUgbmljZSBpZiB3ZSBjb3VsZCBnZXQgdXBzdHJlYW0gdG8gYWN0dWFsbHkgZml4IHRo aXMsIGJ1dCBpIGRvbid0IGV2ZW4ga25vdyBob3cgdG8gc3VibWl0IGJ1Z3MgdGhlcmXigKYKCk1p bmEgR2FsacSHCgpUcnkgUGtnQmFzZTogaHR0cHM6Ly9hbHBoYS5wa2diYXNlLmxpdmUvCgotLS0t LS0tLSBPcmlnaW5hbCBNZXNzYWdlIC0tLS0tLS0tCk9uIDE1IEZlYiAyMDIzLCAxNzowNywgV2Fy bmVyIExvc2ggd3JvdGU6Cgo+IE9uIFN1biwgRmViIDEyLCAyMDIzLCAzOjE4IFBNIFdhcm5lciBM b3NoIDxpbXBAYnNkaW1wLmNvbT4gd3JvdGU6Cj4KPj4gT24gU3VuLCBGZWIgMTIsIDIwMjMgYXQg Mzo1NCBBTSBHb3Jkb24gQmVyZ2xpbmcgPGdiZUBmcmVlYnNkLm9yZz4gd3JvdGU6Cj4+Cj4+PiBI aSwKPj4+Cj4+PiBJIGFtIGN1cnJlbnRseSBzZWVpbmcgYSBidWlsZCBicmVha2FnZSB3aGVuIGJ1 aWxkaW5nIC1DVVJSRU5UIHdpdGggV0lUSF9CRUFSU1NMPTEuCj4+Pgo+Pj4gVGhlIGVycm9yIGlz IHRoZSBmb2xsb3dpbmcKPj4+Cj4+PiBtYWtlWzVdOiAiL2JvaWxlci9uZnMvc3JjL2xpYi9saWJz ZWN1cmVib290L2xvY2FsLnRydXN0Lm1rIiBsaW5lIDEwOTogd2FybmluZzogImNkIC9ib2lsZXIv bmZzL3NyYy9saWIvbGlic2VjdXJlYm9vdCAmJiAnbHMnIC0xICoucGVtIHQqLmFzYyAyPiAvZGV2 L251bGwiIHJldHVybmVkIG5vbi16ZXJvIHN0YXR1cwo+Pj4gL2JvaWxlci9uZnMvc3JjL2NvbnRy aWIvYmVhcnNzbC9zcmMvcnNhL3JzYV9pNjJfa2V5Z2VuLmM6NDM6MjI6IGVycm9yOiBhIGZ1bmN0 aW9uIGRlY2xhcmF0aW9uIHdpdGhvdXQgYSBwcm90b3R5cGUgaXMgZGVwcmVjYXQgZWQgaW4gYWxs IHZlcnNpb25zIG9mIEMgWy1XZXJyb3IsLVdzdHJpY3QtcHJvdG90eXBlc10KPj4+IGJyX3JzYV9p NjJfa2V5Z2VuX2dldCgpCj4+PiBeCj4+PiB2b2lkCj4+PiAxIGVycm9yIGdlbmVyYXRlZC4KPj4+ IC0tLSByc2FfaTYyX2tleWdlbi5waWNvIC0tLQo+Pj4KPj4+IFdoZW4gZGlzYWJsaW5nIEJFQVJT U0wgaW4gdGhlIHNyYy5jb25mIHRoZSBidWlsZCBzdWNjZWVkcyBhcyB1c3VhbC4KPj4+Cj4+PiBI YXMgYW55b25lIGFsc28gc2VlbiB0aGlzIGJ1aWxkIGVycm9yLiBTb3VyY2VzIGFyZSB2ZXJ5IHJl Y2VudCBhbmQgdGhlCj4+PiBzcmMuY29uZiBpcyB0aGUgZm9sbG93aW5nOgo+Pj4KPj4+IFdJVEhf RVhUUkFfVENQX1NUQUNLUz0xCj4+PiAjV0lUSF9CRUFSU1NMPTEKPj4+IFdJVEhfUElFPTEKPj4+ IFdJVEhfUkVUUE9MSU5FPTEKPj4+IFdJVEhfSU5JVF9BTExfWkVSTz0xCj4+PiBXSVRIX09QRU5T U0xfS1RMUz0xCj4+PiBXSVRIT1VUX0NMRUFOPTEKPj4+Cj4+PiBBbnkgaGVscCBpcyB2ZXJ5IGFw cHJlY2lhdGVkLgo+Pgo+PiBXaGF0IGRvZXMgdGhlIGZvbGxvd2luZyBkbyBmb3IgeW91PyBJdCdz IGEgY3V0IGFuZCBwYXN0ZWQgcGF0Y2gsIGJ1dCBpdCBzaG91bGQgYmUgY2xlYXIgZW5vdWdoIHdo YXQgdG8gZG8gaWYgdGhlIG1haWxlciBtYW5nbGVzIGl0Lgo+Pgo+PiBkaWZmIC0tZ2l0IGEvbGli L2xpYmJlYXJzc2wvTWFrZWZpbGUuaW5jIGIvbGliL2xpYmJlYXJzc2wvTWFrZWZpbGUuaW5jCj4+ IGluZGV4IGRkMGUyNDJjOGVmMC4uMmFmNDg2NGQ4NDQxIDEwMDY0NAo+PiAtLS0gYS9saWIvbGli YmVhcnNzbC9NYWtlZmlsZS5pbmMKPj4gKysrIGIvbGliL2xpYmJlYXJzc2wvTWFrZWZpbGUuaW5j Cj4+IEBAIC00LDQgKzQsNCBAQCBCRUFSU1NMPz0gJHtTUkNUT1B9L2NvbnRyaWIvYmVhcnNzbAo+ PiBCRUFSU1NMX1NSQz0gJHtCRUFSU1NMfS9zcmMKPj4KPj4gQ0ZMQUdTKz0gLUkke0JFQVJTU0x9 L2luYwo+PiAtCj4+ICtDRkxBR1MrPSAke05PX1dERVBSRUNBVEVEX05PTl9QUk9UT1RZUEV9Cj4K PiBJIHdlbnQgYWhlYWQgYW5kIGNvbW1pdHRlZCB0aGlzLiBQbGVhc2UgbGV0IG1lIGtub3cgaWYg dGhlIHByb2JsZW0gcGVyc2lzdHMuCj4KPiBXYXJuZXIKPgo+Pg== --b1_OULomWYKTl2A7iy2BZvtT8A9WCRoS6N8Gk6uABKAic Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 V291bGQgYmUgbmljZSBpZiB3ZSBjb3VsZCBnZXQgdXBzdHJlYW0gdG8gYWN0dWFsbHkgZml4IHRo aXMsIGJ1dCBpIGRvbid0IGV2ZW4ga25vdyBob3cgdG8gc3VibWl0IGJ1Z3MgdGhlcmXigKYgPGJy Pjxicj48YnI+PHNwYW4+TWluYSBHYWxpxIc8L3NwYW4+PGRpdj48YnIgLz48L2Rpdj48ZGl2PlRy eSBQa2dCYXNlOiA8YSBocmVmPSJodHRwczovL2FscGhhLnBrZ2Jhc2UubGl2ZS8iIHRpdGxlPSJo dHRwczovL2FscGhhLnBrZ2Jhc2UubGl2ZS8iPmh0dHBzOi8vYWxwaGEucGtnYmFzZS5saXZlLzwv YT48L2Rpdj48c3Bhbj48L3NwYW4+PGJyPjxicj48YnI+PGJyPjxicj48YnI+LS0tLS0tLS0gT3Jp Z2luYWwgTWVzc2FnZSAtLS0tLS0tLTxicj5PbiAxNSBGZWIgMjAyMywgMTc6MDcsIFdhcm5lciBM b3NoIDwgaW1wQGJzZGltcC5jb20+IHdyb3RlOjxibG9ja3F1b3RlIGNsYXNzPSJwcm90b25tYWls X3F1b3RlIj48YnI+PGRpdiBkaXI9ImF1dG8iPjxicj48YnI+PGRpdiBjbGFzcz0iZ21haWxfcXVv dGUiIGRpcj0iYXV0byI+PGRpdiBkaXI9Imx0ciIgY2xhc3M9ImdtYWlsX2F0dHIiPk9uIFN1biwg RmViIDEyLCAyMDIzLCAzOjE4IFBNIFdhcm5lciBMb3NoICZsdDs8YSBocmVmPSJtYWlsdG86aW1w QGJzZGltcC5jb20iPmltcEBic2RpbXAuY29tPC9hPiZndDsgd3JvdGU6PGJyPjwvZGl2PjxibG9j a3F1b3RlIGNsYXNzPSJnbWFpbF9xdW90ZSIgc3R5bGU9Im1hcmdpbjowIDAgMCAuOGV4O2JvcmRl ci1sZWZ0OjFweCAjY2NjIHNvbGlkO3BhZGRpbmctbGVmdDoxZXgiPjxkaXYgZGlyPSJsdHIiPjxk aXYgZGlyPSJsdHIiPjxicj48L2Rpdj48YnI+PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUiPjxkaXYg ZGlyPSJsdHIiIGNsYXNzPSJnbWFpbF9hdHRyIj5PbiBTdW4sIEZlYiAxMiwgMjAyMyBhdCAzOjU0 IEFNIEdvcmRvbiBCZXJnbGluZyAmbHQ7PGEgaHJlZj0ibWFpbHRvOmdiZUBmcmVlYnNkLm9yZyIg dGFyZ2V0PSJfYmxhbmsiIHJlbD0ibm9yZWZlcnJlciI+Z2JlQGZyZWVic2Qub3JnPC9hPiZndDsg d3JvdGU6PGJyPjwvZGl2PjxibG9ja3F1b3RlIGNsYXNzPSJnbWFpbF9xdW90ZSIgc3R5bGU9Im1h cmdpbjowcHggMHB4IDBweCAwLjhleDtib3JkZXItbGVmdDoxcHggc29saWQgcmdiKDIwNCwyMDQs MjA0KTtwYWRkaW5nLWxlZnQ6MWV4Ij5IaSw8YnI+DQo8YnI+DQpJIGFtIGN1cnJlbnRseSBzZWVp bmcgYSBidWlsZCBicmVha2FnZSB3aGVuIGJ1aWxkaW5nIC1DVVJSRU5UIHdpdGggV0lUSF9CRUFS U1NMPTEuPGJyPg0KPGJyPg0KVGhlIGVycm9yIGlzIHRoZSBmb2xsb3dpbmc8YnI+DQo8YnI+DQrC oCBtYWtlWzVdOiAmcXVvdDsvYm9pbGVyL25mcy9zcmMvbGliL2xpYnNlY3VyZWJvb3QvPGEgaHJl Zj0iaHR0cDovL2xvY2FsLnRydXN0Lm1rIiByZWw9Im5vcmVmZXJyZXIgbm9yZWZlcnJlciIgdGFy Z2V0PSJfYmxhbmsiPmxvY2FsLnRydXN0Lm1rPC9hPiZxdW90OyBsaW5lIDEwOTogd2FybmluZzog JnF1b3Q7Y2QgL2JvaWxlci9uZnMvc3JjL2xpYi9saWJzZWN1cmVib290ICZhbXA7JmFtcDsgJiMz OTtscyYjMzk7wqAgwqAtMSAqLnBlbSB0Ki5hc2MgMiZndDsgL2Rldi9udWxsJnF1b3Q7IHJldHVy bmVkIG5vbi16ZXJvIHN0YXR1czxicj4NCsKgIC9ib2lsZXIvbmZzL3NyYy9jb250cmliL2JlYXJz c2wvc3JjL3JzYS9yc2FfaTYyX2tleWdlbi5jOjQzOjIyOiBlcnJvcjogYSBmdW5jdGlvbiBkZWNs YXJhdGlvbiB3aXRob3V0IGEgcHJvdG90eXBlIGlzIGRlcHJlY2F0wqAgZWQgaW4gYWxsIHZlcnNp b25zIG9mIEMgWy1XZXJyb3IsLVdzdHJpY3QtcHJvdG90eXBlc108YnI+DQrCoCBicl9yc2FfaTYy X2tleWdlbl9nZXQoKTxicj4NCsKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgXjxi cj4NCsKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHZvaWQ8YnI+DQrCoCAxIGVy cm9yIGdlbmVyYXRlZC48YnI+DQrCoCAtLS0gcnNhX2k2Ml9rZXlnZW4ucGljbyAtLS08YnI+DQo8 YnI+DQo8YnI+DQpXaGVuIGRpc2FibGluZyBCRUFSU1NMIGluIHRoZSBzcmMuY29uZiB0aGUgYnVp bGQgc3VjY2VlZHMgYXMgdXN1YWwuPGJyPg0KPGJyPg0KSGFzIGFueW9uZSBhbHNvIHNlZW4gdGhp cyBidWlsZCBlcnJvci4gU291cmNlcyBhcmUgdmVyeSByZWNlbnQgYW5kIHRoZTxicj4NCnNyYy5j b25mIGlzIHRoZSBmb2xsb3dpbmc6PGJyPg0KPGJyPg0KV0lUSF9FWFRSQV9UQ1BfU1RBQ0tTPTE8 YnI+DQojV0lUSF9CRUFSU1NMPTE8YnI+DQpXSVRIX1BJRT0xPGJyPg0KV0lUSF9SRVRQT0xJTkU9 MTxicj4NCldJVEhfSU5JVF9BTExfWkVSTz0xPGJyPg0KV0lUSF9PUEVOU1NMX0tUTFM9MTxicj4N CldJVEhPVVRfQ0xFQU49MTxicj4NCjxicj4NCkFueSBoZWxwIGlzIHZlcnkgYXBwcmVjaWF0ZWQu PGJyPg0KPGJyPjwvYmxvY2txdW90ZT48ZGl2Pjxicj48L2Rpdj48ZGl2PldoYXQgZG9lcyB0aGUg Zm9sbG93aW5nIGRvIGZvciB5b3U/IEl0JiMzOTtzIGEgY3V0IGFuZCBwYXN0ZWQgcGF0Y2gsIGJ1 dCBpdCBzaG91bGQgYmUgY2xlYXIgZW5vdWdoIHdoYXQgdG8gZG8gaWYgdGhlIG1haWxlciBtYW5n bGVzIGl0LjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+ZGlmZiAtLWdpdCBhL2xpYi9saWJiZWFy c3NsL01ha2VmaWxlLmluYyBiL2xpYi9saWJiZWFyc3NsL01ha2VmaWxlLmluYzxicj5pbmRleCBk ZDBlMjQyYzhlZjAuLjJhZjQ4NjRkODQ0MSAxMDA2NDQ8YnI+LS0tIGEvbGliL2xpYmJlYXJzc2wv TWFrZWZpbGUuaW5jPGJyPisrKyBiL2xpYi9saWJiZWFyc3NsL01ha2VmaWxlLmluYzxicj5AQCAt NCw0ICs0LDQgQEAgQkVBUlNTTD89ICR7U1JDVE9QfS9jb250cmliL2JlYXJzc2w8YnI+wqBCRUFS U1NMX1NSQz0gJHtCRUFSU1NMfS9zcmM8YnI+PGJyPsKgQ0ZMQUdTKz0gLUkke0JFQVJTU0x9L2lu Yzxicj4tPGJyPitDRkxBR1MrPSAke05PX1dERVBSRUNBVEVEX05PTl9QUk9UT1RZUEV9PC9kaXY+ PC9kaXY+PC9kaXY+PC9ibG9ja3F1b3RlPjwvZGl2PjxkaXYgZGlyPSJhdXRvIj48YnI+PC9kaXY+ PGRpdiBkaXI9ImF1dG8iPkkgd2VudCBhaGVhZCBhbmQgY29tbWl0dGVkIHRoaXMuIFBsZWFzZSBs ZXQgbWUga25vdyBpZiB0aGUgcHJvYmxlbSBwZXJzaXN0cy48L2Rpdj48ZGl2IGRpcj0iYXV0byI+ PGJyPjwvZGl2PjxkaXYgZGlyPSJhdXRvIj5XYXJuZXI8L2Rpdj48ZGl2IGNsYXNzPSJnbWFpbF9x dW90ZSIgZGlyPSJhdXRvIj48YmxvY2txdW90ZSBjbGFzcz0iZ21haWxfcXVvdGUiIHN0eWxlPSJt YXJnaW46MCAwIDAgLjhleDtib3JkZXItbGVmdDoxcHggI2NjYyBzb2xpZDtwYWRkaW5nLWxlZnQ6 MWV4Ij4NCjwvYmxvY2txdW90ZT48L2Rpdj48L2Rpdj4NCjwvZGl2Pg== --b1_OULomWYKTl2A7iy2BZvtT8A9WCRoS6N8Gk6uABKAic-- From nobody Wed Feb 15 20:28:12 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH8mB3fbQz3rJKV for ; Wed, 15 Feb 2023 20:28:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH8mB1b3nz3Cmp for ; Wed, 15 Feb 2023 20:28:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52f.google.com with SMTP id w3so18643350edc.2 for ; Wed, 15 Feb 2023 12:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hlqB0K2mj5kyuu4r+ulE+FQEW18qMlLkI+r+KS+ULhs=; b=pJ6NRB4T/jvV/hLUB9GU66QkAK8VQhsxz2Y8X2dmm1jF4dM69ATt3UnjSVi0UFtf4I pKVjY0nZXT+YeUt9orZzFbWBs63z1OXBDqs13lEf/e8A4JFsuN2gvn4ULh6o6xvvvG4w 4xIxeAX17At6vY80CGNQ8IhsQwTAEtRQ+B0SV5YLOuXGs47xXuJF+L+JWUfpojHxajkQ yLYZkIZqXzZCnF8McsRgp0Jguxoxfq/tKAe5njSeyEmXj3g0DiTbpAJoM++XCaj/hW6p 9sRRaeEXpmEje5YgGa8Ii+wCTEke8w+NkoFb8TQgZ2vS44KE8Xew1feyoq613QzKNCc6 UISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hlqB0K2mj5kyuu4r+ulE+FQEW18qMlLkI+r+KS+ULhs=; b=7jMWKdzEJX3t7oLMLACMXM09oCfdtSdiSk+38Sjd/Y90q+FpmfR1R51CCLsX3X8ocG 320m0SIJwvz/Mho+4ctVvQbVS4JdaOp+qrpEOPYF6nBXDSorVPcryvcAJWFGPIpxtAwI aPOGzCqMNpXv+bqIiyrcBzbNGUYBB9cNh/Ut5IgOK+J5bRMTWaZmPqz3GMWCBQUNzVpI 4HDmeE5QDor4h7/qPpvjWD8IL0f66dOM32nhQBeNJ5LLqtNa2JQO7EyQovQI8+akgpRq /R4upqtXcK3WEJ99yNQuZbzAw1sdggEdPc1YImY0GZZGIJ3vF/NXKzZsmVnxr+MRL1eY fi7Q== X-Gm-Message-State: AO0yUKVtlk3hW0fe6HE2pfuQ004uCTeQbgPa9z4F4jz8d+AQtwXzXPjq tROhfiCOY79du2GpjpGOctHyxlJr0Tua+RHLPoyjUw== X-Google-Smtp-Source: AK7set+SefyyOoG+mCmdNftTVOIgTJESaOdmem9x4boXTsaIVjRaF7m5vaWSfAT/sKHp/kzIEbsUVgb0f1ErrlA8SOs= X-Received: by 2002:a17:906:94d8:b0:895:58be:964 with SMTP id d24-20020a17090694d800b0089558be0964mr1718755ejy.2.1676492903554; Wed, 15 Feb 2023 12:28:23 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Wed, 15 Feb 2023 13:28:12 -0700 Message-ID: Subject: Re: Build breakage with WITH_BEARSSL=1 To: =?UTF-8?Q?Mina_Gali=C4=87?= Cc: Gordon Bergling , FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000fc378b05f4c2eb78" X-Rspamd-Queue-Id: 4PH8mB1b3nz3Cmp X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000fc378b05f4c2eb78 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2023, 1:09 PM Mina Gali=C4=87 wrote: > Would be nice if we could get upstream to actually fix this, but i don't > even know how to submit bugs there=E2=80=A6 > Agreed. I didn't recall off of the top of my head, so I did the quick bandaid. Warner Mina Gali=C4=87 > > Try PkgBase: https://alpha.pkgbase.live/ > > > > > > > -------- Original Message -------- > On 15 Feb 2023, 17:07, Warner Losh < imp@bsdimp.com> wrote: > > > > > On Sun, Feb 12, 2023, 3:18 PM Warner Losh wrote: > >> >> >> On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: >> >>> Hi, >>> >>> I am currently seeing a build breakage when building -CURRENT with >>> WITH_BEARSSL=3D1. >>> >>> The error is the following >>> >>> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: >>> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.as= c 2> >>> /dev/null" returned non-zero status >>> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error= : >>> a function declaration without a prototype is deprecat ed in all versi= ons >>> of C [-Werror,-Wstrict-prototypes] >>> br_rsa_i62_keygen_get() >>> ^ >>> void >>> 1 error generated. >>> --- rsa_i62_keygen.pico --- >>> >>> >>> When disabling BEARSSL in the src.conf the build succeeds as usual. >>> >>> Has anyone also seen this build error. Sources are very recent and the >>> src.conf is the following: >>> >>> WITH_EXTRA_TCP_STACKS=3D1 >>> #WITH_BEARSSL=3D1 >>> WITH_PIE=3D1 >>> WITH_RETPOLINE=3D1 >>> WITH_INIT_ALL_ZERO=3D1 >>> WITH_OPENSSL_KTLS=3D1 >>> WITHOUT_CLEAN=3D1 >>> >>> Any help is very appreciated. >>> >>> >> What does the following do for you? It's a cut and pasted patch, but it >> should be clear enough what to do if the mailer mangles it. >> >> diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc >> index dd0e242c8ef0..2af4864d8441 100644 >> --- a/lib/libbearssl/Makefile.inc >> +++ b/lib/libbearssl/Makefile.inc >> @@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl >> BEARSSL_SRC=3D ${BEARSSL}/src >> >> CFLAGS+=3D -I${BEARSSL}/inc >> - >> +CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE} >> > > I went ahead and committed this. Please let me know if the problem > persists. > > Warner > >> --000000000000fc378b05f4c2eb78 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Feb 15, 2023, 1:09 PM Mina Gali=C4=87 <freebsd@igalic.co> wrote:
=
Would be nice if we could get upstream to ac= tually fix this, but i don't even know how to submit bugs there=E2=80= =A6

Agreed. I didn't recall off of the top of my head, so I did the quic= k bandaid.=C2=A0

Warner= =C2=A0


= Mina Gali=C4=87


<= br>



-------- Original Message --------
On 15 Feb 2023, 17= :07, Warner Losh < imp@bsdimp.com> wrote:



On Sun, Feb 12, 2023, 3:18 PM Warner Losh <imp@bsdimp.com> wrote:


Hi,

I am currently seeing a build breakage when building -CURRENT with WITH_BEA= RSSL=3D1.

The error is the following

=C2=A0 make[5]: "/boiler/nfs/src/lib/libsecureboot/l= ocal.trust.mk" line 109: warning: "cd /boiler/nfs/src/lib/lib= secureboot && 'ls'=C2=A0 =C2=A0-1 *.pem t*.asc 2> /dev/n= ull" returned non-zero status
=C2=A0 /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: a function declaration without a prototype is deprecat=C2=A0 ed in all v= ersions of C [-Werror,-Wstrict-prototypes]
=C2=A0 br_rsa_i62_keygen_get()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 void
=C2=A0 1 error generated.
=C2=A0 --- rsa_i62_keygen.pico ---


When disabling BEARSSL in the src.conf the build succeeds as usual.

Has anyone also seen this build error. Sources are very recent and the
src.conf is the following:

WITH_EXTRA_TCP_STACKS=3D1
#WITH_BEARSSL=3D1
WITH_PIE=3D1
WITH_RETPOLINE=3D1
WITH_INIT_ALL_ZERO=3D1
WITH_OPENSSL_KTLS=3D1
WITHOUT_CLEAN=3D1

Any help is very appreciated.


What does the following do for you? It= 's a cut and pasted patch, but it should be clear enough what to do if = the mailer mangles it.

diff --git a/lib/libbearssl= /Makefile.inc b/lib/libbearssl/Makefile.inc
index dd0e242c8ef0..2af4864d= 8441 100644
--- a/lib/libbearssl/Makefile.inc
+++ b/lib/libbearssl/Ma= kefile.inc
@@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
=C2= =A0BEARSSL_SRC=3D ${BEARSSL}/src

=C2=A0CFLAGS+=3D -I${BEARSSL}/inc-
+CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}

I went ahead and = committed this. Please let me know if the problem persists.

Warner
--000000000000fc378b05f4c2eb78-- From nobody Wed Feb 15 21:55:08 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHCSQ3q3Nz3rQyX for ; Wed, 15 Feb 2023 22:29:58 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHCSN74m2z3lmm for ; Wed, 15 Feb 2023 22:29:56 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of junchoon@dec.sakura.ne.jp has no SPF policy when checking 153.125.133.21) smtp.mailfrom=junchoon@dec.sakura.ne.jp; dmarc=none Received: from kalamity.joker.local (123-1-88-210.area1b.commufa.jp [123.1.88.210]) (authenticated bits=0) by www121.sakura.ne.jp (8.16.1/8.16.1/[SAKURA-WEB]/20201212) with ESMTPA id 31FLt8mR022016 for ; Thu, 16 Feb 2023 06:55:09 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Thu, 16 Feb 2023 06:55:08 +0900 From: Tomoaki AOKI To: freebsd-current@freebsd.org Subject: Re: 1 year src-patch anniversary! Message-Id: <20230216065508.c980a2f3b70bfb5a58f49223@dec.sakura.ne.jp> In-Reply-To: <202301300254.30U2sm0k061914@dell.no.berklix.net> References: <202301292218.30TMIQmM020883@donotpassgo.dyslexicfish.net> <202301300254.30U2sm0k061914@dell.no.berklix.net> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Thu__16_Feb_2023_06_55_08_+0900_BlD9jztAT0DirxZp" X-Spamd-Result: default: False [2.96 / 15.00]; MIME_BAD_ATTACHMENT(1.60)[sh:text/x-sh]; URI_HIDDEN_PATH(1.00)[http://www.berklix.com/~jhs/bin/.csh/customise]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; NEURAL_SPAM_SHORT(0.96)[0.959]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-sh]; RCVD_VIA_SMTP_AUTH(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[sakura.ne.jp]; R_SPF_NA(0.00)[no SPF record]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; HAS_ORG_HEADER(0.00)[]; SUBJECT_ENDS_EXCLAIM(0.00)[]; TO_DN_NONE(0.00)[]; HAS_ATTACHMENT(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP]; GREYLIST(0.00)[pass,body] X-Rspamd-Queue-Id: 4PHCSN74m2z3lmm X-Spamd-Bar: ++ X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --Multipart=_Thu__16_Feb_2023_06_55_08_+0900_BlD9jztAT0DirxZp Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 30 Jan 2023 03:54:48 +0100 "Julian H. Stacey" wrote: > Jamie Landeg-Jones wrote: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261657 is a trivial fix > > to an admittedly trivial issue, but it's soon going to hit one year old, > > and has not had any feedback. Not even "this is rubbish. close ticket" > > > > | jamie@catwalk:~ % stat 'so good they named it twice' > > | stat: so good they named it twice: stat: No such file or directory > > > > As such, it's the oldest of my patches to be completely ignored, but then, > > most of my fixes I haven't even submitted, because, what's the point? > > I've instead spent time writing something so the patches are automatically > > aplied to my src tree, and distributed to all my servers. > > I wrote a tool in 1993 I still use > http://www.berklix.com/~jhs/bin/.csh/customise > to apply trees of generic & personal diffs to src & ports, for multi releases > http://www.berklix.com/~jhs/src/ > to apply diffs, where some are submitted, some committed > for some versions, some diffs still needed for older versions, & > some not submitted or committed. > > I guess many, especially non-commiters, maintain trees of uncommited > diffs & there's probably other applicator scripts, numerous > re-inventing of wheels for decades, 'cos send-pr / > https://bugs.freebsd.org/bugzilla/enter_bug.cgi & volunteer unpaid > commiters can't keep up with submissions. > > & non committers can't afford to wait months or years, remembering > what's been seen commited to Release X.Y & what still needs to be > kept to apply to other inc. older releases. Probably lots of > re-invented wheels: trees of diffs & applicator scripts, but to > different standards, not uniformly exportable, not immediately > familiar to & usable by others. > > While retaining the model of "This generic src/ ports/ doc/ tree > has been built from patches blessed by commiters as fit for all" > > FreeBSD hackers(especially non commiters who must wait for commits > to reduce their heap of candidate diffs) would benefit from a unified > set of tools & directory formats to allow individuals to maintain > & export trees of candidate diffs etc to some common standards. > > It wouldnt obviate / replace send-pr & > https://bugs.freebsd.org/bugzilla/enter_bug.cgi & git etc, but would > be an optional normalied convenience, especially beneficial to those > who are Not commiters but who have growing heaps of uncommited patches. > > Maybe a summer of code or other person might look at Jamie's & my > applicator scripts, & diff tree shapes, not for our actual current diffs, > but to design common unified standards to export trees of candidate diffs > that can be applied by one common applicator tool ? > > Hacker who are not committers presumably accumulate an an ever > growing heap of diffs, a burden best normalised & automated. > > > I know it's a volunteer effort, but I've been here 25 years, and whilst > > I could (and should) take on more port-maintainership, any other offers > > of help have fallen on deaf ears. > > > > *shrug* I miss Mark Linimon. > > Cheers, > -- > Julian Stacey http://StolenVotes.UK/jhs/ Arm Ukraine, Zap Putin. Just FYI: Attached is the sh script I've been using for years to apply/revert multiple patches at once, basically for patches uploaded on bugzilla. I know it's far from perfect, but maybe handy for casual users who have any problem with genuine base or ports and needs multiple patches uploaded on bugzilla, phabricator or anywhere else. The attachement itself should have been stripped by the ML server, but maybe you can see it via "Original text of this message" link at the bottom of the mail archive of this message. -- Tomoaki AOKI --Multipart=_Thu__16_Feb_2023_06_55_08_+0900_BlD9jztAT0DirxZp Content-Type: text/x-sh; name="multipatch.sh" Content-Disposition: attachment; filename="multipatch.sh" Content-Transfer-Encoding: 7bit #!/bin/sh # multipatch: Apply / revert multiple patches at once. # Copyright (C) Mar. 16, 2017 by Tomoaki AOKI all rights reserved. IGNORE_OPT="-p" DRY_OPT="-C" REV_OPT="-R -E" DFL_OPT="-i" OPTION="" TMPFILE=/tmp/multipatch00 __usage() { cat << EOF Usage: multipatch (-fc | -f | -rc | -r | -h) filename multipatch: Apply / revert multiple patches listed in filename. The list file shall list one patchfile per line, lead by ignored depth. Parameters: -r : Revert listed patches. -rc: Revert listed patches (dry run). -f : Apply listed patches. -fc: Apply listed patches (dry run). -h: show this help File format example: 1 ~/LocalPatches/patch1.diff 0 ~/LocalPatches/patch2.patch where src filenames in patch1.diff is like a/sys/kernel/init_sysent.c and src filenames in patch2.patch is like sys/amd64/conf/GENERIC EOF exit 0 } if [ 0 -eq $# ] then __usage fi case "$1" in "-rc") MODE="REVDRY" OPTION="${REV_OPT} ${DRY_OPT}" ;; "-r") MODE="REV" OPTION="${REV_OPT}" ;; "-fc") MODE="FWDDRY" OPTION="${DRY_OPT}" ;; "-f") MODE="FWD" OPTION="" ;; "-c") MODE="DRY" OPTION="${DRY_OPT}" ;; "-h"|"--help") __usage ;; *) __usage ;; esac shift LSTFILE=$1 echo ${LSTFILE} if [ -e ${LSTFILE} ] then if [ "REV" = ${MODE} -o "REVDRY" = ${MODE} ] ; then tail -r ${LSTFILE} > ${TMPFILE} LSTFILE=${TMPFILE} fi cat ${LSTFILE} | while read PATCH do DEPTH=`echo ${PATCH} | cut -w -s -f 1` FILE=`echo ${PATCH} | cut -w -s -f 2` if [ "#" = ${DEPTH} ] ; then continue fi if [ 0 = $((DEPTH)) ] ; then echo patch ${OPTION} ${DFL_OPT} ${FILE} patch ${OPTION} ${DFL_OPT} ${FILE} RESULT=$? if [ 0 != ${RESULT} ] ; then echo ${FILE} doesn\'t apply! exit 1 fi else echo patch ${OPTION} ${IGNORE_OPT}${DEPTH} ${DFL_OPT} ${FILE} patch ${OPTION} ${IGNORE_OPT}${DEPTH} ${DFL_OPT} ${FILE} RESULT=$? if [ 0 != ${RESULT} ] ; then echo ${FILE} doesn\'t apply! exit 1 fi fi done if [ -e ${TMPFILE} ] ; then echo "Cleaning temporary file..." rm ${TMPFILE} fi else echo -n "List file " ; echo -n ${LSTFILE} ; echo "not found." fi --Multipart=_Thu__16_Feb_2023_06_55_08_+0900_BlD9jztAT0DirxZp-- From nobody Thu Feb 16 07:57:38 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHS3X4yZ6z3pKbK for ; Thu, 16 Feb 2023 07:57:44 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHS3X4R4xz3JD1; Thu, 16 Feb 2023 07:57:44 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676534264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wPAPOIjCJxq2PWcC5mDldM4w/mVi9DE4Np+psJ9QAJ8=; b=J+rvRgqGe2gHeEzlE/HC+LkBTZbSXEhp0412aj8uLv+7LRI4OU9UABytEU11s9Tc4X047j ca5OAXLEGJFfPZBYBuz71fESgynId4f8pLCe7J/rvDUW2dz50hXhhH64k/461jNwRfj2fz NbIoJAVT52QqiXOdBUyynzsi4Y6DpIovaodG+f9dl4hHd66Uvm6K1sXTHx7xz6uHXS7MgA Bwjlpdq05eRUramVQ1JtmXOOuL/Ni1Tke9WpCl07/pcPo7FpCYb1FPwcHMyy6WGvgNieOO 36JzI6d33CMjpHVsER2BDvZdVUnlADTIze+MwBHOqQ++qx7v6BjQaO4GSw+psQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676534264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wPAPOIjCJxq2PWcC5mDldM4w/mVi9DE4Np+psJ9QAJ8=; b=gKBUrSbW6so+/jeXvBUMKOQTk2rEACTOqS0OD/ofcQv0+ALyrCx5kfB/nIhEcmp7X15xQo 6b8OMMejG+6+moqAZoyXEwCsRYSqNol+xWrqaF21KYMheyMogR+AmyZ8Ht5kMHwYYazTwR XVe77EITlzOG5H2EVMV6KQcVtgLPHn0Ac8V1TaJEDuU8Mpc/KidUDBEpUh3l14zgSfe83M E1mZsFls3iuFGxhASj3sbHqjMKMJ812dpasvcDydUCeoEZfxHK+TGu2TY4sE8adnZZMq4x sX49MnK2YtynIn+Gieb2nQupNXW8cWqvrkT0wrEe0QII+xIH/XvxcdNkEABiYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676534264; a=rsa-sha256; cv=none; b=aYFFrCF7kEpelwDqreujJ22caYX0mbNcmFrPenZEAYY1igWxc79hxhGW04st7L2Vr4ucQx HCrQg+UwulLFdrCB0+canttncSBiBgzjxWdn1hpYCL64YK9mFICjLykVV76mG5xsiMk0tY jFAeHko0QkOhTXNV33Gc78RzzbubouFFQmcoVYWUqgzE+l7adRxtfeqnK2b2XoRsfXN/zM wYGoUwE4bDo9E5ZknfN0WxQI5/gPxYZ5udO1uZYCjvVyRR4+rJahuLq3dTcka2l00dR/yd ocH1vUrhGMitokiQYm/LBgCx1SyQmO6s2VogGc2gVOBIPxwXK/kG/HdP5oFX7A== Received: from localhost (p200300cb871a694eb5fedb6a75c132cd.dip0.t-ipconnect.de [IPv6:2003:cb:871a:694e:b5fe:db6a:75c1:32cd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PHS3X0QBRz1Qh9; Thu, 16 Feb 2023 07:57:43 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Thu, 16 Feb 2023 08:57:38 +0100 From: Gordon Bergling To: Warner Losh Cc: Gordon Bergling , FreeBSD Current Subject: Re: Build breakage with WITH_BEARSSL=1 Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7oN4/LC7dxEXkojl" Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 13.2-STABLE amd64 X-Host-Uptime: 8:54AM up 15:16, 2 users, load averages: 0.50, 0.39, 0.27 X-ThisMailContainsUnwantedMimeParts: N --7oN4/LC7dxEXkojl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Warner, On Wed, Feb 15, 2023 at 10:07:08AM -0700, Warner Losh wrote: > On Sun, Feb 12, 2023, 3:18 PM Warner Losh wrote: > > On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: > > > >> Hi, > >> > >> I am currently seeing a build breakage when building -CURRENT with > >> WITH_BEARSSL=3D1. > >> > >> The error is the following > >> > >> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: > >> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.a= sc 2> > >> /dev/null" returned non-zero status > >> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: > >> a function declaration without a prototype is deprecat ed in all vers= ions > >> of C [-Werror,-Wstrict-prototypes] > >> br_rsa_i62_keygen_get() > >> ^ > >> void > >> 1 error generated. > >> --- rsa_i62_keygen.pico --- > >> > >> > >> When disabling BEARSSL in the src.conf the build succeeds as usual. > >> > >> Has anyone also seen this build error. Sources are very recent and the > >> src.conf is the following: > >> > >> WITH_EXTRA_TCP_STACKS=3D1 > >> #WITH_BEARSSL=3D1 > >> WITH_PIE=3D1 > >> WITH_RETPOLINE=3D1 > >> WITH_INIT_ALL_ZERO=3D1 > >> WITH_OPENSSL_KTLS=3D1 > >> WITHOUT_CLEAN=3D1 > >> > >> Any help is very appreciated. > >> > >> > > What does the following do for you? It's a cut and pasted patch, but it > > should be clear enough what to do if the mailer mangles it. > > > > diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc > > index dd0e242c8ef0..2af4864d8441 100644 > > --- a/lib/libbearssl/Makefile.inc > > +++ b/lib/libbearssl/Makefile.inc > > @@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl > > BEARSSL_SRC=3D ${BEARSSL}/src > > > > CFLAGS+=3D -I${BEARSSL}/inc > > - > > +CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE} > > >=20 > I went ahead and committed this. Please let me know if the problem persis= ts. Sorry for the late reply. I just tried a fresh build and it still fails with [..]/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a function declaration without a prototype is deprecated in all versions of C [-Werror= ,-Wstrict-prototypes] br_rsa_i62_keygen_get() Did you see any other possibilty to fix this? --Gordon --7oN4/LC7dxEXkojl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmPt4fFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP 09zJjQf+MSMD8j40Nn6hGmgxwuNGOpo9er6v0pirxZw1DUHNs++ysKrOTHeysEyw nSYsXI5cVbgvGVUixuS77vzF44vZXVXLXgmaTSotscjVCrf1BKeL4RMBnmB7RxgW rdTt6EhwSC3tJo1BWOUrmff5C1Nauz2JN98cizFEMMJWKO9aYV8peWMc05eK4xL5 +5LRSTWenvrcoep0zevjHQYNKl8MoWP79Vv+2R5l+fEDxUOSOLAJwWrCQ3LBMHp2 POIlHDNF39xt2mXlHHZkkxM6cEtl1TDDUkej+es8/gEVyWKBmZV+LKTmUV0SfKWY 9EK+20i562ac3f61JhqH0uWuGQWngg== =MFqY -----END PGP SIGNATURE----- --7oN4/LC7dxEXkojl-- From nobody Thu Feb 16 08:15:04 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHSRZ6Wwlz3pLQy for ; Thu, 16 Feb 2023 08:15:06 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHSRZ4t9Xz3LKd; Thu, 16 Feb 2023 08:15:06 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676535306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=SFTlGvAhLmXp1dwgF5VxEGTwz5hR8VZ7mTLWAhTSgHQ=; b=CPtOfa7U82ca9BnE5QvL1Q3mcPGyZIukCWZw6JSaH4bfPCQNMDFXxBo+1WKV5KYlDDwpFT TCR2BlYlByNrOXhaQtwbLBrQDzi1nkIDQFJr05u9HUNWq/Lv8yMpBH8rsl8K/FYtXVDDwm kMeP82kbVABqN+HxxQ1flTaq55EFVT67M+lMPxktlYQ00+j6h40Pe1bwBqVYJc9T7zFAm+ C7PIC9JIM6xeyb5Z2f1KceoheKY4Rmqz6prr9rZ98Bqq7CE1oPfj2PKsYNTaDLG8JxAVCq f6rc5tG2+mTk8rBhcKzw/aFMcTN+XWclrsVWXGDjDdtfIpeMjTeq8kemGpop4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676535306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=SFTlGvAhLmXp1dwgF5VxEGTwz5hR8VZ7mTLWAhTSgHQ=; b=ioQ86lVILEUVX8+0sWpBfXqO6Uq7KgFqibtbRGbfQOtD2/4+caSLC+C/OUd7Li9+tucEjH ik6383877Qm1m8oPQtTNdK7woswW7s/KS/Ye4P+BZiVcL2+CCOpfpvsSCODyqXh5LUCPoF sPi7Q0Hq8iz+fjwSOl1wHforjlpcG8v+8u9NmaL09k2FgAOC/3ua6OMyRMEhlG0s4O69Tc rHE5qlby8lvituyvRTjPFSo9NaibGfvNJEwA9kIUZ2eXKN4BRRPJJKwYP5/hPqDiYiHAJM AtKtTiZ7w3sWc4EoKLm/iPr0XNB0s3jzq2B3KUy6ElP5s2eAvxlyidgzsTvHjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676535306; a=rsa-sha256; cv=none; b=VKV1lQHMLqBx0Lx5DFp8QmE9ZWwYIE79ZGUCHy/VTsB80qyMwu/xUVm0BMsx3iKdm1hzM4 +gWwPnIww9mzqEdiz4NlulOzJx9isj1xLlPAI2qqhx0F1AI0FGEoxCyAnbf5UElpBYlwZJ BLTPYYVA8oqSttgc6wW0xIV2uIIHr4hRHW3VUsQTRncj1YngaB2y7loxE1Bioku4AGstR8 ntN/j0guFWLQLTReikz5fhly+TUh7oEmcZs9bVcEEm5LhCxRh2l/MX3+MheAPqyp5jHapH XrW13oVtyeYazGqdGSq0bqnZGWk6CmR5ag6TYVU1ew0gq+Yuih74J0JBoye9ZA== Received: from localhost (p200300cb871a694eb5fedb6a75c132cd.dip0.t-ipconnect.de [IPv6:2003:cb:871a:694e:b5fe:db6a:75c1:32cd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PHSRZ1Ml6z1Q08; Thu, 16 Feb 2023 08:15:06 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Thu, 16 Feb 2023 09:15:04 +0100 From: Gordon Bergling To: freebsd-current@freebsd.org Cc: jhb@freebsd.org Subject: Missing ktls_ocf.ko Message-ID: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B3nom2SabKmziTwL" Content-Disposition: inline X-Url: X-Operating-System: FreeBSD 13.2-STABLE amd64 X-Host-Uptime: 9:11AM up 15:33, 2 users, load averages: 0.35, 0.30, 0.26 X-ThisMailContainsUnwantedMimeParts: N --B3nom2SabKmziTwL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very recent -CURRENT there is no such kernel module present. Has there anything changed in -CURRENT about this kernel module? On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel. --Gordon --B3nom2SabKmziTwL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmPt5gZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP 09xrEgf/S3zfMtvZOKD7+Qvy74AMihtpcBtwHLdFZJ7N5oqFwipxXl96k2Xv6LZB MrhLdV59vx9viVH8ic9KH0rQu/J5RGh2zTGbl+CwsUF6UwAfJbuMwRbZr2PAQjiE zfw5AZ2nSgSdTJ7Tw8nP7wddY8PIgv4JAZ9KVkjPIUF8EOwCdZOm1wrlbY5Xryqi y0ctP/AcUPSisaAg28gieaZRr0Q8YHkYNalWwLlNp2iuejZ9oVhMh4uRegmsEY48 9zfjvp5y4gJuaEBzwz8CQWTxxvXqAYjHVVq2EVJWnLwL0axEjC2eugcWiYlEdXQG sHVpTYP9Aa9kf07LumVp5JrZn+ctcQ== =4eLN -----END PGP SIGNATURE----- --B3nom2SabKmziTwL-- From nobody Thu Feb 16 08:30:24 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHSnH4YpLz3pMQd for ; Thu, 16 Feb 2023 08:30:27 +0000 (UTC) (envelope-from Stephane.ROCHOY@stormshield.eu) Received: from mail.stormshield.eu (mail.stormshield.eu [91.212.116.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ictdccexch001.one.local", Issuer "Stormshield Servers CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHSnG1cJLz3Ph1; Thu, 16 Feb 2023 08:30:26 +0000 (UTC) (envelope-from Stephane.ROCHOY@stormshield.eu) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=stormshield.eu header.s=signer header.b=bop463Ji; spf=pass (mx1.freebsd.org: domain of Stephane.ROCHOY@stormshield.eu designates 91.212.116.25 as permitted sender) smtp.mailfrom=Stephane.ROCHOY@stormshield.eu; dmarc=pass (policy=quarantine) header.from=stormshield.eu DKIM-Signature: v=1; a=rsa-sha256; d=stormshield.eu; s=signer; c=simple/simple; t=1676536224; h=from:subject:to:date:message-id; bh=aOmHZ3pd2kTA2ueZaHQkSXcPXhhTTqr77bmtcpKXiOc=; b=bop463JiTYFICoIEpldfpnlVXW/CeYQ/Jeeh77C2WkwoCkrKrd8HIbnMDyqOT6PLPFxfuxXO1MV wLDU9Ljb6f+zG1SXFm65N4sDF+2F/XISxU4Pl3UAY03BH3JFvmspc/MBLCJpZHeHQp3zu1VjJHfwu ALQN/vdgfaGmt2gfyWhlrffV4TbuDCTAoYHwjce/ms9wUAuCnSyWvQEv01xwG5WHR/ujZd1nqDkgI +JWJKbIp9hapdmdGmxt2o9Vnzq/9CWgnJkkf4e3D2hZsdVvve4fQQCr0iOJCuCmqhWAQ8iHUc3a5m w/b4EaATijYLkr81paLiH/geTI4AkDCylfzg== Received: from cthulhu.stephaner.labo.int (10.2.16.1) by ICTDCCEXCH001.one.local (10.180.4.1) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Thu, 16 Feb 2023 09:30:24 +0100 Received: by cthulhu.stephaner.labo.int (Postfix, from userid 1001) id 8B0201FDC9; Thu, 16 Feb 2023 09:30:24 +0100 (CET) References: User-agent: mu4e 1.2.0; emacs 27.1 From: Stephane Rochoy To: CC: Mina =?utf-8?Q?Gali=C4=87?= , Gordon Bergling Subject: Re: Build breakage with WITH_BEARSSL=1 In-Reply-To: Date: Thu, 16 Feb 2023 09:30:24 +0100 Message-ID: <86mt5evwpr.fsf@cthulhu.stephaner.labo.int> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.2.16.1] X-ClientProxiedBy: ICTDCCEXCH001.one.local (10.180.4.1) To ICTDCCEXCH001.one.local (10.180.4.1) X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; DMARC_POLICY_ALLOW(-0.50)[stormshield.eu,quarantine]; R_DKIM_ALLOW(-0.20)[stormshield.eu:s=signer]; R_SPF_ALLOW(-0.20)[+ip4:91.212.116.25]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[stormshield.eu:+]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; HAS_XOIP(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; ASN(0.00)[asn:49068, ipnet:91.212.116.0/24, country:FR] X-Rspamd-Queue-Id: 4PHSnG1cJLz3Ph1 X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Warner Losh writes: > On Wed, Feb 15, 2023, 1:09 PM Mina Gali=C4=87 > wrote: > >> Would be nice if we could get upstream to actually fix this, >> but i don't even know how to submit bugs there=E2=80=A6 >> > > Agreed. I didn't recall off of the top of my head, so I did the > quick bandaid. Hi, It may be worth contacting BearSSL's maintainer directly: Thomas Pornin . The guy was very responsive and helpful back in 2020 :) Regards, -- St=C3=A9phane Rochoy O: Stormshield From nobody Thu Feb 16 08:34:11 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHSst5gdQz3pMy3 for ; Thu, 16 Feb 2023 08:34:26 +0000 (UTC) (envelope-from freebsd@igalic.co) Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHSst338Tz3QjL for ; Thu, 16 Feb 2023 08:34:26 +0000 (UTC) (envelope-from freebsd@igalic.co) Authentication-Results: mx1.freebsd.org; none Date: Thu, 16 Feb 2023 08:34:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igalic.co; s=protonmail; t=1676536461; x=1676795661; bh=lOSPy7rTCu/UZ54irSdJF8pHkfycuy9k+NGu6OcsFRE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=zwO269S/aHoRtSuli0JcOfLn7Jx/V/I8lCq/pTEr27xfM6nXSeL4TwOSKVijdFNzE eF2p8VuBq6cOENTE0JisIFdXMM2w54aOkvQQiSPsIAihNcxSY23AwN6QIF5m3g6XMZ o1bT0qs0PZGOvHHRudnijxGfz4BG8hQsLIk9wH4yfV/1v/sjGNTx7jRes+Syjuyvv0 JQHh0rYQxWKgbAdXZc7KMV9MZ/GKtNDqn9BGb3CK1HDwKw8DdAZsbGwsQOhLKP8PEe qEZoVJuUAa9ebpoEuyXiGRjTtzCTG3m6dQ6/yDfdbcRnjJaNdKg/Ml5By06bRgezG/ hhhsCZUe2qsQQ== To: Stephane Rochoy From: =?utf-8?Q?Mina_Gali=C4=87?= Cc: freebsd-current@freebsd.org, Gordon Bergling Subject: Re: Build breakage with WITH_BEARSSL=1 Message-ID: In-Reply-To: <86mt5evwpr.fsf@cthulhu.stephaner.labo.int> References: <86mt5evwpr.fsf@cthulhu.stephaner.labo.int> Feedback-ID: 66573723:user:proton List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4PHSst338Tz3QjL X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:62371, ipnet:185.70.43.0/24, country:CH] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N ------- Original Message ------- On Thursday, February 16th, 2023 at 08:30, Stephane Rochoy wrote: > Warner Losh imp@bsdimp.com writes: >=20 > > On Wed, Feb 15, 2023, 1:09 PM Mina Gali=C4=87 freebsd@igalic.co > > wrote: > >=20 > > > Would be nice if we could get upstream to actually fix this, > > > but i don't even know how to submit bugs there=E2=80=A6 > >=20 > > Agreed. I didn't recall off of the top of my head, so I did the > > quick bandaid. >=20 >=20 > Hi, >=20 > It may be worth contacting BearSSL's maintainer directly: Thomas > Pornin pornin@bolet.org. The guy was very responsive and helpful >=20 > back in 2020 :) >=20 > Regards, > -- > St=C3=A9phane Rochoy > O: Stormshield after re-reading https://bearssl.org/contrib.html that's exactly what it says to do: "Suggestions, comments, patches and other contributions are welcome. They s= hould simply be sent to me (pornin@bolet.org) by email." (reading is hard) From nobody Thu Feb 16 08:37:14 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHSxG0zBdz3pMyk for ; Thu, 16 Feb 2023 08:37:22 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [94.130.200.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail.bsd4all.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHSxF5pvMz3jQM; Thu, 16 Feb 2023 08:37:21 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Date: Thu, 16 Feb 2023 09:37:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1676536634; bh=qhtN3HkcDTu0xoiSDSIAnbPLnite7bcdyqXDAungrME=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=MbVmGozIqyld21pkKRaWpBMM8xOL8u2tVUXTSTXYXEj1qlxXjs4mzVeOigHmQ/1o+ 2EXzVjk+uBiP8zSPLoSfyA52iiv8owFJIY4yL+R/sNwClhi3zGJ5fvZNxzP7Vea+SU iiJUP6brUfmrzGqm/hYcPweRGctgFSybaBLvvYjLgPcZFLk7eyIXHSkfHflXZUqCiH jjSDR2bz5q3ClCrR0G3jnZOXkC9keLFUI5gh8UlOlZv41funXQluDROKkDXfGu3hiT urNR0tMyzVfVmMc3/MdGVUT5l6k1JiZa3IYfet0XxqER0lnd68J/Zu+Q5iYNTceIru t28K3P+kYYuwg== From: "Herbert J. Skuhra" To: Gordon Bergling Cc: freebsd-current@freebsd.org, jhb@freebsd.org Subject: Re: Missing ktls_ocf.ko Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4PHSxF5pvMz3jQM X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, Feb 16, 2023 at 09:15:04AM +0100, Gordon Bergling wrote: > Hi, > > I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very > recent -CURRENT there is no such kernel module present. > > Has there anything changed in -CURRENT about this kernel module? > > On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel. commit 21e3c1fbe2460f144f6d4dfd61c3346b2de59667 Author: John Baldwin Date: Tue May 25 16:59:19 2021 -0700 Assume OCF is the only KTLS software backend. This removes support for loadable software backends. The KTLS OCF support is now always included in kernels with KERN_TLS and the ktls_ocf.ko module has been removed. The software encryption routines now take an mbuf directly and use the TLS mbuf as the crypto buffer when possible. Bump __FreeBSD_version for software backends in ports. Reviewed by: gallatin, markj Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D30138 Does this answer your question? -- Herbert From nobody Thu Feb 16 08:41:54 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHT2X5sqzz3psPB for ; Thu, 16 Feb 2023 08:41:56 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHT2X5QLqz3lF7; Thu, 16 Feb 2023 08:41:56 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676536916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VtR2U6dVmm08Mq8S7R/fm/OwjOxk8U8jviOxXR92+dk=; b=IqXql9FUD2fiEXuQ9ylbdnK91SVAzo/ehUUXW69Zl5hfv/t3DWADkvrVUG6uN6q+aDFS3O 2LywZz6gK6khTrHjrcYrwYfQqFitIYjn8PuTcYjo6ws1kKQX37Z5kAZd4IXLJQu6ueKWyY Md4PqoWwaflzYdjNnaXzsr5nD321gI/YQa9NR04E++60/Z3dXSzrchJZ6fY+OoRYpC86dd angPLsp4BY45k0gQy/EcXT2PJsZkZxTQMWvQSXGXzMDY7tXDeEkBkp+5SOZx4c2ncNvm9k fJwkU4WK7soXBLZ9ZS4q67mhsNVCb2z0A6U0TkUwysoQnQoLysipwFodhAU1Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676536916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VtR2U6dVmm08Mq8S7R/fm/OwjOxk8U8jviOxXR92+dk=; b=vW4/MlwXqWqwMSBoV+arnnprEDPgro/A3H4xa87fEwkMOm+ks2nhfKITnZbxg7U8itkG+l 0mHPAmpLSz8YS9Lr1Y7sbVp24Ci986O5H9m9HuIDiqPB09MbwDw+hKmZQLxm49rcPQafDP 7usf47Iabev6PRzWK3QsOU62byQpB5BoMx3O5bJoCzvS00bweRqFbWyz26Yij2LzWNCuQ+ N9bc7n1rlPS8MtaTVQlVr9bZHig4QXlpJc+Ir3wZ80jyuYMHtwvM20GqC4KMHFgCcQW4m2 7TNpbRjsUhzmj7MSYaWDqe8oSu0XFMt8GGAHWyhdsHMVE+3Xp/Xg0eF+qNEgjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676536916; a=rsa-sha256; cv=none; b=J0/O0+8aXkIbc+zVm0gJOeVImxYqCGq3WAAfscYPFxH9e+qOcPTLj823Doq/yP1ZnM7fDQ ouJ7jIJYtD41yuHor+1XAjCO053T7ABrbsX9SSVledyq7GoOiiosMww4zbBuQOCvsJZrzv 7W3vobK8Jk7/s2hwnTAre+Dgr9UJOfYGTvTQDygeL+0ALTx1a2f9e9nT7kDE+SENF/591e svkpf1j9cYZjbnPI0vtWypFJW4r9pPQoj+7YT1E8hHJk4bZHLiEGrnRQlTM1jVpP4RKfSQ ty3tiDJKm4KH8BgRiiSxM7X/9ZWTYv7bg7kb5ZLmoJZKxaNq5LIDHmAbgCEOPQ== Received: from localhost (p200300cb871a694eb5fedb6a75c132cd.dip0.t-ipconnect.de [IPv6:2003:cb:871a:694e:b5fe:db6a:75c1:32cd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PHT2X20Chz1RJg; Thu, 16 Feb 2023 08:41:56 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Thu, 16 Feb 2023 09:41:54 +0100 From: Gordon Bergling To: "Herbert J. Skuhra" Cc: freebsd-current@freebsd.org, jhb@freebsd.org Subject: Re: Missing ktls_ocf.ko Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HcTgqHwZg+9DHIqR" Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 13.2-STABLE amd64 X-Host-Uptime: 9:25AM up 15:46, 2 users, load averages: 0.47, 0.33, 0.26 X-ThisMailContainsUnwantedMimeParts: N --HcTgqHwZg+9DHIqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Herbert, On Thu, Feb 16, 2023 at 09:37:14AM +0100, Herbert J. Skuhra wrote: > On Thu, Feb 16, 2023 at 09:15:04AM +0100, Gordon Bergling wrote: > > Hi, > >=20 > > I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very > > recent -CURRENT there is no such kernel module present. > >=20 > > Has there anything changed in -CURRENT about this kernel module? > >=20 > > On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel. >=20 > commit 21e3c1fbe2460f144f6d4dfd61c3346b2de59667 > Author: John Baldwin > Date: Tue May 25 16:59:19 2021 -0700 >=20 > Assume OCF is the only KTLS software backend. >=20 > This removes support for loadable software backends. The KTLS OCF > support is now always included in kernels with KERN_TLS and the > ktls_ocf.ko module has been removed. The software encryption routines > now take an mbuf directly and use the TLS mbuf as the crypto buffer > when possible. >=20 > Bump __FreeBSD_version for software backends in ports. >=20 > Reviewed by: gallatin, markj > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D30138 >=20 >=20 > Does this answer your question? Thanks for pointing me to this commit. This answers my question and I will update the manual page for 14-CURRENT so that the documentation is matching the state for 14-CURRENT. --Gordon --HcTgqHwZg+9DHIqR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmPt7FBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP 09xz5Qf+PqgZEmQ/MTVNIjj7s2ltuoNiHJmyXU1cYFqtTkcjqtEkVtt8KAsmNd6C jaIjjqKcktue2cREIywixqQm7Qs5yJ+WBiFXPfhx/sJ4QoxeSI3d62AUbjgQitLQ qpDIfEykvg3zhSEAMawMmr69hTMhaLEC20iSCqr+T442yJXfILCUuBIufyRX+NtY 2Q+ug6V/n58j4h19Bp6s0zcqByi0in1jnG0rdQPoRza8cJ74AUqEvC4DGsZNcv0o qj8BNWpNqG4NCbAQYptg7O2LGJxSORWvTLYcuPzef1oT4BKmrcFtYMErGlFF1Kr/ /JfGQNEeHPIf3+CDZf7fm5/HF41jRg== =q2YV -----END PGP SIGNATURE----- --HcTgqHwZg+9DHIqR-- From nobody Thu Feb 16 13:49:02 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHbsD0YLVz3qSTf for ; Thu, 16 Feb 2023 13:49:20 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHbsC2l8mz3QPm; Thu, 16 Feb 2023 13:49:19 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x633.google.com with SMTP id r8so2085542pls.2; Thu, 16 Feb 2023 05:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Efb0NlCUR3N2FcupVrJs7E8RpvhOYaAU8ld9aBd5eOQ=; b=UMt/wclvgkVVxLuPGmOFrEzbmBWOcis1EXOsly6/hrXkeQMddYdQTKgFjTtwK1Q5hP nsIZyE2kvzVtUmAyixJNI7M8c1J6UTVCCfzGT9+5QR5iEi0Sxz21Ef3d8OFjSi5aIDoz LfY30pOZNgBck1Zx3XfMAJ+sBGhHHwhRD/ZVBzpVwLJM5Jg1AY6b2owKg/ijUw3yANt1 3mGLZOY+LCeEZw4lt9pbH+iH9julvjbxPMpfVKNh4cvB0qwrW7cglHkL9hEVXWxJx7K6 IpE9ykVa/qacCiIYyAV9WSV4lGuVeBETfnGdtDOol+6P0XSyTeD9xB6FMc9SDkSh9dU0 pirg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Efb0NlCUR3N2FcupVrJs7E8RpvhOYaAU8ld9aBd5eOQ=; b=hJzynMfPCn4Rt6yNzd/D1hMzCqZxxU9ARTxtPlIHw0keiGLrSHOBMPrsytkly2dN02 nCaIUH77zLvwvm9acXCWpz7Ic3UHFHFBwx0b2LZ0xgv2DjQRjX+YYrq4TQGRMc801Vtn 0qzHKeRTOX2nH2gBWw3iV1l1gXWmv9YBwWSfEtmJQGEU9jtRmG2z5ds2lRADkNvTfCAP a7sLpOu74MPu56oGs5mjj+fgi1xlSaJZ0AWcvtyLlQJ7kPl2ul8NoDwXdzxdx17BCMSw +rlw/tbESZpTZzMjrhrwqYQTGCrFOaaKEekMIlWUoNaLbg/Hr0NE1VDF3owUslPwKOYR OnoQ== X-Gm-Message-State: AO0yUKUqBd3r9c9oBQdLLOsdISfO63TPQft6fLfN4GT/BdNox+HDW9BN AAiNohLrohNWRlsSK2CraqEUKWpGEWhoRDSO2lpbGvrCOA== X-Google-Smtp-Source: AK7set9TnlNfJ9pCDBWoVdMDG9a8hKzpACuyza0uW59x9LxnXr09kTpJUMRLOFuw9uHbMDGERev5Fw6Qb/tN0dsdBgQ= X-Received: by 2002:a17:90b:3b4d:b0:234:96b1:453a with SMTP id ot13-20020a17090b3b4d00b0023496b1453amr507389pjb.79.1676555357844; Thu, 16 Feb 2023 05:49:17 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Rick Macklem Date: Thu, 16 Feb 2023 05:49:02 -0800 Message-ID: Subject: Re: Missing ktls_ocf.ko To: Gordon Bergling Cc: freebsd-current@freebsd.org, jhb@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PHbsC2l8mz3QPm X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, Feb 16, 2023 at 12:15 AM Gordon Bergling wrote: > > Hi, > > I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very > recent -CURRENT there is no such kernel module present. > > Has there anything changed in -CURRENT about this kernel module? I don't think the module exists or is needed any more, but jhb@ can confirm this. Sounds like a man page update is needed and that's your specialty. rick > > On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel. > > --Gordon From nobody Fri Feb 17 07:40:06 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJ3cn2Y6Qz3rvTt for ; Fri, 17 Feb 2023 07:40:09 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJ3cn25PCz3mPB; Fri, 17 Feb 2023 07:40:09 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676619609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AP871TJ8M0e1c4CCEioz2jorLFKEe9Et6CHbn+sPE2k=; b=IBd/O3YF4na0dxmp+0KSNrcBC9OxcAjuIyv8aJmMgEauslW3luaOirSdlvZrJPnZyqQLkT pq00nhNT014OpI6xmzzyUtLnf8sytL6nDtMe0yfUkd/s//OdzBBl2PSeTyzyDiupLPaoYp vyNxc9QLRWatdxTjtmQGYDVvtQi7wksnALaP6Y33wj0UvuY3FEI70yUoNwnU871ddy3NiU 2S7Feq70lMSZj7XehYYtIc2EkJGXxSpi/8fXMhWlA27iF0EIIXldW75OnSX4cq7S7b06KX XOe/0nJjYhYPvxtfgWrmQA7XFw6SvazoN0Nsw9D6nnkRuVZZ7tv2/D+fvjsZ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676619609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AP871TJ8M0e1c4CCEioz2jorLFKEe9Et6CHbn+sPE2k=; b=MYxBoPw3WLTd1pYeLTYUiC+PN2PSfO1HZSOrF23UaUR156NLo4rKko1Cjb5rUpZp06sfUu 6XTP4xXJMV2jGFQid9faWUfWVT9Gr7Y+uFn4q6ESoVbB0ONHjRjoG68y1qdAQk2s637lFN R6gNXY/IDALKDZzG13OauS74MkPZ5g1FVAH3xJ/bQNXqVy2LAipHygvMpAYoMRiu2wCmTO 9kZ0TaN/2KFXeNnCTSUoIfQ+qsHO8sDaq435b3L3iowDtwmcnCJegKzYMngCz9XIXTyaCw 4pF2/ByVySM6qGDRfLtOa5+FYfRSElKS86t+6smYCK63zz3BlldmkJPwKsvm0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676619609; a=rsa-sha256; cv=none; b=ffGjpaYQZtF8Tm5e9SCuFUxfKg1KwuIRYNXBfAMsk82po3k6gTfbT0RsqB1EGubcEj2utM ipC+O7Ci5Q08d1v+pj317/tuas6GAMwWF8B3W0UhVLJfW3QcsPheCtRrFBmzZ+f5BSmTG0 3eWarWIcrIpCwaBGn2aYP97J3G5MTQcI1eF9TcUVvB7eh/J8iyCpHcnTAPG+//SRytG5+k i6e8QeFHXI2/1Fxz3lngzh7fq4mnrGxEccdA+TWAYGW+5+ybBk2sblIej0kYo+qCJH9HQ/ QaFq33pFwwoxv2hbRfqxO3nnagBzcdPHZSfxy6vMpk51Y1/umbG7zWACu4insQ== Received: from localhost (p200300cb871a695e5c4a6a57393456ec.dip0.t-ipconnect.de [IPv6:2003:cb:871a:695e:5c4a:6a57:3934:56ec]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PJ3cm5BrYzcvB; Fri, 17 Feb 2023 07:40:08 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Fri, 17 Feb 2023 08:40:06 +0100 From: Gordon Bergling To: Rick Macklem Cc: freebsd-current@freebsd.org, jhb@freebsd.org Subject: Re: Missing ktls_ocf.ko Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="o3u6Ale0/iJYs1BI" Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 13.2-STABLE amd64 X-Host-Uptime: 8:35AM up 2:09, 1 user, load averages: 0.27, 0.32, 0.24 X-ThisMailContainsUnwantedMimeParts: N --o3u6Ale0/iJYs1BI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rick, On Thu, Feb 16, 2023 at 05:49:02AM -0800, Rick Macklem wrote: > On Thu, Feb 16, 2023 at 12:15 AM Gordon Bergling wrote: > > > > Hi, > > > > I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very > > recent -CURRENT there is no such kernel module present. > > > > Has there anything changed in -CURRENT about this kernel module? >=20 > I don't think the module exists or is needed any more, but jhb@ can confi= rm > this. Sounds like a man page update is needed and that's your specialty. > I had the same thought but actually the documentation is already correct, I just looked at the 13-STABLE man page not on the -CURRENT one. > > > > On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel. --Gordon --o3u6Ale0/iJYs1BI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmPvL1VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP 09x3/ggAgNh10dlNK9GrIruB3rAm2oLJvsJdcNmed821RooxANPLgpGOVapI9mqG plcAhQLoXLiSjmrBC2R/i5a9Sz0kbCndsr5HDbRmma85VjNuyHg7yFEJOMdm3dGz fmw+IoScVjGmrimad3Q8oJaGlZbpr0KIoqI54M7J9+RhNlfaYwl9YQ3ijR+wTPaR u2fUpP5A60/aRkqQAkBjwqypL97E3WyD4XPlST/aKV6qkqwLeoaN6dbLLLGDXEyu jru0ceHiQrITZnjLx5wuYjArhHxnlKr9TO/DHADCOywDGSbBTssL+Dt/Tlp8/Fa2 xgZhOVQ1DS31aL0WtRL6D0IveGYNdA== =Qc4w -----END PGP SIGNATURE----- --o3u6Ale0/iJYs1BI-- From nobody Sat Feb 18 08:33:11 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJhlc55t1z3rrlN for ; Sat, 18 Feb 2023 08:33:16 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com [IPv6:2a0c:5a00:149::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJhlc08ccz4HbN for ; Sat, 18 Feb 2023 08:33:15 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Authentication-Results: mx1.freebsd.org; dkim=none ("invalid DKIM record") header.d=iherebuywisely.com header.s=selector1 header.b="HONf/n5m"; spf=pass (mx1.freebsd.org: domain of jbtakk@iherebuywisely.com designates 2a0c:5a00:149::25 as permitted sender) smtp.mailfrom=jbtakk@iherebuywisely.com; dmarc=none Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1pTIed-005lf8-IV for current@freebsd.org; Sat, 18 Feb 2023 09:33:11 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iherebuywisely.com; s=selector1; h=Message-Id:Date:Subject:To:From: MIME-Version:Content-Transfer-Encoding:Content-Type; bh=Bt+4PoMJ4CdfGd1jDc5LvKEOMnUf5cTV5LjROars2N8=; b=HONf/n5m5j+m+gx5UY3gmomNdf 47Bg7eW9r8mqeViSj0krEnmqowh3Q1pZtnpoA3cUsKpdAyYbTaTKQVuAuHerBBydJ9nBsWwg5Dvdm Qx79IktrE4efPY9kMT+GwN47i4Sugo5PcbtL1GHJvOoQL6THeAZ1TA4lVtjruAe0Dym+8SH0Exj/2 +99/QGVrXv9odnruz/+lCOZ23LobtDGA5/mjEP2MOdAx9QnjGVor1fAM30dFqqpmDTPFvkHeznYrf hdXgVNX7+bF4FpA3gyktgikoigsZrt4S9Cyxt+x1X+FG/aa/3m6Pt0v3abe1yugXasCMlZ3IK3kko C3wYz3Sg==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1pTIed-0002fn-8w for current@freebsd.org; Sat, 18 Feb 2023 09:33:11 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1pTIed-0003yH-82 for current@freebsd.org; Sat, 18 Feb 2023 09:33:11 +0100 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Received: from [Authenticated alias (650894)] by runbox.com with http (RMM6); for ; Sat, 18 Feb 2023 08:33:11 GMT From: "Jeffrey Bouquet" To: "current" Subject: buildworld failure Date: Sat, 18 Feb 2023 00:33:11 -0800 (PST) X-RMM-Aliasid: 650894 X-Mailer: RMM6 Message-Id: X-Spamd-Result: default: False [0.24 / 15.00]; NEURAL_SPAM_LONG(0.92)[0.921]; NEURAL_HAM_SHORT(-0.91)[-0.914]; NEURAL_SPAM_MEDIUM(0.63)[0.632]; R_SPF_ALLOW(-0.20)[+ip6:2a0c:5a00:149::25]; RCVD_IN_DNSWL_LOW(-0.10)[2a0c:5a00:149::25:from]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[current@freebsd.org]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_PERMFAIL(0.00)[iherebuywisely.com:s=selector1]; DKIM_TRACE(0.00)[iherebuywisely.com:~]; TO_DN_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; ASN(0.00)[asn:50304, ipnet:2a0c:5a00::/29, country:NO]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[iherebuywisely.com]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 4PJhlc08ccz4HbN X-Spamd-Bar: / X-ThisMailContainsUnwantedMimeParts: N Building /usr/obj/usr/src/amd64.amd64/tools/build/test-includes/sys_bitcoun= t.c Building /usr/obj/usr/src/amd64.amd64/tools/build/test-includes/sys_bitcoun= t.o sys_bitcount.c:1:10: fatal error: 'sys/bitcount.h' file not found #include ^~~~~~~~~~~~~~~~ 1 error generated. *** Error code 1 Stop. make[3]: stopped in /usr/src/tools/build/test-includes .ERROR_TARGET=3D'sys_bitcount.o' .ERROR_META_FILE=3D'/usr/obj/usr/src/amd64.amd64/tools/build/test-includes/= sys_bitcount.o.meta' .MAKE.LEVEL=3D'3' MAKEFILE=3D'' .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes ve= rbose' _ERROR_CMD=3D'/usr/local/bin/clang14 -O2 -pipe -fno-common -g -gz=3Dzlib= -std=3Dgnu99 -Wno-format-zero-length -nobuiltininc -idirafter /usr/local/l= lvm14/lib/clang/14.0.6/include -fstack-protector-strong -Wsystem-headers -W= error -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -W= missing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-string= s -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnes= ted-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-= variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int = -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variable -Qunused-a= rguments -c sys_bitcount.c -o sys_bitcount.o; ;' .CURDIR=3D'/usr/src/tools/build/test-includes' .MAKE=3D'make' .OBJDIR=3D'/usr/obj/usr/src/amd64.amd64/tools/build/test-includes' .TARGETS=3D'test-includes' DESTDIR=3D'/usr/obj/usr/src/amd64.amd64/tmp' LD_LIBRARY_PATH=3D'' MACHINE=3D'amd64' MACHINE_ARCH=3D'amd64' MAKEOBJDIRPREFIX=3D'' MAKESYSPATH=3D'/usr/src/share/mk' MAKE_VERSION=3D'20220208' PATH=3D'/usr/obj/usr/src/amd64.amd64/tmp/bin:/usr/obj/usr/src/amd64.amd64/t= mp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd64= .amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:= /usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/amd64.amd64/tm= p/legacy/usr/libexec::/usr/obj/usr/src/amd64.amd64/tmp/bin:/usr/obj/usr/src= /amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj= /usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/l= egacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/= amd64.amd64/tmp/legacy/usr/libexec::/sbin:/bin:/usr/sbin:/usr/bin' SRCTOP=3D'/usr/src' OBJTOP=3D'/usr/obj/usr/src/amd64.amd64 ..................................... Anyone see/know anything causing this error?=20 Also, the buildworld command most likely to build the most amd64 components= from scratch?=20= From nobody Sat Feb 18 15:41:36 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJtG61W3Wz3sf37 for ; Sat, 18 Feb 2023 15:41:50 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJtG55M83z3sty for ; Sat, 18 Feb 2023 15:41:49 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Authentication-Results: mx1.freebsd.org; none Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.17.1/8.17.1) with ESMTPS id 31IFff4s084354 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 18 Feb 2023 07:41:41 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.17.1/8.17.1/Submit) id 31IFfa5E084352; Sat, 18 Feb 2023 07:41:36 -0800 (PST) (envelope-from sgk) Date: Sat, 18 Feb 2023 07:41:36 -0800 From: Steve Kargl To: Jeffrey Bouquet Cc: current Subject: Re: buildworld failure Message-ID: Reply-To: sgk@troutmask.apl.washington.edu References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Rspamd-Queue-Id: 4PJtG55M83z3sty X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, Feb 18, 2023 at 12:33:11AM -0800, Jeffrey Bouquet wrote: > Building /usr/obj/usr/src/amd64.amd64/tools/build/test-includes/sys_bitco= unt.c > Building /usr/obj/usr/src/amd64.amd64/tools/build/test-includes/sys_bitco= unt.o > sys_bitcount.c:1:10: fatal error: 'sys/bitcount.h' file not found > #include > ^~~~~~~~~~~~~~~~ > 1 error generated. > *** Error code 1 >=20 > Stop. > make[3]: stopped in /usr/src/tools/build/test-includes > .ERROR_TARGET=3D'sys_bitcount.o' > .ERROR_META_FILE=3D'/usr/obj/usr/src/amd64.amd64/tools/build/test-include= s/sys_bitcount.o.meta' > .MAKE.LEVEL=3D'3' > MAKEFILE=3D'' > .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes = verbose' > _ERROR_CMD=3D'/usr/local/bin/clang14 -O2 -pipe -fno-common -g -gz=3Dzl= ib -std=3Dgnu99 -Wno-format-zero-length -nobuiltininc -idirafter /usr/local= /llvm14/lib/clang/14.0.6/include -fstack-protector-strong -Wsystem-headers = -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-stri= ngs -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wn= ested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissin= g-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-in= t -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variable -Qunused= -arguments -c sys_bitcount.c -o sys_bitcount.o; ;' > .CURDIR=3D'/usr/src/tools/build/test-includes' > .MAKE=3D'make' > .OBJDIR=3D'/usr/obj/usr/src/amd64.amd64/tools/build/test-includes' > .TARGETS=3D'test-includes' > DESTDIR=3D'/usr/obj/usr/src/amd64.amd64/tmp' > LD_LIBRARY_PATH=3D'' > MACHINE=3D'amd64' > MACHINE_ARCH=3D'amd64' > MAKEOBJDIRPREFIX=3D'' > MAKESYSPATH=3D'/usr/src/share/mk' > MAKE_VERSION=3D'20220208' > PATH=3D'/usr/obj/usr/src/amd64.amd64/tmp/bin:/usr/obj/usr/src/amd64.amd64= /tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd= 64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bi= n:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/amd64.amd64/= tmp/legacy/usr/libexec::/usr/obj/usr/src/amd64.amd64/tmp/bin:/usr/obj/usr/s= rc/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/o= bj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp= /legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/sr= c/amd64.amd64/tmp/legacy/usr/libexec::/sbin:/bin:/usr/sbin:/usr/bin' > SRCTOP=3D'/usr/src' > OBJTOP=3D'/usr/obj/usr/src/amd64.amd64 > ..................................... >=20 > Anyone see/know anything causing this error?=20 > Also, the buildworld command most likely to build the most amd64 componen= ts from scratch?=20 I'm seeing a different buildworld problem. =3D=3D=3D> usr.bin/nm (obj,all,install) = =20 cc -O2 -pipe -fno-common -I/usr/src/contrib/elftoolchain/libelftc -I/usr/sr= c/con trib/elftoolchain/common -std=3Dgnu99 -Wno-format-zero-length -Wsy= stem-headers -Wa ll -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-pr= ototypes -Wmissing-protot ypes -Wpointer-arith -Wreturn-type -Wcast-qual= -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wch= ar-subscripts -Wnested-externs -Wold-style- definition -Wno-pointer-sign= -Wdate-time -Wmissing-variable-declarations -Wthrea d-safety -Wno-empty= -body -Wno-string-plus-int -Wno-unused-const-variable -Wno-er ror=3Dunus= ed-but-set-variable -Qunused-arguments -I/usr/obj/usr/src/amd64.amd64/tm = p/legacy/usr/include -Wl,-zrelro -static -L/usr/obj/usr/src/amd64.amd64= /tmp/l egacy/usr/lib -o nm nm.o -L/usr/obj/usr/src/amd64.amd64/tmp/obj-= tools/lib/libdw arf -ldwarf -L/usr/obj/usr/src/amd64.amd64/tmp/obj-tools= /lib/libelf -lelf -L/usr /obj/usr/src/amd64.amd64/tmp/obj-tools/lib/libz= -lz -L/usr/obj/usr/src/amd64.amd 64/tmp/obj-tools/lib/libelftc -lelftc_= pie -L/usr/obj/usr/src/amd64.amd64/tmp/obj -tools/lib/libelf -lelf -leg= acy =20 PLEASE submit a bug report to https://bugs.freebsd.org/submit/ and include = the crash backtrace. Stack dump: 0. Program arguments: /usr/bin/ld --eh-frame-hdr -Bstatic -o nm /usr/l= ib/crt1.o /usr/lib/crti.o /usr/lib/crtbeginT.o -L/usr/obj/usr/src/amd64.amd= 64/tmp/legacy/usr/lib -L/usr/obj/usr/src/amd64.amd64/tmp/obj-tools/lib/libd= warf -L/usr/obj/usr/src/amd64.amd64/tmp/obj-tools/lib/libelf -L/usr/obj/usr= /src/amd64.amd64/tmp/obj-tools/lib/libz -L/usr/obj/usr/src/amd64.amd64/tmp/= obj-tools/lib/libelftc -L/usr/obj/usr/src/amd64.amd64/tmp/obj-tools/lib/lib= elf -L/usr/lib -zrelro nm.o -ldwarf -lelf -lz -lelftc_pie -lelf -legacy -lg= cc -lgcc_eh -lc -lgcc -lgcc_eh /usr/lib/crtend.o /usr/lib/crtn.o #0 0x000000000164f1c1 (/usr/bin/ld+0x164f1c1) #1 0x000000000164d4a5 (/usr/bin/ld+0x164d4a5) #2 0x000000000164f8e0 (/usr/bin/ld+0x164f8e0) #3 0x0000000827446a60 (/lib/libthr.so.3+0x19a60) #4 0x000000082744601f (/lib/libthr.so.3+0x1901f) #5 0x000000082362e8a3 ([vdso]+0x2d3) #6 0x0000000000cf4830 (/usr/bin/ld+0xcf4830) #7 0x0000000000cf7b89 (/usr/bin/ld+0xcf7b89) #8 0x0000000000cf55a3 (/usr/bin/ld+0xcf55a3) #9 0x0000000000cf5217 (/usr/bin/ld+0xcf5217) #10 0x0000000000dabe23 (/usr/bin/ld+0xdabe23) #11 0x0000000000da7754 (/usr/bin/ld+0xda7754) #12 0x0000000000cf4ec5 (/usr/bin/ld+0xcf4ec5) #13 0x0000000000cc6e83 (/usr/bin/ld+0xcc6e83) #14 0x0000000000cbe4bc (/usr/bin/ld+0xcbe4bc) #15 0x0000000000cbccda (/usr/bin/ld+0xcbccda) cc: error: unable to execute command: Segmentation fault (core dumped) cc: error: linker command failed due to signal (use -v to see invocation) *** Error code 254 % uname -a FreeBSD hotrats 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n260094-906c312bb= f74: Fri Feb 3 21:28:39 PST 2023 kargl@hotrats:/usr/obj/usr/src/amd64.= amd64/sys/HOTRATS amd64 The above is likely=20 --=20 Steve From nobody Sat Feb 18 15:42:58 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJtJ80VRlz3sf53; Sat, 18 Feb 2023 15:43:36 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp052.goneo.de (smtp052.goneo.de [85.220.129.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJtJ65522z3tgJ; Sat, 18 Feb 2023 15:43:34 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=walstatt-de.de header.s=DKIM001 header.b=WMAdtaKc; spf=none (mx1.freebsd.org: domain of freebsd@walstatt-de.de has no SPF policy when checking 85.220.129.60) smtp.mailfrom=freebsd@walstatt-de.de; dmarc=none Received: from hub1.goneo.de (hub1.goneo.de [IPv6:2001:1640:5::8:52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id CD18810A32CA; Sat, 18 Feb 2023 16:43:27 +0100 (CET) Received: from hub1.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPS id 3D11B10A32F4; Sat, 18 Feb 2023 16:43:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1676735006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mkG+EllY6DXIX7i2/JW+zJat3GW/s88d9FPNR8SVHJs=; b=WMAdtaKcKqGM44cbPqEJCnY7eVNMayPxLoADMTFLX2ZOzDPytifNt8HmcnZUKAbsDK1AoQ 7l2cJ2iq0tNEAZyLe08C6i5QVXL+yvK6CSl8AIHiGMBb03G6jZknxaodvOi87ioNCOXsPg g4q8RUpLf/IPf/MzGn4FuGwWSp8S4o1ho5tLMMTmWhmaQSrIVWcK92HJXAEXguD4ya4xj6 pbhid3srgqaxv2Zb3codCzrJ1NU2AE9ZTeGtFbijMVvnZlXPhRH4ZI+HV/lu+QOHb7rTBv 5b108RegdfwpT7IyICM3CCXvA0/tDJ+VPrJwD490/ObPh2COJiRjFhBKxMshVw== Received: from thor.intern.walstatt.dynvpn.de (dynamic-077-013-009-084.77.13.pool.telefonica.de [77.13.9.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPSA id 04EB310A3312; Sat, 18 Feb 2023 16:43:25 +0100 (CET) Date: Sat, 18 Feb 2023 16:42:58 +0100 From: FreeBSD User To: freebsd-net@freebsd.org, FreeBSD CURRENT Subject: IPFW: IPv6 and NPTv6 issues: multiple IPv6 addresses confuses IPFW Message-ID: <20230218164325.3a4c626a@thor.intern.walstatt.dynvpn.de> Organization: walstatt-de.de List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-UID: 093842 X-Rspamd-UID: 4348e2 X-Spamd-Result: default: False [-3.30 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[walstatt-de.de:s=DKIM001]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org,freebsd-net@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[walstatt-de.de:+]; HAS_ORG_HEADER(0.00)[]; ASN(0.00)[asn:25394, ipnet:85.220.128.0/17, country:DE]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[walstatt-de.de]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4PJtJ65522z3tgJ X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hello, running a small nanoBSD firewall/router appliance, the WAN interface (tun0) is confugred via SLAAC when it comes to IPv6. The allpliance is running in-kernel compiled IPFW. The OS is FreeBSD 13-STABLE, compiled on a recuurant weekly basis. On a 24 hour basis, the ISP changes the IPv4 and IPv6 on the WAN interface. We use NPTv6 to translate ULA addresses for the inner IPv6 networks. We use IPv6 privacy on the tun0 interface. The router/firewall is operating after a reboot or restart of mpd5 correctly, IPv6 and IPv4 networks have conection to the internet. When the ISP rotates it IPs, the IPv6 address is configured using SLAAC and mpd5 seems to act weird: - the IPv4 address is always set correct, IPFW and in-kernel NAT route/filter traffic correctly - sometimes old IPv6 address is dumped and only a new IPv6 address - in such a case, the old IPv6 is gone, the new pair (temporary and MACified address are the only IPv6 addresses attached to the interface. - sometimes the old IPv6 address set (= temporary) are marked "deprecated" and/or "detached" and a new set is attached to the interface tun0, in some rare occassion also an IPv6 address WITHOUT its "temoprary" sibbling is attached. In any of the cases above, IPFW's NPTv6 gets confused, routing isn't working properly anymore. In any cases of a change of the IPv6 address, IPFW has to be restartet! In cases with marked deprecated and/or detached addresses, IPFW has to be restarted, AND the deprecated and/or detached IPv6 addresses has to be deleted manually. Otherwise - so it seems to me - NPTv6 takes the wrong (outdated) prefix. NPTv6 should not take any deprecated, detached prefix if a valid prefix is available. Even deleting the deprecated IPv6 requires a restart of IPFW. No matter how long I wait, NPTv6 never gets the changed prefix by itself. Kind regards, Oliver -- O. Hartmann From nobody Sat Feb 18 21:28:58 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PK1yr5tqlz3rsp7 for ; Sat, 18 Feb 2023 21:29:08 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com [IPv6:2a0c:5a00:149::26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PK1yr3hM4z3P0c for ; Sat, 18 Feb 2023 21:29:08 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Authentication-Results: mx1.freebsd.org; none Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1pTUlU-0079gI-FL for current@freebsd.org; Sat, 18 Feb 2023 22:29:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iherebuywisely.com; s=selector1; h=Message-Id:In-Reply-To:Date:Subject:CC: To:From:MIME-Version:Content-Transfer-Encoding:Content-Type; bh=m6Q3TxrCGTqp3qunR9MjX+F+uOkQ2Ce6YWmDePMW3w4=; b=mbJpH3QZlxPKdLZPdEtqGVotCA Aa9jR1C2XWDSRGj/lKkSgVvjjvIJgZQTAwK5znIXYu7ef633ZqnqtPDhVR5+FbXQJG3h5CJFP8h1q 3xJDvEPxzbEwRsfU9doDGFVEyReL1mFhxX3hazqGkzJfmOTpAzsqqci4uVG4U5RjJmudE8dlZt1fW AGesU88ASCJ39SVXi3akp9kGlqhxtMqEvCZcvbPu5esW+xLxd9YRaAypHDz6uBrgEa9crhSBx/3bP EoRdszcQ9DGdZVB5snCfIkgkHXwJdbnkwNuX2EyeHALfmCml8KDezVk9Xcviv6+bfcdn67eAi//lP NR0KVv8g==; Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1pTUlT-00019r-GX; Sat, 18 Feb 2023 22:29:03 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1pTUlO-0006pz-Ec; Sat, 18 Feb 2023 22:28:58 +0100 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Received: from [Authenticated alias (650894)] by runbox.com with http (RMM6); Sat, 18 Feb 2023 21:28:58 GMT From: "Jeffrey Bouquet" To: "Jeffrey Bouquet" CC: "current" Subject: Re: buildworld failure Date: Sat, 18 Feb 2023 13:28:58 -0800 (PST) X-RMM-Aliasid: 650894 X-Mailer: RMM6 In-Reply-To: Message-Id: X-Rspamd-Queue-Id: 4PK1yr3hM4z3P0c X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:50304, ipnet:2a0c:5a00::/29, country:NO] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, 18 Feb 2023 00:33:11 -0800 (PST), "Jeffrey Bouquet" wrote: > Building /usr/obj/usr/src/amd64.amd64/tools/build/test-includes/sys_bitco= unt.c > Building /usr/obj/usr/src/amd64.amd64/tools/build/test-includes/sys_bitco= unt.o > sys_bitcount.c:1:10: fatal error: 'sys/bitcount.h' file not found > #include > ^~~~~~~~~~~~~~~~ > 1 error generated. > *** Error code 1 >=20 > Stop. > make[3]: stopped in /usr/src/tools/build/test-includes > .ERROR_TARGET=3D'sys_bitcount.o' > .ERROR_META_FILE=3D'/usr/obj/usr/src/amd64.amd64/tools/build/test-include= s/sys_bitcount.o.meta' > .MAKE.LEVEL=3D'3' > MAKEFILE=3D'' > .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes = verbose' > _ERROR_CMD=3D'/usr/local/bin/clang14 -O2 -pipe -fno-common -g -gz=3Dzl= ib -std=3Dgnu99 -Wno-format-zero-length -nobuiltininc -idirafter /usr/local= /llvm14/lib/clang/14.0.6/include -fstack-protector-strong -Wsystem-headers = -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-stri= ngs -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wn= ested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissin= g-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-in= t -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variable -Qunused= -arguments -c sys_bitcount.c -o sys_bitcount.o; ;' > .CURDIR=3D'/usr/src/tools/build/test-includes' > .MAKE=3D'make' > .OBJDIR=3D'/usr/obj/usr/src/amd64.amd64/tools/build/test-includes' > .TARGETS=3D'test-includes' > DESTDIR=3D'/usr/obj/usr/src/amd64.amd64/tmp' > LD_LIBRARY_PATH=3D'' > MACHINE=3D'amd64' > MACHINE_ARCH=3D'amd64' > MAKEOBJDIRPREFIX=3D'' > MAKESYSPATH=3D'/usr/src/share/mk' > MAKE_VERSION=3D'20220208' > PATH=3D'/usr/obj/usr/src/amd64.amd64/tmp/bin:/usr/obj/usr/src/amd64.amd64= /tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd= 64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bi= n:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/amd64.amd64/= tmp/legacy/usr/libexec::/usr/obj/usr/src/amd64.amd64/tmp/bin:/usr/obj/usr/s= rc/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/o= bj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp= /legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/sr= c/amd64.amd64/tmp/legacy/usr/libexec::/sbin:/bin:/usr/sbin:/usr/bin' > SRCTOP=3D'/usr/src' > OBJTOP=3D'/usr/obj/usr/src/amd64.amd64 > ..................................... >=20 > Anyone see/know anything causing this error?=20 > Also, the buildworld command most likely to build the most amd64 componen= ts from scratch?=20 seems "make hier" fixed it partially then WITHOUT_OFED=3Dyes in src.conf. maybe fixed, maybe not.=20=