Date: Wed, 25 Jan 2023 19:08:49 +0000 From: Michael <embhd@posteo.de> To: freebsd-embedded@freebsd.org Subject: nanoBSD: =?UTF-8?Q?cust=5Fpkgng=28=29=20bootstraps=20pkg=28=38=29?= =?UTF-8?Q?=20regardless=20of=20required=20pkg-X=2EY=2EZ?= Message-ID: <447bf50fdf772bc645446bca6d40637f@posteo.de>
next in thread | raw e-mail | index | archive | help
--=_41935738af19752ee442b1616b1dd0f9
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
format=flowed
Hello,
I noticed that in cust_pkng(), pkg(7) bootstraps to pkg(8) even though
the function itself requires a pkg-* for bootstrapping. This also seems
to be the reason why _.cust.cust_pkng notes that "the most recent
version of pkg-X.Y.Z is already installed" if the function has been run
with an active internet connection - first, pkg(7) bootstraps to pkg(8),
which then tries to install pkg(8) once more.
At the same time, I would think that if the nanoBSD-image is for an
entirely different plattform/architecture, the just bootstrapped pkg(8)
would not be able to run during operation, since it has been compiled
for the "host" system.
My current solution is to change the command set in ${PKGCMD} to use the
host's pkg(8), which chroots itself to ${NANO_WORLDDIR}. This also makes
the separate calls to chroot(8) by means of CR() and CR0() unnecessary.
Since the latter does not seem to be used anywhere else and the former
only once in clean_build(), they can be removed altogether if CR() is
replaced with a direct call to chroot(8) in clean_build().
Am I missing anything? Otherwise I would go ahead and open a PR.
Regards,
Michael
--=_41935738af19752ee442b1616b1dd0f9
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
name=defaults.patch
Content-Disposition: attachment;
filename=defaults.patch;
size=2023
ZGlmZiAtLWdpdCBhL3Rvb2xzL3Rvb2xzL25hbm9ic2QvZGVmYXVsdHMuc2ggYi90b29scy90b29s
cy9uYW5vYnNkL2RlZmF1bHRzLnNoCmluZGV4IDQ1ZDlmZTQ0YzY1MC4uZTVkNmNhY2RiMzQ0IDEw
MDc1NQotLS0gYS90b29scy90b29scy9uYW5vYnNkL2RlZmF1bHRzLnNoCisrKyBiL3Rvb2xzL3Rv
b2xzL25hbm9ic2QvZGVmYXVsdHMuc2gKQEAgLTI3NywxNiArMjc3LDYgQEAgdGd0X2RpcjJzeW1s
aW5rICggKSAoCiAJZmkKICkKIAotIyBydW4gaW4gdGhlIHdvcmxkIGNocm9vdCwgZXJyb3JzIGZh
dGFsCi1DUiAoICkgewotCWNocm9vdCAiJHtOQU5PX1dPUkxERElSfSIgL2Jpbi9zaCAtZXhjICIk
KiIKLX0KLQotIyBydW4gaW4gdGhlIHdvcmxkIGNocm9vdCwgZXJyb3JzIG5vdCBmYXRhbAotQ1Iw
ICggKSB7Ci0JY2hyb290ICIke05BTk9fV09STERESVJ9IiAvYmluL3NoIC1jICIkKiIgfHwgdHJ1
ZQotfQotCiBjbGVhbl9idWlsZCAoICkgKAogCXBwcmludCAyICJDbGVhbiBhbmQgY3JlYXRlIG9i
amVjdCBkaXJlY3RvcnkgKCR7TUFLRU9CSkRJUlBSRUZJWH0pIgogCkBAIC03NDAsNyArNzMwLDcg
QEAgY3VzdF9pbnN0YWxsX2ZpbGVzICggKSAoCiAJZmluZCAuIC1wcmludCB8IGdyZXAgLUV2ICcv
KENWU3xcLnN2bnxcLmhnfFwuZ2l0KS8nIHwgY3BpbyAke0NQSU9fU1lNTElOS30gLUxkdW1wdiAk
e05BTk9fV09STERESVJ9CiAKIAlpZiBbIC1uICIke05BTk9fQ1VTVF9GSUxFU19NVFJFRX0iIC1h
IC1mICR7TkFOT19DVVNUX0ZJTEVTX01UUkVFfSBdOyB0aGVuCi0JCUNSICJtdHJlZSAtZWlVIC1w
IC8iIDwke05BTk9fQ1VTVF9GSUxFU19NVFJFRX0KKwkJY2hyb290ICIke05BTk9fV09STERESVJ9
IiAvYmluL3NoIC1leGMgIm10cmVlIC1laVUgLXAgLyA8JHtOQU5PX0NVU1RfRklMRVNfTVRSRUV9
IgogCWZpCiApCiAKQEAgLTc1MCw3ICs3NDAsNyBAQCBjdXN0X2luc3RhbGxfZmlsZXMgKCApICgK
IGN1c3RfcGtnbmcgKCApICgKIAlta2RpciAtcCAke05BTk9fV09STERESVJ9L3Vzci9sb2NhbC9l
dGMKIAlsb2NhbCBQS0dfQ09ORj0iJHtOQU5PX1dPUkxERElSfS91c3IvbG9jYWwvZXRjL3BrZy5j
b25mIgotCWxvY2FsIFBLR0NNRD0iZW52IEJBVENIPVlFUyBBU1NVTUVfQUxXQVlTX1lFUz1ZRVMg
UEtHX0RCRElSPSR7TkFOT19QS0dfTUVUQV9CQVNFfS9wa2cgU0lHTkFUVVJFX1RZUEU9bm9uZSAv
dXNyL3NiaW4vcGtnIgorCWxvY2FsIFBLR0NNRD0iZW52IEJBVENIPVlFUyBBU1NVTUVfQUxXQVlT
X1lFUz1ZRVMgUEtHX0RCRElSPSR7TkFOT19QS0dfTUVUQV9CQVNFfS9wa2cgU0lHTkFUVVJFX1RZ
UEU9bm9uZSBwa2cgLWMgJHtOQU5PX1dPUkxERElSfSIKIAogCSMgRW5zdXJlIHBrZy5jb25mIHBv
aW50cyBwa2cgdG8gd2hlcmUgdGhlIHBhY2thZ2UgbWV0YSBkYXRhIGxpdmVzLgogCXRvdWNoICR7
UEtHX0NPTkZ9CkBAIC03ODMsNyArNzczLDcgQEAgY3VzdF9wa2duZyAoICkgKAogCXRyYXAgInVt
b3VudCAke05BTk9fV09STERESVJ9L2RldjsgdW1vdW50ICR7TkFOT19XT1JMRERJUn0vXy5wIDsg
cm0gLXhyZiAke05BTk9fV09STERESVJ9L18ucCIgMSAyIDE1IEVYSVQKIAogCSMgSW5zdGFsbCBw
a2ctKiBwYWNrYWdlCi0JQ1IgIiR7UEtHQ01EfSBhZGQgL18ucC8ke19OQU5PX1BLR19QQUNLQUdF
fSIKKwkke1BLR0NNRH0gYWRkIC9fLnAvJHtfTkFOT19QS0dfUEFDS0FHRX0KIAogCSgKIAkJIyBF
eHBhbmQgYW55IGdsb2IgY2hhcmFjdGVycyBpbiBwYWNha2dlIGxpc3QKQEAgLTc5OCwxMSArNzg4
LDExIEBAIGN1c3RfcGtnbmcgKCApICgKIAogCQkjIEluc3RhbGwgcGFja2FnZXMKIAkJZm9yIF9Q
S0cgaW4gJF9QS0dTOyBkbwotCQkJQ1IgIiR7UEtHQ01EfSBhZGQgL18ucC8ke19QS0d9IgorCQkJ
JHtQS0dDTUR9IGFkZCAvXy5wLyR7X1BLR30KIAkJZG9uZQogCSkKIAotCUNSMCAiJHtQS0dDTUR9
IGluZm8iCisJJHtQS0dDTUR9IGluZm8gfHwgdHJ1ZQogCiAJdHJhcCAtIDEgMiAxNSBFWElUCiAJ
dW1vdW50ICR7TkFOT19XT1JMRERJUn0vZGV2Cg==
--=_41935738af19752ee442b1616b1dd0f9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?447bf50fdf772bc645446bca6d40637f>