From nobody Sun Nov 5 06:21:18 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SNPWM1nxMz50TMs for ; Sun, 5 Nov 2023 06:21:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SNPWM0jLCz4gfH for ; Sun, 5 Nov 2023 06:21:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699165279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vUItKGA46g13YTpKBzpnq0RAwtkPPULxFTUw7EE77KM=; b=fotd8NI/3j4Z7uA+GGTO3h/dk8ijLwCpKooKWvrZVUDUzf/UFREVOecOvG1ySXGYj2TcCL WVFB6QIpGSM9isyOv6qnRFfkkiIN1D2uQOJgfPmGBwZu+dYX+CdVXzDaBjNR/EMDOOjxse xI3d2S7lywdUiPeHYX34p2eZX7BBiCq9UXdT+hvsyUFfRmsQkp7teNpFZNNB0zzUenWe9l 9UM1lyobpD39cYtHRu7pG8m7v6L3sPbuQ0yNdyVTswQsWK4MjtNqYuiVX7C1Fb4DHiJMYs /4YYcgr/TNG+2rrQfrDLn6rutLMY5tWcE5Ptph577hpcIFBFg/oqqa+NTaEiYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699165279; a=rsa-sha256; cv=none; b=gVFOpc0fZpky+c1ThwWdW15FnX2EyPLrkHOPhUl5Hk5h/kh4j4gBHBxIgUjqeEKQLoy29i INtciQ3jlxwmuBiMoUou/yCRdC66HP5e9tL3wP1cuHzlfxX6ojrUcLrqWoUHSCgNiE4X9A Yh3j8uXOe/1+hT9VUGOqMeDv6NVN9Gd0NKPnOqjdBohqirbNhukMlpPb8N2+myXShKiYr5 /p9/FJz3QyCoGit3MXvDpQvmOLRtgd+LxD8L82LJhSh8kGKtwGCfiN0xNq0NrLO1Qmg8WF YCoajzxk0fak5gopTxMc5BT2kMcrmXQsb2vx39kqh0pcayVm2u5Og48jsjKC7g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SNPWL6wQxz1SW1 for ; Sun, 5 Nov 2023 06:21:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A56LIWm038682 for ; Sun, 5 Nov 2023 06:21:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A56LI2W038681 for pf@FreeBSD.org; Sun, 5 Nov 2023 06:21:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Sun, 05 Nov 2023 06:21:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[pf][panic] immediately on |panic immediately on |loading ruleset, in |loading ruleset, in |pf_ioctl_addrule sha |pf_ioctl_addrule sha |#4ffe410 |#4ffe410 Assignee|bugs@FreeBSD.org |pf@FreeBSD.org Keywords| |crash --- Comment #1 from Mark Linimon --- ^Triage: assign to pf@. While here, remove the [tag] information -- that was a hack for GNATS back = in the day. We use Bugzilla's Keywords now. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Nov 5 11:53:29 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SNXtd3Ky4z4ylNt for ; Sun, 5 Nov 2023 11:53:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SNXtd1PsGz3ZmP for ; Sun, 5 Nov 2023 11:53:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699185209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQM0q7psag4mXuLxnokVbP8Se30Nh+Dh1tNSDwTs0XM=; b=RCXME9vuG9yGpSh5vBsh/yCr6+WWCuFYeJ5kNbqLpyrdcsfEUx0Caii2PtvieWKH94wNqc 9zMUzWd5FkzMDfSee7KoiZ/CU+5//BuKBTJTBwWEA3ux2gz+y4v4LJKMSunBWIivVyqFda BLP4fuD8lHIDn1Rlay0EgPuyvxnsKgYHCAQrq5fdi1HLRSVJelWwrRmGcJGnK9RIxuZwIh S6MgJjiQLRNKP9nbzTurOZKOtFivexq0jp0TnQR+QZC+ga7g6g/Si+sPWDLTHyqpmwWCY6 cIL7E6aAZ1MeZz6ywjHAfgo5Rrz8pg6Vl+/9acDr0Y5hfJv2pjHdtRQItzYr4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699185209; a=rsa-sha256; cv=none; b=tBTe3D4Pldc1urt32daWAEcJ6Dtf9jOyAf0YamXGRHCclFp9jLNnr9FdtMuuoRRzR5Q0Bh Fx1Loc1AETbUL2ih8seIItBSfNKvwBRaXYeKpaq2XvoQJRQlXjnrK3N6morVX/SBCWxouS oSEfxue38uX/I2LknvXy/mej2josKrnxZDo7NM+f5a4hcw9XRCWe1jxExsSUQMP2Cop0rA eaoq3rZA2ylW/XI42t3gZ5FuAXS/s4ttW9vYbg1Wkc9EfF35yGpyhRvRBLsSPwF0b6wfuu mAp6ox62yn80TWT45QxUP4jJAbZJg5JA3Xl1KVcgGnw9HGtKXTq2DCMKo2UGNw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SNXtd0SrKz8lW for ; Sun, 5 Nov 2023 11:53:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A5BrTEj057866 for ; Sun, 5 Nov 2023 11:53:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A5BrT3k057865 for pf@FreeBSD.org; Sun, 5 Nov 2023 11:53:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Sun, 05 Nov 2023 11:53:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 Kristof Provost changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kp@freebsd.org --- Comment #2 from Kristof Provost --- Hi Dave, I've not been able to reproduce this yet. The attached pf.conf appears to h= ave been HTML-mangled, so perhaps I'm missing something in it. The rule addition code has recently been moved to netlink, so it's not at a= ll impossible that I missed something there, but it'll be easier to debug if I= can reproduce it. Failing that, if you can pass it though kgdb on your box and have that iden= tify the panicing line in pf_ioctl_addrule(), that might give a clue as well. (Basically, `sudo kgdb /boot/kernel/kernel /var/crash/vmcore.last`, and then 'bt' to get a backtrace, select the pf_ioctl_addrule() frame 'frame X', and= 'l' to get the source line.) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Nov 7 13:18:35 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SPpgv6dnsz502kW for ; Tue, 7 Nov 2023 13:18:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SPpgv5cjkz4NnP for ; Tue, 7 Nov 2023 13:18:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699363115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AvPCRc6/4WR4AfPwqUpaLVyTC2pQ447riinSZMDR9Fs=; b=jZ6CA4tKo0vc/LfY1Kaq9IkB4dCwjBVtPak5QsipPh53DQ6UWsQbAx0mC6ykDdw9Tr1lW8 GMQqjWZQBsCPXwzsuO/Xk8mFOvl1ERcFe6WHYAGa8U6RpJT2DIDh2AGG53VS8go+XRkrpc 8y1HgrDKTDSyamrPrui8ldYxUdYiERmLYTFkjCZuCUbJl//uVmcfnUA/AVY+7fwF8jhSgC O7Qhjv9X888rvvaCdUJHMcJDnHK5BSWqDL09ajS5JaACsGYrNMcJifO6Tw58iJQqPpkwKy ukBgrlNO5AohcnEW/mHLcXTBP7CI7t1bzwi67dXtTP3NaFmE2CzdIuDEZ9TuUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699363115; a=rsa-sha256; cv=none; b=qq3KKtzX/aVVl6CDpU9QJtqaAb0yTdyipXIdxBl6VgGcJ4XQNiFGxB48Nv0ZQcCOsSMftS pTNikk63zu9ripBi7Nf+zQwSMuCfCWoqQxJhKBRJX9af/tw5vSwl6Appm0/BqtbO6bq2Zt 8Gannd9EqoTcrGj/XlmHuw67OdjAM83HGE4xK48XDLVkKJrFi8IiPU12a6UTU+80UdFULs X8X5rpy8lLhJu/DnyHj87K8qE2tMmsOAexEhduP4nS0HK8JPEkM9vtGnA0amw1ziDz52fZ 0gmldkHCPkzJE1x4UD71Hw/vhoasOINhkapnELKe6o3P1GfmQqVtFUMrUsXTGg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SPpgv4bGXzrY3 for ; Tue, 7 Nov 2023 13:18:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A7DIZSR084827 for ; Tue, 7 Nov 2023 13:18:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A7DIZ2I084826 for pf@FreeBSD.org; Tue, 7 Nov 2023 13:18:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 273207] pf_syncookie_mac for IPv6 random cause panic Date: Tue, 07 Nov 2023 13:18:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: crash, ipv6 X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: sthalik@tehran.lain.pl X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273207 --- Comment #33 from Stanislaw Halik --- (In reply to Franco Fichtner from comment #31) The commit appears to be ae0512bb02ccd3d878b1d0cf6ee5c77942120a21 on stable= /13. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Nov 7 13:21:45 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SPplY5t1Xz50379 for ; Tue, 7 Nov 2023 13:21:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SPplY4qqlz4PKr for ; Tue, 7 Nov 2023 13:21:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699363305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M7LatRgg56FpwNklgtXX8gex0btDmH7VPr8QuGI9biE=; b=nzQuFnJnaQiaHAeC4ySKv0N519chQNcO4qWBc53vZJuat7RAX4Qk0rtmZ8cK5321cIbVwM wMI8YJnr0HlQFZLr5bWwFL8yy/iZb6Htcw8qK9WzoU2AN/bpfz7SGEpsHy+Q3dPXOAs6iM 0R0mQ5XGMv0PLjVPnISVORn9jIEMFb+v1zQnhFE37OkwUv/JAdmOhbfrsuZe1IAoQjrM69 vLSxltPxKd0FIfEP1WF3gP+WACAAV6nYVl6v9rWeFLpIg1HyNN3C9sPMtRb59kUryop0Pc yY93HalNRMb9QKp9+l3qItHGTsTv26c2q8BfJTvEWUDu65gJRd5geAS+L2zx7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699363305; a=rsa-sha256; cv=none; b=D3NaBQdLp9/o8h1hPsayAoj3tj3CwjieJFxan2+lB1TOrPf2AqdS8VRiGG3kXobJY2Wsy8 uy/beU8LCJ/vho2t65kAdFhsrjk0pr8eCQlTA68UwEpA5r8RYCMIw7SJzPa7krWzBp4QWw rG/oIFfmgIjxTxhPrB7IRHobiSTxDeRyl9E3J24cjuLf3prJtRx6Gkgbdrz7b74FjtzDo/ alOGw1J10LEJwrQuQp1iBAWcKWFn2ZUVkKgm8dcdGAjETSzQLTQn2SAreIxynJtuZmxOTZ WmNyd0+N33WUIy+EH/esXR4d8SwmCKhiEryhao6bxqlOazdhVA53auzczBWr0A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SPplY3wlPzsBP for ; Tue, 7 Nov 2023 13:21:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A7DLjNF095401 for ; Tue, 7 Nov 2023 13:21:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A7DLjMg095400 for pf@FreeBSD.org; Tue, 7 Nov 2023 13:21:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 273207] pf_syncookie_mac for IPv6 random cause panic Date: Tue, 07 Nov 2023 13:21:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: crash, ipv6 X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273207 --- Comment #34 from Franco Fichtner --- I'm sure the assignee can confirm and close. I suppose errata for 13.2-RELE= ASE is out of the question? --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Nov 7 22:58:13 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SQ3Xj47tkz4yYWD for ; Tue, 7 Nov 2023 22:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SQ3Xj2kbjz3C3w for ; Tue, 7 Nov 2023 22:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699397893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jftUxVzUaFoUEN1+oJiuR+dFW6aFyyl538Paxid/ITA=; b=qWLJFgbuA2DASHdIQ4tK42q9NmhoeA7k1Lsi1/hCiEL0oBHGgGYgBoBgceb8fOoEoPM14Z sDl+o9vM/OfNxZrZxzNp3k+BX/SX3FhNO7gOiDL6iFn7s16HuUv0k8Q6PIJ/fqopGv7WHB gnIXAZoCm2ec39CoXxmFBwuET/bcZPzKHMlyUumn3xNNvdR0RKFv3LFNqis6enLDJLQNyr LB23Vcx1jZncEi4D6+UHeQQW/ZYTXr9he6HcCcOW43oEbA8N0obrTg/QYQXPqloK1R6tWK 0zPcoE+NzQs9Ub4FfbOMX3xX9VWPpvqppgCCZ2WTJBmRdmBzg5vU3JVgEep5Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699397893; a=rsa-sha256; cv=none; b=qckplfwZk/R7pHYfZbsUbDHHWwNvx+BZG+eSUyA8wY0dDCebMk5mEJKSfenrc6azWf+OEb PNpHHDAWeg4Lxlq3waieBsX2Hvl/oj2nUt324/3F6O6kXS5prKPgbp9rL4xgswTSj+a6/k O2ADz58NQy6OZjt9EP6tfJzR8dD8LZc/C6FdfRNFhchkQJo9KBAdxvzk7oFvMR/1YAJpcQ FL69jk0AzqtVqgg9awjq9HvLVp71nF8lYDTFlyVXAyZtz76gUi7X7GTwo9E45rWUpqLH6P 6aYjaPzxmFc0t0WZ8/Co/gCOUJB+cyQ6HwXq0YkJR7QeZMYJK2cIlJo+CLywMA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SQ3Xj1jTtz17lZ for ; Tue, 7 Nov 2023 22:58:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A7MwDwj089805 for ; Tue, 7 Nov 2023 22:58:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A7MwDSF089804 for pf@FreeBSD.org; Tue, 7 Nov 2023 22:58:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Tue, 07 Nov 2023 22:58:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dch@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 Dave Cottlehuber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --- Comment #3 from Dave Cottlehuber --- (kgdb) bt #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:57 #1 doadump (textdump=3Dtextdump@entry=3D0) at /usr/src/sys/kern/kern_shutdown.c:405 #2 0xffffffff804a291a in db_dump (dummy=3D, dummy2=3D, dummy3=3D, dummy4=3D) at /usr/src/sys/ddb/db_command.c:591 #3 0xffffffff804a271d in db_command (last_cmdp=3D, cmd_table=3D, dopager=3Dtrue) at /usr/src/sys/ddb/db_command= .c:504 #4 0xffffffff804a23dd in db_command_loop () at /usr/src/sys/ddb/db_command.c:551 #5 0xffffffff804a5d56 in db_trap (type=3D, code=3D) at /usr/src/sys/ddb/db_main.c:268 #6 0xffffffff80b9c527 in kdb_trap (type=3Dtype@entry=3D3, code=3Dcode@entr= y=3D0, tf=3Dtf@entry=3D0xfffffe0268632860) at /usr/src/sys/kern/subr_kdb.c:790 #7 0xffffffff8102214d in trap (frame=3D0xfffffe0268632860) at /usr/src/sys/amd64/amd64/trap.c:608 #8 #9 kdb_enter (why=3D, msg=3D) at /usr/src/sys/kern/subr_kdb.c:556 #10 0xffffffff80b4d4b3 in vpanic (fmt=3D0xffffffff8114dead "%s", ap=3Dap@entry=3D0xfffffe0268632a90) at /usr/src/sys/kern/kern_shutdown.c:958 #11 0xffffffff80b4d343 in panic (fmt=3D0xffffffff816b6b98 "\020\3272\201\377\377\377\377\001") at /usr/src/sys/kern/kern_shutdown.c:8= 94 #12 0xffffffff8102260c in trap_fatal (frame=3D0xfffffe0268632b80, eva=3D0) = at /usr/src/sys/amd64/amd64/trap.c:952 #13 0xffffffff8102265f in trap_pfault (frame=3D0xfffffe0268632b80, usermode=3Dfalse, signo=3D, ucode=3D) at /usr/src/sys/amd64/amd64/trap.c:760 #14 #15 0xffffffff83710574 in pf_ioctl_addrule (rule=3Drule@entry=3D0xfffff80cd= c854800, ticket=3Dticket@entry=3D2, pool_ticket=3Dpool_ticket@entry=3D196, anchor=3Danchor@entry=3D0xfffff8014bb5c028 "", anchor_call=3Danchor_call@entry=3D0xfffff8014bb5c030 "", uid=3D, pid=3D0) at /usr/src/sys/netpfil/pf/pf_ioctl.c:2094 #16 0xffffffff83730750 in pf_handle_addrule (hdr=3D0xfffff8014bb5c000, npt=3D0xfffffe0268632dc0) at /usr/src/sys/netpfil/pf/pf_nl.c:631 #17 0xffffffff80d947fb in nl_receive_message (hdr=3D0xfffff8014bb5c000, remaining_length=3D, nlp=3D0xfffff80c49506e00, npt=3D0xfffffe0268632dc0) at /usr/src/sys/netlink/netlink_io.c:506 #18 nl_process_mbuf (m=3D0xfffff80164c27300, nlp=3D0xfffff80c49506e00) at /usr/src/sys/netlink/netlink_io.c:580 #19 nl_process_received_one (nlp=3D0xfffff80c49506e00) at /usr/src/sys/netlink/netlink_io.c:293 #20 nl_process_received (nlp=3D0xfffff80c49506e00) at /usr/src/sys/netlink/netlink_io.c:320 #21 nl_taskqueue_handler (_arg=3D0xfffff80c49506e00, pending=3D) at /usr/src/sys/netlink/netlink_io.c:371 #22 0xffffffff80bb2452 in taskqueue_run_locked (queue=3Dqueue@entry=3D0xfffff80c4cb46c00) at /usr/src/sys/kern/subr_taskqueue.c:512 #23 0xffffffff80bb36e2 in taskqueue_thread_loop (arg=3Darg@entry=3D0xfffff80c49506e60) at /usr/src/sys/kern/subr_taskqueue.= c:824 #24 0xffffffff80b0661f in fork_exit (callout=3D0xffffffff80bb3620 , arg=3D0xfffff80c49506e60, frame=3D0xfffffe0268632f= 40) at /usr/src/sys/kern/kern_fork.c:1160 #25 (kgdb) frame 15 #15 0xffffffff83710574 in pf_ioctl_addrule (rule=3Drule@entry=3D0xfffff80cd= c854800, ticket=3Dticket@entry=3D2, pool_ticket=3Dpool_ticket@entry=3D196, anchor=3Danchor@entry=3D0xfffff8014bb5c028 "", anchor_call=3Danchor_call@entry=3D0xfffff8014bb5c030 "", uid=3D, pid=3D0) at /usr/src/sys/netpfil/pf/pf_ioctl.c:2094 warning: Source file is more recent than executable. 2094 tail =3D TAILQ_LAST(ruleset->rules[rs_num].inactive.ptr, (kgdb) (kgdb) l 2089 */ 2090 if (ruleset->rules[rs_num].inactive.tree =3D=3D NULL) { 2091 ERROUT(EINVAL); 2092 } 2093 2094 tail =3D TAILQ_LAST(ruleset->rules[rs_num].inactive.ptr, 2095 pf_krulequeue); 2096 if (tail) 2097 rule->nr =3D tail->nr + 1; 2098 else (kgdb) I bumped my src repo today for $WORK but its not a big jump. Easy enough no= w to repro with your steps above, thank-you! --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Nov 7 23:06:02 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SQ3jl099pz4yZmQ for ; Tue, 7 Nov 2023 23:06:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SQ3jk5XRhz3D8Y for ; Tue, 7 Nov 2023 23:06:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699398362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u3S1W8vp8TZaCZn82rw9GXJhLwDIAb+OA0FiheHF3bw=; b=X3ADiNFDBpd1RIXS18IEzq1ka5JicTfuSbvx3yEnv9bQJYGdPms9gs3dXEL6p/x+0hI8Cq vj9mOyZ3LvYfURfxZs8BhgDvRkKPX1yidQ2ANQ48n8+WinPa1YPCNLWVHDh6A7xMZpmkqd nUZexm5DlDRDgvDaHaceiDfwL1PaDS1mpmxMBSrnm9OsNYqfYk1GRUjj3An8j3XxUQrKSc rYS/jMzFUFAnTYFRRe+7yYBaRU0FuQ6yLEeQ5GVvt22SNVR9gShn2RmtJwmtPXPDcOBIIK t2IUu5vjdUrAp3MMGqeqqRCNnUHW/pTsfcluOOfc8Y1Qa/pbZKh1HebzWBfePg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699398362; a=rsa-sha256; cv=none; b=ZKtg/uxy1fEuHhtPkYmo5Rhzu7EHJNixYzF92hiHrqN3H4DLEYHLJZw+xzpo3InTNWi/5X d95Xo5C6kP4gIcS8/oODWkTw3Ttz2vvRn1HNJgERBmwhYjNvvJbajRCLUUTYjggWPDDyRr QFb6FoMI7JWadmrUwY5BJjDpuZvZ2eaokih1wTkuJp3IBUJn4Wfv4Ske96B6C1Jlp1SFZs Lu89oNFdxffi0eocMpVi3bAV19SSg4YC/KFVprgM9pQHAeD1yTc40ec4p85hoGmAGqDlFJ Z9t/fiAHYcyTAjHFerc45yxvkOVXgLW3ATRDD7X+sypPsRyL6UQXHFikv7mgEg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SQ3jk4Vcwz17jx for ; Tue, 7 Nov 2023 23:06:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A7N62CZ006160 for ; Tue, 7 Nov 2023 23:06:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A7N62dg006159 for pf@FreeBSD.org; Tue, 7 Nov 2023 23:06:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Tue, 07 Nov 2023 23:06:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 --- Comment #4 from Kristof Provost --- (In reply to Dave Cottlehuber from comment #3) Can you also try printing rs_num, ruleset and ruleset->rules? (p rs_num) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Wed Nov 8 07:16:38 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SQGbp4qbmz50DYh for ; Wed, 8 Nov 2023 07:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SQGbp12DPz4GTH for ; Wed, 8 Nov 2023 07:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699427798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWjjldD1bNcX5VlgRA7+WHbcGS1O+VsEpKWCYVhQy8E=; b=P5w7cHjYvtOTJlZwn2nwqN5B4fNe9AYeQ2cTHH3jwCbb3V7aXhGTbTfFJsyNOA7o/Aknj/ qOJqrJyDsNB7n6vYl+JKMqOlpZrtkK4AX1G0B8j4Jp+AnucPkfOw1U+ICqw2/dpcrecKiw bb3zwi8dOe1eRfl9+WVpZ/goNuL2aS5UMAkLmNvrieG2BRzAFsO76hyCNWRx5KgLV72GgK Z79BZjS6c8YMSqr5qymjqkSUNZdAMa+GczqHnrryiLzqAgVgbnzsO9CJ+j/nLhHEHZ73Sq L5nJxphRy+P0VtfxjrTKnD7boxwFb75KK3Gi4c6xKtvMQwRVFg/YXZ9jjmAhDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699427798; a=rsa-sha256; cv=none; b=YrQt0XWc9Pdd4WOHaCh0/u+YOgKxgvTS+V42d0D+1zuQjefLEoZYdUw3CtjiSnFuDeONqv ix7ra5V8MnR18meL19oK/+6FvF7zdN1w/GdqV2BlHbO7lLTikzrQWGTA34sVyQq3aRPhGs aCb/uD2FKZV0TUeRr5ELeCqHYYbVWwtIo8ApNablBVgqNBVHpcgtwinOjsqChRz7MKq4q/ CjZQvhABWTV9mjYr8sUSU5zVeBAUNll8nVwKaEw4Nk17AmOXe+RVx+PNdjWOVYqe9ESVzI uB48KzB3/La9WvCD/kodpxzK0PzPzQ+4dmLyh3fA4b/wKnCev51fH7rCk9+NVA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SQGbp07Fnz89h for ; Wed, 8 Nov 2023 07:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A87GbYJ072532 for ; Wed, 8 Nov 2023 07:16:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A87Gbha072531 for pf@FreeBSD.org; Wed, 8 Nov 2023 07:16:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Wed, 08 Nov 2023 07:16:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dch@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 --- Comment #5 from Dave Cottlehuber --- -- redone with src & core matching again https://git.sr.ht/~dch/src/commit/c6fd7e65435a3ea7184bbeb0e0138a4daf6d80e6 (kgdb) bt #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:57 #1 doadump (textdump=3Dtextdump@entry=3D0) at /usr/src/sys/kern/kern_shutdown.c:405 #2 0xffffffff804a2a1a in db_dump (dummy=3D, dummy2=3D, dummy3=3D, dummy4=3D) at /usr/src/sys/ddb/db_command.c:591 #3 0xffffffff804a281d in db_command (last_cmdp=3D, cmd_table=3D, dopager=3Dfalse) at /usr/src/sys/ddb/db_command.c:504 #4 0xffffffff804a2966 in db_command_script (command=3Dcommand@entry=3D0xffffffff817b5724 "dump") at /usr/src/sys/ddb/db_command.c:569 #5 0xffffffff804a7f58 in db_script_exec (scriptname=3Dscriptname@entry=3D0xfffffe026a44e520 "kdb.enter.panic", warnifnotfound=3Dwarnifnotfound@entry=3D0) at /usr/src/sys/ddb/db_scrip= t.c:302 #6 0xffffffff804a7d82 in db_script_kdbenter (eventname=3D) = at /usr/src/sys/ddb/db_script.c:324 #7 0xffffffff804a5e51 in db_trap (type=3D, code=3D) at /usr/src/sys/ddb/db_main.c:267 #8 0xffffffff80b9c627 in kdb_trap (type=3Dtype@entry=3D3, code=3Dcode@entr= y=3D0, tf=3Dtf@entry=3D0xfffffe026a44e860) at /usr/src/sys/kern/subr_kdb.c:790 #9 0xffffffff8102214d in trap (frame=3D0xfffffe026a44e860) at /usr/src/sys/amd64/amd64/trap.c:608 #10 #11 kdb_enter (why=3D, msg=3D) at /usr/src/sys/kern/subr_kdb.c:556 #12 0xffffffff80b4d5b3 in vpanic (fmt=3D0xffffffff8114decf "%s", ap=3Dap@entry=3D0xfffffe026a44ea90) at /usr/src/sys/kern/kern_shutdown.c:958 #13 0xffffffff80b4d443 in panic (fmt=3D0xffffffff816b6b98 "\320\3312\201\377\377\377\377\001") at /usr/src/sys/kern/kern_shutdown.c:894 #14 0xffffffff8102260c in trap_fatal (frame=3D0xfffffe026a44eb80, eva=3D0) = at /usr/src/sys/amd64/amd64/trap.c:952 #15 0xffffffff8102265f in trap_pfault (frame=3D0xfffffe026a44eb80, usermode=3Dfalse, signo=3D, ucode=3D) at /usr/src/sys/amd64/amd64/trap.c:760 #16 #17 0xffffffff836de574 in pf_ioctl_addrule (rule=3Drule@entry=3D0xfffff80c1= 342a000, ticket=3Dticket@entry=3D2, pool_ticket=3Dpool_ticket@entry=3D196, anchor=3Danchor@entry=3D0xfffff80cbe561028 "", anchor_call=3Danchor_call@entry=3D0xfffff80cbe561030 "", uid=3D, pid=3D0) at /usr/src/sys/netpfil/pf/pf_ioctl.c:2094 #18 0xffffffff836fe730 in pf_handle_addrule (hdr=3D0xfffff80cbe561000, npt=3D0xfffffe026a44edc0) at /usr/src/sys/netpfil/pf/pf_nl.c:631 #19 0xffffffff80d94aeb in nl_receive_message (hdr=3D0xfffff80cbe561000, remaining_length=3D, nlp=3D0xfffff80161e77300, npt=3D0xfffffe026a44edc0) at /usr/src/sys/netlink/netlink_io.c:506 #20 nl_process_mbuf (m=3D0xfffff80193368a00, nlp=3D0xfffff80161e77300) at /usr/src/sys/netlink/netlink_io.c:580 #21 nl_process_received_one (nlp=3D0xfffff80161e77300) at /usr/src/sys/netlink/netlink_io.c:293 #22 nl_process_received (nlp=3D0xfffff80161e77300) at /usr/src/sys/netlink/netlink_io.c:320 #23 nl_taskqueue_handler (_arg=3D0xfffff80161e77300, pending=3D) at /usr/src/sys/netlink/netlink_io.c:371 #24 0xffffffff80bb2552 in taskqueue_run_locked (queue=3Dqueue@entry=3D0xfffff80c09004a00) at /usr/src/sys/kern/subr_taskqueue.c:512 #25 0xffffffff80bb37e2 in taskqueue_thread_loop (arg=3Darg@entry=3D0xfffff80161e77360) at /usr/src/sys/kern/subr_taskqueue.= c:824 #26 0xffffffff80b0671f in fork_exit (callout=3D0xffffffff80bb3720 , arg=3D0xfffff80161e77360, frame=3D0xfffffe026a44ef= 40) at /usr/src/sys/kern/kern_fork.c:1160 #27 (kgdb) frame 17 #17 0xffffffff836de574 in pf_ioctl_addrule (rule=3Drule@entry=3D0xfffff80c1= 342a000, ticket=3Dticket@entry=3D2, pool_ticket=3Dpool_ticket@entry=3D196, anchor=3Danchor@entry=3D0xfffff80cbe561028 "", anchor_call=3Danchor_call@entry=3D0xfffff80cbe561030 "", uid=3D, pid=3D0) at /usr/src/sys/netpfil/pf/pf_ioctl.c:2094 2094 tail =3D TAILQ_LAST(ruleset->rules[rs_num].inactive.ptr, (kgdb) l 2089 */ 2090 if (ruleset->rules[rs_num].inactive.tree =3D=3D NULL) { 2091 ERROUT(EINVAL); 2092 } 2093 2094 tail =3D TAILQ_LAST(ruleset->rules[rs_num].inactive.ptr, 2095 pf_krulequeue); 2096 if (tail) 2097 rule->nr =3D tail->nr + 1; 2098 else (kgdb) p rs_num $1 =3D (kgdb) p ruleset $2 =3D (struct pf_kruleset *) 0xfffffe00d69e4078 (kgdb) p ruleset->rules $3 =3D {{queues =3D {{tqh_first =3D 0xfffff801616ea000, tqh_last =3D 0xfffff801616ea328}, {tqh_first =3D 0x0, tqh_last =3D 0xfffffe00d69e4088}}, active =3D {ptr =3D 0xfffffe00d69e4088, ptr_array =3D 0x0, rcount =3D 0= , ticket =3D 1, open =3D 0, tree =3D 0xfffff80c850ea4d0}, inactive =3D { ptr =3D 0xfffffe00d69e4078, ptr_array =3D 0x0, rcount =3D 1, ticket = =3D 2, open =3D 1, tree =3D 0xfffff80193841180}}, {queues =3D {{ tqh_first =3D 0xfffff80be2d45000, tqh_last =3D 0xfffff80c1342a328}, {tqh_first =3D 0x0, tqh_last =3D 0xfffffe00d69e40f8}}, active =3D { ptr =3D 0xfffffe00d69e40f8, ptr_array =3D 0x0, rcount =3D 0, ticket = =3D 1, open =3D 0, tree =3D 0xfffff801617f8f60}, inactive =3D { ptr =3D 0xfffffe00d69e40e8, ptr_array =3D 0x0, rcount =3D 150, ticket= =3D 2, open =3D 1, tree =3D 0xfffff80a1889d4f0}}, {queues =3D {{ tqh_first =3D 0xfffff80a182e4800, tqh_last =3D 0xfffff8016b176328}, {tqh_first =3D 0x0, tqh_last =3D 0xfffffe00d69e4168}}, active =3D { ptr =3D 0xfffffe00d69e4168, ptr_array =3D 0x0, rcount =3D 0, ticket = =3D 1, open =3D 0, tree =3D 0xfffff80a188a4640}, inactive =3D { ptr =3D 0xfffffe00d69e4158, ptr_array =3D 0x0, rcount =3D 18, ticket = =3D 2, open =3D 1, tree =3D 0xfffff80a1889d5b0}}, {queues =3D {{ tqh_first =3D 0x0, tqh_last =3D 0xfffffe00d69e41c8}, {tqh_first =3D= 0x0, tqh_last =3D 0xfffffe00d69e41d8}}, active =3D { ptr =3D 0xfffffe00d69e41d8, ptr_array =3D 0x0, rcount =3D 0, ticket = =3D 1, open =3D 0, tree =3D 0xfffff80c850ea4e0}, inactive =3D { ptr =3D 0xfffffe00d69e41c8, ptr_array =3D 0x0, rcount =3D 0, ticket = =3D 2, open =3D 1, tree =3D 0xfffff80c850ea490}}, {queues =3D {{ tqh_first =3D 0xfffff80be2d3f800, tqh_last =3D 0xfffff80be2d3fb28}, {tqh_first =3D 0x0, tqh_last =3D 0xfffffe00d69e4248}}, active =3D { ptr =3D 0xfffffe00d69e4248, ptr_array =3D 0x0, rcount =3D 0, ticket = =3D 1, open =3D 0, tree =3D 0xfffff80cac818520}, inactive =3D { ptr =3D 0xfffffe00d69e4238, ptr_array =3D 0x0, rcount =3D 1, ticket = =3D 2, open =3D 1, tree =3D 0xfffff80a1889d530}}} (kgdb) btw see you on irc for faster RTT --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Wed Nov 8 15:06:14 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SQT1f6lyZz4yxr0 for ; Wed, 8 Nov 2023 15:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SQT1f5Jh1z4SjV for ; Wed, 8 Nov 2023 15:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699455974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KI5otXkrvcsyCAaCcGJfUPC36etUaGtQTZtXlAQPqvg=; b=n60pEzvcRmtiFQkaqVVtDVjV1S2RRk3OItxi3t3vPce75gfiWBcw9xwaZevaGX+hib2eIN U+8hmojL+Jn+yQ0HEMSyXotcUNfTqtW9Kh2WltdiS2gF94EAhmEmvI2EB4eGQJkA3++Vw6 cx0lx95UZFF9/bb5l6e4jjzGv17+A/ZpdcPuRl+zlojyZb8PeYWxK1FHmg1I+C9qlM742S sUaKcI4Atew/6pCFvGFAcMescGxSMI96OSxiT2XT3lwd9rZEaTnTZkQrDWrgdta526nCBw cdtu5vRqgLx2OfyEqpaH1TMyDJDlPgOkLGO5nvZJJnSRnuSt3/2pfxlhvU0vYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699455974; a=rsa-sha256; cv=none; b=FHw7j8jIACzP+rxurlyyKV8oA771BNA95DnFoMLRm/L1BveFQCfyr15ClBnxjFJFZA2cjS T3yxzzUUO1S5yg361mbZkjKSWNCoaHnQohr/qqPr3ruL+uUAyysRWICcaSIdrIatoWYdjV YFlE5aV+zQn4K/PlgBPqJ/EhXJfDr2INE1rACvDqoyOiF/6n37tTfdDpEP6UcK3JEmxe5d wyNY78bjYDeaIVaJogw0pGi179rrEdd5K78Z3XdMsuLRsOuiBwKku29+zucJFNPF32ls7r hxUF4li+b/zMsYmIHdVtNiMvVs5SGI/IrRoRIfvmOj50e/JWMftlgkX8y8hnFA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SQT1f4MMrzdQT for ; Wed, 8 Nov 2023 15:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A8F6EE1018708 for ; Wed, 8 Nov 2023 15:06:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A8F6EZx018707 for pf@FreeBSD.org; Wed, 8 Nov 2023 15:06:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Wed, 08 Nov 2023 15:06:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dch@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 --- Comment #6 from Dave Cottlehuber --- Created attachment 246199 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D246199&action= =3Dedit kp's fix perfect. thanks! --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Wed Nov 8 21:56:37 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SQf794tgQz50S7H for ; Wed, 8 Nov 2023 21:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SQf793T3rz4cHx for ; Wed, 8 Nov 2023 21:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699480597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OJmoaHL6DwtUNS497nccKZfU8RsH7BzPlIvlmks4Lsk=; b=mMYWcetrQObIgFfMEQgcCQb45HX0p+YJGJHGhh4t2tcy5gHHQuW05vCgw7GttWJqu13AbW 5OrxrYOtHI0lwaNafsqAzSpKKn16wS2s/v6nX6Yq/lpy0MEkZ3ecTGPYYCb1KvRmDpq3G5 ypw3baXnbKVFeT1Sda8TWQq3EIQuIY5JtaW0cW6r08Dr3M+NaAtNJ+rRcmlcaTNOpOtvOG jIEikVOHgmMa6ybSYnD/Gb3n6TPf0HxchiUSTor70f4QYKg6uOUoKgojZHR3fq9hGDBKl5 wm6oRktFfUdBHNYIIpqgdxr43nC10JU3kJnJbs4hrI65gmUg7w8i46m8rtZBvw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699480597; a=rsa-sha256; cv=none; b=J3Kq2JROUVunMHPfHuqhhXdGyPIoNYKyIQetkI22aJUA283FJh1GAG3EY7wOkYFfd5XCI2 x9WsKbrTNEmKek3SgUQcPM8ZkK5BY6FApYuOHlxPQ40HTsgQfcVOuPTfEGGqiD0lfESt+i lbM8CCbjsPeBPp7sCwiw0IyVsA0V4cGEd/tufRRdNTT9uI3ZFsahbYPl8v+cBMGjnnhJc6 p/PyXdWleSvWBFFa+DzaQ83jgJWUtcJPr9ZBaw9XJaL7xqX/7m5ij/8B0dwSJokDSwMdEN fWf9PdwvA4zlgN70bCGtSe29rtNYj+Aup3oGWc3mygTrgHaUqUZw5JZHYysj1g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SQf792S8dzphM for ; Wed, 8 Nov 2023 21:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A8Lubsn067002 for ; Wed, 8 Nov 2023 21:56:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A8Lubdh067001 for pf@FreeBSD.org; Wed, 8 Nov 2023 21:56:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Wed, 08 Nov 2023 21:56:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Da6246a50b63450d0fe34e3429807bd5ab= a8cc2ac commit a6246a50b63450d0fe34e3429807bd5aba8cc2ac Author: Kristof Provost AuthorDate: 2023-11-08 14:06:15 +0000 Commit: Kristof Provost CommitDate: 2023-11-08 20:58:52 +0000 pf: fix double free if pf_ioctl_addrule() fails If pf_ioctl_addrule() returns an error it will have freed the rule itself. There's no need for the caller to free it again. PR: 274915 Reported by: Dave Cottlehuber MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") sys/netpfil/pf/pf_nl.c | 3 --- 1 file changed, 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Thu Nov 9 14:40:12 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SR4P84rxfz4yw51 for ; Thu, 9 Nov 2023 14:40:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SR4P8344Wz3Qgp for ; Thu, 9 Nov 2023 14:40:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699540812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2xJygMQWzuiue6DL5QLqMB3I/ZPC+Gty90oTO4W/GaM=; b=U0LZ1PxGZ9SMbScqI5aEBg6uSk2I4SYIFKQEQA/wfri33aw5f9YUjMde83nd+4Y9WD/DI9 BKtHeRqPtse5VguQuh9wk43vRyzPDZwLMhYY+YazN5QHsP0ozyTQGjqD5SdK+DvoTtlrSu q41JKIip+i9Jt+/A1X+R3pAPRYMpRbYcq6igdVQ2qrrrSS3mqkfsY0iCxBH4cE87YNva9U g3Nm0gWaxBd2xMID99F3Z+WxlDiOzTrmRy7lRjauJisFGsH7YC/1DfIiDF0UWhRiHvE11S GL1qlI5Tv4miSzpMMzv2yOjwjc0p2Fyj30vcLomj/d/2c2H0QLLsRWm49kSx4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699540812; a=rsa-sha256; cv=none; b=QLiuW5o/F5ii+lmZYSJ2ftkCj0dww5QkpJxM1Xk8S8RQRDUOS8j+gUtaEHidh3Oog7YOwX mS6wedJU5FO6XIgMsvUTqT19T+MocNcsAAaNB7oGpDSavV0W49vR7jmYZ2teU6oOlBtKq/ MWYx+vGLFLX6nG5XR9tkybztoBt7E7K6z/aqNJ3dH+okldF99S73kdhY8LqMgy/lpvCQn8 +91keK+bu0xEXfQaEfUob7DNhKj1ViQDOvm8JXweSxeYELruLTxOFGH7wlKfLnMJUPobTm V3M8FKRrrdWUU+9X3Ug48zUBdFimr+zCreHGrU6h9LEhlBWQzsRzU5eJYU0HMg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SR4P827Kgz4cN for ; Thu, 9 Nov 2023 14:40:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A9EeCkO036915 for ; Thu, 9 Nov 2023 14:40:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A9EeCvJ036913 for pf@FreeBSD.org; Thu, 9 Nov 2023 14:40:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 272770] "divert-to" rule creates packet loops on all FreeBSD 11.0 to 14.0 CURRENT versions Date: Thu, 09 Nov 2023 14:40:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272770 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2f3f9c9d54bb274dfb5de40f4ce7ca944= d4e05a5 commit 2f3f9c9d54bb274dfb5de40f4ce7ca944d4e05a5 Author: Igor Ostapenko AuthorDate: 2023-10-19 10:12:15 +0000 Commit: Kristof Provost CommitDate: 2023-11-09 09:55:45 +0000 pf: fix pf divert-to loop Resolved conflict between ipfw and pf if both are used and pf wants to do divert(4) by having separate mtags for pf and ipfw. Also fix the incorrect 'rulenum' check, which caused the reported loop. While here add a few test cases to ensure that divert-to works as expected, even if ipfw is loaded. divert(4) PR: 272770 MFC after: 3 weeks Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D42142 (cherry picked from commit fabf705f4b5aff2fa2dc997c2d0afd62a6927e68) sys/netinet/ip_divert.c | 31 ++- sys/netinet/ip_var.h | 10 + sys/netpfil/pf/pf.c | 32 ++- tests/sys/netpfil/pf/Makefile | 4 + tests/sys/netpfil/pf/divapp.c (new) | 149 ++++++++++++ tests/sys/netpfil/pf/divert-to.sh (new) | 413 ++++++++++++++++++++++++++++= ++++ 6 files changed, 625 insertions(+), 14 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Nov 10 06:41:00 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SRTjm0cw3z50VB5 for ; Fri, 10 Nov 2023 06:41:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SRTjl60MHz4TMg for ; Fri, 10 Nov 2023 06:40:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699598459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nHzY1MjnEl3agZo/MfzhbvPk+Sx26+qZxZ+zzeYfmQg=; b=fxvIDZEridjuwPhFEtOLbl65jIoMPFgARyohlwZv8kOWcrRJh2KB8+kd+4vwAcSFhkR0Ay uXoRDmmTcUqqJkLQ+4U9d4yRjVo+LVC7H7phOFRlQb8oljhNkkiBjxhIwfHMdpmuzQkvx5 vwOJWCcDgOrBepowbgV9lDwPVwYZmgLZQjrTcYuU4frPYCHm7ST6fQdx///J/5NSZ5q90X HpY+CceaUxtu2EB2zpm7tiDR/LaBao5Rz2YsGsx44MBRIqj36FajmBtWBhpUKXWJE8Tut5 Ekj6s+vLf+Sz3AAyCAzJpPPlX5zGd1W0QBDm2PwdUjnAqxCqgO95dKcuLrbZTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699598459; a=rsa-sha256; cv=none; b=ltLzNGXNUROgUCzIIP1gQVIpBmXgnhoXlsa2olQZVuVa7VTInQ5fKEqLku+PXiCoh1WY5H 8gXsSNE+4NBGlsXLBta1IjAxxNNSFbZzN9/n9jhlxVxomXKCleGFEDqZNzcfNMKyzEnkMS gxoradPOSTlBHJg5hB535o6FUCo9MJlzrTGLV8Q+n+iNIAx6z3RkMTiexWB9i7qXmWkp1z NSN9jXO2mL7zy8o4Z2fLmhu0EGM/RsbB3atIXG2mBHsENrSXg4EZQ9gg2x9S0kRjmsOw3b Ds0hHQqXB6bt52Ttg+oog/tkRiSwCHPUPKCQhjml+XwhRe/2Ec9erk3PFSlaLg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SRTjl54S8znd5 for ; Fri, 10 Nov 2023 06:40:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AA6exNv068926 for ; Fri, 10 Nov 2023 06:40:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AA6exEu068925 for pf@FreeBSD.org; Fri, 10 Nov 2023 06:40:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Fri, 10 Nov 2023 06:41:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dch@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 Dave Cottlehuber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Progress |Closed Resolution|--- |FIXED --=20 You are receiving this mail because: You are the assignee for the bug.=