Date: Sun, 7 May 2023 20:29:08 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> To: stable@freebsd.org Subject: Re: etcupdate created empty files = system unbootable Message-ID: <0ff15452-ea25-d72e-58ae-6ed526b2615c@quip.cz> In-Reply-To: <004e8a85-7bc1-6b33-8a42-70d7b43f9497@quip.cz> References: <312ae63f-4fab-e194-c603-a85fd11f6edd@quip.cz> <bae5d97b-42af-48a6-abf8-ff88ac19c62e@app.fastmail.com> <0db3bbf1-9e98-d721-c734-fdfe2483cbf0@quip.cz> <95169DC0-5DB6-41D1-8B04-5A450094529F@FreeBSD.org> <19399711-4a71-7025-7ceb-8dd481ec0038@quip.cz> <7afb4128-3eef-f2d9-07c0-035a237cba45@quip.cz> <004e8a85-7bc1-6b33-8a42-70d7b43f9497@quip.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/05/2023 09:33, Miroslav Lachman wrote: [..] > As you can see, cp failed, but etcupdate continued without any sign of > error. > cp failed because I did installkernel & installworld without rebooting. > I have never run into a problem like this in the past, but I understand > the reason - running the new 13.2 binary "cp" on an older 12.3 kernel is > not supported. > > > However, there is a bug in etcupdate which causes it to continue > silently instead of stopping when the first copy fails. > > This function needs to check the return status of cp and not blindly > return 0 even if the copy failed. In other words, the function > install_new() does not do what the comment says. This needs to be fixed. PR 271287 with attached patch https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271287 Kind regards Miroslav Lachman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0ff15452-ea25-d72e-58ae-6ed526b2615c>