From nobody Thu Jun 8 16:20:22 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QcTvq681jz4bwl7 for ; Thu, 8 Jun 2023 16:20:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QcTvq50bXz3BvS for ; Thu, 8 Jun 2023 16:20:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686241223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dvqg8X6rrGDXQWg6EdlFMpa9OIy+wgpGMukz23H18dc=; b=Y0UQqd0HJzmwb/2mHn4z8OxsGb03/7x9dSY7kC0iVrkLxTXxX5vcg0YszFd/mKYpQtJep9 CcYkss5nMQP0VX/RAhy8YJO8j5uKpIIW5QzPMvuplAWGbK74zLhpcPDAjYwoRKqG3dnErL 5PfpIuQxa+lBSuRunrrOfgBD99MSq0E7ERLyqJJHNZobOU3Bqw3N38ZwW78uvaqBc01oFM ETJWbPlWyhy63kgkwT9f1dh3IX4D/zzg7L+mErcIJzI/cGXh78Js5OovFfC9slE0VuTE3T /uZpxEt15rKxPewmQK/4FBmOPEnVDYOy0Czj4J1fNG9q65o8BJyK2/stQhpxVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686241223; a=rsa-sha256; cv=none; b=dswCjLATfMMqXDvxy2lyDGgc6vuVoEd4n5lylPoEfa5WXQ+bRcDir9FD+FoEy66X1EIA7E 2Ome8HpxexPZ5PQOFfOvl7JcWfl7qSiDG2wAb4ey0hvcRG3/+TxFQMveeSzS1ZIvtgvkZ6 ZLRT5sCssCu4IFx6/dJO+Q11lHFl8StzMFzAq74rA7/De1CGWP6FG+bWovk2lWY/xdEyc8 x9E9d2Acjlih5Nws69la+a8V6+0dRayy8y5f38gEGwzbuHN9adKgpQGbnNdyqamAZf9qJH FvM1iVGGT7xGySZvENV8LoJayWsQkyhyz2Xa0KuGS3TXKCgXMvXzgMzDv4nTMw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QcTvq3jnxz11Q4 for ; Thu, 8 Jun 2023 16:20:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 358GKNvp021637 for ; Thu, 8 Jun 2023 16:20:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 358GKNma021636 for virtualization@FreeBSD.org; Thu, 8 Jun 2023 16:20:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 271782] VM crashes with: bhyve exited with status 0 Date: Thu, 08 Jun 2023 16:20:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271782 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org --- Comment #1 from Mark Johnston --- "bhyve exited with status 0" just means that the guest rebooted. See the "= EXIT STATUS" section of the bhyve man page. Without some more diagnostics from the guest, or a reproducible test case, I don't see how this can be tracked down. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Jun 11 21:00:41 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QfRzt4GpJz4d4NG for ; Sun, 11 Jun 2023 21:00:42 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QfRzt1lsPz3jMx for ; Sun, 11 Jun 2023 21:00:42 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686517242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XLbwJl8KIOgZGiuF+7I4/oBuBEFCcmyWCsyRVKKyhtQ=; b=JF5CDLYSWKWUNWYX1zeOB+2ahNaaqHvpQd+v+nbamBahL/YheykKWG1ultlLS+bircaf/6 fpvmXnNVgi2hjngvMb1qnML+WeOKT++Fy0FRV6f4uPnjkehWrwBqfy8VNmxj/1r/a7lH0O UaXOwPUVN+QOqLruTqEEpdk+dpugJeqoDx67rKPX4+CXEeE2SsJld1QLRMCu90lc8sBcKP SPpt6K5jKUMF0F1zi+41XyFztHgTVm7FFI6/FIxRrp8ed+ccZaWrwHQ82fkYzX6UG4JMOx VfwDZb9IU/rXDUYiRE1URD+4iWDAfwfg20FyQ7ZPZLkeWGnLEj/SMQPLzkAdrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686517242; a=rsa-sha256; cv=none; b=F3+ALujkiwl7IQbTRwq6WthUexBSErwORg4J3n/kH2QNMOf3LdqZDyZj8rB/GP0EqQtQYg hL9uj6HX2Y8kz2urwLY53qQ37FVvwWUe9R2IMzT24F7lseSuh4U5OO3hRcUsqYR8Hy3TXy UWNHIlD6kVfOzpUooMP6Kq0n2+PxwI4hpPHFq66HO/xmG3waxWtSZ63OByrjfe013vcIT4 0gKA7AF0ZBMQW8ZCgI7Ild2n/989FA1vo14zspORQd0r4iaURP12ZeDifxrcX8l7PDQ7mU wuK2eJytYnOt2Q5Bpv8JMZGkSwpul7btIa1FtUk+OC6mtxpsAR+XTwEX4+rRbg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QfRzt0PKLz1ChJ for ; Sun, 11 Jun 2023 21:00:42 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35BL0fFg016090 for ; Sun, 11 Jun 2023 21:00:41 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35BL0fj3016089 for virtualization@FreeBSD.org; Sun, 11 Jun 2023 21:00:41 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202306112100.35BL0fj3016089@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: virtualization@FreeBSD.org Subject: Problem reports for virtualization@FreeBSD.org that need special attention Date: Sun, 11 Jun 2023 21:00:41 +0000 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="16865172410.651bdfB6.13475" Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N --16865172410.651bdfB6.13475 Date: Sun, 11 Jun 2023 21:00:41 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 247208 | mpt(4): VMWare virtualized LSI controller panics New | 240945 | [hyper-v] [netvsc] hn network driver incorrectly Open | 244838 | "bectl activate -t" does not honor the -t flag in 3 problems total for which you should take action. --16865172410.651bdfB6.13475 Date: Sun, 11 Jun 2023 21:00:41 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" 
The following is a listing of current problems submitted by FreeBSD users,
which need special attention. These represent problem reports covering
all versions including experimental development code and obsolete releases.

Status      |    Bug Id | Description
------------+-----------+---------------------------------------------------
In Progress |    247208 | mpt(4): VMWare virtualized LSI controller panics 
New         |    240945 | [hyper-v] [netvsc] hn network driver incorrectly 
Open        |    244838 | "bectl activate -t" does not honor the -t flag in

3 problems total for which you should take action.
--16865172410.651bdfB6.13475-- From nobody Mon Jun 12 05:37:48 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QfgSX2sXyz4ctxd for ; Mon, 12 Jun 2023 05:37:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QfgSX0Jm8z40qF for ; Mon, 12 Jun 2023 05:37:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686548268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ndhJDdUW7iq917moD98L3VkcC55dia0b8uSRBHxbniM=; b=Z5+b84M4082U7gLMYJJdOJiQxqnEDXQmMqbScxvuy4ZssL3nWXdm8unv2KhcYngiC+WEfO XoA6Fb5gqo71jLdVHflMTZ+zNgnNldvLyP8hHnSWKPjWR0LIJi/HfjrfvkV1l67/Onxb1y ezbPO2oWgXv1VhrMMqTb9dlzFjhUbpYgdN3NQ/knteTbxKRnMOObQTTYIKLtY1MJLJNZpH klAWzoycLJrAo25qWWnKCZ8IM1V3ulvvFcXV1CA819e20KeAyZNHPG/VXGFN0o7mLW4RKw iL/lhklQFrJ70RfTnkDNF+9C9+T2aOogCNKJ6CdR5LVEtolXhLqbjrHMdWLShQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686548268; a=rsa-sha256; cv=none; b=xLt9FTTDytZwKvTKpOMsdLOry1jPcYZFiLG53GkUPiGpwGlZC54O2XpPuLrONOzZb1r1eZ w8BM/ETse5n9q8CJIFEs9kEuBcfqchHVubiEELniW09fEl3P+GH3lppRcaiWdOa+2qQ2EO y36Wb/avV5VhuCA8yX74ibErQ9dqH6apzaUwGs7k+rVl0v93hB1zWoEgumKIQz9eVn7xO+ lHnGx4An1KFs4vhQ9pVG2sr2bSeG/Cr9atmri+KR0lLUaPqouxed3M6/Wy4IlyGtZ1QGkP brgU91U10t6T8z9WANJR2FaL9FCHLNVK+b09TtNv4q6nC+1hQHYdyNoBvjY+1g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QfgSW6WxVzT2b for ; Mon, 12 Jun 2023 05:37:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35C5blba021365 for ; Mon, 12 Jun 2023 05:37:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35C5blqK021364 for virtualization@FreeBSD.org; Mon, 12 Jun 2023 05:37:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 267193] devel/gettext-tools: msgmerge -q /dev/null /dev/null hangs uninterruptedly on amd64 in kvm Date: Mon, 12 Jun 2023 05:37:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: zeus@gnu.org.ua X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267193 Zeus Panchenko changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zeus@gnu.org.ua --- Comment #4 from Zeus Panchenko --- same for me 13.1 and 13.2 on Hetzner AMD VMs causes exactly same behavior and switching= to Intel VM solved everything ... > truss -f -d -s 400 /usr/local/bin/msgmerge --update -q /dev/null /dev/null ... 69098: 0.021860797 sigprocmask(SIG_SETMASK,{ },0x0) =3D 0 (0x0) 69098: 0.021970072 sigprocmask(SIG_SETMASK,{ SIGHUP|SIGINT|SIGQUIT|SIGILL|SIGTRAP|SIGABRT|SIGEMT|SIGFPE|SIGKILL|SIGBUS|S= IGSEGV|SIGSYS|SIGPIPE|SIGALRM|SIGTERM|SIGURG|SIGSTOP|SIGTSTP|SIGCONT|SIGCHL= D|SIGTTIN|SIGTTOU|SIGIO|SIGXCPU|SIGXFSZ|SIGVTALRM|SIGPROF|SIGWINCH|SIGINFO|= SIGUSR1|SIGUSR2 },{ }) =3D 0 (0x0) 69098: 0.022076361 sigaction(SIGPIPE,0x0,{ SIG_DFL SA_RESTART ss_t }) =3D 0= (0x0) 69098: 0.022158451 sigprocmask(SIG_SETMASK,{ },0x0) =3D 0 (0x0) 69098: 0.022254249 cpuset_getaffinity(0x3,0x1,0xffffffffffffffff,0x20,0x800e1a140) =3D 0 (0x0) 69098: 0.022351039 cpuset_getaffinity(0x3,0x1,0xffffffffffffffff,0x20,0x800e1a1c0) =3D 0 (0x0) 69098: 0.022462919 cpuset_setaffinity(0x3,0x1,0xffffffffffffffff,0x20,0x800e1a240) =3D 0 (0x0) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jun 12 12:52:38 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qfs6K5Vqjz4dJYs; Mon, 12 Jun 2023 12:52:41 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qfs6K552kz3wHT; Mon, 12 Jun 2023 12:52:41 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686574361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nXWx514K9LJxxJNZb1gisEdLAynfqrYO1JqSxvK3Ws0=; b=ftd2t85qBfvhdVpdcxM+ZBxkpP4eMy+7L1ehUO+29radtkj+j5A3o2fICsF6ouQyVV4PtH BAqEskpn59vOf3Xd2siLslq6bihRF2znN+U3onDYTJH/NzRPscNX+YWt6LH1lrfFr8hqD3 IIKR+K3C7c0y+P4nl6v59gWl+IrzoJby3pO/9I2iLJscPKKMDce3YxK5aecLN3esk3OhgT RhrJ4svbG7nXO3gAplgP9UeUvweAaT+g4zuSlyvhjRv4/LH9wIvv+t14ZWlbceqWtk80J2 ZBIPHlYAJQJWEePojcb9UrfytQiPbwONzRoNpVhRAVKM0zB6nLy2ChmCWW0f3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686574361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nXWx514K9LJxxJNZb1gisEdLAynfqrYO1JqSxvK3Ws0=; b=rtnAzpRs5IhdbPj5tN9s5dmHamgDqFBun5OZdS4IZm3Y4/GG/j7OoUSi6lnyRvICEnHfiz SobcbyKHBI7SucCxG03vxUQMPuFOoQFfd20NPtuoL3FibbT7rrhbrShwwY5+/5BcXCdy/f aWK/Gba/Q7Y2r3L6BD1brOcdEuSfr04kbSbjzlnbqecjReGp0DjtKuGJDAsecE8O6nwifJ 0FuYGyQqcQ7lLppJtgALPnmxe6OX9NyA4jLKQXgQgqV9rWLb5NnbmbMW4XWARdU0msSRq/ DQMcFc32nCjMxOdC+CEarqnDUxI2Rzpb/SAXg2oLDVvclhVWWaIrRbjk3wwboA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686574361; a=rsa-sha256; cv=none; b=rTKnfLr7tTY/2wDHy8vM9o6EAfZSFRDerzBdpH0+L27Lt2TxbZBcSP7zMZNll834digbK1 v+9bHgKSqNYj75mrdMjGTxf8H38H93qd3ncw4lftAj+FsDMnn/smKSKxakQjFwqvy3Lyis ElWFHNuRJ9q+nYiYDEVlzNk6qDaRx4Ky3ijgdTobcgFxunYkRgf0Msp17lyPhIpPpn/+Y4 BzGUrsuLx94Vdh5+H30cEhfEYRwb9zTWY88bdoWIu3/1IS/qWorpPZgjGhjX4xLzPFnXhl vkHqPVwN42Ft5HfJMJnoS8RVyf9POeQI4HwDATrK8VL97ipXW3v8IgyM6M6XaQ== Received: from [172.21.179.48] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qfs6J5k8zzNW4; Mon, 12 Jun 2023 12:52:40 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: Subject: Re: BHYVE SNAPSHOT image format proposal From: Corvin =?ISO-8859-1?Q?K=F6hne?= To: Vitaliy Gusev Cc: virtualization@freebsd.org, freebsd-hackers@freebsd.org Date: Mon, 12 Jun 2023 14:52:38 +0200 In-Reply-To: <986A83D8-E0E0-4030-9369-A5B3500E27C6@gmail.com> References: <67FDC8A8-86A6-4AE4-85F0-FF7BEF9F2F06@gmail.com> <6b98da58a5bd8e83bc466efa20b5a900298210aa.camel@FreeBSD.org> <8387AC83-6667-48E5-A3FA-11475EA96A5F@gmail.com> <986A83D8-E0E0-4030-9369-A5B3500E27C6@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-xnrujQRzsKXlzKBTlGyT" User-Agent: Evolution 3.48.3 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N --=-xnrujQRzsKXlzKBTlGyT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 T24gV2VkLCAyMDIzLTA2LTA3IGF0IDIxOjI1ICswMzAwLCBWaXRhbGl5IEd1c2V2IHdyb3RlOgo+ IEhpIENvcnZpbizCoAo+IAo+ID4gT24gNiBKdW4gMjAyMywgYXQgMTU6NTksIENvcnZpbiBLw7Zo bmUgPGNvcnZpbmtARnJlZUJTRC5vcmc+IHdyb3RlOgo+ID4gPiAuLi4KPiA+IAo+ID4gV2UgbWF5 IGhhdmUgZGlmZmVyZW50IHZlcnNpb24gb2YgdGhlIGZvcm1hdCBmcm9tIHRoZSBzYW1lIHByb2R1 Y2UuCj4gPiBJTUhPLCBpdCBtYWtlcyBzZW5zZSB0byBoYXZlIGEgZGVkaWNhdGVkIElERU5UIGFu ZCBWRVJTSU9OIGZpZWxkIHRvCj4gPiBlYXNpbHkgZmlndXJlIG91dAo+ID4gCj4gPiAxKSBpZiB0 aGUgcHJvZHVjZXIgb2YgdGhlIGltYWdlIGlzIGtub3duCj4gPiAyKSBpZiB3ZSBzdXBwb3J0IHRo YXQgdmVyc2lvbiBvZiB0aGUgcHJvZHVjZXIKPiA+IAo+ID4gRXZlbiBpZiB5b3UgYWxsb2NhdGVk IGEgaHVnZSBhbW91bnQgb2YgZnJlZSBzcGFjZSwgc29tZW9uZSB3b3VsZAo+ID4gbmVlZAo+ID4g bW9yZS4gU28sIHdoYXQgZG8geW91IHRoaW5rIGFib3V0IHRoaXMgZm9ybWF0Ogo+ID4gCj4gPiAr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCj4gPiAtLS0rCj4gPiB8IElERU5UIC0gMTYgQllURVMKPiA+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHwKPiA+ICstLS0tLS0tLS0tLS0tLS0t LS0tKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+IC0t LSsKPiA+IHwgVkVSU0lPTiAtIDQgQllURVMgfCBOVkxJU1QgU0laRSAtIDQgQllURVMgfCBOVkxJ U1QgT0ZGU0VUIC0gOAo+ID4gQllURVMgfAo+ID4gKy0tLS0tLS0tLS0tLS0tLS0tLS0rLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gLS0tKwo+ID4gfCBQ T1NTSUJMRSBGUkVFIFNQQUNFIChlLmcuIGZvciBjdXN0b20gZGF0YSwgYWxpZ25tZW50IGV0Yy4p Cj4gPiDCoMKgwqDCoMKgwqDCoMKgwqB8Cj4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAtLS0rCj4gPiB8IE5W TElTVCBEQVRBCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgfAo+ID4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gLS0tKwo+ID4gfCBQT1NTSUJMRSBGUkVF IFNQQUNFIChmb3Igd2hhdGV2ZXIgcmVhc29uKQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHwKPiA+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+IC0tLSsKPiA+ IHwgU05BUFNIT1QgREFUQQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgfAo+ID4gK+KAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKA lOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKAlOKA lOKAlOKAlOKAlCsKPiA+IAo+IAo+IE5vdGUsIHNpbXBsZSBzdHJpbmcgIkJIWVZFIENIRUNLUE9J TlQgSU1BR0XigJ0gaGFzIDIyIGJ5dGVzLiBTbyAxNgo+IGJ5dGVzIHNlZW1zCj4gdG9vIHNtYWxs LsKgCj4gCgpJIGRvbid0IGNhcmUgYWJvdXQgdGhlIGZpbmFsIHN0cmluZyBidXQgd2UgY2FuIGp1 c3QgdXNlIGFub3RoZXIgc3RyaW5nCmxpa2UgIkJIWVZFIFNOQVBTSE9UIiB3aGljaCBmaXRzIGlu dG8gMTYgYnl0ZXMuCgo+IFNvIEkgd291bGQgbm90IHRvIGNvbXBsaWNhdGUgYSBoZWFkZXIgZmly c3QuwqAKPiAKPiBJIHdvdWxkIHJhdGhlciBkZXNjcmliZSBpZGVhcywgY29uZGl0aW9ucyBhbmQg dGhlbiBzb2x1dGlvbnM6Cj4gCj4gwqDCoMKgMS4gTmVlZCB0b8KgZGlzdGluZ3Vpc2ggc25hcHNo b3QgaW1hZ2UgZmlsZSBmcm9tIG90aGVyIGZpbGVzLiAKPiDCoMKgwqDCoMKgwqBTb2x1dGlvbjog SGVhZGVyIHNob3VsZCBoYXZlICJtYWdpYyBpZOKAnS4KPiAKClRoYXQgd2hhdCB5b3VyIHByZXZp b3VzIElERU5UIGZpZWxkIHdhcyBmb3IuCgo+IMKgwqDCoMKgwqDCoAo+IMKgwqDCoDIuIE5lZWTC oGEgYmFycmllciBmb3IgcmVzdW1pbmcgaWYgaW1hZ2UgImlzIG5vdCBvdXJz4oCdLiBJZGVhIGlz IG5vdAo+IHRvIGFsbG93IHRvIHJlc3VtZSBpbWFnZXMgZnJvbSBvdGhlciBwcm9kdWNlcnMuCj4g wqDCoMKgwqDCoMKgCj4gwqDCoMKgwqDCoMKgVGhlIHJlYXNvbiB0byBoYXZlIGl0IGFuZCB1c2Ug aXQgaW5zdGVhZCBvZiBoZWFkZXIgdmVyc2lvbmluZzogCj4gwqDCoMKgwqDCoMKgCj4gwqDCoMKg wqDCoMKgSW1hZ2luZSB0aGF0IG1haW5zdHJlYW0gaGFzIGl0cyBvd24gaW1wbGVtZW50YXRpb24g YW5kCj4gY29tcGFueeKAmXMgZm9yayByZXBvIGhhcyBpdHMgb3duIGltcGxlbWVudGF0aW9uLiBI b3cgdG8gZW5zdXJlCj4gdGhhdMKgdGhlIHZlcnNpb25zIGluIGFuIGltYWdlIGZpbGUgYXJlIG91 cnMgYW5kIG5vdCBzb21lYm9keeKAmXMgZWxzZT8KPiDCoMKgwqDCoMKgwqAKCkNvbXBhbmllcyBz aG91bGQgdXNlIHRoZSB1cHN0cmVhbSB2ZXJzaW9uLiBJZiBpdCBkb2Vzbid0IGZpdCB0aGVpciB1 c2UKY2FzZSwgdGhleSBzaG91bGQgd29yayBvbiBpbXByb3ZpbmcgdGhlIHVwc3RyZWFtIHZlcnNp b24uCgpJZiBhIGNvbXBhbnkgZGVjaWRlcyB0aGF0IGl0IG5lZWRzIGFuIG93biBpbWFnZSBmb3Jt YXQsIHRoZXkgY2FuIGNoYW5nZQp0aGUgIm1hZ2ljIGlkIiwgdXBzdHJlYW0gYmh5dmUgc3RvcHMg cHJvY2Vzc2luZyBpdCBhbmQgd2UgZG9uJ3QgaGF2ZSB0bwpjYXJlIGFib3V0IGl0IGFueSBtb3Jl LgoKQXMgSSBjYW4ndCBzZWUgYSB1c2UgY2FzZSBmb3IgdGhpcyBmaWVsZCwgSSB3b3VsZCBkcm9w IGl0LgoKPiDCoMKgwqDCoMKgwqBTb2x1dGlvbjogwqBIZWFkZXIgc2hvdWxkIGhhdmUg4oCcUHJv ZHVjZXIgaWTigJ0gc3RyaW5nLgo+IMKgwqDCoMKgwqDCoAo+IMKgwqDCoMKgwqDCoEV4YW1wbGU6 IFNuYXBzaG90IGltYWdlIGZpbGUgaGFzIGVtcHR5IFByb2R1Y2VyIHN0cmluZyAsIGJ1dAo+IGJo eXZlIGhhcyBjdXJyZW50IFByb2R1Y2VyIGFzIOKAnE1ZQ09NUEFOWeKAnS4gU3RyaW5ncyBhcmUg bm90IGVxdWFsLAo+IHJlc3VtZSBtdXN0IGZhaWwuCj4gwqDCoMKgwqDCoMKgCj4gwqDCoMKgMy4g VGhlIFJ1bGUgYWJvdmUgZG9lcyBub3QgcmVzdHJpY3QgZ2V0dGluZy9kZWNvZGluZyBkYXRhIGZy b20gYW4KPiBpbWFnZSBmaWxlLiBJdCBzaG91bGQgYmUgcG9zc2libGUgdG8gbG9vayBhdCBhbiBp bWFnZSBmaWxlIGFuZAo+IGFuYWx5c2UgaW50ZXJuYWxzLCB0byBnZXQvZGVjb2RlIHZhbHVlcywg ZXRjLgo+IMKgwqDCoMKgwqDCoFNvbHV0aW9uOiBIYXZlIGFkZGl0aW9uYWwgb3B0aW9uIGVpdGhl ciBpbiBiaHl2ZSBvciBiaHl2ZWN0bCB0bwo+IGdldCBpbnRvIGltYWdlIGZpbGUuCj4gCgpBZ3Jl ZWQsIHRoYXQgaXQgd291bGQgYmUgZ3JlYXQgdG8gaGF2ZSBzb21lIHRvb2xzIGZvciBhbmFseXNp bmcgdGhlCmltYWdlIGZpbGUuCgoKPiDCoMKgwqA0LiBGb2xsb3dpbmcgbnZsaXN0IGhlYWRlciBk YXRhIHNob3VsZCBoYXZlIGEgc2hvcnQgaW5mb3JtYXRpb24KPiBhYm91dCBpbWFnZSBmaWxlIGFu ZCBpdHMgaW50ZXJuYWxzLgo+IMKgwqDCoMKgwqDCoFNvbHV0aW9uOiBOViBIRUFERVIgY2FuIGhh dmUgc2V2ZXJhbCBzZWN0aW9uczog4oCcY29uZmln4oCdLAo+IOKAnGtlcm5lbOKAnSwg4oCcZGV2 aWNlc+KAnSwg4oCcbWVtb3J54oCdLCDigKYKPiDCoMKgwqDCoMKgwqAKCkFncmVlZC4KCj4gwqDC oMKgNS4gVmVyc2lvbmluZyBvZiBOViBIRUFERVIuIElkZWEgaXMgdG8gaGF2ZSBhbiBpbmZvcm1h dGlvbiBpbgo+IGFkdmFuY2XCoHdoZXRoZXIgaXQgaXMgcG9zc2libGUgdG8gYmUgcmVzdW1lZCBv ciBub3QuIEluIG90aGVyIHdvcmRzLAo+IGJlZm9yZSBkbyByZXN1bWUsIGdldCBpbmZvcm1hdGlv biBhYm91dCBhYmlsaXR5IHRvIHJlc3VtZS4KPiDCoMKgwqDCoMKgwqAKPiDCoMKgwqDCoMKgwqBT b2x1dGlvbjogRWFjaCBTZWN0aW9uIHNob3VsZCBoYXZlIOKAnHZlcnNpb27igJ0gwqBhbmQg4oCc c3VidmVyc2lvbuKAnS4KPiBXaGlsZSDigJx2ZXJzaW9u4oCdIGlzIHJlc3BvbnNpYmxlIGZvciBi b3RoIMKgdHlwZXMgb2YgY29tcGF0aWJpbGl0eToKPiBiYWNrd2FyZCBhbmQgZm9yd2FyZCwg4oCc c3VidmVyc2lvbuKAnSBpcyBmb3IgZm9yd2FyZCBjb21wYXRpYmlsaXR5IG9ubHkuCj4gwqDCoMKg wqDCoMKgCgpJTUhPLCB0aGF0J3MgY29tcGxpY2F0aW5nIHRoZSBmb3JtYXQgdG9vIG11Y2guIE5v dyB5b3UgaGF2ZSB0byBjaGVjawp0d28gdmVyc2lvbiBmaWVsZHMgZm9yIGVhY2ggc2VjdGlvbiBh bmQgeW91IGhhdmUgdG8gY2hlY2sgaWYgYWxsCnJlcXVpcmVkIHNlY3Rpb25zIGFyZSBwcmVzZW50 LgoKSXQgd291bGQgYmUgbXVjaCBlYXNpZXIgd2l0aCBhIHNpbmdsZSB2ZXJzaW9uIGZpZWxkIGlu IHRoZSBoZWFkZXIuIEluCnRoYXQgY2FzZSwgYmh5dmUgY2FuIGNoZWNrIGlmIHRoZSB2ZXJzaW9u IGlzIHN1cHBvcnRlZC4gVGhhdCdzIGEgc2luZ2xlCmNoZWNrIQoKPiDCoMKgwqDCoMKgwqBSdWxl cyBmb3IgY2hlY2s6Cj4gwqDCoMKgwqDCoMKgwqAgwqAgwqAgwqAgSWYgYmhfdmVyc2lvbiA9PSB2 ZXJzaW9uICYmIGJoX3N1YnZlcnNpb24gPj0gc3VidmVyc2lvbgo+IMKgdGhlbgo+IMKgwqDCoMKg wqDCoMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEJoeXZlIGFibGUgdG8gcmVzdW1lIHRoZSBT ZWN0aW9uCj4gwqDCoMKgwqDCoMKgwqAgwqAgwqAgwqAgRWxzZQo+IMKgwqDCoMKgwqDCoMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIEJoeXZlIGNhbm5vdCByZXN1bWUgdGhlIFNlY3Rpb24KPiDC oMKgwqDCoMKgwqDCoCDCoCDCoCDCoCBFbmRpZgo+IMKgwqDCoMKgwqDCoAo+IMKgwqDCoMKgwqDC oEV4YW1wbGUgMTogU2VjdGlvbiBpbiBpbWFnZSBoYXMg4oCcdmVyc2lvbj0xIiwg4oCcc3VidmVy c2lvbj014oCdLAo+IMKgQmh5dmUgaGFzIOKAnHZlcnNpb249MSIsIOKAnHN1YnZlcnNpb249NiIu IFRoYXQgbWVhbnMsIGJoeXZlIGNhbiByZXN1bWUKPiB0aGUgU2VjdGlvbi4KPiDCoMKgwqDCoMKg wqAKPiDCoMKgwqDCoMKgwqBFeGFtcGxlIDI6IFRoZSBzYW1lIGltYWdlIFNlY3Rpb24sIGJ1dCBi aHl2ZSBoYXMg4oCcdmVyc2lvbj0xIiwKPiDigJxzdWJ2ZXJzaW9uPTQiLiBCaHl2ZSBjYW5ub3Qg cmVzdW1lIHRoZSBTZWN0aW9uLgo+IMKgwqDCoMKgwqDCoAo+IMKgwqDCoMKgwqDCoEV4YW1wbGUg MzogVGhlIHNhbWUgaW1hZ2UgU2VjdGlvbiwgYnV0IGJoeXZlIGhhcyDigJx2ZXJzaW9uPTIiLAo+ IOKAnHN1YnZlcnNpb249NeKAnS4gQmh5dmUgY2Fubm90IHJlc3VtZSB0aGUgU2VjdGlvbi4KPiDC oMKgwqDCoMKgwqAKPiDCoMKgwqDCoMKgwqBSdWxlcyBmb3IgaW5jcmVhc2luZyB2ZXJzaW9uczoK PiDCoMKgwqDCoMKgwqDCoCAtIMKgSWYgZHVyaW5nIGNvZGUtY2hhbmdlIOKAnGJhY2t3YXJk4oCd IGNvbXBhdGliaWxpdHkgaXMgYnJva2VuLAo+IOKAnHZlcnNpb27igJ0gc2hvdWxkIGJlIGluY3Jl YXNlZCBhbmQg4oCcc3VidmVyc2lvbuKAnSBpcyBzZXQgdG8gMC4KPiDCoMKgwqDCoMKgwqDCoCAt IMKgSWYgZHVyaW5nIGNvZGUtY2hhbmdlIOKAnGZvcndhcmTigJ0gY29tcGF0aWJpbGl0eSBpcyBi cm9rZW4sCj4g4oCcc3VidmVyc2lvbuKAnSBzaG91bGQgYmUgaW5jcmVhc2VkLgo+IMKgwqDCoMKg wqDCoAo+IMKgwqDCoDYuIE90aGVyIHZlcnNpb25pbmcgaW4gSEVBREVSIGlzIHJlZHVuZGFudC4g SWYgc29tZXRoaW5nIGlzCj4gY2hhbmdlZCBpbiB0aGUgZm9ybWF0LCDigJxtYWdpYyBpZOKAnSBj YW4gYmUgY2hhbmdlZCBhcHByb3ByaWF0ZWx5Lgo+IMKgwqDCoMKgwqDCoFNvbHV0aW9uOiDigJxt YWdpYyBpZOKAnSBzaG91bGQgYmUgc3RhYmxlIGFuZCBub3QgY2hhbmdlZCBmb3IgYQo+IGxvbmcg dGltZS4KPiAKCiJtYWdpYyBpZCIgc2hvdWxkIG5ldmVyIGNoYW5nZSEKCj4gCj4gQXMgcmVzdWx0 IEkgd291bGQgc3VnZ2VzdCB0byBnaXZlIGF0IGxlYXN0IDMyIGJ5dGVzIGZvciAibWFnaWMgaWTi gJ0gLwo+IGlkZW50IGFuZCAzMiBieXRlcyBmb3Ig4oCccHJvZHVjZXIgaWTigJ0uCj4gRm9ybWF0 IG9mIGVudGlyZSBpbWFnZSBmaWxlIGNhbiBiZToKPiAKPiAKPiArLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rCj4gfCDCoCDC oCDCoCDCoCDCoCDCoCDCoCBIRUFERVIgTUFHSUMgSUQgwqAgwqAgLSAzMiBCWVRFUyDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoHwKPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rCj4gfCDCoCDCoCDCoCDCoCDCoCDC oCDCoCBIRUFERVIgUFJPRFVDRVIgSUQgwqAtIDMyIEJZVEVTIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgfAo+ICvigJTigJTigJTigJTigJTigJTigJTigJTigJTigJTigJTigJTigJTigJTi gJQtLS0tLS0tLS0tLS0tLS0t4oCU4oCU4oCU4oCU4oCU4oCU4oCU4oCULS3igJQtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLSsKPiB8IMKgIMKgIMKgIMKgIMKgIMKgIMKgIE5WTElTVCBIRUFERVIgU0la RSDCoC0gwqA0IEJZVEVTIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgfMKgCj4gKy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tKwo+IHwgwqAgwqAgwqAgwqAgwqAgwqAgwqAgTlZMSVNUIEhFQURFUiBEQVRBIChTRUNUSU9O UykgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgfAo+ICstLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiB8IMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIFNOQVBTSE9UIERBVEEgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgfAo+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiAKPiAKPiBNQUdJQyBJ RDogc2hvdWxkIGJlIGhhcmRjb2RlZDogIkJIWVZFIENIRUNLUE9JTlQgSU1BR0XigJ0uCj4gCj4g UFJPRFVDRVIgSUQ6IGNhbiBiZSBlbXB0eSBhbmQgc3VwcG9ydGVkIGJ5IHByb2R1Y2VyLCBpLmUu IHJlc2VydmVkLsKgCj4gCj4gTlZMSVNUIEhFQURFUiBTSVpFOiBoYXMgZW5vdWdoIGRpbWVuc2lv biwgYnV0IGluIGdlbmVyYWwgc2l6ZSBpcyBsZXNzCj4gdGhhbiA0S0IKPiAKPiBOVkxJU1QgSEVB REVSIERBVEE6IFBhY2tlZCBudmxpc3QgZGF0YSwgY29udGFpbnMgU2VjdGlvbnM6IMKg4oCcY29u Zmln4oCdLAo+IOKAnGtlcm5lbOKAnSwg4oCcZGV2aWNlc+KAnSwg4oCcbWVtb3J54oCdLCDigKYg Ogo+IAo+ID4gW2NvbmZpZ10KPiA+IMKgIMKgIMKgIMKgIG9mZnNldCA9IDB4MTAwMCAoNDA5NikK PiA+IMKgIMKgIMKgIMKgIHNpemUgPSAweDFmNiAoNTAyKQo+ID4gwqAgwqAgwqAgwqAgdHlwZSA9 IHRleHQKPiA+IMKgdmVycyA9IDEKPiA+IMKgc3VidmVycyA9IDUKPiA+IFtrZXJuZWxdCj4gPiDC oCDCoCDCoCDCoCBvZmZzZXQgPSAweDExZjYgKDQ1OTgpCj4gPiDCoCDCoCDCoCDCoCBzaXplID0g MHgxOWE3ICg2NTY3KQo+ID4gwqAgwqAgwqAgwqAgdHlwZSA9IG52bGlzdAo+ID4gwqB2ZXJzID0g MQo+ID4gwqBzdWJ2ZXJzID0gMAo+ID4gW2RldmljZXNdCj4gPiDCoCDCoCDCoCDCoCBvZmZzZXQg PSAweDJiOWQgKDExMTY1KQo+ID4gwqAgwqAgwqAgwqAgc2l6ZSA9IDB4MTAxNDViYSAoMTY4NjA2 MDIpCj4gPiDCoCDCoCDCoCDCoCB0eXBlID0gbnZsaXN0Cj4gPiDCoHZlcnMgPSAyCj4gPiDCoHN1 YnZlcnMgPSAxCj4gPiBbbWVtb3J5XQo+ID4gwqAgwqAgwqAgwqAgb2Zmc2V0ID0gMHgxMjAwMDAw ICgxODg3NDM2OCkKPiA+IMKgIMKgIMKgIMKgIHNpemUgPSAweDNjZTAwMDAwICgxMDIxMzEzMDI0 KQo+ID4gwqAgwqAgwqAgwqAgdHlwZSA9IHBhZ2VzCj4gPiDCoHZlcnMgPSAxCj4gPiDCoHN1YnZl cnMgPSAwwqAKPiAKPiAKPiBJIGhvcGUgSSBnYWluZWQgYSB3aG9sZSB1bmRlcnN0YW5kaW5nLgo+ IFRoYW5rcywKPiBWaXRhbGl5IEd1c2V2Cj4gCgpCdHc6IFdlIGNhbiBhZGQgZmVhdHVyZSBiaXRz IHRvIHRoZSBudmxpc3QgaGVhZGVyIGRhdGEuIFRoaXMgbWFrZXMgaXQKdW5uZWNjZXNzYXJ5IHRv IGxlYXZlIHNwYWNlIGZvciBmb3J3YXJkIGNvbXBhdGliaWxpdHkuCgoKLS0gCktpbmQgcmVnYXJk cywKQ29ydmluCg== --=-xnrujQRzsKXlzKBTlGyT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmSHFRYACgkQ2FTaVjFe AmpzTg/8CmTYSY3M5puT1orq+SqbtyGOIeKkQoGuUCz9VAIg173GoEsj44zsux2W H5STli9t3Z2/MJzGVEVAajTTJz5iJx9w+fGBN9OXnbzEHZapD+yrGIGttyz2KF1e yc5hIfEzqlhZ8EIYfhPTr+UmNdAaB/xeY2JIHbl2z9pgzg20DBcTl0tIYj0QgLmi qjxxcfJAVd7daDBSCBYu2TsSAZbBIn3SVeE3xGSXXH5mE0JOHsuR6Q/L1vzQSpi/ Qhk96eIiAJj5LSNqsmVE01WN+qY7EBaPOT3zBjqYdLImoVfZ22AdtvZ5QoCsxami Q2Kzgm21Ndd1/Zvut44toTqsyfzLqeinqkopkMy4IomjyiYSOyJfjtgLEuE9xRLO kzQppjEu3D9J8P7nUJycx40pO2Vxlv+FYXNYj7WPbeQEIyS4GRDTCpmtysemZm0Y FGggdq9p1VxZYlXFdAZqi0e5GfzL951pSLJmt08jPwixRGqkjNg9yhHf/ecPDuVV sYqYA7Yv5PStvgiMnJDLVn+6Rjn8PxIaBEMYsvLcXv9ilyBgRMBm4GZHHA0e6AVs QCGs6w2QurmOB32oyiplfAhrfEUzsupnH63MhBQuFqF21rqA099Szn0NXRPBKTir DIr2RuluzgwLQ1jZvrRroIlwUIsgMXuxSfv1kBDXGdk4MokQ+BM= =Avmp -----END PGP SIGNATURE----- --=-xnrujQRzsKXlzKBTlGyT-- From nobody Mon Jun 12 13:18:44 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qfsrz6zPdz4cBfk for ; Mon, 12 Jun 2023 13:26:11 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qfsrz6WzPz43fQ; Mon, 12 Jun 2023 13:26:11 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jClN5/X9Aeo75n7KGHHy0lOsjmV7Ed6PUzhJY+HFhxw=; b=bhT/sK9q5cajmrMpoBSM30WAoFLODnCX5SDJ6iMhzwD94/vOaKaW4m+hTOchVZ/We/9dpa fsgg/qLWfxtZgOvoKQ/MkBFeAWMb2lMpdnClSldL6Mp+CRS1DzXcAbCidejLPsJukvr3LM Jwf1EGkcTGGdKYJWhOnzm/JoN2yWTgPqamfxwwEbQ9NAlLILggKMTD+B8W5Y9uXheXjb/I Rf/cnn/VoVmX9g2u2ucjIExyEeD1U1HS2z8kRE1GWflrYlgCsvOzVa7+ajwTXXiTg8jzgE Vw9yjcvifeZmNaIosHJRaKXVja71/72KuBas5PPNSgtq1/AWyemIBOQKwJcL1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jClN5/X9Aeo75n7KGHHy0lOsjmV7Ed6PUzhJY+HFhxw=; b=nMpL4ZBg3ngo6DYgSTNJdcS/+BEPe4BVpEsCj3AWukuQhbJBC3kYGbnxtWzKDRqFSkse/n xHLOr6JspNC810SqyyQS0mJCTOsZHCmzp0g2+MLAHZmqldGh5edqXK1cZShDCm/pmx8kCs udhOekBr9l8YIroqlnUQIgtrfCw2xN4JzKh6UKoO4NnjEy1xioUJH8UYqXZ7IUXU7SH5A3 VFUvThMz71HwHKDBFGBqirTXnBX+wRlDtQsMHPhqZjVTaryZGIVXe5bLBh7amf6z1IrZ3+ DijdUGaZVwYRUPOATYPx/nr07DYHSpAQfx8uqQUUVGktorC70C4OloytwsR+oQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686576371; a=rsa-sha256; cv=none; b=HSSdDxHMDAy9HOhzl+Syvrjh9yD6AINM+nTeIJGcJl2qrnyohs0+Oi04on6TpK/EalHeQr kEiyIglHpUhoZopGV1rxzTEUlx7HNqTfAlHJtdUxUgwrf80kWKOxQ2UprhnF5R1a+O0aLc aSY1f0MT3ptokSbg/fjfTVUX6NBIbFupJFiVO+GKIKfouS/fW/sPp48fd/EmSCHujlHSVF 8BaX0XfKwtoE3ajwYWuocdKf0akNVNEyNZWIDDfGz7ob/GnhOF2tNX47ngNgLxPbOLVTyx fF5vV1EREp+CqkFIf7GQgXVcZTslGhVcfH6zWpVKEC1LiV7r3y9EUWbaMDeRhA== Received: from corvink-nb.beckhoff.com (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qfsrz2gdMzPKw; Mon, 12 Jun 2023 13:26:11 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: virtualization@freebsd.org Cc: =?UTF-8?q?Corvin=20K=C3=B6hne?= Subject: [PATCH 0/5] OvmfPkg/Bhyve: install ACPI tables by FwCfg Date: Mon, 12 Jun 2023 15:18:44 +0200 Message-ID: <20230612132558.349152-1-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N Hi, this is the next patch stack for EDKII. Bhyve is able to pass ACPI tables to the guest by FwCfg. This is more flexible and less space limited than our current approach of placing ACPI tables into memory. So, this patch stack modifes the guest firmware to pick up ACPI tables from FwCfg. If that's not possible, it's falls back to our old approach of picking up ACPI tables from memory. Any feedback, even if it's just a short "Looks good" or "Keep going", is appreciated. Kind regards, Corvin Corvin Köhne (5): OvmfPkg: move PciEncoding into AcpiPlatformLib OvmfPkg: move BootScript into AcpiPlatformLib OvmfPkg: move QemuFwCfgAcpi into AcpiPlatformLib OvmfPkg: avoid including AcpiPlatformLib twice OvmfPkg/Bhyve: install Acpi tables provided by FwCfg OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 10 +- .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 - .../AcpiPlatformLib/DxeAcpiPlatformLib.inf | 14 ++ OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 51 ---- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 17 -- OvmfPkg/Include/Library/AcpiPlatformLib.h | 56 +++++ OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 3 + OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 + OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c | 232 ------------------ .../AcpiPlatformLib}/BootScript.c | 3 +- .../AcpiPlatformLib}/PciDecoding.c | 3 +- .../AcpiPlatformLib}/QemuFwCfgAcpi.c | 3 +- 13 files changed, 83 insertions(+), 316 deletions(-) delete mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c rename OvmfPkg/{AcpiPlatformDxe => Library/AcpiPlatformLib}/BootScript.c (96%) rename OvmfPkg/{AcpiPlatformDxe => Library/AcpiPlatformLib}/PciDecoding.c (96%) rename OvmfPkg/{AcpiPlatformDxe => Library/AcpiPlatformLib}/QemuFwCfgAcpi.c (96%) -- 2.41.0 From nobody Mon Jun 12 13:18:45 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qfss04fHkz4cBhk for ; Mon, 12 Jun 2023 13:26:12 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qfss03vCBz43WZ; Mon, 12 Jun 2023 13:26:12 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y4/ReiOKLwsaJngnpP5SodwYgdM2o/jmdJm13HHgTRk=; b=jFMZwSsFp67iYFjGmueS9FYIEN6UibxmppqEVNvkSNwo6ijBa5MZoTt9auYpRMW/Sso+10 xxzjtu2QYTm0vg6Qn2DUJvcWThISOimUnMdVucBY38VOt1HOcsuoHfIl4PAoaWWIZF16bI l3rAD25nKxknNRFhRpuwHMgLuozHbCSFy9LzJY6Z5XdGGL4yxdbagYid/y+2LJ/o2S44CH NEAjjMwR2s5afsuBjNWoo33qmHw6rrE2KUmfUpD8vAdCou1b/sHLtaL4JyT2v4mW/VcDKA /cGk4mJCJueNbPBL22G8vML8C+OBsupqMMRUpQsMn9eDSCdM6WemsbQF7vvWWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y4/ReiOKLwsaJngnpP5SodwYgdM2o/jmdJm13HHgTRk=; b=XhsuxRoWwHRRs6Y/wO/F++CdfrNarm1979sDLobknlv5tno9XL+J/ELzzFCW6WNcDAiNOD wbfUBigfkArab2aoOJAQCpQvrp9qH01Bjd6PZKnSSYXSFp4LVj+NiJmqDln7ql7h1cDzuv LnOuz9sIEklsiwh3QmhghvLi4tDGYffRtTaNs4QaUh1JsWOEfQJNSgV+lCobOm10utH32K WF3M9KVcL34iwxDpqSkiWI6QCCSFK/W9mVdCJ/f2EHqYhCHnfijAXO6esICFjHRjL74rnl vYYjKRvpJGaIKd3+o1cVibPAa6J8MNNDlOoH6WCpnisN/TA/69z+KiLImTu/Og== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686576372; a=rsa-sha256; cv=none; b=wN1Bs9dk7DxzIODGnzV6yWrHOyejp8lCGdb8lpDIZXGaJh+bXIdsrTSYPADkoj8j7t9847 hVqt3JBQ6WmO5SZ+jPQrx/kuVlDg748vPuo/NUJIvUWFaCcoumCzn/SZt9teUBRpjFYsqh nqWu1UMQrjenJwWjotorSmZ+NAhTcaON0K0kycx/xrhcNd+hXyGULaMecB4cderTywvtQX WiStP8laDpjYM+FaGqdTAG9sbJWQnBomgJoo7xij+VGh16wtWBlYywZYPUhqEdJFOZHCvW 0lLkZa3VRJ/LLktYWo2XPMOKhO9J13q+aciNOpjoHuyAkVgRflR9bn416xEaBQ== Received: from corvink-nb.beckhoff.com (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qfsrz704VzPPd; Mon, 12 Jun 2023 13:26:11 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: virtualization@freebsd.org Cc: =?UTF-8?q?Corvin=20K=C3=B6hne?= Subject: [PATCH 1/5] OvmfPkg: move PciEncoding into AcpiPlatformLib Date: Mon, 12 Jun 2023 15:18:45 +0200 Message-ID: <20230612132558.349152-2-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612132558.349152-1-corvink@FreeBSD.org> References: <20230612132558.349152-1-corvink@FreeBSD.org> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N Bhyve supports providing ACPI tables by FwCfg. Therefore, InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the code. As first step, move PciEncoding into AcpiPlatformLib. Signed-off-by: Corvin Köhne --- OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 5 +- .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 - .../AcpiPlatformLib/DxeAcpiPlatformLib.inf | 7 + OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 18 -- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 17 -- OvmfPkg/Include/Library/AcpiPlatformLib.h | 18 ++ OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 1 + OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c | 232 ------------------ .../AcpiPlatformLib}/PciDecoding.c | 3 +- 10 files changed, 29 insertions(+), 274 deletions(-) delete mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c rename OvmfPkg/{AcpiPlatformDxe => Library/AcpiPlatformLib}/PciDecoding.c (96%) diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index e1c0a6fe9ff7..24ac834e0631 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -399,6 +399,7 @@ [LibraryClasses.common.UEFI_DRIVER] PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf [LibraryClasses.common.DXE_DRIVER] + AcpiPlatformLib|OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf TimerLib|OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf index 3fd0483b50eb..b22aad95e081 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -26,7 +26,6 @@ [Sources] BootScript.c CloudHvAcpi.c EntryPoint.c - PciDecoding.c QemuFwCfgAcpi.c [Packages] @@ -35,15 +34,13 @@ [Packages] OvmfPkg/OvmfPkg.dec [LibraryClasses] + AcpiPlatformLib BaseLib BaseMemoryLib - DebugLib MemoryAllocationLib OrderedCollectionLib - PcdLib QemuFwCfgLib QemuFwCfgS3Lib - UefiBootServicesTableLib UefiDriverEntryPoint HobLib TpmMeasurementLib diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf index 75ed8e4a7deb..2e228d815b87 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -26,7 +26,6 @@ [Sources] AcpiPlatform.h Bhyve.c EntryPoint.c - PciDecoding.c [Packages] MdePkg/MdePkg.dec diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf index dfe0e5623d32..4be501bb2c58 100644 --- a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf +++ b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf @@ -16,11 +16,18 @@ [Defines] [Sources] DxeAcpiPlatformLib.c + PciDecoding.c [Packages] + MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec OvmfPkg/OvmfPkg.dec [LibraryClasses] BaseLib DebugLib + PcdLib + UefiBootServicesTableLib + +[Pcd] + gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h index 3ec509865863..1328f6d1cba6 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h @@ -10,12 +10,6 @@ #define ACPI_PLATFORM_H_ #include // EFI_ACPI_TABLE_PROTOCOL -#include // EFI_PCI_IO_PROTOCOL - -typedef struct { - EFI_PCI_IO_PROTOCOL *PciIo; - UINT64 PciAttributes; -} ORIGINAL_ATTRIBUTES; typedef struct S3_CONTEXT S3_CONTEXT; @@ -43,18 +37,6 @@ InstallAcpiTables ( IN EFI_ACPI_TABLE_PROTOCOL *AcpiTable ); -VOID -EnablePciDecoding ( - OUT ORIGINAL_ATTRIBUTES **OriginalAttributes, - OUT UINTN *Count - ); - -VOID -RestorePciDecoding ( - IN ORIGINAL_ATTRIBUTES *OriginalAttributes, - IN UINTN Count - ); - EFI_STATUS AllocateS3Context ( OUT S3_CONTEXT **S3Context, diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h index 54d1af073eab..b75292b73546 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h @@ -21,11 +21,6 @@ #include #include -typedef struct { - EFI_PCI_IO_PROTOCOL *PciIo; - UINT64 PciAttributes; -} ORIGINAL_ATTRIBUTES; - typedef struct S3_CONTEXT S3_CONTEXT; EFI_STATUS @@ -58,16 +53,4 @@ InstallAcpiTables ( IN EFI_ACPI_TABLE_PROTOCOL *AcpiTable ); -VOID -EnablePciDecoding ( - OUT ORIGINAL_ATTRIBUTES **OriginalAttributes, - OUT UINTN *Count - ); - -VOID -RestorePciDecoding ( - IN ORIGINAL_ATTRIBUTES *OriginalAttributes, - IN UINTN Count - ); - #endif /* _ACPI_PLATFORM_H_INCLUDED_ */ diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/Library/AcpiPlatformLib.h index 73a170636032..a1198da296a5 100644 --- a/OvmfPkg/Include/Library/AcpiPlatformLib.h +++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h @@ -5,6 +5,12 @@ **/ #include +#include + +typedef struct { + EFI_PCI_IO_PROTOCOL *PciIo; + UINT64 PciAttributes; +} ORIGINAL_ATTRIBUTES; /** Searches and returns the address of the ACPI Root System Description Pointer (RSDP) in system memory. @@ -47,3 +53,15 @@ InstallAcpiTablesFromRsdp ( IN EFI_ACPI_TABLE_PROTOCOL *AcpiProtocol, IN EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER *Rsdp ); + +VOID +EnablePciDecoding ( + OUT ORIGINAL_ATTRIBUTES **OriginalAttributes, + OUT UINTN *Count + ); + +VOID +RestorePciDecoding ( + IN ORIGINAL_ATTRIBUTES *OriginalAttributes, + IN UINTN Count + ); diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c index a073b292b743..3de039d57414 100644 --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c @@ -11,6 +11,7 @@ #include // EFI_ACPI_DESCRIPTION_HEADER #include // QEMU_LOADER_FNAME_SIZE #include +#include #include // AsciiStrCmp() #include // CopyMem() #include // DEBUG() diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c deleted file mode 100644 index 0dcf3517f1e7..000000000000 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c +++ /dev/null @@ -1,232 +0,0 @@ -/** @file - Temporarily enable IO and MMIO decoding for all PCI devices while QEMU - regenerates the ACPI tables. - - Copyright (C) 2016, Red Hat, Inc. - - SPDX-License-Identifier: BSD-2-Clause-Patent -**/ - -#include - -#include "AcpiPlatform.h" - -/** - Collect all PciIo protocol instances in the system. Save their original - attributes, and enable IO and MMIO decoding for each. - - This is a best effort function; it doesn't return status codes. Its - caller is supposed to proceed even if this function fails. - - @param[out] OriginalAttributes On output, a dynamically allocated array of - ORIGINAL_ATTRIBUTES elements. The array lists - the PciIo protocol instances found in the - system at the time of the call, plus the - original PCI attributes for each. - - Before returning, the function enables IO and - MMIO decoding for each PciIo instance it - finds. - - On error, or when no such instances are - found, OriginalAttributes is set to NULL. - - @param[out] Count On output, the number of elements in - OriginalAttributes. On error it is set to - zero. -**/ -VOID -EnablePciDecoding ( - OUT ORIGINAL_ATTRIBUTES **OriginalAttributes, - OUT UINTN *Count - ) -{ - EFI_STATUS Status; - UINTN NoHandles; - EFI_HANDLE *Handles; - ORIGINAL_ATTRIBUTES *OrigAttrs; - UINTN Idx; - - *OriginalAttributes = NULL; - *Count = 0; - - if (PcdGetBool (PcdPciDisableBusEnumeration)) { - // - // The platform downloads ACPI tables from QEMU in general, but there are - // no root bridges in this execution. We're done. - // - return; - } - - Status = gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiPciIoProtocolGuid, - NULL /* SearchKey */, - &NoHandles, - &Handles - ); - if (Status == EFI_NOT_FOUND) { - // - // No PCI devices were found on either of the root bridges. We're done. - // - return; - } - - if (EFI_ERROR (Status)) { - DEBUG (( - DEBUG_WARN, - "%a: LocateHandleBuffer(): %r\n", - __func__, - Status - )); - return; - } - - OrigAttrs = AllocatePool (NoHandles * sizeof *OrigAttrs); - if (OrigAttrs == NULL) { - DEBUG (( - DEBUG_WARN, - "%a: AllocatePool(): out of resources\n", - __func__ - )); - goto FreeHandles; - } - - for (Idx = 0; Idx < NoHandles; ++Idx) { - EFI_PCI_IO_PROTOCOL *PciIo; - UINT64 Attributes; - - // - // Look up PciIo on the handle and stash it - // - Status = gBS->HandleProtocol ( - Handles[Idx], - &gEfiPciIoProtocolGuid, - (VOID **)&PciIo - ); - ASSERT_EFI_ERROR (Status); - OrigAttrs[Idx].PciIo = PciIo; - - // - // Stash the current attributes - // - Status = PciIo->Attributes ( - PciIo, - EfiPciIoAttributeOperationGet, - 0, - &OrigAttrs[Idx].PciAttributes - ); - if (EFI_ERROR (Status)) { - DEBUG (( - DEBUG_WARN, - "%a: EfiPciIoAttributeOperationGet: %r\n", - __func__, - Status - )); - goto RestoreAttributes; - } - - // - // Retrieve supported attributes - // - Status = PciIo->Attributes ( - PciIo, - EfiPciIoAttributeOperationSupported, - 0, - &Attributes - ); - if (EFI_ERROR (Status)) { - DEBUG (( - DEBUG_WARN, - "%a: EfiPciIoAttributeOperationSupported: %r\n", - __func__, - Status - )); - goto RestoreAttributes; - } - - // - // Enable IO and MMIO decoding - // - Attributes &= EFI_PCI_IO_ATTRIBUTE_IO | EFI_PCI_IO_ATTRIBUTE_MEMORY; - Status = PciIo->Attributes ( - PciIo, - EfiPciIoAttributeOperationEnable, - Attributes, - NULL - ); - if (EFI_ERROR (Status)) { - DEBUG (( - DEBUG_WARN, - "%a: EfiPciIoAttributeOperationEnable: %r\n", - __func__, - Status - )); - goto RestoreAttributes; - } - } - - // - // Success - // - FreePool (Handles); - *OriginalAttributes = OrigAttrs; - *Count = NoHandles; - return; - -RestoreAttributes: - while (Idx > 0) { - --Idx; - OrigAttrs[Idx].PciIo->Attributes ( - OrigAttrs[Idx].PciIo, - EfiPciIoAttributeOperationSet, - OrigAttrs[Idx].PciAttributes, - NULL - ); - } - - FreePool (OrigAttrs); - -FreeHandles: - FreePool (Handles); -} - -/** - Restore the original PCI attributes saved with EnablePciDecoding(). - - @param[in] OriginalAttributes The array allocated and populated by - EnablePciDecoding(). This parameter may be - NULL. If OriginalAttributes is NULL, then the - function is a no-op; otherwise the PciIo - attributes will be restored, and the - OriginalAttributes array will be freed. - - @param[in] Count The Count value stored by EnablePciDecoding(), - the number of elements in OriginalAttributes. - Count may be zero if and only if - OriginalAttributes is NULL. -**/ -VOID -RestorePciDecoding ( - IN ORIGINAL_ATTRIBUTES *OriginalAttributes, - IN UINTN Count - ) -{ - UINTN Idx; - - ASSERT ((OriginalAttributes == NULL) == (Count == 0)); - if (OriginalAttributes == NULL) { - return; - } - - for (Idx = 0; Idx < Count; ++Idx) { - OriginalAttributes[Idx].PciIo->Attributes ( - OriginalAttributes[Idx].PciIo, - EfiPciIoAttributeOperationSet, - OriginalAttributes[Idx].PciAttributes, - NULL - ); - } - - FreePool (OriginalAttributes); -} diff --git a/OvmfPkg/AcpiPlatformDxe/PciDecoding.c b/OvmfPkg/Library/AcpiPlatformLib/PciDecoding.c similarity index 96% rename from OvmfPkg/AcpiPlatformDxe/PciDecoding.c rename to OvmfPkg/Library/AcpiPlatformLib/PciDecoding.c index c7dbfb1baaea..58fbfeefda36 100644 --- a/OvmfPkg/AcpiPlatformDxe/PciDecoding.c +++ b/OvmfPkg/Library/AcpiPlatformLib/PciDecoding.c @@ -7,12 +7,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent **/ +#include #include // DEBUG() #include // AllocatePool() #include // gBS -#include "AcpiPlatform.h" - /** Collect all PciIo protocol instances in the system. Save their original attributes, and enable IO and MMIO decoding for each. -- 2.41.0 From nobody Mon Jun 12 13:18:46 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qfss21Tz7z4cBl7 for ; Mon, 12 Jun 2023 13:26:14 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qfss10y23z43Wn; Mon, 12 Jun 2023 13:26:13 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjTKO4LYDcsrVo6j4c2xRcv7WgfSI3eQvKmJtm7qeao=; b=ovX6loSGtKga5/BUJbdhy4RZ94L9yKy/s5rorqtsrh3/t3DXcz+FvHMvmVjOklETXS0u2F 8VRB15lqVOlIf/wX1mW4jd+eX4Vuy8F/KQIezqlhv7m4r6ino2BD5DnqWfCw92s4HoSDr2 FT0MSR/bpI3vqnBfO5sfBBBvcM4+ztouNdSrRVebDy23vjcHBCXDgF7D+c2qtpMhnJ4vd9 OQLbe1IRDcO+UFr5MvtUNQ3MU2ty9hBLmYFOW0Ha+xBK1NqagNXywxbFy4LjAFDd4zSCfc GLLw/YB1wosgmqnfq51pBx87JOnyIMRvMTUVuKOmgZkh4JoTzqmqnagIcV/UHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjTKO4LYDcsrVo6j4c2xRcv7WgfSI3eQvKmJtm7qeao=; b=SFUPhtqBYXKsPYuFmh4+b8GCI9RquYZIBt2dSUmhoZw7kZIEWBg0nlRswuoSAVFkPhQfn9 cmyRMuCqKCEJs5XM2kGgVCjJP7xQJPDwtynAjnVJ1OVkJ8YNOmbvFbLQUdobEFjWh+Sj4T NvbcxjUTvwcmE2S5bEil8I+SV1qc0M25rP/2nebpDVGQmY1WH1sW0gpRWV/M8YSi4sF9v+ Cofg3cTi7a8c9OiFGcfjjJ9CAYfRbcVMU3y0QTkAJPMyeEb4Re0/jwD7Su6uWsXIVuLNFC lV1uZkFFaI2pfN9FTAiy9HHSZD4LAAk8yIFeRX5hbePQ+BYRGwe46rsu7r4vlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686576373; a=rsa-sha256; cv=none; b=omQfbFEYz8y80wJyLOe3Gy8oEU2KuZfaD2UkD3Ksg0kYKlhIIFSXPHBbiYORwUHkfX1KdV z880L+BKyNnHeDqpb9GWHYEB3WO5itztfBFnFWwHRK/An/GNmjUKgZMUn1aaytGhFhzfCo GKgkt61opptl8ejIoeCm5YVcBeBLpfaz+KIWZ/U6hmE7bnpZsw7LUcxGFunDgBTkKDc5Ow uYzhOgMUdobC+iTpzcx1l/Xa/41m7DY/SDSMOmCSwfkSiwSQk7OYR6Y9MeZNWEvgF5SUd3 ysgh6rdEtCqpKTA+sJ8LVf7XQxtuPQur/vXa2/PyPHh4kuTbQYFkdaQHG10WCA== Received: from corvink-nb.beckhoff.com (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qfss04L9CzPBG; Mon, 12 Jun 2023 13:26:12 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: virtualization@freebsd.org Cc: =?UTF-8?q?Corvin=20K=C3=B6hne?= Subject: [PATCH 2/5] OvmfPkg: move BootScript into AcpiPlatformLib Date: Mon, 12 Jun 2023 15:18:46 +0200 Message-ID: <20230612132558.349152-3-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612132558.349152-1-corvink@FreeBSD.org> References: <20230612132558.349152-1-corvink@FreeBSD.org> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N This is required to move InstallQemuFwCfgTables into AcpiPlatformLib. Signed-off-by: Corvin Köhne --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 -- .../AcpiPlatformLib/DxeAcpiPlatformLib.inf | 2 ++ OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 27 ------------------- OvmfPkg/Include/Library/AcpiPlatformLib.h | 27 +++++++++++++++++++ .../AcpiPlatformLib}/BootScript.c | 3 +-- 5 files changed, 30 insertions(+), 31 deletions(-) rename OvmfPkg/{AcpiPlatformDxe => Library/AcpiPlatformLib}/BootScript.c (96%) diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf index b22aad95e081..6001b9626970 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -23,7 +23,6 @@ [Defines] [Sources] AcpiPlatform.c AcpiPlatform.h - BootScript.c CloudHvAcpi.c EntryPoint.c QemuFwCfgAcpi.c @@ -40,7 +39,6 @@ [LibraryClasses] MemoryAllocationLib OrderedCollectionLib QemuFwCfgLib - QemuFwCfgS3Lib UefiDriverEntryPoint HobLib TpmMeasurementLib diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf index 4be501bb2c58..b6e55b618cbb 100644 --- a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf +++ b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf @@ -15,6 +15,7 @@ [Defines] LIBRARY_CLASS = AcpiPlatformLib [Sources] + BootScript.c DxeAcpiPlatformLib.c PciDecoding.c @@ -27,6 +28,7 @@ [LibraryClasses] BaseLib DebugLib PcdLib + QemuFwCfgS3Lib UefiBootServicesTableLib [Pcd] diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h index 1328f6d1cba6..c9f2755014a1 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h @@ -11,8 +11,6 @@ #include // EFI_ACPI_TABLE_PROTOCOL -typedef struct S3_CONTEXT S3_CONTEXT; - EFI_STATUS EFIAPI InstallCloudHvTablesTdx ( @@ -37,29 +35,4 @@ InstallAcpiTables ( IN EFI_ACPI_TABLE_PROTOCOL *AcpiTable ); -EFI_STATUS -AllocateS3Context ( - OUT S3_CONTEXT **S3Context, - IN UINTN WritePointerCount - ); - -VOID -ReleaseS3Context ( - IN S3_CONTEXT *S3Context - ); - -EFI_STATUS -SaveCondensedWritePointerToS3Context ( - IN OUT S3_CONTEXT *S3Context, - IN UINT16 PointerItem, - IN UINT8 PointerSize, - IN UINT32 PointerOffset, - IN UINT64 PointerValue - ); - -EFI_STATUS -TransferS3ContextToBootScript ( - IN S3_CONTEXT *S3Context - ); - #endif diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/Library/AcpiPlatformLib.h index a1198da296a5..a79d698a8750 100644 --- a/OvmfPkg/Include/Library/AcpiPlatformLib.h +++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h @@ -12,6 +12,8 @@ typedef struct { UINT64 PciAttributes; } ORIGINAL_ATTRIBUTES; +typedef struct S3_CONTEXT S3_CONTEXT; + /** Searches and returns the address of the ACPI Root System Description Pointer (RSDP) in system memory. @@ -65,3 +67,28 @@ RestorePciDecoding ( IN ORIGINAL_ATTRIBUTES *OriginalAttributes, IN UINTN Count ); + +EFI_STATUS +AllocateS3Context ( + OUT S3_CONTEXT **S3Context, + IN UINTN WritePointerCount + ); + +VOID +ReleaseS3Context ( + IN S3_CONTEXT *S3Context + ); + +EFI_STATUS +SaveCondensedWritePointerToS3Context ( + IN OUT S3_CONTEXT *S3Context, + IN UINT16 PointerItem, + IN UINT8 PointerSize, + IN UINT32 PointerOffset, + IN UINT64 PointerValue + ); + +EFI_STATUS +TransferS3ContextToBootScript ( + IN S3_CONTEXT *S3Context + ); diff --git a/OvmfPkg/AcpiPlatformDxe/BootScript.c b/OvmfPkg/Library/AcpiPlatformLib/BootScript.c similarity index 96% rename from OvmfPkg/AcpiPlatformDxe/BootScript.c rename to OvmfPkg/Library/AcpiPlatformLib/BootScript.c index ff1491de0d2d..1b1658d703b0 100644 --- a/OvmfPkg/AcpiPlatformDxe/BootScript.c +++ b/OvmfPkg/Library/AcpiPlatformLib/BootScript.c @@ -7,13 +7,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent **/ +#include #include // CpuDeadLoop() #include // DEBUG() #include // AllocatePool() #include // QemuFwCfgS3ScriptSkipBytes() -#include "AcpiPlatform.h" - // // Condensed structure for capturing the fw_cfg operations -- select, skip, // write -- inherent in executing a QEMU_LOADER_WRITE_POINTER command. -- 2.41.0 From nobody Mon Jun 12 13:18:47 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qfss21dH9z4cBl9 for ; Mon, 12 Jun 2023 13:26:14 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qfss15QmMz43PF; Mon, 12 Jun 2023 13:26:13 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=81pSQjipPQ5C1A1BM7vtTXb0zY2bfpARrmVm+XV/hro=; b=QGHJ/kf2Ot9y+MRbcdnOxUuyin+/9j+fLUoClP/x75VGfoiT4nltFM6nVlE5JUrA9ZcAhH ATl7WcoQzaM8oXQYvQC8mNk615yFDoCdtnYKG29A/lJqG2UYS27D+YWgrR6BZRhHv4qv57 Tnc7Svv3vTxf0qSxQn1aWIiI+9hlltps311IOC0cJ5+dGZDmVeMMmeUUoLjJ4NHEs4URPj GmTwpf/DwvFLFjY3tuyKQR5OAKubu2F0eXb+N7imV3mUqUG8HKTmmo/zLLCLR1G0hyTaLq CkFCsQFRNFg9S3EW/I6zwWfIiGFcW/OUpRevC1cNKuZql+3rjC8VLwLVI8i5UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=81pSQjipPQ5C1A1BM7vtTXb0zY2bfpARrmVm+XV/hro=; b=P4tVIP/IBxhxnUBNlv4s1Bl3HrT7AwXPNqrdvi6tpjZddbeYoO8pbz0hk7bVP8QkzjlX5u RpcD+8qJNi3OM0OpBRyZtafPAaD1apdqfpGz+TO2cSaAJmckeQBWG1HgMywmP8f/hTURYv CmuplHO0xpV4eDsUYj0J6nBHGrNzR1DmsJbTBYwHbtptK5/jga9bdQCUrTFo4Wr4hidkV4 jojF0LcsLzdDTY0XJRZosoA4Jr8UfCNBKjrvbT/0KTrg/cSYbnOvpMZQYq/hWBT6xzP7vu RW5X1MFfJ1+WIFfZbN3DAZYyjKuXmEVfYJfZqrc0YlRgXqoZl8DKpigaAWYDRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686576373; a=rsa-sha256; cv=none; b=OSHninhi4B3V2fsP4Qv6x9k3ID5vw4rjMD60kClklA1NU0mzGdeH0Vj4qUtFz75pHPZDuv 88CrPU7YEB+yZ6bBrKL4buCerLLgXZJlGNWRsEEPeU+yi9lrUj0oUhmCKUSCCcF/dEg7nu TCO1TCMLAFgAKYanKuXRgsUAc2RWvIjscnTSbSDZc/DZU4gHydhp+Ji2P5HapvrALirUh5 1/t/vU727oB+nNx+Q+dUltyYrQVjknqDuA0Dv7I7yoAWTvy2HJdAb6vGNvJg6E/hvhr6bT 8d4VoW+rl+6TPCuMGqGV/XUbvivDOplyRCwGn8f50/LvXHgZBpZyER7NaRkNsQ== Received: from corvink-nb.beckhoff.com (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qfss11V5zzPBH; Mon, 12 Jun 2023 13:26:13 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: virtualization@freebsd.org Cc: =?UTF-8?q?Corvin=20K=C3=B6hne?= Subject: [PATCH 3/5] OvmfPkg: move QemuFwCfgAcpi into AcpiPlatformLib Date: Mon, 12 Jun 2023 15:18:47 +0200 Message-ID: <20230612132558.349152-4-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612132558.349152-1-corvink@FreeBSD.org> References: <20230612132558.349152-1-corvink@FreeBSD.org> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N This makes the InstallQemuFwcfgTables function reusable by bhyve. Signed-off-by: Corvin Köhne --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 --- OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf | 5 +++++ OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 6 ------ OvmfPkg/Include/Library/AcpiPlatformLib.h | 6 ++++++ OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 3 +++ .../AcpiPlatformLib}/QemuFwCfgAcpi.c | 2 -- 6 files changed, 14 insertions(+), 11 deletions(-) rename OvmfPkg/{AcpiPlatformDxe => Library/AcpiPlatformLib}/QemuFwCfgAcpi.c (96%) diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf index 6001b9626970..622589e607e9 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -25,7 +25,6 @@ [Sources] AcpiPlatform.h CloudHvAcpi.c EntryPoint.c - QemuFwCfgAcpi.c [Packages] MdeModulePkg/MdeModulePkg.dec @@ -41,12 +40,10 @@ [LibraryClasses] QemuFwCfgLib UefiDriverEntryPoint HobLib - TpmMeasurementLib [Protocols] gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED gEfiPciIoProtocolGuid # PROTOCOL SOMETIMES_CONSUMED - gQemuAcpiTableNotifyProtocolGuid # PROTOCOL PRODUCES [Guids] gRootBridgesConnectedEventGroupGuid diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf index b6e55b618cbb..59fcb957d059 100644 --- a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf +++ b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf @@ -18,6 +18,7 @@ [Sources] BootScript.c DxeAcpiPlatformLib.c PciDecoding.c + QemuFwCfgAcpi.c [Packages] MdeModulePkg/MdeModulePkg.dec @@ -30,6 +31,10 @@ [LibraryClasses] PcdLib QemuFwCfgS3Lib UefiBootServicesTableLib + TpmMeasurementLib + +[Protocols] + gQemuAcpiTableNotifyProtocolGuid # PROTOCOL PRODUCES [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h index c9f2755014a1..f4ae84b5a194 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h @@ -23,12 +23,6 @@ InstallCloudHvTables ( IN EFI_ACPI_TABLE_PROTOCOL *AcpiProtocol ); -EFI_STATUS -EFIAPI -InstallQemuFwCfgTables ( - IN EFI_ACPI_TABLE_PROTOCOL *AcpiProtocol - ); - EFI_STATUS EFIAPI InstallAcpiTables ( diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/Library/AcpiPlatformLib.h index a79d698a8750..54c89d62b3bf 100644 --- a/OvmfPkg/Include/Library/AcpiPlatformLib.h +++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h @@ -56,6 +56,12 @@ InstallAcpiTablesFromRsdp ( IN EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER *Rsdp ); +EFI_STATUS +EFIAPI +InstallQemuFwCfgTables ( + IN EFI_ACPI_TABLE_PROTOCOL *AcpiProtocol + ); + VOID EnablePciDecoding ( OUT ORIGINAL_ATTRIBUTES **OriginalAttributes, diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c index b446bb487234..20c98bb67fa3 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c @@ -9,6 +9,9 @@ #include // CLOUDHV_DEVICE_ID #include + +#include + #include "AcpiPlatform.h" /** diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/Library/AcpiPlatformLib/QemuFwCfgAcpi.c similarity index 96% rename from OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c rename to OvmfPkg/Library/AcpiPlatformLib/QemuFwCfgAcpi.c index 3de039d57414..d9d0163ffd9f 100644 --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c +++ b/OvmfPkg/Library/AcpiPlatformLib/QemuFwCfgAcpi.c @@ -22,8 +22,6 @@ #include // gBS #include -#include "AcpiPlatform.h" - // // The user structure for the ordered collection that will track the fw_cfg // blobs under processing. -- 2.41.0 From nobody Mon Jun 12 13:18:49 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qfss31tpCz4cBlM for ; Mon, 12 Jun 2023 13:26:15 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qfss26jNnz43Rk; Mon, 12 Jun 2023 13:26:14 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8NES8BmAdnCOf8CMjUvHv2h/19/QOsNYXX4cTnefPYk=; b=nNRzKX3aJN1ZanpI+eU7yDfthJSFwGDgt/mb9Mx3OoqLe4D0KxgKgaIlPIw7HRNzbwGK3J Q+z2MjVRXFGQXpcDT69BkwBOgQ+Ox0M+ktDjyueqc8W7BF6V9g11dLFYct29FGPLEvzwvl dSXGHeLAwQuctX3YHphPQKuF6c/hkI4wwoA3y3KylgvySIdDx/grPACpx5ksNbSIeo+dbB 51GWyTBHPdduMIQTj0n7lQaSmx6+vR6x0zE7fV+VPiw9g2SFIMz1JAuFJulYwkZonptabh PcHmn3dBW5taaYZHNcZrir7CK576ZSRhlKnHB8OdD8xZNRs4tU/T7PtRXAu0vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8NES8BmAdnCOf8CMjUvHv2h/19/QOsNYXX4cTnefPYk=; b=TUWZxoJUyRnQ/U/GNtWdte1rIZvSjbwLfg66teAUtU5NBPGB+r2AOhNOrBZF9UIcf2K/8z 4roxyOHNLWV7+jHbBwKgdoPIm5MaTwTVRdEeDbPsp1fHkNd0TH3zixWxUcovX4RQbM3l3Q zXnuPqAq7yrQdw7hMPmfqXZqGYOyPefhcumAOFkwAufsceQHvGmA/tNPmvijOKvcTYsiWE 13qdxiv6InN8RvHVZwN4PtCroAnos826UDI0KKTzqTVBgDJLkHsmLRaSbyKOrmXSpcLQ0V VznA1bv3mb95dC1SnLxkDjdV1NYqaRM38TrQDcvvMa4ivPIUecLn2HQsbJbg+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686576374; a=rsa-sha256; cv=none; b=DcuLdvc7Hrdl3q5hgKNO6W4bYl5gzVCpCVhqhAJHUWi+8b7/ohOrwCExZGZYG3LpekfVu2 i/SXcDYi8+A3NeK4pIZOnc6pQQlKdYzTnUnGmSOSFzvnWHpNKvH3R+qgPV2GlEYW2QfyHn CxGCW7NNHPOqRLWFeN1nypdV6ausbmGm0W8KawXpAo94E9TW6ECPF+lno3U3bs0DWPRkEd l+r5nPVMrJ3p7SKPsP8qyAACzw8WXOvV9f+zJQfUIhECKrfpQ2vcp4FxAEpVgM0rDiQm/3 7uFRAXk7h7XTqulEXY/Ss+lSdIpCZKv/EVf51EtCE6jFPU9un5oiZRBA3WBLbg== Received: from corvink-nb.beckhoff.com (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qfss22zHRzPSX; Mon, 12 Jun 2023 13:26:14 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: virtualization@freebsd.org Cc: =?UTF-8?q?Corvin=20K=C3=B6hne?= Subject: [PATCH 5/5] OvmfPkg/Bhyve: install Acpi tables provided by FwCfg Date: Mon, 12 Jun 2023 15:18:49 +0200 Message-ID: <20230612132558.349152-6-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612132558.349152-1-corvink@FreeBSD.org> References: <20230612132558.349152-1-corvink@FreeBSD.org> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N Signed-off-by: Corvin Köhne --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c index 1e1c90614ea1..fb926a8bd803 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c @@ -249,6 +249,11 @@ InstallAcpiTables ( EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER *Rsdp; EFI_STATUS Status; + Status = InstallQemuFwCfgTables (AcpiTable); + if (!EFI_ERROR (Status)) { + return EFI_SUCCESS; + } + Status = GetAcpiRsdpFromMemory ( BHYVE_ACPI_PHYSICAL_ADDRESS, BHYVE_BIOS_PHYSICAL_END, -- 2.41.0 From nobody Mon Jun 12 13:18:48 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qfss31w84z4cBj4 for ; Mon, 12 Jun 2023 13:26:15 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qfss22RLJz43fk; Mon, 12 Jun 2023 13:26:14 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qr6eqH/EYMuybYwhkX2WGDBt6gnRYFCk9Pb5fbpY1Uo=; b=mAAJvAdW4bdY0jMh53AvdHR/SBXGxs+JjIwdlfZZx4MBVT9c8bDIiWgG6Gq8t0rjijFvjV dyse/tSIunOTL8iG4giJ0nhNLLfe+/95MLrA86J2Vmb/OOoq4kUZVQ5YPAwAXAfWSKUov/ 6BWLva6c6QR9Nxmw74TcxvveVdpJUI3jQ/3VmuccIwaDW/tcSV4D6B8Vl5D93g5qSyi6z5 8+/GQVkfNdq2TrBDBBWop7spvjSDDjV0EPimoBnxt9jhFfR/8WGItN5g6rLqqN8b+jvRWn AUFQulZLR65uOkVePjxw4olg0qvYMYnmPhNDLSbSXzHsV8d2l+wOa5tGUfQ5Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686576374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qr6eqH/EYMuybYwhkX2WGDBt6gnRYFCk9Pb5fbpY1Uo=; b=ASN0AU9JbAUsrDsgEtb6gKvybnUrc3cIBxehMg29f+B/REQhEmSxg0/vpheB8WY8l36DHn iI7E+yw7pImRxVto7eQbWIcaPHaJy/aw+4koyUUHTiLauIv/j5zVI0aw4/G6qOW6qTbxuJ BObMLx1DBaOO3lY9naevZb5suONfRtrl4XuKo/ouubgkvRBHLk7rLNOGRkBs/Ss9vqq9AI 0Jyo6OLjpO9Xm/lr3BrNTU9sFHC9OgfjyA22QTyhAfB5wGeIft1O1Jl4uuc+Xxjx4ppjoF NQQ4+mhdm9HRSyVncAndsb23nO8Xib4i0trW/VLBvTtpxHa/yyL8ahi9w36e8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686576374; a=rsa-sha256; cv=none; b=nuqIKcVvL6RjuZ01IA4aa8fFk6OkFs/PndI8LG9EMGt1FMB+jRS9MZHcayCvTABOgRx+PS S/2o0lY301XeEluket+5TNjWoiri+tU7T5HyTajDBfgsSLMgtuxAkAxH/s+nZHA2bRoY5F Dz9fezKEQmKM/vfbLf9kdaS5NzVq+mofDG8UA0IRZwMTAyuF0NV8QBdFwWztowWzVQWrIs 7UUwvnfEB5zc8BEJu+osr1pb9nY3BtvHQixopbc6tSz8QrPbHZXqDco+a+n8rSbbZ08u2e evDXwGCKQUZ17zMxc97VGE8DcfW+UeQ4y+M0EWdt5PolS9rGU8PXB0QXOtgTdQ== Received: from corvink-nb.beckhoff.com (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qfss15r5NzPKx; Mon, 12 Jun 2023 13:26:13 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: virtualization@freebsd.org Cc: =?UTF-8?q?Corvin=20K=C3=B6hne?= Subject: [PATCH 4/5] OvmfPkg: avoid including AcpiPlatformLib twice Date: Mon, 12 Jun 2023 15:18:48 +0200 Message-ID: <20230612132558.349152-5-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230612132558.349152-1-corvink@FreeBSD.org> References: <20230612132558.349152-1-corvink@FreeBSD.org> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N Signed-off-by: Corvin Köhne --- OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/Library/AcpiPlatformLib.h index 54c89d62b3bf..df141b9b13cf 100644 --- a/OvmfPkg/Include/Library/AcpiPlatformLib.h +++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h @@ -4,6 +4,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent **/ +#ifndef ACPI_PLATFORM_LIB_H_ +#define ACPI_PLATFORM_LIB_H_ + #include #include @@ -98,3 +101,5 @@ EFI_STATUS TransferS3ContextToBootScript ( IN S3_CONTEXT *S3Context ); + +#endif -- 2.41.0 From nobody Tue Jun 13 10:18:19 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QgPdp709Nz4ckMR for ; Tue, 13 Jun 2023 10:18:22 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QgPdp6My0z4kpt for ; Tue, 13 Jun 2023 10:18:22 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686651502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=DU470Nj43FjaA2EU7RC+/RIvT1JaJsBe0TPbl0hQrUk=; b=kHC76vUCtZyCP/Fsp6+fMcCGuTlWJsotABnzOBinMTCXQ2yiloaRn+SOVPrFupig7vegp5 DNy4e/1tvTqMTDiFcsLABuSgblE2Wy4KFukLmieXvOinZm4xxBlqAY9CLcnzJ2ygwQ4TSv rW7gXWPRapHY7jl98IJpaP4yWcgtNmMqhUoqqcbMBaX+nl8XPoXS+472cyiWklNTIo0zG+ 2I65LVVry6+rHuxR7L4n1K9jrViyA6ryL3p7eOkPaqFua/Z8zI97MikZVNozr4n91b9O/a CBZHA117w5+LMCYjPfQA46sqJ8S0T5rpqrxuQPi8+px+M731n0BMvLXiJB5kDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686651502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=DU470Nj43FjaA2EU7RC+/RIvT1JaJsBe0TPbl0hQrUk=; b=sO0/msMwVKc9GZQA0LFwyWgQRhTwok6zmSm8LlB9jNlEUaLVEGZv0tpaqKwNd335DINQe4 CbSxnHJuI4zG1wjtL6KNlj7ZmlL80SXuvGR9Cms4d4dnJAvKfu8EzCWjGNTUC/VcxkvbAn CoSy67fEcOewGrN+7PE93fH8M+DfACKeY3B+4XUlu56eABJ7UrWzuWGJmlOubLsNaF5B0F qJ4mrhdStqB0vvOJrV4fVC7x9GifLx8n/qD1nqpjYDIWDSMamLLJeH6zklWHeKeaLm2c7B cUisOWY2tsIAy+Q89COxwBhlibJJ3j5x9XiHO9Zpl4XNhqYSq0zlzgf510KWpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686651502; a=rsa-sha256; cv=none; b=OebKnp8QcsJ6WN1v7T0D8xkxxZ0PZmmIhiXnkVucpRfKo7ZKa1ph0Y/bIVYQAw8zAJcJul 9k6QUcZy63M7Y74NHN+LIbVpP9dYASUbRToce+wEyTik0l/wP4q0m9TF9k6M8ZTUjC1gNJ 2B/SMiw2t1+Y1Amwo/r9gH7KgptuJq1dGNEBYTDGbrcqJBIZYe1dOqVkPwrLgH3NHSjJXy j1VzwgCy2TOPFthY63EyZ82nFXoMnChDp84malGPykwf8Fy+3699XpwkVfXdX26IIydlo8 hu3x+F/5D/t3rGLumgfjq8GF/BVtX5tteOcnCrYYqPPPwbgONSNXdz09a8aqnA== Received: from [172.21.179.48] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QgPdp3Bh1znkK for ; Tue, 13 Jun 2023 10:18:22 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: <8f4207144eb5f020e840e3fe2aa3612e63792bc8.camel@FreeBSD.org> Subject: How to remove bhyve's fwctl device? From: Corvin =?ISO-8859-1?Q?K=F6hne?= To: virtualization@FreeBSD.org Date: Tue, 13 Jun 2023 12:18:19 +0200 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-qtWotbAPq1B06jIHvtVE" User-Agent: Evolution 3.48.3 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N --=-qtWotbAPq1B06jIHvtVE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, this is a request for some guidance on how to remove the fwctl device of bhyve. I've recently added support for qemu's fwcfg device as replacement for bhyve's fwctl device. As both devices are using the same io ports they can't coexist. For that reason, I'd like to remove the fwctl device from bhyve. However, this breaks old guest firmware because it doesn't support qemu's fwcfg. Old guest firmware won't be able to detect the number of vcpus. So, it'll report only a single vcpu to the guest OS. More recent guest firmware doesn't have this issue. Any advice would be appreciated. --=20 Kind regards, Corvin --=-qtWotbAPq1B06jIHvtVE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmSIQmsACgkQ2FTaVjFe AmpFOw/9GHP+RSHmbsaJE4jjxuJFgshfqClY8CZdp0EXovFNRpH7vcAasqO5Srf3 fBcf0snRCV3YVfJr8GDC6T68qxSIa2kdKSfFfZSj4tjkFXzWaZJNlXz8f8fcmsxG dwK+FGpdAhSRNNpDrhMUf6RhHJ0SGV3S/61WPHZV4rUDGXbYhvv5J4X0rC706iiO v2rTQJfVwH6U8xernwVf09ac86GGm9M8u8VvHR10tLmI6dXOIc8l9PFmVW2/4SZU 614de2aiofT1arKTPUWGBNWiO6mzvmWY6qaHCT4trjaSuWSoVf/iEedliMIHiR+Z pduprqJqjo5gOrMTFEfqpIQH/PgqE4KwqZbQXMYCVKa8fB7AwpMpWdSLYoBSFWvN +qzIeZRhtrtAHWc7oiuHKURnV0VpF6Yf6y1WEmVixnfZeyDCGKB6tOlD9Q7taxhK XN1sMj4qcp+hs9WQuf6er2G4G2qDksNYysYdlpDtPy0aLnX21aST6wOoLW1XqfvL yTlA7tQQOBeyrzGMABAXVM/VFQgPyTJd1UsQZtSIegk/K3C0gbiipcX22ahseSnn xnLhsVtO4F34hhr4Th9m4L2HGn0Rw6JIzueYl2xmvgj9wOPFGUonEm62/TdOmftQ 3NBkTP9QLjWDUqbTfgUnFFyw8UEU1rfNk0wR8jNElL5GmZuPMBw= =1Oxa -----END PGP SIGNATURE----- --=-qtWotbAPq1B06jIHvtVE-- From nobody Tue Jun 13 11:02:11 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QgQcV5hN9z4cp21 for ; Tue, 13 Jun 2023 11:02:18 +0000 (UTC) (envelope-from SRS0=34ti=CB=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QgQcV2d6tz3Fvw for ; Tue, 13 Jun 2023 11:02:17 +0000 (UTC) (envelope-from SRS0=34ti=CB=freebsd.org=grehan@iredmail.onthenet.com.au) Authentication-Results: mx1.freebsd.org; none Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id DC48620B4993 for ; Tue, 13 Jun 2023 21:02:11 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id D1C66213C0C3 for ; Tue, 13 Jun 2023 21:02:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nt.com.au; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:to:content-language:subject:subject :user-agent:mime-version:date:date:message-id; s=dkim; t= 1686654131; x=1689246132; bh=vsfSFvOEa0z1DfX2qsrG2MeNLDZPCnbR0UY fABxAuNU=; b=T/vF5F/kAC0LYu3Y/8S+untPG8OwYBs/Tea2Uc/weYPhI7o1u80 vlxk+yHPRo2Ycknr20sHITJTWyLCpQgKkSjYQ4u0e/W7XlmrrxhrjMVmFPRhGu3+ umeolTP94DvSsJ5mNiA8iB5RVXU9PAldrs1Taf5YGKXylVMXcJLdeb7M= Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2vsMRjZ995Bm for ; Tue, 13 Jun 2023 21:02:11 +1000 (AEST) Received: from [192.168.1.104] (otn-120-29-29-223.broadband.onthenet.net [120.29.29.223]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id AC3EF213C0C2; Tue, 13 Jun 2023 21:02:11 +1000 (AEST) Message-ID: Date: Tue, 13 Jun 2023 21:02:11 +1000 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 0/5] OvmfPkg/Bhyve: install ACPI tables by FwCfg Content-Language: en-US To: =?UTF-8?Q?Corvin_K=c3=b6hne?= , virtualization@freebsd.org References: <20230612132558.349152-1-corvink@FreeBSD.org> From: Peter Grehan In-Reply-To: <20230612132558.349152-1-corvink@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=HqHt53bS c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=2JZ6tUy8bcDxYaQTggag0w==:17 a=IkcTkHD0fZMA:10 a=of4jigFt-DYA:10 a=aBEiHzcDQmrt9SMqE4oA:9 a=QEXdDO2ut3YA:10 X-Rspamd-Queue-Id: 4QgQcV2d6tz3Fvw X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:9313, ipnet:203.13.68.0/24, country:AU] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Hi Corvin, > this is the next patch stack for EDKII. Bhyve is able to pass ACPI > tables to the guest by FwCfg. This is more flexible and less space > limited than our current approach of placing ACPI tables into memory. > So, this patch stack modifes the guest firmware to pick up ACPI tables > from FwCfg. If that's not possible, it's falls back to our old approach > of picking up ACPI tables from memory. > > Any feedback, even if it's just a short "Looks good" or "Keep going", is > appreciated. Looks good, keep going :) later, Peter. From nobody Thu Jun 15 12:25:29 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QhhMY5mzJz4dLGk for ; Thu, 15 Jun 2023 12:25:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QhhMY1Hzfz4DDP for ; Thu, 15 Jun 2023 12:25:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686831929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9D7cgsWAqElVOKpRNPbMdG/n9p1HTdrQivHpb0VfqEI=; b=cv6LpxDyMZo3i85gPBh8O+eiwZkLC3zZ6E2ypH8+zmshs+Z1Ej5/9T79rtXRCW1J0o9UJS sPke274EVAGsBPizvh4viWkls8/V96y6Ad/e7X0RcsQ5WnVhFAQlxYLi+lNlEq5/h+8CBD Z1DnDa02Q0OzDirA34z07ykgtu9XDeXTfDTcuZcb0uUGpeFsYFsJvwy9/E6PZRnIRdYdVu jG+dBABvb76QWjh/mXtUNPkIXpJD4UXqACm0P7mmeQZy61NcYqKqmMVRTOERTOF49IvyEG ResfWouWyO5YDKhNKV1zeVLGz2kHROWabrGogr3hOXqWgjCfpQSKICY5gTP9Cg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686831929; a=rsa-sha256; cv=none; b=VM2JJbbn8hSR7iTTGj8wLqMdKEcKsUQUcO9TqHrs8/FUSzkZM1kVZepiH2jXH+pIxj20sf T1cXqynnGBH23khlal5wYiktSuhr/Oe+Y9LItLgDk18MdrNQkKOE9bwWtvsiYBZwwXzlnh 8OAjxZurGll6Wx00foFnTScnF2F95Kmgde53lhs+T62kwHNtSelcVsm5wXI/oKQcbzMLTU jS1bFUYZmomKlY9ZNBFnpa1d6MPdLc3Nsph3gVVDrJxg25SPVfoIVhSVZN0KrsjaxyiIpx P7HIfnhwH83tjSlLm+fkBjnAI9+6OPumjAZqGJaLbkbnia4FISipDsfDwKnGKA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QhhMY0M7tzlXl for ; Thu, 15 Jun 2023 12:25:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35FCPSIm031476 for ; Thu, 15 Jun 2023 12:25:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35FCPSA2031475 for virtualization@FreeBSD.org; Thu, 15 Jun 2023 12:25:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 264697] FreeBSD 13 AWS AMI can not use free tier because t2 instance cannot use UEFI boot Date: Thu, 15 Jun 2023 12:25:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: freebsd@igalic.co X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264697 Mina Gali=C4=87 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freebsd@igalic.co Status|Open |In Progress --- Comment #4 from Mina Gali=C4=87 --- copying the commit hook from the wrong bug here: A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbcf9147144f3499976a623f92712ecd0a= ca71912 commit bcf9147144f3499976a623f92712ecd0aca71912 Author: Colin Percival AuthorDate: 2023-06-07 22:17:12 +0000 Commit: Colin Percival CommitDate: 2023-06-14 18:31:10 +0000 EC2: Default to "uefi-preferred" boot mode In EC2, UEFI boots faster than BIOS, but not all amd64 instance types support UEFI. AMIs need to have their boot mode designated, which created a dilemma: Faster boots, or wider compatibility? The recently added "uefi-preferred" option solves this: AMIs can be marked to use UEFI where it's available, but fall back to BIOS on instance types which do not support UEFI. This uses bsdec2-image-upload 1.4.6, which recently landed in the ports tree. PR: 265697 Reviewed by: delphij, imp MFC after: 1 week Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D40470 release/Makefile.ec2 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) maybe on MFC we can target the right bug ;) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Thu Jun 15 17:12:02 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QhpkC1HJfz4cTnv for ; Thu, 15 Jun 2023 17:12:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QhpkB6Csvz4Pt3 for ; Thu, 15 Jun 2023 17:12:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686849122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gKOqSb8tGZjsXv35RPnFXxm4XUCBBqikri5Vlxbcnko=; b=QWFFX6V34Ss4QlKj99CSPoJmeSkUZB9FYkZjsGrl/7uZNrTMYe7xToKKPjDzDvrrwjf8SW Qj8Fm59fVY7mH6xmWR6Da+dGGaFBm+khOYrL+7DO5u1/r84HOoOplPXsWDpu4P03LAwhX0 9bYhEWGwFhBN2sJ3nCs4XDpY7hpGgL4QXJ4piCI7f/870MLTyf3fHt1SSjvVN9XKr4eP5v XGcvWwwN0TNCFkkjnwxeMwU311Qz7qm51Vg4FaxGXpc0A2tnPKUdg6vC/0dPSt8BnG/l0W q7KlMgr+/K4LZuWQNL1SFagTJmcDEad9pBlZNGpvXBtq8C5y/Yfjx7OuPYShrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686849122; a=rsa-sha256; cv=none; b=Cm9VYDfi7CEU4GOA2OOzPUHA282WIoGavvAdPzGdo7r34C+1FADingC26aDfT+W1rU8MQi qwWmcpNsCTMkne5zm9jncpq1JV+Eyi1gdEt0lkt5iyls/3a434MvK2jq/qoSSNWc6S2bLt 9vJwyTkalJvinwk8diuVcyjp0mKG+a158IzvfpReayWsOUP4CX+JkJOYSDF2y6tN5HZ19J prKp3p3ZW9oO8II5BiGNk6S/eGjQZVzyKaeHqETRF/thDGIVeGkCEuLojshSzZMO9x9UGp l3hXKA87FajBBRFpqS321PUUu1fxrFovySdi4l3IVTIemrn/vZ/w5X/aEK9BNw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QhpkB5HWjzvBv for ; Thu, 15 Jun 2023 17:12:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35FHC2t0083712 for ; Thu, 15 Jun 2023 17:12:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35FHC2sw083711 for virtualization@FreeBSD.org; Thu, 15 Jun 2023 17:12:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 272015] make -j8 buildworld *** [vdev_raidz_math_sse2.o] Error code 1 Date: Thu, 15 Jun 2023 17:12:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nbari@tequila.io X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272015 Bug ID: 272015 Summary: make -j8 buildworld *** [vdev_raidz_math_sse2.o] Error code 1 Product: Base System Version: 13.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bhyve Assignee: virtualization@FreeBSD.org Reporter: nbari@tequila.io Created attachment 242796 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D242796&action= =3Dedit vdev_raidz_math_sse2-7de6a9.sh ******************** *** [vdev_raidz_math_sse2.o] Error code 1 make[5]: stopped in /usr/src/cddl/lib/libzpool --- kerberos5/lib__L --- make[4]: stopped in /usr/src/kerberos5/lib --- lib__L --- make[3]: stopped in /usr/src --- kerberos5/lib__L --- make[3]: stopped in /usr/src --- cddl/lib__L --- 1 error make[5]: stopped in /usr/src/cddl/lib/libzpool make[4]: stopped in /usr/src/cddl/lib make[3]: stopped in /usr/src make[2]: stopped in /usr/src make[1]: stopped in /usr/src make: stopped in /usr/src --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Thu Jun 15 19:19:55 2023 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QhsYr1px3z4fKwD for ; Thu, 15 Jun 2023 19:20:00 +0000 (UTC) (envelope-from sean@rogue-research.com) Received: from mail.rogue-research.com (mail.rogue-research.com [207.115.102.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.rogue-research.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QhsYq4QM3z3lBs for ; Thu, 15 Jun 2023 19:19:59 +0000 (UTC) (envelope-from sean@rogue-research.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of sean@rogue-research.com designates 207.115.102.151 as permitted sender) smtp.mailfrom=sean@rogue-research.com; dmarc=pass (policy=none) header.from=rogue-research.com Received: from localhost (localhost [127.0.0.1]) by mail.rogue-research.com (Postfix) with ESMTP id C772CE47BD14 for ; Thu, 15 Jun 2023 15:19:58 -0400 (EDT) X-Virus-Scanned: amavisd-new at rogue-research.com Received: from mail.rogue-research.com ([127.0.0.1]) by localhost (kingu.rogue-research.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rIKuw-Whlyef for ; Thu, 15 Jun 2023 15:19:57 -0400 (EDT) Received: from [172.16.6.1] (dullahan.rogue-research.com [10.29.19.120]) by mail.rogue-research.com (Postfix) with ESMTPSA id B4B9EE47BCFD for ; Thu, 15 Jun 2023 15:19:57 -0400 (EDT) From: Sean McBride To: freebsd-virtualization@FreeBSD.org Subject: Ubuntu in bhyve Date: Thu, 15 Jun 2023 15:19:55 -0400 X-Mailer: MailMate (1.14r5937) Message-ID: <1AC64CF0-2CCF-4B72-9E44-75104E813CF6@rogue-research.com> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_14BCE42E-BB60-4D4C-BC88-5DE111B192F3_=" X-Spamd-Result: default: False [-3.69 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.98)[-0.979]; NEURAL_HAM_SHORT(-0.91)[-0.914]; DMARC_POLICY_ALLOW(-0.50)[rogue-research.com,none]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:11478, ipnet:207.115.96.0/20, country:CA]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MLMMJ_DEST(0.00)[freebsd-virtualization@FreeBSD.org]; RCVD_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FREEFALL_USER(0.00)[sean]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4QhsYq4QM3z3lBs X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N --=_MailMate_14BCE42E-BB60-4D4C-BC88-5DE111B192F3_= Content-Type: text/plain; format=flowed; markup=markdown Hi all, I am running bhyve (via TrueNAS Core 13) and have some Ubuntu 20.04 and 22.04 guests. One of them rather regularly seizes up hard, where I cannot ssh to it, then after a few minutes works again. This happens repeatedly and on and off. In the Ubuntu logs I see messages like: ``` clocksource: timekeeping watchdog on CPU2: Marking clocksource 'tsc' as unstable because the skew is too large: clocksource: 'hpet' wd_nsec: 536417782 wd_now: 638cb3ff wd_last: 63036152 mask: ffffffff clocksource: 'tsc' cs_nsec: 536821277 cs_now: 225a9f9e1250b cs_last: 225a9b3891749 mask: ffffffffffffffff clocksource: 'tsc' is current clocksource. tsc: Marking TSC unstable due to clocksource watchdog TSC found unstable after boot, most likely due to broken BIOS. Use 'tsc=unstable'. sched_clock: Marking unstable (12899572906362, 9192186981)<-(12908811630850, -46250627) clocksource: Checking clocksource tsc synchronization from CPU 2 to CPUs 0-1,3. clocksource: Switched to clocksource hpet loop8: detected capacity change from 0 to 114000 ``` Although I don't fully grok these messages, they sound like something that could be bhyve's fault. Anyone know if that may indeed be the case? There is a thread about this on the TrueNAS forum too, but with no answers really: https://www.truenas.com/community/threads/debian-vms-under-bhyve-clock.108376/ Thanks, Sean --=_MailMate_14BCE42E-BB60-4D4C-BC88-5DE111B192F3_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable

Hi all,

I am running bhyve (via TrueNAS Core 13) and have some Ub= untu 20.04 and 22.04 guests.

One of them rather regularly seizes up hard, where I cann= ot ssh to it, then after a few minutes works again. This happens repeated= ly and on and off. In the Ubuntu logs I see messages like:

clocksource: timekeeping watchdog on CPU=
2: Marking clocksource 'tsc' as unstable because the skew is too large:
clocksource:                       'hpet' wd_nsec: 536417782 wd_now: 638c=
b3ff wd_last: 63036152 mask: ffffffff
clocksource:                       'tsc' cs_nsec: 536821277 cs_now: 225a9=
f9e1250b cs_last: 225a9b3891749 mask: ffffffffffffffff
clocksource:                       'tsc' is current clocksource.
tsc: Marking TSC unstable due to clocksource watchdog
TSC found unstable after boot, most likely due to broken BIOS. Use 'tsc=3D=
unstable'.
sched_clock: Marking unstable (12899572906362, 9192186981)<-(129088116=
30850, -46250627)
clocksource: Checking clocksource tsc synchronization from CPU 2 to CPUs =
0-1,3.
clocksource: Switched to clocksource hpet
loop8: detected capacity change from 0 to 114000

Although I don't fully grok these messages, they sound li= ke something that could be bhyve's fault. Anyone know if that may indeed= be the case?

There is a thread about this on the TrueNAS forum too, bu= t with no answers really:

https://www.t= ruenas.com/community/threads/debian-vms-under-bhyve-clock.108376/

=

Thanks,

Sean

--=_MailMate_14BCE42E-BB60-4D4C-BC88-5DE111B192F3_=-- From nobody Thu Jun 15 21:42:35 2023 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qhwkc18zpz4fXnC for ; Thu, 15 Jun 2023 21:42:48 +0000 (UTC) (envelope-from jason@tubnor.net) Received: from mail.tubnor.net (mail.tubnor.net [103.236.162.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qhwkb21jxz4LhN for ; Thu, 15 Jun 2023 21:42:47 +0000 (UTC) (envelope-from jason@tubnor.net) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tubnor.net; s=20220915; t=1686865354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wuexlp/Nfy/DlbZrEGtuDM6mvExFm5rwOSSCmAxh5Dk=; b=V08mvtcJSz8MDFO+PBYrXhytSfv3QcRIruag1mad5vKZwVa+6q7KFPSjDF9lrA5Ny5Wxv3 e6RAGoElnc6E8EXQNf9F7qdogoJXqQNQC6INioj64my7JA7n6gdZhI5KOOBOSXGZ7soh9z SxV8h2TsY84IP5GMCBBa2ZY7mLSkW8E= Received: from THEMASTER ( [2403:5812:73e6:1:6807:b315:69c1:b336]) by mel01.ar18.net (OpenSMTPD) with ESMTPSA id 99be6499 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 16 Jun 2023 07:42:34 +1000 (AEST) From: To: "'Sean McBride'" , References: <1AC64CF0-2CCF-4B72-9E44-75104E813CF6@rogue-research.com> In-Reply-To: <1AC64CF0-2CCF-4B72-9E44-75104E813CF6@rogue-research.com> Subject: RE: Ubuntu in bhyve Date: Fri, 16 Jun 2023 07:42:35 +1000 Message-ID: <002401d99fd2$4c6d2470$e5476d50$@tubnor.net> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0025_01D9A026.1E19F7C0" X-Mailer: Microsoft Outlook 16.0 Content-Language: en-au Thread-Index: AQG7j4KiCHDB8k9TVed3dRnx5vsdbK/IhHmA X-Rspamd-Queue-Id: 4Qhwkb21jxz4LhN X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:133159, ipnet:103.236.162.0/23, country:AU] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N This is a multipart message in MIME format. ------=_NextPart_000_0025_01D9A026.1E19F7C0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Make sure your guests (and host) are syncing to a reliable time source. I have heard time to time of some having this issue, but we haven't seen it though we do use OpenNTPD across our BSD/*nix guests (windows has its own time sync service). Cheers, Jason. From: owner-freebsd-virtualization@freebsd.org On Behalf Of Sean McBride Sent: Friday, June 16, 2023 5:20 AM To: freebsd-virtualization@FreeBSD.org Subject: Ubuntu in bhyve Hi all, I am running bhyve (via TrueNAS Core 13) and have some Ubuntu 20.04 and 22.04 guests. One of them rather regularly seizes up hard, where I cannot ssh to it, then after a few minutes works again. This happens repeatedly and on and off. In the Ubuntu logs I see messages like: clocksource: timekeeping watchdog on CPU2: Marking clocksource 'tsc' as unstable because the skew is too large: clocksource: 'hpet' wd_nsec: 536417782 wd_now: 638cb3ff wd_last: 63036152 mask: ffffffff clocksource: 'tsc' cs_nsec: 536821277 cs_now: 225a9f9e1250b cs_last: 225a9b3891749 mask: ffffffffffffffff clocksource: 'tsc' is current clocksource. tsc: Marking TSC unstable due to clocksource watchdog TSC found unstable after boot, most likely due to broken BIOS. Use 'tsc=unstable'. sched_clock: Marking unstable (12899572906362, 9192186981)<-(12908811630850, -46250627) clocksource: Checking clocksource tsc synchronization from CPU 2 to CPUs 0-1,3. clocksource: Switched to clocksource hpet loop8: detected capacity change from 0 to 114000 Although I don't fully grok these messages, they sound like something that could be bhyve's fault. Anyone know if that may indeed be the case? There is a thread about this on the TrueNAS forum too, but with no answers really: https://www.truenas.com/community/threads/debian-vms-under-bhyve-clock.10837 6/ Thanks, Sean ------=_NextPart_000_0025_01D9A026.1E19F7C0 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Make sure your guests (and host) = are syncing to a reliable time source. I have heard time to time of some = having this issue, but we haven’t seen it though we do use = OpenNTPD across our BSD/*nix guests (windows has its own time sync = service).

 

Cheers,

 

Jason.

 

From: = owner-freebsd-virtualization@freebsd.org = <owner-freebsd-virtualization@freebsd.org> On Behalf Of = Sean McBride
Sent: Friday, June 16, 2023 5:20 = AM
To: freebsd-virtualization@FreeBSD.org
Subject: = Ubuntu in bhyve

 

Hi = all,

I am running bhyve (via TrueNAS = Core 13) and have some Ubuntu 20.04 and 22.04 = guests.

One of them rather regularly = seizes up hard, where I cannot ssh to it, then after a few minutes works = again. This happens repeatedly and on and off. In the Ubuntu logs I see = messages like:

clocksource: timekeeping =
watchdog on CPU2: Marking clocksource 'tsc' as unstable because the skew =
is too large:
clocksource:   &n=
bsp;           &nb=
sp;       'hpet' wd_nsec: 536417782 =
wd_now: 638cb3ff wd_last: 63036152 mask: ffffffff
clocksource:   &n=
bsp;           &nb=
sp;       'tsc' cs_nsec: 536821277 cs_now: =
225a9f9e1250b cs_last: 225a9b3891749 mask: ffffffffffffffff
clocksource:   &n=
bsp;           &nb=
sp;       'tsc' is current =
clocksource.
tsc: Marking TSC unstable due =
to clocksource watchdog
TSC found unstable after boot, =
most likely due to broken BIOS. Use 'tsc=3Dunstable'.
sched_clock: Marking unstable =
(12899572906362, 9192186981)<-(12908811630850, -46250627)
clocksource: Checking =
clocksource tsc synchronization from CPU 2 to CPUs 0-1,3.
clocksource: Switched to =
clocksource hpet
loop8: detected capacity change =
from 0 to 114000

Although I don't fully grok = these messages, they sound like something that could be bhyve's fault. = Anyone know if that may indeed be the = case?

There is a thread about this on = the TrueNAS forum too, but with no answers = really:

https://www.truenas.com/community/threads/debian-= vms-under-bhyve-clock.108376/

Thanks,

= Sean

=
------=_NextPart_000_0025_01D9A026.1E19F7C0-- From nobody Thu Jun 15 22:22:19 2023 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QhxcL1Mqdz4df4q for ; Thu, 15 Jun 2023 22:22:26 +0000 (UTC) (envelope-from sean@rogue-research.com) Received: from mail.rogue-research.com (mail.rogue-research.com [207.115.102.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.rogue-research.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QhxcK5gFFz3GDh for ; Thu, 15 Jun 2023 22:22:25 +0000 (UTC) (envelope-from sean@rogue-research.com) Authentication-Results: mx1.freebsd.org; none Received: from localhost (localhost [127.0.0.1]) by mail.rogue-research.com (Postfix) with ESMTP id 37504E47FE36; Thu, 15 Jun 2023 18:22:24 -0400 (EDT) X-Virus-Scanned: amavisd-new at rogue-research.com Received: from mail.rogue-research.com ([127.0.0.1]) by localhost (kingu.rogue-research.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Hi4sPTlftfr; Thu, 15 Jun 2023 18:22:21 -0400 (EDT) Received: from [172.16.6.1] (dullahan.rogue-research.com [10.29.19.120]) by mail.rogue-research.com (Postfix) with ESMTPSA id A3D67E47FE13; Thu, 15 Jun 2023 18:22:21 -0400 (EDT) From: Sean McBride To: jason@tubnor.net Cc: freebsd-virtualization@FreeBSD.org Subject: Re: Ubuntu in bhyve Date: Thu, 15 Jun 2023 18:22:19 -0400 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <002401d99fd2$4c6d2470$e5476d50$@tubnor.net> References: <1AC64CF0-2CCF-4B72-9E44-75104E813CF6@rogue-research.com> <002401d99fd2$4c6d2470$e5476d50$@tubnor.net> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_C7833C97-3B71-4A0C-A381-0BD751521718_=" Embedded-HTML: [{"plain":[783,2097],"uuid":"385C24F8-818F-4661-910E-FEEBF47434BA"}] X-Rspamd-Queue-Id: 4QhxcK5gFFz3GDh X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:11478, ipnet:207.115.96.0/20, country:CA] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --=_MailMate_C7833C97-3B71-4A0C-A381-0BD751521718_= Content-Type: text/plain; format=flowed Jason, Thanks for your reply. We run NTP on our router (a pfsense) and both the host (TrueNAS) and guests are using it, correctly I believe. On TrueNAS: # ntpdate -q time.rogue-research.com server 10.xx.xx.1, stratum 2, offset -0.000149, delay 0.02580 15 Jun 18:19:11 ntpdate[1239]: adjust time server 10.xx.xx.1 offset -0.000149 sec On Ubuntu: $ timedatectl Local time: Thu 2023-06-15 18:17:02 EDT Universal time: Thu 2023-06-15 22:17:02 UTC RTC time: Thu 2023-06-15 22:17:02 Time zone: America/Toronto (EDT, -0400) System clock synchronized: yes NTP service: active RTC in local TZ: no I believe both indicate that it's working... Sean On 15 Jun 2023, at 17:42, jason@tubnor.net wrote: > Make sure your guests (and host) are syncing to a reliable time > source. I > have heard time to time of some having this issue, but we haven't seen > it > though we do use OpenNTPD across our BSD/*nix guests (windows has its > own > time sync service). > > > > Cheers, > > > > Jason. > > > > From: owner-freebsd-virtualization@freebsd.org > On Behalf Of Sean McBride > Sent: Friday, June 16, 2023 5:20 AM > To: freebsd-virtualization@FreeBSD.org > Subject: Ubuntu in bhyve > > > > Hi all, > > I am running bhyve (via TrueNAS Core 13) and have some Ubuntu 20.04 > and > 22.04 guests. > > One of them rather regularly seizes up hard, where I cannot ssh to it, > then > after a few minutes works again. This happens repeatedly and on and > off. In > the Ubuntu logs I see messages like: > > clocksource: timekeeping watchdog on CPU2: Marking clocksource 'tsc' > as > unstable because the skew is too large: > clocksource: 'hpet' wd_nsec: 536417782 wd_now: > 638cb3ff wd_last: 63036152 mask: ffffffff > clocksource: 'tsc' cs_nsec: 536821277 cs_now: > 225a9f9e1250b cs_last: 225a9b3891749 mask: ffffffffffffffff > clocksource: 'tsc' is current clocksource. > tsc: Marking TSC unstable due to clocksource watchdog > TSC found unstable after boot, most likely due to broken BIOS. Use > 'tsc=unstable'. > sched_clock: Marking unstable (12899572906362, > 9192186981)<-(12908811630850, > -46250627) > clocksource: Checking clocksource tsc synchronization from CPU 2 to > CPUs > 0-1,3. > clocksource: Switched to clocksource hpet > loop8: detected capacity change from 0 to 114000 > > Although I don't fully grok these messages, they sound like something > that > could be bhyve's fault. Anyone know if that may indeed be the case? > > There is a thread about this on the TrueNAS forum too, but with no > answers > really: > > > 76/> > https://www.truenas.com/community/threads/debian-vms-under-bhyve-clock.10837 > 6/ > > Thanks, > > Sean --=_MailMate_C7833C97-3B71-4A0C-A381-0BD751521718_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Jason,

Thanks for your reply.

We run NTP on our router (a pfsense) and both the host (T= rueNAS) and guests are using it, correctly I believe.

On TrueNAS:

ntpdate -q time.rogue-research.com

server 10.xx.xx.1, stratum 2, offset -0.000149, delay 0.0= 2580
15 Jun 18:19:11 ntpdate[1239]: adjust time server 10.xx.xx.1 offset -0.00= 0149 sec

On Ubuntu:

$ timedatectl
Local time: Thu 2023-06-15 18:17:02 EDT
Universal time: Thu 2023-06-15 22:17:02 UTC
RTC time: Thu 2023-06-15 22:17:02
Time zone: America/Toronto (EDT, -0400)
System clock synchronized: yes
NTP service: active
RTC in local TZ: no

I believe both indicate that it's working...

Sean

On 15 Jun 2023, at 17:42, jason@tubnor.net wrote:

Make su= re your guests (and host) are syncing to a reliable time source. I have h= eard time to time of some having this issue, but we haven=E2=80=99t seen = it though we do use OpenNTPD across our BSD/*nix guests (windows has its = own time sync service).

 <= /span>

Cheers,=

 <= /span>

Jason.<= /span>

 <= /span>

From: owner-freebsd-virtualization@freebsd.org <owner-freebsd-vi= rtualization@freebsd.org> On Behalf Of Sean McBride
Sent: Friday, June 16, 2023 5:20 AM
To: freebsd-virtualization@FreeBSD.org
Subject: Ubuntu in bhyve

 

Hi all,

I am running = bhyve (via TrueNAS Core 13) and have some Ubuntu 20.04 and 22.04 guests.<= /span>

One of them r= ather regularly seizes up hard, where I cannot ssh to it, then after a fe= w minutes works again. This happens repeatedly and on and off. In the Ubu= ntu logs I see messages like:

clocksource: timekeeping watchdog on CPU2: Marking cl=
ocksource 'tsc' as unstable because the skew is too large:<=
/pre>

clocksource:                       'hpet' wd_ns=
ec: 536417782 wd_now: 638cb3ff wd_last: 63036152 mask: ffffffff


clocksource:                       'tsc' cs_nse=
c: 536821277 cs_now: 225a9f9e1250b cs_last: 225a9b3891749 mask: fffffffff=
fffffff


clocksource:                       'tsc' is cur=
rent clocksource.


tsc: Marking TSC unstable due to clocksource wa=
tchdog


TSC found unstable after boot, most likely due =
to broken BIOS. Use 'tsc=3Dunstable'.


sched_clock: Marking unstable (12899572906362, =
9192186981)<-(12908811630850, -46250627)


clocksource: Checking clocksource tsc synchroni=
zation from CPU 2 to CPUs 0-1,3.


clocksource: Switched to clocksource hpet


loop8: detected capacity change from 0 to 11400=
0


Although I do=
n't fully grok these messages, they sound like something that could be bh=
yve's fault. Anyone know if that may indeed be the case?


There is a th=
read about this on the TrueNAS forum too, but with no answers really:


https://www.truenas.com/community/thre=
ads/debian-vms-under-bhyve-clock.108376/


Thanks,


Sean
--=_MailMate_C7833C97-3B71-4A0C-A381-0BD751521718_=-- From nobody Sat Jun 17 05:56:30 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qjldp6HG3z4fS9t for ; Sat, 17 Jun 2023 05:56:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qjldp4QHwz3qrg for ; Sat, 17 Jun 2023 05:56:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686981390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PJYmhyPc+kYgSx0gFS+vyzVoJvwFv6/pfnr5eEsKyYc=; b=rlj5eh/yOB2kgrL+Kfn5c7XkkMx345HPbt/yb3Hb7HOphFm2oJWVp5eLAZ+JtvqnFyPpQT upmguLM/OK7hSyxFaH2u8RRzdY9+4n7nl84ZZ9/X7wHGhA0tQgtiBYv0L7SJ5CSbgetj9U HLlVaq0er68g4WJpPH2KXNqOXLqQb7+6VSVjHVAnnZlDAaG6lOZMOMmBgBnW+o5wKYq0ci Kb3H9lQy/XwzVqKc4Cpjamui734tQQrYWdpyoGFH3IOriNkCLH6Y1dcx7yJFW7LKkamVTT u4gBjTcW4CGl8PY7VxqDWyU/HONbpm9ydMmPnRbJsJBaE0PWDvWpQD8mHF1swQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686981390; a=rsa-sha256; cv=none; b=Nu7wxZQHrtwmidfjiERuJYkOqVp4AOxEZ+/uWIE1zI6YrW0bOZdHUTfgmLHapxNgIiaMyY iOliKS2psMCRaGrw0JsjEHKXyNI8T2G6VBD8LtXbHM3Z75BTG3cJOzXsKbpE2f4xoS2vmI l6mAzzqrEVlFi/DPjtpoyw0PhJx3et6gEmHwRMfcXqUBcmvs3683crNqED5/BvDRpObNA9 /crX86mzh+Qj3KfHs8vUAF5szbjdTi8DQWNAwGd+7w7pSvRnCxC6wRdOEZ9XMRWV32gWoz 198i5/tvxiEslmhDxff8P4ezz3BvFctSDQCIKo7YLQMukBH8Q2Rs0E9tamimcw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Qjldp3VgRzyXs for ; Sat, 17 Jun 2023 05:56:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35H5uUSI029981 for ; Sat, 17 Jun 2023 05:56:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35H5uUHR029980 for virtualization@FreeBSD.org; Sat, 17 Jun 2023 05:56:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 272015] make -j8 buildworld *** [vdev_raidz_math_sse2.o] Error code 1 Date: Sat, 17 Jun 2023 05:56:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: grahamperrin@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272015 Graham Perrin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grahamperrin@freebsd.org Status|New |Open Keywords| |needs-qa --- Comment #1 from Graham Perrin --- > 13.1-STABLE Which version, exactly? (In reply to nbari from comment #0) I see 13.2 in the script =E2=80=A6 --=20 You are receiving this mail because: You are the assignee for the bug.=