From nobody Mon Apr 27 00:07:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g3kQy1fTZz6bHlK for ; Mon, 27 Apr 2026 00:07:38 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yx1-xb131.google.com (mail-yx1-xb131.google.com [IPv6:2607:f8b0:4864:20::b131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g3kQw5sPSz3JRP for ; Mon, 27 Apr 2026 00:07:36 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=NJP5D2+I; dmarc=pass (policy=none) header.from=gmail.com; arc=pass ("google.com:s=arc-20240605:i=1"); spf=pass (mx1.freebsd.org: domain of oliver.pntr@gmail.com designates 2607:f8b0:4864:20::b131 as permitted sender) smtp.mailfrom=oliver.pntr@gmail.com Received: by mail-yx1-xb131.google.com with SMTP id 956f58d0204a3-64937edbc9eso8181838d50.2 for ; Sun, 26 Apr 2026 17:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777248454; cv=none; d=google.com; s=arc-20240605; b=CmkOq3sFOOUpbrceyDikAlZk9xa5f73wlfldpBQCSq2Tkjj1GWaR4Il/O8NIkzoJoj 6CSpqUo5yDS77osXtGBfyIcJf9u0YBHlKYkFv7wJBWM3+G1kth+uuc+yLnV1w5W3inX6 kjagX5dF1z9mKiKXP25o+qpCXArSp/WuiZxOvNRZYRUFFRFzDWij4PfnCYDVdMMeo1pO MMBoVcmbDJAJTkdNMcq6LK6sz6qIGAlBWjEjXpcJ3mvJHpwCXjubUc+LAGq6hLNY/RBK fFhkdp1k0ygds5iNK52rKbYIpZUjiY//s2T4uT9wzu80EaIlQSpzNCdxf5aJKCIG2YBq qYsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature; bh=FZ8vENP1nW95B3r7puKpWIg/bNBkQk5Owq801tANlKw=; fh=lsbO4UjFpN9SjBERsJTbz/LQZRclaJ7RbGszf6q4+3A=; b=Wz3lY1TitzIKCZPYClLF7U6gqdjGTKpJQD1MZRC1s1+0tlFsy3nWAO/DHz0RHqws6T u+OReQ8bY4EIlMztnRdb+xUWYJkZ2J4wtMTAIX3DllaUD0wNV+5THC49luG95BRWeOuD d9NtrabsJkp/GvnD3HYCEGaqAk7K57vjQGFKknG3pfOt/N8WWqAJSHxVUP9mIQMiBYH1 WcciPeO2mkRrI/9pm44U0TtSK3+VHoKckUykjx4HW25Y2Tdi8Y5zh36aaMsuLaaxDsLv Zm6tMLciOYW8+DCiaFWl2qE+FAaUQZWrJXHiNwMNP3oi8rYFXPfNU8FTYu5eWUJWwoSs 2o6w==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777248454; x=1777853254; darn=freebsd.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FZ8vENP1nW95B3r7puKpWIg/bNBkQk5Owq801tANlKw=; b=NJP5D2+ISjIHT4symHD2Q2mbHTS3f5FqhL+eTJgCUkGAXaDSfYesZtmQoyCyWq2Op1 goAZ0VU57CRN8ijOYbPSMaoqs7GHtC6lpFq25GHu8z8S8WIlrP4iE55yTvMtdyUvUHiB xPIwXgJj9mBbqQc1soKNzMrM5CDz7uXR95u3Q8xe1zPNy+HUofgWhbm+B2wwgmhFwzyW IR+uHVDjdDbJWg4nVexwhJPCjAwCd8PVglzPizKM4AjtM5pLkFUxAoPpIL2qapPQkUBf apqkBOd54cgd62gKpLTEO2B7EyCFsKGLl2EV1f6AiU0WYon1TKiXCRp9nobC6aHWuon4 vIRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777248454; x=1777853254; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FZ8vENP1nW95B3r7puKpWIg/bNBkQk5Owq801tANlKw=; b=omOyQOsHRp5gQQR6bu7XgNa9G5JdI6xiNQGnPGjuqg2v8AkbNfekJLcPKAtMmynqH9 YTwq7M9AH3MyI+ycq7pe+MbYrlW1/cYck7TwmhRyQ4/MEckqZpVB7gHHHDNVSAsnsfAN Zoc6IVUFh1PhX3mbhg28TAbTjM63aCN3dHZVwEaBIImRY/ZofFlHJMMK5K5Z4OzLQBXe iVwHMVZQRv5uQbgklArzUg1n9wXA2jeqEPwNZErNo44yQySar8d+TxOLBJqT4d4lQyzo +Y97C/ZN7ysXi7ovlPyqMlS1MOfLh7KOqakAk6AL3p3nYdNCIhbSuyA+FXvqmTnx23t4 qfEw== X-Forwarded-Encrypted: i=1; AFNElJ+KjwPtJDoPWgN901jUg3TIvd1enNLBt7Kt2ZTFiKGg0u0bPzpTDe5Vx7/nY21NPSQfnZoc1YTse2meMb582YYYNN+K@freebsd.org X-Gm-Message-State: AOJu0Yy8/DbqEWS+ZELpPObdu+evjWCvbJ5ApsMJzkTGqo1EpfomM/By BSAKaqiLT+QMvRhhaRV81yEzACLuLWArU+GSlFOGIuPEz8Q2N5MWTBtoodE0clAmqdeyv57ZWR9 B/lK3OnEnWl5/8PDz5y30dKjAkdAxiVE= X-Gm-Gg: AeBDietU/XZfLWCjC58WT8mlo4bCNMSKG4woErjKLIODq1quZOQChsp0zFLwA0/4kCE K+C0ec+SUTlVI3TV0ONXxXSUIHfBbRrsGunOl8r8Q3BFQ3J+JGCsPzRav2mIkwZqQS9mXR6+XdL 60AQ0QFIeHMnY0qECwIZnktfShlCg1yjkapI4pP3FdOVBoYElfZMHB+KumQGLo36NsBn/um2OmK NdvUK2+MoOmu7cOKnfBWvMFIIyA8VnQkLCh+HTdMUiwJZ5sphI6aD2i/ptPcdO1jDwdugYBQ25M CsEZ/u7G1/0GTu3Ztuq8fuKlVEaHlbBtJ0Oa4YSeovYYPUdzxd35 X-Received: by 2002:a53:e304:0:b0:651:d0a5:cee with SMTP id 956f58d0204a3-65310a0b6famr29178761d50.34.1777248453878; Sun, 26 Apr 2026 17:07:33 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Received: by 2002:a05:7010:3d1f:b0:515:7086:c541 with HTTP; Sun, 26 Apr 2026 17:07:32 -0700 (PDT) In-Reply-To: <69e8f964.39869.24418b55@gitrepo.freebsd.org> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> From: Oliver Pinter Date: Mon, 27 Apr 2026 01:07:32 +0100 X-Gm-Features: AVHnY4JDb8IzvAJg5shAlDyfL4lpzl_VIaqrT6O4iHaDjNeEW9G_nTxGhdIOlSo Message-ID: Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently To: "Simon J. Gerraty" Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000c568a3065065e699" X-Spamd-Result: default: False [-5.00 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TAGGED_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::b131:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4g3kQw5sPSz3JRP X-Spamd-Bar: ---- --000000000000c568a3065065e699 Content-Type: text/plain; charset="UTF-8" Hi! Do you have unit tests for these? Have a nice day, op On Wednesday, April 22, 2026, Simon J. Gerraty wrote: > The branch main has been updated by sjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id= > 566cc005812b72a4ba236764651dd8e82c94a166 > > commit 566cc005812b72a4ba236764651dd8e82c94a166 > Author: Simon J. Gerraty > AuthorDate: 2026-04-22 16:37:35 +0000 > Commit: Simon J. Gerraty > CommitDate: 2026-04-22 16:37:35 +0000 > > safe_set treat ':' and '#' differently > > Treat '#' as a comment anywhere, > but ':' only at start of line. > --- > libexec/rc/safe_eval.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libexec/rc/safe_eval.sh b/libexec/rc/safe_eval.sh > index f96c34dda936..3b3241ae821d 100644 > --- a/libexec/rc/safe_eval.sh > +++ b/libexec/rc/safe_eval.sh > @@ -1,6 +1,6 @@ > : > # RCSid: > -# $Id: safe_eval.sh,v 1.27 2026/04/22 16:11:57 sjg Exp $ > +# $Id: safe_eval.sh,v 1.28 2026/04/22 16:36:32 sjg Exp $ > # > # @(#) Copyright (c) 2023-2026 Simon J. Gerraty > # > @@ -32,7 +32,7 @@ fi > # "xtras" should be used with caution and cannot include ';' > # > safe_set() { > - ${SED:-sed} 's/^[ ]*//;s/^[:#].*//;/^[A-Za-z_][ > A-Za-z0-9_]*=/!d;s;[^A-Za-z0-9_. "'"$1"'$,/=:+-];_;g' > + ${SED:-sed} 's/^[ ]*//;s/[ ]*#.*//;s/^:.*//;/^[A-Za-z_][ > A-Za-z0-9_]*=/!d;s;[^A-Za-z0-9_. "'"$1"'$,/=:+-];_;g' > } > > ## > > --000000000000c568a3065065e699 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi!

Do you have unit tests for these?

Have a nice day,
op

On Wednesday, April 22, 2026, S= imon J. Gerraty <sjg@freebsd.org&= gt; wrote:
The branch main has been updat= ed by sjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=3D566cc005812b72a4ba236764651dd8e82c94a166

commit 566cc005812b72a4ba236764651dd8e82c94a166
Author:=C2=A0 =C2=A0 =C2=A0Simon J. Gerraty <sjg@FreeBSD.org>
AuthorDate: 2026-04-22 16:37:35 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Simon J. Gerraty <sjg@FreeBSD.org>
CommitDate: 2026-04-22 16:37:35 +0000

=C2=A0 =C2=A0 safe_set treat ':' and '#' differently

=C2=A0 =C2=A0 Treat '#' as a comment anywhere,
=C2=A0 =C2=A0 but ':' only at start of line.
---
=C2=A0libexec/rc/safe_eval.sh | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libexec/rc/safe_eval.sh b/libexec/rc/safe_eval.sh
index f96c34dda936..3b3241ae821d 100644
--- a/libexec/rc/safe_eval.sh
+++ b/libexec/rc/safe_eval.sh
@@ -1,6 +1,6 @@
=C2=A0:
=C2=A0# RCSid:
-#=C2=A0 =C2=A0 =C2=A0 $Id: safe_eval.sh,v 1.27 2026/04/22 16:11:57 sjg Exp= $
+#=C2=A0 =C2=A0 =C2=A0 $Id: safe_eval.sh,v 1.28 2026/04/22 16:36:32 sjg Exp= $
=C2=A0#
=C2=A0#=C2=A0 =C2=A0 =C2=A0 @(#) Copyright (c) 2023-2026 Simon J. Gerraty =C2=A0#
@@ -32,7 +32,7 @@ fi
=C2=A0# "xtras" should be used with caution and cannot include &#= 39;;'
=C2=A0#
=C2=A0safe_set() {
-=C2=A0 =C2=A0 ${SED:-sed} 's/^[=C2=A0 ]*//;s/^[:#].*//;/^[A-Za-z_][A-Za-z0-9_]*=3D/!d;s;[^A-Za-z0-9_.=C2=A0 =C2=A0"'"$1&q= uot;'$,/=3D:+-];_;g'
+=C2=A0 =C2=A0 ${SED:-sed} 's/^[=C2=A0 ]*//;s/[=C2=A0 =C2=A0 =C2=A0 =C2= =A0 ]*#.*//;s/^:.*//;/^[A-Za-z_][A-Za-z0-9_]*=3D/!d;s;[^A-Za-z0-9= _.=C2=A0 =C2=A0"'"$1"'$,/=3D:+-];_;g'
=C2=A0}

=C2=A0##

--000000000000c568a3065065e699--