From nobody Mon Apr 27 00:07:32 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g3kQy1fVsz6bHfx for ; Mon, 27 Apr 2026 00:07:38 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yx1-xb12f.google.com (mail-yx1-xb12f.google.com [IPv6:2607:f8b0:4864:20::b12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g3kQw1nJ8z3JcT for ; Mon, 27 Apr 2026 00:07:36 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=NJP5D2+I; dmarc=pass (policy=none) header.from=gmail.com; arc=pass ("google.com:s=arc-20240605:i=1"); spf=pass (mx1.freebsd.org: domain of oliver.pntr@gmail.com designates 2607:f8b0:4864:20::b12f as permitted sender) smtp.mailfrom=oliver.pntr@gmail.com Received: by mail-yx1-xb12f.google.com with SMTP id 956f58d0204a3-6501c9903edso9626395d50.1 for ; Sun, 26 Apr 2026 17:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777248454; cv=none; d=google.com; s=arc-20240605; b=RBOCn7gcNSVh8jLKjLUHtxgRWOi58lEZ0jg2t4tJblxfngfqG/PqWEaeWj04yk6GEP r7gJYkyzl2/8BuiM/qR2RfSveo2fJb8Bk1LX0N5ALiaFRWEak30EoeoWBdPxGypN3fC8 cjKVT1EjXRHujoWNHQ3kLZQ+l4+DLQlTD2fTf3Z0/OFNctz8NH7VMaPnDRHSeGQt5B5H Uuv3bDQwmvLzc3/hE5Yr8/eSsf0t/y+UjuGgXP48X0eY+r3CT8gSLiTryVlCylHeb8eF xm2zfmFEnmbXuaMNbPnB/iGkz5WOZCg6e2Sp7O5Q+9oVgEeaLJM4MIJ+s5z6WM4f/h68 PKoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature; bh=FZ8vENP1nW95B3r7puKpWIg/bNBkQk5Owq801tANlKw=; fh=4hRH4vjRNFhM/8+0CuuncFYXTRDpqjn2zDlgoPePwGQ=; b=e9+K3s6FF5kLuXQPys5J5efJ/7eX0XLqDFbMlJydeOz2jlOCV1g5bei/TR/1GIGjYc k/fTyHJbEjb4IV8HnKtNKG89tUtNKP4/2XY8phQ2LxdSO3TM32OfAw0Dbg8eiuO1iu3I oN2INue5y32xsgw0/J+KErqsu2SEx4MHhDccqCc8HYOdncVj8Nntcy/0nYCP+w38eZoA u7N+tes+nV7hh7Nh5slGQbIfzA3Rd98x+OEY9ATNc7f1rAGfUz/zkswwQ2j1aZ2TbQ81 tQcWA5rWPX/c6EeTvSm5AQ0X88UNjaX+IA5iBiJfNkLZgJIQp7v1AJZqVUFfSh8bEQPr S5fw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777248454; x=1777853254; darn=freebsd.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FZ8vENP1nW95B3r7puKpWIg/bNBkQk5Owq801tANlKw=; b=NJP5D2+ISjIHT4symHD2Q2mbHTS3f5FqhL+eTJgCUkGAXaDSfYesZtmQoyCyWq2Op1 goAZ0VU57CRN8ijOYbPSMaoqs7GHtC6lpFq25GHu8z8S8WIlrP4iE55yTvMtdyUvUHiB xPIwXgJj9mBbqQc1soKNzMrM5CDz7uXR95u3Q8xe1zPNy+HUofgWhbm+B2wwgmhFwzyW IR+uHVDjdDbJWg4nVexwhJPCjAwCd8PVglzPizKM4AjtM5pLkFUxAoPpIL2qapPQkUBf apqkBOd54cgd62gKpLTEO2B7EyCFsKGLl2EV1f6AiU0WYon1TKiXCRp9nobC6aHWuon4 vIRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777248454; x=1777853254; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FZ8vENP1nW95B3r7puKpWIg/bNBkQk5Owq801tANlKw=; b=IdkVETpoS9DztQWQzdApysKdmY24ju4gXKgC7L53IsoqJ4OwD1t3CbsBX66hFzdGff LzPDhvZPfbNvjZWIEJm8mfR2YC8GzNsaaJkkQj08KTmNFp1yS1nzWQvOEG8bxq3F6Y4M 7jElEZfTujDfk9XlWwPFUwpDHN9THOYIOXTb1YJwz3OBUEEJSzAYxBR3VizofHbiC2Fz PQfbo7y/xH45G6RTOas+Yf3U2j1c4bZ5GfzxAxssBo/3vwNPMIhu2Ti3Ax92QjuNCGxA gNxJFtEJGMQsqpNHQ7dcXFvf1UHuJKyqQLlO5nkj+0qAPZcWPd4O3M//BWJ9TdGdRjpW GvZA== X-Forwarded-Encrypted: i=1; AFNElJ+ClT5wfSC1+cRPYVwJIqz1Gx7kueXs/cngSqGjYlzORZ2AMeO9iC+Xai99nPkGYgj2t7OJgPH2p0pX/yJt4bGoSNudqQ==@freebsd.org X-Gm-Message-State: AOJu0YwvlGbbhktTIy1wZEZ0AoNoCTwJVDf7qWPjSKRAUzonyrBfMqMX uTH48SB9+Hov74Hvobh/7OWsqglFAmntA8nfJqUEe4cNcXzbFasWIiYYBCjdnDxGdIbHvJUR0Op SwVnnSJsi05S2jnWrH1jVZOLvLOOONMpSGw== X-Gm-Gg: AeBDiesx1vIoREDqOk+fWtxIgaPiNFeRDXRvBL/NiQnDDf7O1tcmdQvveZcUBWP6tVO 3PJlUKYvv8wZX79W2GSUi5MGtUwvZV//G6gJ+O5rDZaMb50LAwJCe+93lzUcyLu92K7pd0PZV6b z90XbmeHGpEA65xlhrNsT5USDZTLRlzh4fUYhU77VeE23RxDuLcPoyKSvAiOTvto2frHsZT25/V VvnLO8Y0bqOFyNYbkjuvoyHDBV+J4RYJAzF/I7HLQgGQS4ssTfzQN5UVAqSw2tdVb+5SCAR3lCx Kb+oYzrgR4e+scTRHk+qs4abI2MKEGG3QoX13UDSJwP3K9ZVKbib X-Received: by 2002:a53:e304:0:b0:651:d0a5:cee with SMTP id 956f58d0204a3-65310a0b6famr29178761d50.34.1777248453878; Sun, 26 Apr 2026 17:07:33 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Received: by 2002:a05:7010:3d1f:b0:515:7086:c541 with HTTP; Sun, 26 Apr 2026 17:07:32 -0700 (PDT) In-Reply-To: <69e8f964.39869.24418b55@gitrepo.freebsd.org> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> From: Oliver Pinter Date: Mon, 27 Apr 2026 01:07:32 +0100 X-Gm-Features: AVHnY4JDb8IzvAJg5shAlDyfL4lpzl_VIaqrT6O4iHaDjNeEW9G_nTxGhdIOlSo Message-ID: Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently To: "Simon J. Gerraty" Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000c568a3065065e699" X-Spamd-Result: default: False [-5.00 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TAGGED_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::b12f:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4g3kQw1nJ8z3JcT X-Spamd-Bar: ---- --000000000000c568a3065065e699 Content-Type: text/plain; charset="UTF-8" Hi! Do you have unit tests for these? Have a nice day, op On Wednesday, April 22, 2026, Simon J. Gerraty wrote: > The branch main has been updated by sjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id= > 566cc005812b72a4ba236764651dd8e82c94a166 > > commit 566cc005812b72a4ba236764651dd8e82c94a166 > Author: Simon J. Gerraty > AuthorDate: 2026-04-22 16:37:35 +0000 > Commit: Simon J. Gerraty > CommitDate: 2026-04-22 16:37:35 +0000 > > safe_set treat ':' and '#' differently > > Treat '#' as a comment anywhere, > but ':' only at start of line. > --- > libexec/rc/safe_eval.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libexec/rc/safe_eval.sh b/libexec/rc/safe_eval.sh > index f96c34dda936..3b3241ae821d 100644 > --- a/libexec/rc/safe_eval.sh > +++ b/libexec/rc/safe_eval.sh > @@ -1,6 +1,6 @@ > : > # RCSid: > -# $Id: safe_eval.sh,v 1.27 2026/04/22 16:11:57 sjg Exp $ > +# $Id: safe_eval.sh,v 1.28 2026/04/22 16:36:32 sjg Exp $ > # > # @(#) Copyright (c) 2023-2026 Simon J. Gerraty > # > @@ -32,7 +32,7 @@ fi > # "xtras" should be used with caution and cannot include ';' > # > safe_set() { > - ${SED:-sed} 's/^[ ]*//;s/^[:#].*//;/^[A-Za-z_][ > A-Za-z0-9_]*=/!d;s;[^A-Za-z0-9_. "'"$1"'$,/=:+-];_;g' > + ${SED:-sed} 's/^[ ]*//;s/[ ]*#.*//;s/^:.*//;/^[A-Za-z_][ > A-Za-z0-9_]*=/!d;s;[^A-Za-z0-9_. "'"$1"'$,/=:+-];_;g' > } > > ## > > --000000000000c568a3065065e699 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi!

Do you have unit tests for these?

Have a nice day,
op

On Wednesday, April 22, 2026, S= imon J. Gerraty <sjg@freebsd.org&= gt; wrote:
The branch main has been updat= ed by sjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=3D566cc005812b72a4ba236764651dd8e82c94a166

commit 566cc005812b72a4ba236764651dd8e82c94a166
Author:=C2=A0 =C2=A0 =C2=A0Simon J. Gerraty <sjg@FreeBSD.org>
AuthorDate: 2026-04-22 16:37:35 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Simon J. Gerraty <sjg@FreeBSD.org>
CommitDate: 2026-04-22 16:37:35 +0000

=C2=A0 =C2=A0 safe_set treat ':' and '#' differently

=C2=A0 =C2=A0 Treat '#' as a comment anywhere,
=C2=A0 =C2=A0 but ':' only at start of line.
---
=C2=A0libexec/rc/safe_eval.sh | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libexec/rc/safe_eval.sh b/libexec/rc/safe_eval.sh
index f96c34dda936..3b3241ae821d 100644
--- a/libexec/rc/safe_eval.sh
+++ b/libexec/rc/safe_eval.sh
@@ -1,6 +1,6 @@
=C2=A0:
=C2=A0# RCSid:
-#=C2=A0 =C2=A0 =C2=A0 $Id: safe_eval.sh,v 1.27 2026/04/22 16:11:57 sjg Exp= $
+#=C2=A0 =C2=A0 =C2=A0 $Id: safe_eval.sh,v 1.28 2026/04/22 16:36:32 sjg Exp= $
=C2=A0#
=C2=A0#=C2=A0 =C2=A0 =C2=A0 @(#) Copyright (c) 2023-2026 Simon J. Gerraty =C2=A0#
@@ -32,7 +32,7 @@ fi
=C2=A0# "xtras" should be used with caution and cannot include &#= 39;;'
=C2=A0#
=C2=A0safe_set() {
-=C2=A0 =C2=A0 ${SED:-sed} 's/^[=C2=A0 ]*//;s/^[:#].*//;/^[A-Za-z_][A-Za-z0-9_]*=3D/!d;s;[^A-Za-z0-9_.=C2=A0 =C2=A0"'"$1&q= uot;'$,/=3D:+-];_;g'
+=C2=A0 =C2=A0 ${SED:-sed} 's/^[=C2=A0 ]*//;s/[=C2=A0 =C2=A0 =C2=A0 =C2= =A0 ]*#.*//;s/^:.*//;/^[A-Za-z_][A-Za-z0-9_]*=3D/!d;s;[^A-Za-z0-9= _.=C2=A0 =C2=A0"'"$1"'$,/=3D:+-];_;g'
=C2=A0}

=C2=A0##

--000000000000c568a3065065e699--