From nobody Mon Jun 8 03:16:46 2026 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gYcdq4R10z6gf59 for ; Mon, 08 Jun 2026 03:16:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gYcdq3npCz451m for ; Mon, 08 Jun 2026 03:16:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780888607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jPjCI81toUzXpixxxjKtlQxXkcYZ9FtidnJkITuh5SM=; b=au/IOjs21VwfCT+StJs7O5owiwC/EObuIuHqlABdISCuIat9n7suVwMJSmFB33UoTQi1py 2GM/V9+prjUrRcrEOLpkXpuTwF4murS8XMoW9WZk+v937rRKNc6TBTxFNBkl8ZFiz9So1o sEUBFhTX4uKc+EzvThQNQheYmYJ3s2e3ZHrKjVdSLT/MqdN+ztBgK/utIgnZheVwOaaRst fg50ETyz0dLdUFkGKLTm2nyhrT74g+T8XJmIXetU1LHMMvykrrIlCZlGYpwFWH+hODm0A8 TEyqgPR1S+XFQYm22rpHKTCLm2kc2CQ4DnDQXUudy4RGyaPfqt28+HfbpxLzww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780888607; a=rsa-sha256; cv=none; b=jE3njq+D5fZIw4h+Imc8/Gs2ur0AyoX6nnTeCt/Nty/0VR5FHNiMitHVZPF8P4/Am6WAek G7vHYnf3VHFtlcobSeX0ggG++8WHN3tBPE3DJjQoenfflKYQl5nfN5CaoWKTY72zyru2DL yjj1NN/dl3PeCiC6H8rire2W752OD+aacqmdRQAohSGyRW2cgESeAbvF5pV5f6eZ1pwHhL Db2E0MjnAkjOi3v8xTLcDd2MDkzQkyHETr3nmyZzc/831w/KV6qoYm+JdZoQpDL7mrziIT D5eJ24IVniiNTIJkfrpI0XZq/iZ1wiaPKEsAuqezIZegKZicMmHTXrQ+HWi/Iw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780888607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jPjCI81toUzXpixxxjKtlQxXkcYZ9FtidnJkITuh5SM=; b=t8T/FwnhPGxqLWZ1T31721/RDrn1SQP4YNbl+HliT3lTUFOWizsHVDb+8JG/gorK5H1Ufp LF7H/5B+Nr4xcgVO1/hBF1G3vU51tXV7CwIe+jTEk5dOYdnbCQjXzbZifAJZ44OgBr7lc8 aKtXVqgrj8Aadro/k7Y3Jey8rAfbgiu8UIv1MxbqlwwwDaQmvME4PMLT0EgWX+DWyuNHSF syidQ18omT1TsRXYDK/6if/Xzv2fubxmYXuFU2ezdY2UrGyexb4OQJEkQ1DeQ/g5oL71mT qgnXosiXcHTqY+9m+2Uxz1K133dqLgjvG8iAaSSvk4V8SBmqABDMiE7mmrfDuA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4gYcdq3NJBzVbh for ; Mon, 08 Jun 2026 03:16:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 6583GlWc089795 for ; Mon, 8 Jun 2026 03:16:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 6583GlhD089794 for net@FreeBSD.org; Mon, 8 Jun 2026 03:16:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 110284] [if_ethersubr] Invalid Assumption in SIOCSIFADDR in ether_ioctl() Date: Mon, 08 Jun 2026 03:16:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 6.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: zlei@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Feedback Timeout X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D110284 --- Comment #8 from Zhenlei Huang --- Note that, the `IFF_DRV_RUNNING ` flag is a driver managed flag. It should = be read or written under driver managed lock. It is encouraged to handle the running state in the driver, typically the `ifp->if_init()` routine, rather than in the net stack. Many many drivers already have this ( similar ) logic in the init routine, ``` foo_init(sc) { foo_driver_lock(sc); foo_init_locked(sc); foo_driver_unlock(sc); } foo_init_locked(sc) { assert_foo_driver_locked(sc); if (ifp->if_drv_flags & IFF_DRV_RUNNING !=3D 0) return; /* handle hw init */ ....=20 /* ready */ ifp-> if_drv_flags |=3D IFF_DRV_RUNNING; } ``` So this patch is not relevant anymore. See also change https://cgit.freebsd.org/src/commit/?id=3D879773c18b50 whic= h did the opposite to this patch. --=20 You are receiving this mail because: You are the assignee for the bug.=