From owner-svn-src-all@FreeBSD.ORG Thu Sep 27 18:16:02 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8CD801065673; Thu, 27 Sep 2012 18:16:02 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 491018FC1C; Thu, 27 Sep 2012 18:16:01 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 1D39ED4F; Thu, 27 Sep 2012 20:15:00 +0200 (CEST) Date: Thu, 27 Sep 2012 20:16:25 +0200 From: Pawel Jakub Dawidek To: "Kenneth D. Merry" Message-ID: <20120927181624.GX1402@garage.freebsd.pl> References: <201209221241.q8MCfnhJ067937@svn.freebsd.org> <20120925233712.GA26920@nargothrond.kdm.org> <20120926072005.GH1391@garage.freebsd.pl> <20120926172917.GA71268@nargothrond.kdm.org> <20120926185339.GA1402@garage.freebsd.pl> <20120926192117.GA89741@nargothrond.kdm.org> <20120926194541.GB1402@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkJ987n7uXEPtlXE" Content-Disposition: inline In-Reply-To: <20120926194541.GB1402@garage.freebsd.pl> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, jdp@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org Subject: Re: svn commit: r240822 - head/sys/geom X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 18:16:02 -0000 --vkJ987n7uXEPtlXE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 26, 2012 at 09:45:41PM +0200, Pawel Jakub Dawidek wrote: > On Wed, Sep 26, 2012 at 01:21:17PM -0600, Kenneth D. Merry wrote: > > Ahh. How about using LIST_FOREACH_SAFE? Would that address the proble= m at > > hand? Are there any other races in there? >=20 > It depends. If one geom can hold more than one provider then it might be > racy, but from what I see there is always only one provider - there has > to be only one, because disk_destroy() destroys it and struct disk > represents always only one disk. If that's true then I see not reason to > have a loop in there. I'd change it to: >=20 > void > disk_gone(struct disk *dp) > { > struct g_geom *gp; > struct g_provider *pp; >=20 > gp =3D dp->d_geom; > if (gp !=3D NULL) { > pp =3D LIST_FIRST(&gp->provider); > if (pp !=3D NULL) > g_wither_provider(pp, ENXIO); > } > } Final patch for review: http://people.freebsd.org/~pjd/patches/geom_disk.c.3.patch --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --vkJ987n7uXEPtlXE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlBkl/gACgkQForvXbEpPzRfSQCfbgfGEZuHkyWZpWlzZwz+7A7M pZ4AnjpQ8TFfjaLRvGGJJXT0qGEiEm/O =z+cR -----END PGP SIGNATURE----- --vkJ987n7uXEPtlXE--