From nobody Thu Jan 29 16:22:25 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f24DV249tz6QwKr for ; Thu, 29 Jan 2026 16:22:34 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic310-21.consmr.mail.gq1.yahoo.com (sonic310-21.consmr.mail.gq1.yahoo.com [98.137.69.147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4f24DT4N7xz3FkF for ; Thu, 29 Jan 2026 16:22:33 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1769703748; bh=43dFGTnoLEMnvTnTYKAou6cm6swf59kx/VW/Cezxi6s=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From:Subject:Reply-To; b=Q8z2ihZT/4rs97C2uvMt/TZSt1+ca3/FFQ+JVptQr28Dh/+ZWac+HgxxpODUAtas0lB/T0YLudyTyVOwGy/A5QxHrsN+uzoM3aox6dyE4mCrGIY6VkngYWXYiqNdjJoEALgiu1fs8MuQpHRHQmcCI2ySPLWYj+0p77sYG9eJE+7/zvbr05a6MBZQgOH4GV0xbj7ymM/E4AmAZ6z0ldRTjgiQcfWwVRZh69NpnhzzPagkmq55u73Z/flXjwf7o42nzSF/ry3w8l96plPvAuqnKuByDu+RQVlnBocom35MxSiGdXnTDWjvL8koA7aDDwvJbi8Twkz4fa3hpYv+m+j+WQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1769703748; bh=JFK3Bu3I4TFKl70Avt5+Xn5wj+ZiKZYcK2BI6/yqsrc=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=GUgDz24J8JqJYfjZYPwvXH7wgqNqq70BsfV0MSWqTB+uoND6g9V6UKE7xl+1jzRHP6jabwzkDOWodxM5vupkiTKsm1hx0KRPFc6CPdehKSY1o7bRN0yCf6FYk8DAJ1OAu4/quo+JykD95jTyMWa6CVkZA5ViYYB+ai5fWdL35nCm7KjshKxHmiYEOHyeon3spaq2aCh68xuZvKty+h6jn4Hn91VLghhSSzP8Z1CicXNzSKRLj1ET3Egr3m8KbjIm0freIHZJZGlsSkoY/WgUjkLIxeC58z2glqGP9+0yMzhnU42bSj0WokVV4i8ybsTnVe78oGyGoC22MiGOGYkQhw== X-YMail-OSG: bO1Vp8oVM1nK4SU8FYWE9AioB6adjFJfI03XwcbzfsY5kSbEpWQMbeEjAu4rM6V W0m8xwp6nTRYpzCR3p63apHvxSWx3DBCMS6Iep1hM9pHeTFUgYuzM8.do9p9YFfLbozeirKeyYFk f2V73a1uMDMdxqWoOuSYYWsjqzi1djRCJcPwczaAwrhl5k3EM.PNvaGcVcyoYmteMUFENtAjHTsq h91I8H9ToUTKdyN78vUj0rkZ5eU9Vqijf5MhR8tpBkuGVLumZFji11a0Me9Tf.NgHq5Eg5uxFrMl mEZ27UFT.gltxKlcg8p7Gy8fmzfDxThIx7fkDeKWk5StS7TkpljPQ9.vaSiwFzunWaF0mZU96Ci1 guqJnNKLNLtD9XdYPVP590.8Wy6CVDhnbCk8..QM6LtWY7z8ADT1h1Y6wQnklcAlNu39OqKmKcHc BYddNmqXePCdHFy3bKM6nSpdcdYwC2jGVg6x5tusNIIioxGn4Yg4horqgvx1I0O6szEBHVGj9jtQ 1PJQ3iRsMEgXSFpWrF1BZqPQ9X1qTaDXeqddo010Dm6wu9H_4U7lK2yGVs8T.npZHUA4mIp5cWAm ada6TCihBHx6EBxwoBHBFcit53j2lhzPH1NLXGXd3n9hxrNnbtm3iUVDH9w3zgslxfmfAzU0Ba8_ Q7qUHDbwHazAU2J3vopbwPIjiYozZfROXR2eC2uiRpkdmB9qtFYpFlN60prtHtb.XvIg_RNdKvSr hwrMITRxr14fCmOHuvDtWCeTaIVucHKKxkwMrIqI6dC_syGSsDNKPrBESKMehBTxFnjdom7N30Qs IAbw_xTW5wezkdZWxkl6sNmGy_J3o5bm4dObKlA7URsy00mo_BKOp2CHA.rlmC9zv8xb8eGbGK4G RRWpyWuki1wepn_VbwJIdMGyiHCb_PhT6GRH7i34y.d91A6FxIEl5HbAiI6NbBx7vXRm2kPKn625 K_ozl_MgtwdOBxMV6ykpkAleskj8AgKX9QCW4jgwhgB_8rVc6Inbeli7NlSmeXwPHGlfFvck98VF lpjpD1BLjlIWKMcuPzplJxVx4fIV39eqL.1zZIpoThZ8Bc4Z5J_1OVfOaNuR8I.d8trDX2S10XBI Gd82oaiu0qO7XCElQ7kNxFe2UtWp3kbOkcy0YmmrPtJtIj11MMJxI_xevcGAaiws3f_LV_Pe5.8Y Ge8X492OPnM.HgTPridOuVlU4id.NxVT_wCwgcehmfBz.ro9c_Rcag4RAdEpfxc5a_LLZMunhMhM 19NBIFvwEZ_ZHJrFtAVwXWjpCRXBEUmyRT93c5Q5ezU13YwyNRP0v7afrDMj.75Osx4XzBZlpSfc 2t8HNdkXS5PzdBSlHciNDCtSe5L3RrVLYb2Yt_sz0RUICNfBdKCanew3uCVMph8BUIXva7wBbcnB 44cNU3YkMFX7mwE4biye3bRMWFB_XPP98o7bVGQHJDP344SyMHesX_WfWMgXfJA3ucvhuGxwfPDR Vbqs0BMtJs9bAwIPwl6J5u4ZqbGaVEiKTjTbxuzgPJ.2jn8UklJfMMs1hx4g8TldBaXeXtwbct5W Fdlw.tfcb9ythP3XzWuL4sTJMwttoU9dy.byu2Lhj6igvl5IoC7uUtTMRuj872azpkRpmRUirTEO qYU4NcAd4nzhPxczs52mvGg6n6S_tzwEH.Qqavo63JltxQeWnnPRK3vIR3W4JrBE04IJJJpfQEkp To6aARLOcXPse2yPaQvwj85KVgklmF0J2PgDDAXbE8rCzgn9SKlGbjMSOfLuQiDMyD.U875o1_Sp EhUXH2nZTUCAikZBtSoOOvyrx6ffZaosa701poMkjTUkqQobPK3SpIdM4qzzrcAT5.s_FoocdH6u yXhL_QVSp6Mr9YZDn26mpKh9UszmSlLtrMdTS8F_AednAk6M6Vg9t4V_t3Qxo7.pKxDMMw_2sk_E 36_ImdMyl8vwfKoo3UhyPOL_7t31kYcex9Fj2HRX0GhaI0.yYnLtM8R5ZUe4zc7nsiv6pFDpyR9e 2VRJ4S1u1rywiALhB4yOZunTSRE2FqgBtrIJPmzju3eQLC_0rI325fVisO61IozMG4dkeSBXU2hk ZGDlEIroFg3wykL1DjMtMA7D8gCdSy3AlYyvtCnkuQa.K2KVUhKSMRTtTkVjgsWNmF6sRs1b__27 C_cWyg6kw1aKW0EAX1Fgab5cCmOiaJ252Ww.7jC.UnFl_J3v6y89RtWbZ2fXsio7uxut4L1MsZOd C5CL.WLEuQH9WXNffvOu._NH84HwHkp8x0EHInn9CKr_GjZaWRbQVximtXPk8ni6p5cTrP..z4QL VyqKsECsPOj_Hdep4VIQQ1z_2yFi8EFZFGeeCsDbbn70MRn91gw-- X-Sonic-MF: X-Sonic-ID: 09078ce0-2bc1-401f-ad88-795e2cc96de8 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Thu, 29 Jan 2026 16:22:28 +0000 Received: by hermes--production-gq1-86969b76cd-9v8tf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2d85dabad46e443222a557b4c3608952; Thu, 29 Jan 2026 16:22:26 +0000 (UTC) Message-ID: Date: Thu, 29 Jan 2026 08:22:25 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 56970c3c4b0b - main - loader: Prefer comma-separated list of values for "console" To: Michael Osipov , dev-commits-src-main@FreeBSD.org References: <697b1e0e.27b69.ae3352c@gitrepo.freebsd.org> Content-Language: en-US From: Mark Millard Cc: Warner Losh In-Reply-To: <697b1e0e.27b69.ae3352c@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.24987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 4f24DT4N7xz3FkF X-Spamd-Bar: ---- On 1/29/26 00:45, Michael Osipov wrote: > The branch main has been updated by michaelo: > > URL: https://cgit.FreeBSD.org/src/commit/?id=56970c3c4b0bc61d972837661a31cc2b9e8e8d7c > > commit 56970c3c4b0bc61d972837661a31cc2b9e8e8d7c > Author: Michael Osipov > AuthorDate: 2026-01-28 09:02:33 +0000 > Commit: Michael Osipov > CommitDate: 2026-01-29 08:44:45 +0000 > > loader: Prefer comma-separated list of values for "console" > > PR: 292595 > Reviewed by: imp > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D54923 > --- > release/tools/azure.conf | 2 +- > release/tools/openstack.conf | 2 +- > stand/efi/loader/main.c | 4 ++-- > stand/i386/loader/main.c | 4 ++-- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/release/tools/azure.conf b/release/tools/azure.conf > index 981e40566a1c..4fa6ba4d924d 100644 > --- a/release/tools/azure.conf > +++ b/release/tools/azure.conf > @@ -59,7 +59,7 @@ autoboot_delay="-1" > beastie_disable="YES" > loader_logo="none" > hw.memtest.tests="0" > -console="comconsole efi vidconsole" > +console="comconsole,efi,vidconsole" > comconsole_speed="115200" > boot_multicons="YES" > boot_serial="YES" > diff --git a/release/tools/openstack.conf b/release/tools/openstack.conf > index 9ce65a75c3c5..6cfb02bab9af 100644 > --- a/release/tools/openstack.conf > +++ b/release/tools/openstack.conf > @@ -33,7 +33,7 @@ vm_extra_pre_umount() { > echo 'autoboot_delay="-1"' >> ${DESTDIR}/boot/loader.conf > echo 'beastie_disable="YES"' >> ${DESTDIR}/boot/loader.conf > echo 'boot_multicons="YES"' >> ${DESTDIR}/boot/loader.conf > - echo 'console="comconsole vidconsole"' >> ${DESTDIR}/boot/loader.conf > + echo 'console="comconsole,vidconsole"' >> ${DESTDIR}/boot/loader.conf > echo 'comconsole_speed="115200"' >> ${DESTDIR}/boot/loader.conf > > # Reboot quickly, Don't wait at the panic screen > diff --git a/stand/efi/loader/main.c b/stand/efi/loader/main.c > index 22dbd10a0f37..7ff2cf188509 100644 > --- a/stand/efi/loader/main.c > +++ b/stand/efi/loader/main.c > @@ -1316,10 +1316,10 @@ main(int argc, CHAR16 *argv[]) > setenv("console", "comconsole", 1); > break; > case VID_SER_BOTH: > - setenv("console", "efi comconsole", 1); > + setenv("console", "efi,comconsole", 1); > break; > case SER_VID_BOTH: > - setenv("console", "comconsole efi", 1); > + setenv("console", "comconsole,efi", 1); > break; > /* case VIDEO_ONLY can't happen -- it's the first if above */ > } [Note: I CC'd Warner just because I'm not sure anyone else knows for sure about this area's complicated history and issues.] This looks possibly wrong to me for efi for all but amd64 --but for the references to comconsole, not the space vs. comma issue. stand: efi create eficom console device. (2023-05-11) QUOTE of console=comconsole talks to the hardware directly. This is available only on amd64. It is not available anywhere else (and so requires changes for people doing comconsole on aarch64) console=eficom talks to the console via EFI protocols. It's available on amd64, aarch64 and riscv64. It's the first port that we find, though it can be overriden by efi_com_port (which should be set to the UID of the serial port, not the I/O port, despite the name). devinfo -v will give the UID to uartX mapping. This is an incompatible change for HYPER-V on amd64. It only works with eficom console, so you'll need to change your configuration in loader.conf. No compatibility hack will ever be provided for this (since it requires renamig, which the loader cannot reliably do). It's also an incompatible change for aarch64. comconsole will need to change to eficom. There might be a comconsole "shim" for this. END QUOTE stand: add comconsole backwards compatibility shim for aarch64 (2023-05-11) QUOTE of Add a compat shim for the "comconsole" name so that people with a "console=comconsole" in their loader.conf on aarch64 will continue to work (though with a warning). This is only aarch64: it will never be there for amd64 (where comconsole always means talk to the hardware directly). To do that is too hard. END QUOTE But that last (f93416d67743) is only for: +#if defined(__aarch64__) && __FreeBSD_version < 1500000 +/* Hack for backward compatibility -- but only for a while */ +extern struct console comconsole; +#endif . . . +#if defined(__aarch64__) && __FreeBSD_version < 1500000 + &comconsole, +#endif . . . (and so on) . . . So, as of FreeBSD 15+, aarch64 does not have comconsole as far as I can tell. It looks to me like for FreeBSD 15+ eficom should be referenced mostly, instead of comconsole, comconsole being only for amd64. For FreeBSD 14.3+ and stable/14 it may be that comconsole should be used for amd64 and aarch64. (stable/13 does not have the commits at all.) There is also a prior: if (efi_has_gop()) how |= RB_MULTIPLE; else how |= RB_MULTIPLE | RB_SERIAL; setenv("console", "efi,comconsole", 1); and: #if defined(__riscv) /* * This workaround likely is papering over a real issue */ if ((uhowto & RB_SERIAL) != 0) setenv("console", "comconsole", 1); #endif that may well both be wrong for stand/efi/loader/main.c too. > diff --git a/stand/i386/loader/main.c b/stand/i386/loader/main.c > index a70b3a253b90..7538c6d4fb3f 100644 > --- a/stand/i386/loader/main.c > +++ b/stand/i386/loader/main.c > @@ -162,9 +162,9 @@ main(void) > bi_setboothowto(initial_howto); > if (initial_howto & RB_MULTIPLE) { > if (initial_howto & RB_SERIAL) > - setenv("console", "comconsole vidconsole", 1); > + setenv("console", "comconsole,vidconsole", 1); > else > - setenv("console", "vidconsole comconsole", 1); > + setenv("console", "vidconsole,comconsole", 1); > } else if (initial_howto & RB_SERIAL) { > setenv("console", "comconsole", 1); > } else if (initial_howto & RB_MUTE) { > > -- === Mark Millard marklmi at yahoo.com