From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Apr 27 15:04:00 2005 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AB3816A4CE; Wed, 27 Apr 2005 15:04:00 +0000 (GMT) Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9337D43D2F; Wed, 27 Apr 2005 15:03:59 +0000 (GMT) (envelope-from vd@datamax.bg) Received: from sinanica.bg.datamax (sinanica.bg.datamax [192.168.10.1]) by jengal.datamax.bg (Postfix) with QMQP id B4EEB87EC; Wed, 27 Apr 2005 18:03:57 +0300 (EEST) Received: (nullmailer pid 51510 invoked by uid 1004); Wed, 27 Apr 2005 15:03:57 -0000 Date: Wed, 27 Apr 2005 18:03:57 +0300 From: Vasil Dimov To: Tomaz Message-ID: <20050427150357.GA51319@sinanica.bg.datamax> References: <200504270935.j3R9ZJgn056250@www.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="eAbsdosE1cNLO4uF" Content-Disposition: inline In-Reply-To: <200504270935.j3R9ZJgn056250@www.freebsd.org> X-OS: FreeBSD 5.4-STABLE User-Agent: Mutt/1.5.9i cc: freebsd-ports-bugs@freebsd.org cc: bug-followup@FreeBSD.org Subject: Re: ports/80395: libmemcache does not properly configure itself on FreeBSD 4.11 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: vd@datamax.bg List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2005 15:04:00 -0000 --eAbsdosE1cNLO4uF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The problem is that pmk tries to include sys/socket.h without sys/types.h and the following program fails: #include #include int main() {return(0);} In file included from ./pmk_SG9entFc.c:2: /usr/include/sys/socket.h:52: syntax error before `sa_family_t' /usr/include/sys/socket.h:52: warning: data definition has no type or storage class /usr/include/sys/socket.h:163: syntax error before `u_char' /usr/include/sys/socket.h:174: syntax error before `u_short' ..... Does anyone know how to force pmk include sys/types.h before sys/socket.h in its test programs, so we can create the proper patch? The attached patch removes failing checks as we certainly know they would pass on FreeBSD if appropriate headers were included as in the source of libmemcache. --eAbsdosE1cNLO4uF Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="pmkfile.patch" --- pmkfile.orig Wed Apr 27 14:54:44 2005 +++ pmkfile Wed Apr 27 11:35:47 2005 @@ -16,13 +16,13 @@ IF(!debug) { DEFINE { - CFLAGS = "-std=c99 -pipe -O3" + CFLAGS = "-pipe -O3" } } IF(debug) { DEFINE { - CFLAGS = "-std=c99 -g -Wall -Wunused -Wshadow -Wpointer-arith -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings -Wsign-compare -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wformat -Wpacked -Wdeprecated-declarations -Wredundant-decls -Wnested-externs -Winline -Wdisabled-optimization -pipe -pedantic" + CFLAGS = "-g -Wall -Wunused -Wshadow -Wpointer-arith -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings -Wsign-compare -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wformat -Wpacked -Wdeprecated-declarations -Wredundant-decls -Wnested-externs -Winline -Wdisabled-optimization -pipe -pedantic" } } @@ -121,24 +121,6 @@ NAME="unistd.h" } -CHECK_HEADER(include_socket) { - REQUIRED=TRUE - FUNCTION="socket" - NAME="sys/socket.h" -} - -CHECK_HEADER(include_setsockopt) { - REQUIRED=TRUE - FUNCTION="setsockopt" - NAME="sys/socket.h" -} - -CHECK_HEADER(include_connect) { - REQUIRED=TRUE - FUNCTION="setsockopt" - NAME="sys/socket.h" -} - CHECK_HEADER(include_freeaddrinfo) { REQUIRED=TRUE FUNCTION="freeaddrinfo" @@ -170,12 +152,6 @@ NAME="ctype.h" } -CHECK_HEADER(include_readv) { - REQUIRED=TRUE - FUNCTION="readv" - NAME="sys/uio.h" -} - CHECK_HEADER(include_errno) { REQUIRED=FALSE FUNCTION="errno" @@ -194,12 +170,6 @@ NAME="unistd.h" } -CHECK_HEADER(include_writev) { - REQUIRED=TRUE - FUNCTION="writev" - NAME="sys/uio.h" -} - CHECK_HEADER(include_snprintf) { REQUIRED=TRUE FUNCTION="snprintf" @@ -281,12 +251,6 @@ REQUIRED=TRUE FUNCTION="bzero" NAME="strings.h" -} - -CHECK_HEADER(include_select) { - REQUIRED=TRUE - FUNCTIOn="select" - NAME="sys/select.h" } CHECK_HEADER(include_strdup) { --eAbsdosE1cNLO4uF--