From owner-freebsd-current Sun Mar 5 18:58:28 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id SAA18808 for current-outgoing; Sun, 5 Mar 1995 18:58:28 -0800 Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id SAA18802 for ; Sun, 5 Mar 1995 18:58:24 -0800 Received: (from nate@localhost) by trout.sri.MT.net (8.6.9/8.6.9) id UAA24058; Sun, 5 Mar 1995 20:02:02 -0700 Date: Sun, 5 Mar 1995 20:02:02 -0700 Message-Id: <199503060302.UAA24058@trout.sri.MT.net> To: "Justin T. Gibbs" Cc: current@FreeBSD.org Subject: Re: Kernel build fails? In-Reply-To: <199503052306.PAA10391@estienne.cs.berkeley.edu> References: <199503052306.PAA10391@estienne.cs.berkeley.edu> Reply-To: nate@sneezy.sri.com (Nate Williams) From: nate@sneezy.sri.com (Nate Williams) Sender: current-owner@FreeBSD.org Precedence: bulk Justin T. Gibbs writes: > > Today's kernel falls over for me: > > loading kernel > tty.o: Definition of symbol `_ttydefchars' (multiply defined) > tcp_output.o: Definition of symbol `_tcp_outflags' (multiply defined) > tcp_subr.o: Definition of symbol `_tcp_outflags' (multiply defined) > sio.o: Definition of symbol `_ttydefchars' (multiply defined) > *** Error code 1 > > Is this related to Nate's ld changes? I did a make world last night, so > this should be with the new ld. Okay, this should be fixed now. The definition of tcp_outflags wasn't needed in tcp_subr.c, and I changed the declaration of ttydefchars to static per Bruce Evans suggestion. There needs to be a better solution to the ttydefchars problem (and others) since we really shouldn't be declaring data inside of .h files, but this is the best fix proposed that solves the broken kernel build problems which doesn't break the user-land code. Again, I'm sorry I didn't catch this sooner, but everything seems to be working on my box again after testing this stuff out. Nate