Date: Wed, 16 Jul 2014 16:20:09 +0200 From: Kurt Jaeger <pi@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r361987 - in head/security: . signify signify/files Message-ID: <20140716142009.GR73593@f10.opsec.eu> In-Reply-To: <20140716095652.GB53961@FreeBSD.org> References: <201407151748.s6FHmep9006450@svn.freebsd.org> <20140716095652.GB53961@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi!
> > 'signify' from OpenBSD as of July 15 2014, with the necessary plumbing
> > cobbled together from the OpenBSD CVS to make it compile under Linux.
>
> Sorry, but this is very poor work.
>
> > +COMMENT= OpenBSD signify ported by fefe
>
> Who/what is "fefe"? Organization, person, robot, a giant mushroom?
See the other mail.
I changed it.
> > +do-install:
> > + ${CP} ${WRKSRC}/signify ${STAGEDIR}${PREFIX}/bin
>
> Why INSTALL_PROGRAM was not used instead?
Because I just did not remember the proper command 8-}
> It does some nice things like
> ensuring correct permissions and stripping of executables.
Fixed.
> > +-CC=gcc -D_GNU_SOURCE -D_BSD_SOURCE -DHAVE_SYS_SYSCALL_H
> > ++CC=clang -D_GNU_SOURCE -D_BSD_SOURCE -DHAVE_SYS_SYSCALL_H
>
> You realise that there are FreeBSD releases that are still GCC-based? Why
> clang is even required for this port?
Because the host I tested it on had several gcc versions, and
I did not want to hard-code a specific one. Yes, you are right,
that was sloopy.
> Even if it is (which I really doubt)
> it should've been set via MAKE_ARGS instead of the privial patch file, and
> correct USES=compiler:... provided as well.
>
> > + CFLAGS=-Os -pipe
>
> We generally try to uphold our CFLAGS (also easier to do via MAKE_ARGS than
> to patch Makefile in simple cases like this one).
I committed a fix.
> > +++ head/security/signify/pkg-plist Tue Jul 15 17:48:40 2014 (r361987)
> > @@ -0,0 +1 @@
> > +bin/signify
>
> One-line pkg-plist, in 2014? (Hint: PLIST_FILES).
Yes, yes! "Dont be tired and commit!" I try to remember this rule 8-}
--
pi@FreeBSD.org +49 171 3101372 6 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140716142009.GR73593>