From owner-svn-src-head@FreeBSD.ORG  Fri Jan  6 19:19:57 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1205)
	id 99D1F106567B; Fri,  6 Jan 2012 19:19:57 +0000 (UTC)
Date: Fri, 6 Jan 2012 19:19:57 +0000
From: Navdeep Parhar <np@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Message-ID: <20120106191957.GA58317@hub.freebsd.org>
Mail-Followup-To: Gleb Smirnoff <glebius@FreeBSD.org>,
	src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
	svn-src-head@FreeBSD.org
References: <201201061829.q06ITfP0001841@svn.freebsd.org>
	<20120106190515.GU34721@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120106190515.GU34721@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r229714 - head/sys/netinet
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jan 2012 19:19:57 -0000

On Fri, Jan 06, 2012 at 11:05:15PM +0400, Gleb Smirnoff wrote:
>   Navdeep,
> 
> On Fri, Jan 06, 2012 at 06:29:41PM +0000, Navdeep Parhar wrote:
> N> Author: np
> N> Date: Fri Jan  6 18:29:40 2012
> N> New Revision: 229714
> N> URL: http://svn.freebsd.org/changeset/base/229714
> N> 
> N> Log:
> N>   Always release the inp lock before returning from tcp_detach.
> 				 ^ after ?

I don't see anything wrong in the message.  The lock is released within
tcp_detach (before it returns), and not after.


Navdeep


> 
> N> Modified:
> N>   head/sys/netinet/tcp_usrreq.c
> N> 
> N> Modified: head/sys/netinet/tcp_usrreq.c
> N> ==============================================================================
> N> --- head/sys/netinet/tcp_usrreq.c	Fri Jan  6 18:18:25 2012	(r229713)
> N> +++ head/sys/netinet/tcp_usrreq.c	Fri Jan  6 18:29:40 2012	(r229714)
> N> @@ -204,8 +204,10 @@ tcp_detach(struct socket *so, struct inp
> N>  			tcp_discardcb(tp);
> N>  			in_pcbdetach(inp);
> N>  			in_pcbfree(inp);
> N> -		} else
> N> +		} else {
> N>  			in_pcbdetach(inp);
> N> +			INP_WUNLOCK(inp);
> N> +		}
> N>  	}
> N>  }
> N>  
> 
> -- 
> Totus tuus, Glebius.