Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Oct 2010 01:03:31 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r213537 - head/sys/dev/usb/wlan
Message-ID:  <201010080103.o9813VbC073284@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Fri Oct  8 01:03:30 2010
New Revision: 213537
URL: http://svn.freebsd.org/changeset/base/213537

Log:
  In r207768 I silenced a console warning from rum(4).  There was legitimate
  opposition to the change, since really we need to implement missing
  functionality in drivers or the 802.3 layer.
  
  For now, restore a reminder message for a missing rum_update_mcast, but
  print it only once.

Modified:
  head/sys/dev/usb/wlan/if_rum.c

Modified: head/sys/dev/usb/wlan/if_rum.c
==============================================================================
--- head/sys/dev/usb/wlan/if_rum.c	Fri Oct  8 00:44:53 2010	(r213536)
+++ head/sys/dev/usb/wlan/if_rum.c	Fri Oct  8 01:03:30 2010	(r213537)
@@ -1819,8 +1819,12 @@ rum_update_promisc(struct ifnet *ifp)
 static void
 rum_update_mcast(struct ifnet *ifp)
 {
+	static int warning_printed;
 
-	/* XXX do nothing? */
+	if (warning_printed == 0) {
+		if_printf(ifp, "need to implement %s\n", __func__);
+		warning_printed = 1;
+	}
 }
 
 static const char *



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010080103.o9813VbC073284>