From owner-svn-src-all@freebsd.org Thu Aug 13 16:28:26 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4774837DD65 for ; Thu, 13 Aug 2020 16:28:26 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BSBp06Cspz4Tmw for ; Thu, 13 Aug 2020 16:28:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f67.google.com with SMTP id f12so5818311wru.13 for ; Thu, 13 Aug 2020 09:28:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=C5Ip2FOgYoYhZuzTjd8zJhymMg2fSB5i5gKLktVF45I=; b=c/ESid1uYQ+44O2L+zLsmf49wyAhA49X1dGkMyrFDyjHlW/wl1W/0ZiHiD+m16eOXW XJgS/I5ovvrEVIS1c0iAzdM3tZY79sDNQyPI2EjA16Wu83KVERD8GEaLjcfpMaxpt106 xc/slZ2WIxNXo3aFL1+HzOeglLW396qGdjet5l5OPbO+17DM3E8aMeDFwfpybUSEiVRy H05MBcsP4bsbIwR5Ol5NritemfCSdOg01qBM4oWmPLCsaOcZAWmEM8jMTXU3thwSkxHF lygG5sBwL1w5XcTSsaGp3FXKTNHYhpj/J32Y+t+4/ICE7tVQHpcpa6DTa7rnYyQkIhAG B0CQ== X-Gm-Message-State: AOAM530eSgiRaBXNPusJybydwP8GnTz0O3ostaYuKcWwHECuHIxqVhX9 b5YfGMxZ1cJmvHLqOwVt5ufOnQ== X-Google-Smtp-Source: ABdhPJwlZb7ypEeY2KKZYbOsae0w6W67uzXFPAwHCVcC5CRHseIXdmplFukeS+y8MEP4YeITsHvOgA== X-Received: by 2002:a5d:63d1:: with SMTP id c17mr4942661wrw.241.1597336103508; Thu, 13 Aug 2020 09:28:23 -0700 (PDT) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id y142sm10981945wmd.3.2020.08.13.09.28.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Aug 2020 09:28:22 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: svn commit: r364190 - head/tools/build From: Jessica Clarke In-Reply-To: <202008131622.07DGMoMw043409@gndrsh.dnsmgr.net> Date: Thu, 13 Aug 2020 17:28:22 +0100 Cc: Alex Richardson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <84875FF7-A833-4FA1-9BB0-B75D607C4183@freebsd.org> References: <202008131622.07DGMoMw043409@gndrsh.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Rspamd-Queue-Id: 4BSBp06Cspz4Tmw X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.51 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.02)[-1.021]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.999]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.67:from]; NEURAL_HAM_MEDIUM(-0.99)[-0.987]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.67:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 16:28:26 -0000 On 13 Aug 2020, at 17:22, Rodney W. Grimes = wrote: >=20 >> Author: arichardson >> Date: Thu Aug 13 14:14:46 2020 >> New Revision: 364190 >> URL: https://svnweb.freebsd.org/changeset/base/364190 >>=20 >> Log: >> Add pwd to the list of tools that are linked to $WORLDTMP/legacy >=20 > Since "sh" is already in this list, and our "sh" has a builtin pwd > that does the correct thing with pwd -P this should not be needed. >=20 > Or are we contininue to use the host "sh" for far too long? >=20 > For me from ancient days of hand bootstrapping BSD sources onto > another system sh(1) and make(1) are the first 2 tools to get > working. The issue is that r364174 used `env pwd -P` rather than just `pwd -P`. = With that fixed, this should be revertible; even if the bootstrap sh isn't = being used at this point, I don't know of any contemporary sh-compatible shell = that doesn't implement pwd as a builtin (but surely we are using the = bootstrap sh by this point otherwise BUILD_WITH_STRICT_TMPPATH would have complained = about sh). Jess >> After r364166 and r364174, crunchgen needs a pwd binary in $PATH = instead >> of using a hardcoded absolute path. This commit is needed for >> BUILD_WITH_STRICT_TMPPATH builds (currently not on by default). >>=20 >> Modified: >> head/tools/build/Makefile >>=20 >> Modified: head/tools/build/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/tools/build/Makefile Thu Aug 13 13:59:31 2020 = (r364189) >> +++ head/tools/build/Makefile Thu Aug 13 14:14:46 2020 = (r364190) >> @@ -113,8 +113,8 @@ SYSINCS+=3D ${SRCTOP}/sys/sys/font.h >> # Linux/MacOS since we only use flags that are supported by all of = them. >> _host_tools_to_symlink=3D basename bzip2 bunzip2 chmod chown cmp = comm cp date dd \ >> dirname echo env false find fmt gzip gunzip head hostname id ln = ls \ >> - mkdir mv nice patch rm realpath sh sleep stat tee touch tr true = uname \ >> - uniq wc which >> + mkdir mv nice patch pwd rm realpath sh sleep stat tee touch tr = true \ >> + uname uniq wc which >>=20 >> # We also need a symlink to the absolute path to the make binary used = for >> # the toplevel makefile. This is not necessarily the same as `which = make` >>=20 >=20 > --=20 > Rod Grimes = rgrimes@freebsd.org