From owner-cvs-src-old@FreeBSD.ORG Wed Jul 8 05:58:18 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8BD9106564A for ; Wed, 8 Jul 2009 05:58:18 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 942E98FC0A for ; Wed, 8 Jul 2009 05:58:18 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n685wIec085744 for ; Wed, 8 Jul 2009 05:58:18 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n685wIng085743 for cvs-src-old@freebsd.org; Wed, 8 Jul 2009 05:58:18 GMT (envelope-from marcel@repoman.freebsd.org) Message-Id: <200907080558.n685wIng085743@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to marcel@repoman.freebsd.org using -f From: Marcel Moolenaar Date: Wed, 8 Jul 2009 05:56:14 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata atapi-cd.c src/sys/geom geom_dev.c src/sys/geom/part g_part.c g_part_if.m src/sys/sys disk.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2009 05:58:18 -0000 marcel 2009-07-08 05:56:14 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cd.c sys/geom geom_dev.c sys/geom/part g_part.c g_part_if.m sys/sys disk.h Log: SVN rev 195436 on 2009-07-08 05:56:14Z by marcel Revert revisions 188839 and 188868. Use of the ioctl in geom_dev.c is invalid because the ioctl happens without prior open. The ioctl got introduced to provide backward compatibility for extended partitions, but it ended up not being used because it didn't work as expected. Since there are no consumers of the ioctl and the implementation is broken, the best fix is to remove the code entirely. Spotted by: phk Approved by: re (kensmith) Revision Changes Path 1.206 +1 -4 src/sys/dev/ata/atapi-cd.c 1.102 +0 -12 src/sys/geom/geom_dev.c 1.39 +0 -28 src/sys/geom/part/g_part.c 1.9 +0 -9 src/sys/geom/part/g_part_if.m 1.45 +0 -6 src/sys/sys/disk.h