From nobody Wed Feb 4 22:40:07 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f5wKQ3Zhyz6QlqV; Wed, 04 Feb 2026 22:40:10 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f5wKQ2zKWz3LBY; Wed, 04 Feb 2026 22:40:10 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770244810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ATtnWG1uJ9Abov6naU32wXPI3GTAJsmzM0nEdGXGYyM=; b=pggvjOxXHXKWdS+9asU4hGRUXUt73HrUzNIH90mkd5NGIYM/CLRGdBsE+pCV7hROfmruTU gYRIXwGLDW10yVWXRaPFq7/4rIVEnH0VH+iYPX8mhRA6G9DnbSc4YeHuRjmh24HI2IlwAw 40gQJg974o+m04LfEkV1b9xf1YcUnt5Hu6ED9bNvsPQtL680BX0SZcSRbuNQkhJk2B6O15 yhhs+U6aPKXr/qTSdec5ysR+vU60L3Jwkj7ZEfU37q/IF8GgHNdZ93RlxRXgq2WeIGomgu OfbWyfoCmQZc4oXVNsmZYzB/7El1z7axdD+htyS5Svj8EYDrulg0muFvOlvb4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770244810; a=rsa-sha256; cv=none; b=jGDF4pqxREIk5Ux3Z1BGyazKKESbE8+Kj4PeKpIlqE6wygqeJMfEOCf517wop56ZQJIwEJ IuKZNSq7xJgMiwGtU+Zy6nr/eGMy0Zg2En5AUeE8YnoEdr/jkxxd3Y/N7zMwp0GSouVSBE HYXaTvsWUMOP/Y7whN984yilrJOL11IgEhz5+haqIo/buF2WJnwHu2JeVRGUurY5CnILUF 5q74PGzNBNsEu4DiLRdPKCyeLgauCI+acvDHVtOqKy6dPbkeP2PKtc7WcdtjGF4YmU08WL qb+wFGRuCcJobQRMnaWfejcBIlAqx/ALWJHGGKhHtlwLq8g2MQsTMkN7orcU5Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770244810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ATtnWG1uJ9Abov6naU32wXPI3GTAJsmzM0nEdGXGYyM=; b=yzv3VHo178ND42ouMIugzwt8BUJZIHixBnPFH3vkkccJhtlyMUMZNzNuh4R+kjJ/hw5xnH axoTPaWZFw3S/6vm2idJGurGDsg82LRUXmM0f69VUcf5hHLJ0J5VoZYHZymnbYmA9K6Aud zKeTezvQJ1Te+TXBkRQDPjSJ9BlMG1rCE9KJ/VmX09oPLFz5eIaUXARB0d4t28B6wbrBUz rKi08+XDlpXa+Xy8K3nBIuWeWt30yZrZCD2QpwKU6naWUO0kVJ7HWttUcid6GNkRveyLE/ wn/iBN/TFBq91IzsAKXANcaF8AjX1fOXxCKDvh2vYlalj3CfABuhKf+jl8o5TA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f5wKP4Wb4zvjJ; Wed, 04 Feb 2026 22:40:09 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 4 Feb 2026 14:40:07 -0800 From: Gleb Smirnoff To: Zhenlei Huang Cc: Mark Johnston , src-committers@freebsd.org, "" , dev-commits-src-main@freebsd.org Subject: Re: git: 349fcf079ca3 - main - net: add ifnet_rename_event EVENTHANDLER(9) for interface renaming Message-ID: References: <6948abb4.37a66.71609f61@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 04, 2026 at 09:21:37AM +0800, Zhenlei Huang wrote: Z> >> commit 349fcf079ca32d5c93e45366d2b27638747affeb Z> >> Author: Gleb Smirnoff Z> >> AuthorDate: 2025-12-21 21:31:43 +0000 Z> >> Commit: Gleb Smirnoff Z> >> CommitDate: 2025-12-22 02:23:14 +0000 Z> >> Z> >> net: add ifnet_rename_event EVENTHANDLER(9) for interface renaming Z> >> Z> >> and don't trigger ifnet_arrival_event and ifnet_departure_event for a Z> >> rename, as the interface isn't being detached from any protocol. The Z> >> consumers of the arrival/departure events are divided into a few Z> >> categories: Z> >> - which indeed need to do the same actions as if interface was fully Z> >> detached and attached: routing socket and netlink notifications to Z> >> userland and the Linux sysfs. All addressed by this commit. Z> >> - which build their logic based on an interface name, but should actually Z> >> update their database on rename: packet filters. This commit leaves Z> >> them with the old behavior - emulate full detach & attach, but this Z> >> should be improved. Z> >> - which shouldn't do anything on rename, not touched by the commit. Z> >> - ng_ether and if_tuntap, that are special and will be addressed by Z> >> separate commits. Z> > Z> > Can we get rid of the IFF_RENAMING flag now? IIUC all of its uses are Z> > in ifnet_departure_event handlers to short-circuit the handler because Z> > the interface is not actually going away. Z> Z> Now that we have ifnet_rename_event, I think the flag IFF_RENAMING is Z> not longer required. Z> Z> Well there're still some consumers, they should be cleaned up prior to retire Z> IFF_RENAMING. 100% correct. Fell free to do that, or I can do that. -- Gleb Smirnoff