From owner-svn-src-head@freebsd.org Sun Apr 12 19:43:19 2020 Return-Path: <owner-svn-src-head@freebsd.org> Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71B362C72C3 for <svn-src-head@mailman.nyi.freebsd.org>; Sun, 12 Apr 2020 19:43:19 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic317-20.consmr.mail.gq1.yahoo.com (sonic317-20.consmr.mail.gq1.yahoo.com [98.137.66.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 490hxf1KLwz4Z9R for <svn-src-head@freebsd.org>; Sun, 12 Apr 2020 19:43:17 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: YT7UHPUVM1ljMsIGYmrfMyISIDG39FI4N0BX7uwRxbgmaEx9P3VFNnElLcMMuIo izuq5N2xB4Z3lQ1gA8hVGztefrElh2oDEXUhOlF3qw9Ph71xfUBP3K1Yivu_WUW2XEWFpxbPynEz B_VXyNGWR11uWRxkITRd5CTMhrUNqrIZ88dTIClViuvWDj2sQ2fKRGAiuq8qmhBd14VNmL2Egbay Qb5DWRxpcSWG6h.a.LhSa4P.WPVFZpK.sm8y0k3x9xAEvmG510rd4YzHr_6bEmr2wcw2IJY6wS.b 4L0J1Cn1bo.NUrZUm2q.CYKS7mq0YbJFiNxUXNAYE0cniWGay63eZe29MVA.Cwv4qnELd_Vwft2n u4Qz7bNCVAIeer_YI79cgE8dMVe272yEWDg7dGmR8FdIr0HiZXae9XMZ84SqzMMWmlMIrIGpLyIC wb5DTaoq2SJyOc8EXz5cyT8MIyM0SbYXWDI9AVrW7xiUQqgFr9VpI.XqQP26V_macG3qgfynYqTi 4LpNUeqAFRQc7dg60Ma8bNW7ElVbgyajILsURmKutcKmQdQiaeHO2vEkpZUndTO_3_2Cqdh2TBbD L9aU6YgHn5NqgBEAFkR_wPc2uq7KXRKjCCypwudRRplFvvfc_MeLJxbS0Nl1.MOMD_phrCyGiCbl I_jCZWjxzfypF9m7mIbqNsES0gW94ProFxGuQTKKTHS5k3ncVHjVPzbXsLM47RSGODiTn54QWCbH UsOr86VkCuLG2DQXEwzWmmSDkQEYmO.cWB5Tu5Y.Siv.BKjUgy_cS.RNQj3OmcPOOYQHIQkNjSU4 d.piXj.mICzjljLiOflkUBL9gvoSyV73CoyPapaQJjD8eo8rNw64CKaQqsQPL5FFAmuFvwg0tX6G rcahRwiII2L1BDwI3cLS3MzpASeCvT_RvmRL7w03pWJFhc9jrAb8zN3lHyCukHuWnJHn1WavuZbZ lu9yngqKaT3GMmoSSQxitrGuE7_MQW3w76x7RUQHMlscLKVpbRGqZSg_pmfc9hu.niTubqK8b_Gs bQbsbKRx44fisV7UX0TO8J63aS6ZVkeSO6G3Ej55HTCWxCVi0GVYVYVB2Gu0ydM2HEcZNYZzxmYg k7Av6n4_WCj0._xXKX807lJUy4otFDAQgQOdS4sXmr7Dw7OPV_xuxWW_kc1G1lGxHT_vfhd9Kygt 2wCAEla5znBQk95XFxOiZD0zBeMFWWBcqrlnXmkzf3ZMzfFuqQ_4j4SzyNpJf_LUcz8fOlR.E3r4 WRlz6EP4lRJH5nQoAR8SRE.aH25xUEr_6Ax1.uf44XlkSl9K.l.I3QTQkc4RA0fHjeOOurQtz3kq bZ0SXmmGtWfGP21xGPOrL5zxw_.6clIOSgGzHH2YtugiLt3EAx.R7u77GJ5s0NWHYQWdSlGBxuMh Yq8HEHXvqdnZKdw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Apr 2020 19:43:14 +0000 Received: by smtp408.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 11ed29bf99e374ff22cef9309f149490; Sun, 12 Apr 2020 19:43:09 +0000 (UTC) From: Mark Millard <marklmi@yahoo.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: svn commit: r359829 - in head/sys: amd64/conf conf Message-Id: <A3E65DD3-5F41-4353-A6C9-8F9431CFB6AA@yahoo.com> Date: Sun, 12 Apr 2020 12:43:07 -0700 To: Conrad Meyer <cem@freebsd.org>, svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3608.80.23.2.2) References: <A3E65DD3-5F41-4353-A6C9-8F9431CFB6AA.ref@yahoo.com> X-Rspamd-Queue-Id: 490hxf1KLwz4Z9R X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.05 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.62)[-0.625,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-0.92)[-0.921,0]; IP_SCORE_FREEMAIL(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[146.66.137.98.list.dnswl.org : 127.0.5.0]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.00)[ip: (3.16), ipnet: 98.137.64.0/21(0.83), asn: 36647(0.66), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/> List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 12 Apr 2020 19:43:19 -0000 > Author: cem > Date: Sun Apr 12 18:04:20 2020 > New Revision: 359829 > URL:=20 > https://svnweb.freebsd.org/changeset/base/359829 >=20 >=20 > Log: > Add queue(2) debug macros as build options > =20 > Add QUEUE_MACRO_DEBUG_TRACE and QUEUE_MACRO_DEBUG_TRASH as proper = kernel > options. While here, alpha-sort the debug section of = sys/conf/options. > =20 > Enable QUEUE_MACRO_DEBUG_TRASH in amd64 GENERIC (but not = GENERIC-NODEBUG) > kernels. It is similar in nature and cost to other use-after-free = pointer > trashing we do in GENERIC. It is probably reasonable to enable in = any arch > GENERIC kernel that defines INVARIANTS. Going the other way: Is QUEUE_MACRO_DEBUG_TRASH unsafe when INVARIANTS has been disabled? I historically produce non-debug/less-debug kernels via including = GENERIC and then disabling various debugging options, including frequently disabling INVARIANTS and INVARIANTS_SUPPORT. Would the following be appropriate for the comments, with its extra "required by" on the first line shown: options INVARIANTS # Enable calls of extra sanity = checking, required by QUEUE_MACRO_DEBUG_TRASH options INVARIANT_SUPPORT # Extra sanity checks of = internal structures, required by INVARIANTS options QUEUE_MACRO_DEBUG_TRASH # Trash queue(2) internal = pointers on invalidation Should head/sys/conf/NOTES have material about avoiding QUEUE_MACRO_DEBUG_TRASH with INVARIANTS disabled? =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)