From owner-svn-src-head@freebsd.org Fri Apr 14 15:55:41 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3C4ECD3D57F; Fri, 14 Apr 2017 15:55:41 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yb0-x22e.google.com (mail-yb0-x22e.google.com [IPv6:2607:f8b0:4002:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF70E3A7; Fri, 14 Apr 2017 15:55:40 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yb0-x22e.google.com with SMTP id i124so19901835ybc.3; Fri, 14 Apr 2017 08:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0l92peGyC1c0oC3XKcey8A1obDtlicssyrnmqUeajBQ=; b=W6paLrdJ8vuks2rrB/O1HKPhzSSSHb/a6p/ZLl93X7vTlRI4KNC+zoLbqEdeack55V YNxr0twJnUofwVWQILf1jSMkhDupAJW69V452tyU6Cg2NRAtqnVPNa7RMEYfHpm7dIKn 4+DE48nWGhmXpl7gv6IHh9nw0AujbfvwUPuLuySklmMBM+OtMbZcl0CKU5Gojs2gg9V9 cScHju3SeZmWfMkRlujq6MOFngsz0J8hIYQIKUm49he3cDMCK5+oWw9YRIebpvIGKilb MMaMQx290b2Tdw4ts/5YX58casmPUuCiJ+jA4uRY9s4FV0jAnyk9MTbtTskXChcYOeL8 q+iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0l92peGyC1c0oC3XKcey8A1obDtlicssyrnmqUeajBQ=; b=Kp+LBqzlJQRMYfudzU/X7TTFkQ2EoyHd086V/JAFn4PWn5sGC1qGSpIRSDdbfRYW0B j+1TE2FDjpHr4gGrJIC1ocyr4LfdXUheFqWVKV66qI2ADJVF2vJlF1QHA6sajhUPFR6B wFRjRXVMGveQEyeLe4audCw6HtBrxCVwC2HySgdRLJidw0WWa7Q8go7kqsmz88raoQ0U EzjZTbX/OLnxy5xv9QBzzy1wv7uVPtKO06T268BdfN+GcPbCWh9TypZajVLG1ZJhM1eI wVFXlZH5iu1xlqTptIlR9CQFkUkZu/NCw8K3ZN5PNFK8sBzD6CwbtTgcuPylaaM/fjnM 5TDA== X-Gm-Message-State: AN3rC/7b3pje9CytmQK7sjejzWR80c9dfbrT1U8jy3spetGiHVSPt1T8 3wvnALN9CAc2WRndyNdN6aoGGF1p4Q== X-Received: by 10.37.171.132 with SMTP id v4mr6800266ybi.9.1492185339833; Fri, 14 Apr 2017 08:55:39 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.20.214 with HTTP; Fri, 14 Apr 2017 08:55:39 -0700 (PDT) In-Reply-To: <201704141535.v3EFZ7BY096442@repo.freebsd.org> References: <201704141535.v3EFZ7BY096442@repo.freebsd.org> From: Alan Somers Date: Fri, 14 Apr 2017 09:55:39 -0600 X-Google-Sender-Auth: qaM-nqDQv4EqBkrcmiFkuTqDOho Message-ID: Subject: Re: svn commit: r316854 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Andriy Gapon Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 15:55:41 -0000 Are you sure it's a good idea to MFC this change? Doing so will upset anybody currently setting that sysctl in /etc/sysctl.conf. On Fri, Apr 14, 2017 at 9:35 AM, Andriy Gapon wrote: > Author: avg > Date: Fri Apr 14 15:35:07 2017 > New Revision: 316854 > URL: https://svnweb.freebsd.org/changeset/base/316854 > > Log: > rename vfs.zfs.debug_flags to vfs.zfs.debugflags > > While the former name is easier to read, the "_flags" suffix has a special > meaning for loader(8) and, thus, it was impossible to set the knob via > loader.conf(5). The loader interpreted the setting as flags that should > be passed to a kernel module named "vfs.zfs.debug". > > Discussed with: smh > MFC after: 2 weeks > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c Fri Apr 14 15:31:04 2017 (r316853) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c Fri Apr 14 15:35:07 2017 (r316854) > @@ -353,7 +353,7 @@ sysctl_vfs_zfs_debug_flags(SYSCTL_HANDLE > return (0); > } > > -SYSCTL_PROC(_vfs_zfs, OID_AUTO, debug_flags, > +SYSCTL_PROC(_vfs_zfs, OID_AUTO, debugflags, > CTLTYPE_UINT | CTLFLAG_MPSAFE | CTLFLAG_RWTUN, 0, sizeof(int), > sysctl_vfs_zfs_debug_flags, "IU", "Debug flags for ZFS testing."); > >