From owner-freebsd-acpi@FreeBSD.ORG  Fri Jul 13 08:15:41 2012
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0A3D5106566B;
	Fri, 13 Jul 2012 08:15:41 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id BC5408FC08;
	Fri, 13 Jul 2012 08:15:39 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA03637;
	Fri, 13 Jul 2012 11:15:38 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1Spb2I-000ARe-2s; Fri, 13 Jul 2012 11:15:38 +0300
Message-ID: <4FFFD92B.8080600@FreeBSD.org>
Date: Fri, 13 Jul 2012 11:15:39 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:13.0) Gecko/20120620 Thunderbird/13.0.1
MIME-Version: 1.0
To: sbruno@FreeBSD.org
References: <4FF95F79.30309@FreeBSD.org> <1341935370.4493.4.camel@powernoodle>
In-Reply-To: <1341935370.4493.4.camel@powernoodle>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "freebsd-acpi@freebsd.org" <freebsd-acpi@FreeBSD.org>,
	Giovanni Trematerra <gianni@FreeBSD.org>,
	Sean Bruno <seanbru@yahoo-inc.com>, John Baldwin <jhb@FreeBSD.org>,
	Vitaly Magerya <vmagerya@gmail.com>
Subject: Re: improve cx_lowest logic
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2012 08:15:41 -0000

on 10/07/2012 18:49 Sean Bruno said the following:
> On Sun, 2012-07-08 at 03:22 -0700, Andriy Gapon wrote: 
>> I would like to propose the following change for review and testing:
>> http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff
> 
> Very nice.  After a review I went ahead and applied it for testing.  All
> seems to be well on battery and A/C on my T520 so I'm very happy to see
> this go into the tree.
> 
> Let me know if you want me to do the man page update for acpi_cpu(4) 

Sean,

I would appreciate this a lot as I am currently a little bit busier than usual.

On a related note I also have this change for acpi.4:
--- a/share/man/man4/acpi.4
+++ b/share/man/man4/acpi.4
@@ -80,8 +80,12 @@ A scheduling algorithm will select states between
 and this setting
 as system load dictates.
 To enable ACPI CPU idling control,
-.Va machdep.cpu_idle_hlt
-must be set to 1.
+.Va machdep.idle
+should be set to
+.Li acpi
+if it is listed in
+.Va machdep.idle_available
+.
 .It Va hw.acpi.cpu.cx_supported
 List of supported CPU idle states and their transition latency
 in microseconds.

How does this look?
-- 
Andriy Gapon