Date: Sun, 28 May 2006 13:43:03 +0300 From: Diomidis Spinellis <dds@aueb.gr> To: src-committers@FreeBSD.ORG Cc: cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vnode_if.src Message-ID: <44797EB7.60406@aueb.gr> In-Reply-To: <200605280724.k4S7OCl5083567@repoman.freebsd.org> References: <200605280724.k4S7OCl5083567@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Diomidis Spinellis wrote: > dds 2006-05-28 07:24:12 UTC > > FreeBSD src repository > > Modified files: > sys/kern vnode_if.src > Log: > Add missing % signs in the lock annotations of the functions: > lookup, rename, strategy, islocked > The missing % sign meant that the lines were processed as plain > comments and the corresponding assertions were never generated. > > Revision Changes Path > 1.80 +8 -8 src/sys/kern/vnode_if.src To avoid this from happening again in the future, I intend to replace the "#!" and "#%" special comments that mark the pre- and post-conditions with a character sequence that can't be mistaken for a comment, and also add some error checking in the corresponding awk script. If you have any strong objections please speak up within the coming week. Diomidis - dds@
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44797EB7.60406>