From eugen@grosbein.net Sat Aug 26 07:14:21 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RXp4D1hDkz4rPd8; Sat, 26 Aug 2023 07:15:08 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RXp4C6FMKz3X2k; Sat, 26 Aug 2023 07:15:07 +0000 (UTC) (envelope-from eugen@grosbein.net) Authentication-Results: mx1.freebsd.org; none Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.17.1/8.17.1) with ESMTPS id 37Q7F3hg023848 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 26 Aug 2023 07:15:04 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: gjb@freebsd.org Received: from [10.58.0.11] (dadvw [10.58.0.11] (may be forged)) by eg.sd.rdtc.ru (8.17.1/8.17.1) with ESMTPS id 37Q7F2Xu031410 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 26 Aug 2023 14:15:02 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: git: 7be29291845a - stable/14 - UPDATING: fix a vestigial reference to -CURRENT To: Glen Barber References: <202308251843.37PIhUtc015238@gitrepo.freebsd.org> <20230825205541.GK4090@FreeBSD.org> <20230826003202.GN4090@FreeBSD.org> Cc: FreeBSD stable , "freebsd-net@freebsd.org" From: Eugene Grosbein Message-ID: Date: Sat, 26 Aug 2023 14:14:21 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 In-Reply-To: <20230826003202.GN4090@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT autolearn=disabled version=3.4.6 X-Spam-Report: * -0.0 SHORTCIRCUIT No description available. * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hz.grosbein.net X-Rspamd-Queue-Id: 4RXp4C6FMKz3X2k X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE] 26.08.2023 7:32, Glen Barber wrote: Moving to stable@ and net@ as requested. > On Sat, Aug 26, 2023 at 05:13:50AM +0700, Eugene Grosbein wrote: >> 26.08.2023 3:55, Glen Barber wrote: >> >>>> Please note the following commit: >>>> https://cgit.freebsd.org/src/commit/libexec/rc/rc.conf?id=ccc806a049383e5611b3752e6f384cf03a208039 >>>> >>>> I mean, we need to comment out dumpdev="AUTO" for stable/14, too. >>>> >>> >>> On stable/14, dumpdev is set to "NO", per the documented changes to make >>> on a new stable branch. >>> >>> https://docs.freebsd.org/en/articles/freebsd-releng/#releng-head-branching >>> >>> As it is, it matches libexec/rc/rc.conf from stable/13. >> >> dumpdev="NO" in /etc/defaults/rc.conf overrides dumpdev in /boot/loader.conf >> That should not happen. >> > > This seems backwards to me. The implementation has always been handled > in rc.conf, so as an end-user that explicitly set something(tm) in > rc.conf, I do not expect to have to change loader.conf as well. Right. However, dumpdev is special one. A panic in STABLE could occur before /etc/rc.conf is consulted. Therefore, one have to specify dumpdev in the loader.conf instead of rc.conf in such a case. Sadly, dumpdev in the loader.conf is later overridden by dumpdev="NO" in /etc/defaults/rc.conf unless it is duplicated in /etc/rc.conf OR we comment out dumpdev="NO" in /etc/defaults/rc.conf for STABLE. I suggest we do the latter for STABLE. > Having said that, since both stable/14 and stable/13 are in sync in this > regard (dumpdev="NO" in rc.conf), I will not object to commenting the > entry in releng/14.0 when it is branched. > > I would also like this taken to a more appropriate list, such as > -current or -stable. > > Glen > Eugene