From owner-svn-src-all@freebsd.org Wed May 30 12:41:50 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40C12EF8B46; Wed, 30 May 2018 12:41:50 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D2E9881656; Wed, 30 May 2018 12:41:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w4UCfhRE071875; Wed, 30 May 2018 05:41:43 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w4UCfhoE071874; Wed, 30 May 2018 05:41:43 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201805301241.w4UCfhoE071874@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool In-Reply-To: To: Antoine Brodin Date: Wed, 30 May 2018 05:41:42 -0700 (PDT) CC: Hans Petter Selasky , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 12:41:50 -0000 > On Wed, May 30, 2018 at 8:20 AM, Hans Petter Selasky wrote: > > On 05/30/18 10:02, Antoine Brodin wrote: > >> > >> Could the pcap/pcap.h header be fixed instead with #ifdef HAVE_REMOTE > >> as it previously had? > > > > > > The HAVE_REMOTE was removed upstream: > > > > https://github.com/the-tcpdump-group/libpcap/commit/a372536befc9b1ee1d355058daa2eb9f66aa0c59#diff-46964bcbd8e8a5cec9a75c66ab26a97b > > > > What do you think? Shall we re-add it to base? > > Either hide remote packet capture functions from the header or enable > remote capture functions? > Note that net/p5-Net-Pcap will fail to build with libpcap from ports > too when libpcap from ports is updated to version 1.9.0 (pre-release). If there is any thoughs of merging this to stable/11 wont the HAVE_REMOTE have to be turned on anyway? I suppose it get be #ifdef FreeBSD_VERSION. -- Rod Grimes rgrimes@freebsd.org