From owner-freebsd-current@FreeBSD.ORG Wed Jul 16 01:59:54 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 296D037B401; Wed, 16 Jul 2003 01:59:54 -0700 (PDT) Received: from obsecurity.dyndns.org (adsl-64-169-107-199.dsl.lsan03.pacbell.net [64.169.107.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B2A943FA3; Wed, 16 Jul 2003 01:59:52 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 6D9F666CFA; Wed, 16 Jul 2003 01:59:45 -0700 (PDT) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id 0ED14C04; Wed, 16 Jul 2003 01:59:45 -0700 (PDT) Date: Wed, 16 Jul 2003 01:59:44 -0700 From: Kris Kennaway To: Marcel Moolenaar Message-ID: <20030716085944.GB26428@rot13.obsecurity.org> References: <20030715175821.K34004@beagle.fokus.fraunhofer.de> <20030715185438.GB15674@dhcp01.pn.xcllnt.net> <20030715190456.GC15674@dhcp01.pn.xcllnt.net> <20030715193518.GA1660@crow.dom2ip.de> <20030716010908.GA24218@rot13.obsecurity.org> <20030716051103.GB17596@dhcp01.pn.xcllnt.net> <20030716051601.GA25527@rot13.obsecurity.org> <20030716074337.GA17997@dhcp01.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hQiwHBbRI9kgIhsi" Content-Disposition: inline In-Reply-To: <20030716074337.GA17997@dhcp01.pn.xcllnt.net> User-Agent: Mutt/1.4.1i cc: anholt@FreeBSD.org cc: current@FreeBSD.org cc: Kris Kennaway Subject: Re: Fix for rman [was: Re: [-CURRENT tinderbox] ...] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2003 08:59:54 -0000 --hQiwHBbRI9kgIhsi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 16, 2003 at 12:43:37AM -0700, Marcel Moolenaar wrote: > On Tue, Jul 15, 2003 at 10:16:01PM -0700, Kris Kennaway wrote: > > >=20 > > > malloc, you say? I have build failures in XFree4-clients because > > > rman coredumps and I have a backtrace full of free() frames... > > >=20 > > > Coincidence? > >=20 > > Some of the XFree86 utilities contain malloc bugs..rman in particular > > has been dumping core on certain ports for a couple of years. I tried > > to track it down once but couldn't find it. >=20 > [cc anholt@] >=20 > The attached patch fixes rman. The faulting case is "\\\0". The '\0' > was handled in the default case for escaped characters, which also > incremented the pointer p beyond the terminating '\0'.=20 >=20 > Oh: this goes to devel/imake-4 of course. >=20 > --=20 > Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net The print/gv port has patch-ad to work around another rman bug. This bug is only exposed by malloc debugging. Kris --hQiwHBbRI9kgIhsi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/FRQAWry0BWjoQKURAj1mAKCWpv9spSxgPZ3SgeMPdZRZXErMUQCggRpC nG/xeKR2igUy1C3DMywv3Cs= =hHl6 -----END PGP SIGNATURE----- --hQiwHBbRI9kgIhsi--