From owner-dev-commits-src-all@freebsd.org Wed Feb 3 09:25:05 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ADFA553146A; Wed, 3 Feb 2021 09:25:05 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DVx9F09xrz3rTh; Wed, 3 Feb 2021 09:25:04 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ej1-f49.google.com with SMTP id f14so10255964ejc.8; Wed, 03 Feb 2021 01:25:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FsYh2nSYLSPLoFU54SITZmykM6OZ9mnKgp7tnX86VIk=; b=k+MUtQTMZ/VxwyQTr0WPSlrGeE1I/9YE+/epu2kSlb9pfo6I73og+29mCGvNL3DKaY sXSWsWsnxlNtiBsSIhG8IGNGvDkMyfI5/T+wop99Tj220Gqiy72GCKQZdyBSh+WpxfVC oCvQ9Q8aLrg/I1VCpTSkbPz4ZuGreMhXpKYoLyhM6ym8x+PcM8gymSeIgvpD5omrSBW1 luF3o9AzrR8gqPj9rTrek4Jjo5OX1zAqjS5w3FsZSqWyb7fbvmBkkcZrbiD7l5KBl1C2 hnYrukrSrm4l4P45GDx69i6PqlCtEMgFHJVdFmRc1ojCZavry8fOlvmUjTMfnV320Uez Vr9w== X-Gm-Message-State: AOAM530xE1KwebRvX/Jm/p9qkuV77SXOqo8+g3kVKvN9OYfpve23U9mS 7Hy5JU6O/0UG75dGlCfgLFeUH52c4AJZGw== X-Google-Smtp-Source: ABdhPJxWke3gL6vj41fyOgR/0GSx9HSmy/Z2Gn2JqizSpt8pEOw0Vc7p0A+d4ypxWDtXY3WCSVOrIQ== X-Received: by 2002:a17:906:a48:: with SMTP id x8mr2257407ejf.444.1612344303581; Wed, 03 Feb 2021 01:25:03 -0800 (PST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com. [209.85.221.49]) by smtp.gmail.com with ESMTPSA id ov9sm726209ejb.53.2021.02.03.01.25.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 01:25:03 -0800 (PST) Received: by mail-wr1-f49.google.com with SMTP id d16so23284645wro.11; Wed, 03 Feb 2021 01:25:03 -0800 (PST) X-Received: by 2002:a5d:4443:: with SMTP id x3mr2470061wrr.409.1612344303049; Wed, 03 Feb 2021 01:25:03 -0800 (PST) MIME-Version: 1.0 References: <202102021008.112A8RkU069892@gitrepo.freebsd.org> In-Reply-To: From: Alexander Richardson Date: Wed, 3 Feb 2021 09:24:52 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 83c20b8a2da0 - main - tests/sys/kern/crc32: Check for SSE4.2 before using it To: Peter Jeremy Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4DVx9F09xrz3rTh X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of arichardsonkde@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=arichardsonkde@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RWL_MAILSPIKE_GOOD(0.00)[209.85.218.49:from]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[arichardson@freebsd.org,arichardsonkde@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[arichardson@freebsd.org,arichardsonkde@gmail.com]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.218.49:from]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.218.49:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.49:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2021 09:25:05 -0000 On Wed, 3 Feb 2021, 08:24 Peter Jeremy, wrote: > On 2021-Feb-02 10:08:27 +0000, Alex Richardson > wrote: > >The branch main has been updated by arichardson: > > > >URL: > https://cgit.FreeBSD.org/src/commit/?id=83c20b8a2da04937cf4af127366b3dc92c855784 > ... > > Differential Revision: https://reviews.freebsd.org/D28395 > >--- > ... > >diff --git a/tests/sys/kern/Makefile b/tests/sys/kern/Makefile > >index 1806d7ce8597..f350b740b7ea 100644 > >--- a/tests/sys/kern/Makefile > >+++ b/tests/sys/kern/Makefile > >@@ -56,15 +56,15 @@ NETBSD_ATF_TESTS_C+= sysv_test > > CFLAGS.mqueue_test+= -I${SRCTOP}/tests > > LIBADD.mqueue_test+= rt > > > >-.if ${MACHINE_ARCH} == "amd64" || \ > >- ${MACHINE_ARCH} == "i386" || \ > >- ${MACHINE_CPUARCH} == "aarch64" > > ATF_TESTS_C+= libkern_crc32 > >+SRCS.libkern_crc32+= libkern_crc32.c > >+.PATH: ${SRCTOP}/sys/libkern > >+SRCS.libkern_crc32+= gsb_crc32.c > >+CFLAGS.libkern_crc32+= -DTESTING > > .if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" > >-LDADD.libkern_crc32+= ${SRCTOP}/sys/libkern/x86/crc32_sse42.c > >-.else > >-LDADD.libkern_crc32+= ${SRCTOP}/sys/libkern/arm64/crc32c_armv8.S > >-.endif > >+SRCS.libkern_crc32+= ${SRCTOP}/sys/libkern/x86/crc32_sse42.c > >+.elif ${MACHINE_CPUARCH} == "aarch64" > >+SRCS.libkern_crc32+= ${SRCTOP}/sys/libkern/arm64/crc32c_armv8.S > > .endif > > > > # subr_unit.c contains functions whose prototypes lie in headers that > cannot be > > This breaks buildworld with a RO /usr/src for me: > ... > ===> tests/sys/kern (all) > ... > Building /usr/obj/usr/src/arm64.aarch64/tests/sys/kern/pdeathsig > (cd /usr/src/tests/sys/kern && DEPENDFILE=.depend.libkern_crc32 > NO_SUBDIR=1 make -f /usr/src/tests/sys/kern/Makefile _RECURSING_PROGS=t > PROG=libkern_crc32 ) > Building /usr/src/sys/libkern/arm64/crc32c_armv8.o > clang -cc1as: error: unable to open output file > '/usr/src/sys/libkern/arm64/crc32c_armv8.o': 'Read-only file system' > *** Error code 1 > > I do have an (empty) > /usr/obj/usr/src/arm64.aarch64/tests/sys/kern/usr/src/sys/libkern/arm64 > Hi, I have a fix that I'm currently testing and will commit shortly. It seems the problem is that I changed it from (ab)using LDADD to using SRCS which defaults to creating the .o file in the same directory as the source. Alex