From nobody Tue Aug 23 14:24:09 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MBs1M3S5Cz4Zmyr for ; Tue, 23 Aug 2022 14:24:23 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MBs1M2XhVz4HPW for ; Tue, 23 Aug 2022 14:24:23 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661264663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZTZmNEumPzp+SQD9kk5LEhe7JF/ivsp6/5nxZ4Lsmg8=; b=GBMDY6UUczDl8X7ywksZ3mFKoAU1S/fCVreMcLkNvCgAX9RqfNIAyZe+FpMJde4vTvcdem iDJT4+Gzbz3oTmne9p6oh7WLnPbvH0YGikPeem+tTYZjxXlXc4PHdom7fOVFFd814jHx5w kufN3c/VImC55aJ0QDFDxhxo1y7hCAQWkXnJe8BBdQQgkvEa+8NNayn7BRZVCb/DWsYA5m UFko+fMYEvJOHYJdsFERfDnb7FMNvmgyEuCjkcEKIW89iE2JkQm0xPBUOW1UZaY96//16q 5hxKZfE4jnQOZqZL+S1XNFbcw6Zo+gjoaf6iSTXi6EbcaziDKm77uf4bYewFOg== Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MBs1M1TwlztdL for ; Tue, 23 Aug 2022 14:24:23 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f50.google.com with SMTP id 190so6356069vsz.7 for ; Tue, 23 Aug 2022 07:24:23 -0700 (PDT) X-Gm-Message-State: ACgBeo2AhsMwFCYTxVKc/HHKj9qE04NSczTE2a1oo6vAzPZ4cXTLXS9Z 4yMss5Sg14INmakikivGV90mq5twjL7xzKmZezI= X-Google-Smtp-Source: AA6agR7Ob7/wzZ+UXAPxwA1X/ReooyNf/IXtE6Aio+++NidagwLvjob+A9/u6e34vlLk91a+vQHFWjW8YowwOSyswFE= X-Received: by 2002:a05:6102:1509:b0:390:825e:24f with SMTP id f9-20020a056102150900b00390825e024fmr1014781vsv.51.1661264662721; Tue, 23 Aug 2022 07:24:22 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <20220823092244.bxi5uyrzicuff5yy@nexus.home.palmen-it.de> In-Reply-To: <20220823092244.bxi5uyrzicuff5yy@nexus.home.palmen-it.de> From: Nuno Teixeira Date: Tue, 23 Aug 2022 15:24:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Patching Conditionally for 12.3 Releases To: FreeBSD Mailing List Content-Type: multipart/alternative; boundary="00000000000019805605e6e952cf" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661264663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZTZmNEumPzp+SQD9kk5LEhe7JF/ivsp6/5nxZ4Lsmg8=; b=A1oyE+lDNBZTcsNQHqPrnm7HpR0FiN/urvqRfCOEXfbwrwGWSOjylcvPkJlAos4mOEMA+m 1EhHcyyy6XydHdttmSu/05rjmnOTQ2NdiRcvz0vKbq/KAc9KmrbkR0BMPFhD/ueKiYvO85 YrSxysJuD96VyztsNOwFnHxpem2lgBn4URHCWNmtWzdK57CgNcdhjGvjpXy+5fyjrK61fX FMhIvKkRoF+bbZYLBO3UCdEHRWzTb/CL2+Ek/kMWPwcYKFYd1RYXpzRE2W706Sep0/zHt5 zzQEPYRLyfGoa7D2jt91CM3sVi9jrJcCoWBVeSowy0ed60SMI9XlKA+xDo0QaA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661264663; a=rsa-sha256; cv=none; b=evYXM1H4TUkberoCB6mWGOTamh8WgS3aesFCPrFIWdIy/ihuSgyYONwJtbxWMCkBoMh9bi Ve56XDznNB6v0OFCTp6NpTsqRdq/GojBwVYO2m1iGZWXimf2WWtXLw5JY8w2wn25dEzn56 Y4ebyYs4jwWbbC2QUAbBaF8QJxPMSQ9DVZZlLmW+LsDxoHt4gmO4MePvrHWS7vb9Viqhkp nIejvyaKHtDZWSuQEHwyoVGR3Bx8ut6YJucTZKhpF1hxBRaxQYbO5mqoDDzzZscgThGjDp 9YofOAg7uGnYPEl7BPiq8JkS31fD29NveDT2RSIsD7SC+0vkdHnHjdXwUJmumQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --00000000000019805605e6e952cf Content-Type: text/plain; charset="UTF-8" Hi Felix, Possible alternative without if: > > EXTRA_PATCHES= ${EXTRA_PATCHES_${OPSYS}} > EXTRA_PATCHES_FreeBSD= ${${OSVERSION}<1300000:?${PATCHDIR}/extra-foo:} > It is nice without showing if condition but it becomes way more cryptic and complex. It will be very nice if ports include OPSYS, OSVERSION, etc: OPTIONS_DEFINE= FOO BAR FOO_OSVERSION= > 1300000 BAR_OSVERSION= > 1200000 && < 1300000 FOO_EXTRA_PATCHES= ${PATCHDIR}/extra-patch-foo BAR_EXTRA_PATCHES_OFF= ${PATCHDIR}/extra-patch-bar.c It's solved this way :) Cheers, -- > Nuno Teixeira FreeBSD Committer (ports) --00000000000019805605e6e952cf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Felix,

=
FOO_OSVERSION=3D > 1300000
BAR_OSVERSION=3D > 1200000 && < 1300000
=
FOO_EXTRA_PATCHES=3D =C2=A0${PATCHDIR}/ext= ra-patch-foo
BAR_EXTRA_PATCHES_OFF=3D ${PATCHDIR}/extra-patch-bar.c
<= div>
=C2=A0It's solved this way :)

Cheers,

--
=
Nuno Teixeira
Fr= eeBSD Committer (ports)
--00000000000019805605e6e952cf--