From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Dec 5 08:07:31 2012 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1C15E287 for ; Wed, 5 Dec 2012 08:07:31 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B1D148FC12 for ; Wed, 5 Dec 2012 08:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qB5800jQ001135 for ; Wed, 5 Dec 2012 08:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qB5800EO001134; Wed, 5 Dec 2012 08:00:00 GMT (envelope-from gnats) Resent-Date: Wed, 5 Dec 2012 08:00:00 GMT Resent-Message-Id: <201212050800.qB5800EO001134@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ruslan Mahmatkhanov Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5548CCEB for ; Wed, 5 Dec 2012 07:50:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 32E398FC0C for ; Wed, 5 Dec 2012 07:50:38 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qB57ocv4017898 for ; Wed, 5 Dec 2012 07:50:38 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id qB57oc3s017897; Wed, 5 Dec 2012 07:50:38 GMT (envelope-from nobody) Message-Id: <201212050750.qB57oc3s017897@red.freebsd.org> Date: Wed, 5 Dec 2012 07:50:38 GMT From: Ruslan Mahmatkhanov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/174145: net-mgmt/noc: remove bogus setuptools dependency X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 08:07:31 -0000 >Number: 174145 >Category: ports >Synopsis: net-mgmt/noc: remove bogus setuptools dependency >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Dec 05 08:00:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Ruslan Mahmatkhanov >Release: 10.0-CURRENT >Organization: >Environment: 10.0-CURRENT amd64 >Description: - remove bogus setuptools dependency - trim Makefile header - move LICENSE and *_DEPENDS into proper block (portlint warning) - remove shlib version in LIB_DEPENDS (portlint warning) - eliminate using PYTHON_SITELIBDIR - convert to optionsng - limit python version to 2.x only since noc (and the most of it's dependencies) not [fully] supports 3.x - remove trailin whitespace from pkg-descr - do not bump PORTREVISION because the port is marked BROKEN (next 0.7.5 release adding django 1.4 support, so hopefully it will be working again soon) As for setuptools dependency - it's only usage is in erroneous setup.py's comment. It also mentioned in installation guide, but only in context of installing it's dependencies (that is already handled by our ports tree). As you may see in setup.py, it's using distutils for installing. buildlog: http://people.freebsd.org/~rm/noc-0.6.4_1.log >How-To-Repeat: >Fix: Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 308315) +++ Makefile (working copy) @@ -1,9 +1,5 @@ -# New ports collection makefile for: noc -# Date created: 27.08.2009 -# Whom: Stanislav Svirid -# +# Created by: Stanislav Svirid # $FreeBSD$ -# PORTNAME= noc PORTVERSION= 0.6.4 @@ -14,37 +10,38 @@ MAINTAINER= count@211.ru COMMENT= Operation Support System (OSS) for the Telco, SP, and Enterprise NOC -EXTRA_PATCHES= ${PATCHDIR}/extra-patch-sa_sae.py -EXTRA_PATCHES+= ${PATCHDIR}/extra-patch-0.6.4.rst +LICENSE= BSD -LIB_DEPENDS= smi.2:${PORTSDIR}/net-mgmt/libsmi -BUILD_DEPENDS= easy_install:${PORTSDIR}/devel/py-setuptools \ - ${PYTHON_PKGNAMEPREFIX}sphinx>0:${PORTSDIR}/textproc/py-sphinx \ +LIB_DEPENDS= smi:${PORTSDIR}/net-mgmt/libsmi +BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sphinx>0:${PORTSDIR}/textproc/py-sphinx \ ${PYTHON_PKGNAMEPREFIX}flup>0:${PORTSDIR}/www/py-flup -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django>=1.3<1.4:${PORTSDIR}/www/py-django \ +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}django>0:${PORTSDIR}/www/py-django \ ${PYTHON_PKGNAMEPREFIX}django-tagging>0:${PORTSDIR}/www/py-django-tagging \ ${PYTHON_PKGNAMEPREFIX}south>0:${PORTSDIR}/databases/py-south \ ${PYTHON_PKGNAMEPREFIX}coverage>0:${PORTSDIR}/devel/py-coverage \ ${PYTHON_PKGNAMEPREFIX}protobuf>0:${PORTSDIR}/devel/py-protobuf \ - ${PYTHON_SITELIBDIR}/psycopg2/_psycopg.so:${PORTSDIR}/databases/py-psycopg2 \ + ${PYTHON_PKGNAMEPREFIX}psycopg2>0:${PORTSDIR}/databases/py-psycopg2 \ ${PYTHON_PKGNAMEPREFIX}snmp4>=0:${PORTSDIR}/net-mgmt/py-snmp4 \ ${PYTHON_PKGNAMEPREFIX}creole>0:${PORTSDIR}/textproc/py-creole \ ${PYTHON_PKGNAMEPREFIX}webob>0:${PORTSDIR}/www/py-webob \ ${PYTHON_PKGNAMEPREFIX}WebTest>0:${PORTSDIR}/www/py-WebTest \ ${PYTHON_PKGNAMEPREFIX}netifaces>0:${PORTSDIR}/net/py-netifaces \ - ${PYTHON_SITELIBDIR}/Crypto/__init__.py:${PORTSDIR}/security/py-pycrypto + ${PYTHON_PKGNAMEPREFIX}pycrypto>0:${PORTSDIR}/security/py-pycrypto BROKEN= unsatisfyable dependency object -OPTIONS= GMPY "Enable use GMP library in SSH" on \ - PEP8 "Intsall pep8 for checking source" off +EXTRA_PATCHES= ${PATCHDIR}/extra-patch-sa_sae.py +EXTRA_PATCHES+= ${PATCHDIR}/extra-patch-0.6.4.rst -USE_PYTHON= 2.6+ +OPTIONS_DEFINE= GMPY PEP8 +OPTIONS_DEFAULT=GMPY +GMP_DESC= Use GMP library in SSH +PEP8_DESC= Intsall pep8 for checking source + +USE_PYTHON= -2.7 USE_PYDISTUTILS= yes PYDISTUTILS_EGGINFODIR= ${NOCDIR} -LICENSE= BSD - NOCUSER= noc NOCGROUP= noc NOCDIR?= ${PREFIX}/noc @@ -54,13 +51,13 @@ USERS= ${NOCUSER} GROUPS= ${NOCGROUP} -.include +.include -.if defined(WITH_GMPY) -RUN_DEPENDS+= ${PYTHON_SITELIBDIR}/gmpy.so:${PORTSDIR}/math/py-gmpy +.if ${PORT_OPTIONS:MGMPY} +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}gmpy>0:${PORTSDIR}/math/py-gmpy .endif -.if defined(WITH_PEP8) +.if ${PORT_OPTIONS:MPEP8} RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}pep8>0:${PORTSDIR}/devel/pep8 .endif @@ -152,4 +149,4 @@ @${SH} ${PKGINSTALL} ${DISTNAME} POST-INSTALL @${CAT} ${PKGMESSAGE} -.include +.include Index: pkg-descr =================================================================== --- pkg-descr (revision 308315) +++ pkg-descr (working copy) @@ -1,4 +1,4 @@ -NOC Project is an Operation Support System (OSS) for the Telco, +NOC Project is an Operation Support System (OSS) for the Telco, Service provider and Enterprise Network Operation Centers (NOC). Areas covered by NOC: @@ -9,13 +9,13 @@ * Virtual Circuits management (VLAN, DLCI, etc) * Configuration Management * DNS provisioning - * Peering management, RPSL and BGP filters generator, integrated + * Peering management, RPSL and BGP filters generator, integrated looking glass - * Reporting + * Reporting NOC Project is distributed under the term of BSD-like LICENSE. Enjoy! -The NOC Project Team +The NOC Project Team WWW: http://www.nocproject.org/ >Release-Note: >Audit-Trail: >Unformatted: