From nobody Wed Jun 25 23:22:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bSHsC03sxz5ygtw; Wed, 25 Jun 2025 23:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bSHsB5JQPz3dWv; Wed, 25 Jun 2025 23:22:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750893726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jhQl/C7I407ZCJwMmPr5Q+s4ilE1d+Ggahuc+iAn5ww=; b=J3lfbwTF+st5vcANxr0n+Y0BZrk/4yHWDCgDRC7dXwHICx0ubi7t5KIZ1dXprx4FJbWgtF iNSj8fI3oxjDDk/Z6upAvqr68l66RWz/dwwDeo0SCWAYnx8tg6qy+paQCgZhn8KYkVM+Jx H3B6rw+iJ2q2S6T/nMi9BRR9lAxKN7jaP5WtLfMsAwEQdyM/mjuIwySjWt+5/f8JzluJef tpRuHbxflvB4nDpUp3vgvLye0twwO1X0LwKSWxSGMJ7uJs46LLemIUVld9fO7dqfZcjRYM MKXnkmupLfJWb8w1oAF0zp9k4lZkkdvIvVfRPhylkLx8gfwQZZpU/kY2egrOaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750893726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jhQl/C7I407ZCJwMmPr5Q+s4ilE1d+Ggahuc+iAn5ww=; b=ucnnB07qWe17GZMejLn8boVbxYaC9gXfGaZ9HtqbC4zXRjbndkNg4+JwoGhgWMnYEywU+L QV21frkonYagtMjqJ12yyTEMj25KrAh2eeyk8Epa8+/eo37fVHOnbIygMo9q7m+kZWpZs+ yiLz9D2MtvgSHD7la19TJKWVKr4iuV8sRMcSWxkbopyTOc9rYLGLRgTzd8a8JgC1IbDNNx fY2xS9Q5uSwaIifcJsBQ4mdvkez4xhWsRWNqksIeHQnEgbeQIfuMYp36VN7BMEPjy7GWjF PtOFYi8/iuljoIJpEHx+Vo7jmW04wPtYazDU+nCdKtYyvlSVgdbKJsDjW03bYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750893726; a=rsa-sha256; cv=none; b=UWmrNse2sj9IDhWhOV7R1BHg0S9Zv41h6giYOUM64hLVuU4OTTtiZlS/BBjGz54962xac8 k+WAi9Tcq3PDwHOrgHxOB6yAAmjkKYyu5SPPSxoFrYrlIobpVnTsBDuS2DV0zwd58AQK8U yN6hM9NJjZ+8FeBsUnx5FFMvNpfjT55SSJn0enzX/+Ml7C6LnW8oPpSbo6hgT8mWQghj6A PvnnpAPSjw+wxk2lDrewzh+lhinsyNeClqayeYahAxCi8QCt8vL3zurGZty7kjM3VJ90eF b08jSiCEgzZaZm76m6pYsJ8vwmXiNGSWOabA5JVhpvoYMKGRQxu0rtL9Q17kWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bSHsB4ZhZzfTp; Wed, 25 Jun 2025 23:22:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55PNM6HC054330; Wed, 25 Jun 2025 23:22:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55PNM6vG054327; Wed, 25 Jun 2025 23:22:06 GMT (envelope-from git) Date: Wed, 25 Jun 2025 23:22:06 GMT Message-Id: <202506252322.55PNM6vG054327@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Ziaee Subject: git: d16b1904d1ee - main - pf.4/pf.conf.5: Remove unused sysctl List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ziaee X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d16b1904d1eefaa0aecb8a317b79254d14ec49c7 Auto-Submitted: auto-generated The branch main has been updated by ziaee: URL: https://cgit.FreeBSD.org/src/commit/?id=d16b1904d1eefaa0aecb8a317b79254d14ec49c7 commit d16b1904d1eefaa0aecb8a317b79254d14ec49c7 Author: Alexander Ziaee AuthorDate: 2025-06-25 23:17:59 +0000 Commit: Alexander Ziaee CommitDate: 2025-06-25 23:19:42 +0000 pf.4/pf.conf.5: Remove unused sysctl "We never actually added the sysctl. The limit was implemented, and the sysctl to tune it was documented but never added (so the limit is there, but is always 16 and cannot be changed)." ~kp MFC after: 3 days Fixes: 339a1977c324 (pf: Add a systl to limit work) Reported by: kp Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D50859 --- share/man/man4/pf.4 | 5 ----- share/man/man5/pf.conf.5 | 6 +----- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/share/man/man4/pf.4 b/share/man/man4/pf.4 index 9ab46558a2d6..d17a80bc9512 100644 --- a/share/man/man4/pf.4 +++ b/share/man/man4/pf.4 @@ -104,11 +104,6 @@ to also filter on the loopback output hook. This is typically used to allow redirect rules to adjust the source address. .It Va net.pf.request_maxcount The maximum number of items in a single ioctl call. -.It Va net.pf.rdr_srcport_rewrite_tries -The maximum number of times to try and find a free source port when handling -redirects. -Such rules are typically applied to external traffic, so an exhaustive search -may be too expensive. .El .Pp Read only diff --git a/share/man/man5/pf.conf.5 b/share/man/man5/pf.conf.5 index 3bdba4958aea..49c81f51294c 100644 --- a/share/man/man5/pf.conf.5 +++ b/share/man/man5/pf.conf.5 @@ -1479,11 +1479,7 @@ A .Ar rdr-to opion may cause the source port to be modified if doing so avoids a conflict with an existing connection. -A random source port in the range 50001-65535 is chosen in this case; to -avoid excessive CPU consumption, the number of searches for a free port is -limited by the -.Va net.pf.rdqr_srcport_rewrite_tries -sysctl. +A random source port in the range 50001-65535 is chosen in this case. Port numbers are never translated with a .Ar binat-to option.