From owner-freebsd-current@FreeBSD.ORG Wed Jul 25 17:14:52 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE36316A468 for ; Wed, 25 Jul 2007 17:14:52 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 2225C13C467 for ; Wed, 25 Jul 2007 17:14:51 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 16375 invoked from network); 25 Jul 2007 17:10:12 -0000 Received: from dotat.atdotat.at (HELO [62.48.0.47]) ([62.48.0.47]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 25 Jul 2007 17:10:12 -0000 Message-ID: <46A7850A.3070408@freebsd.org> Date: Wed, 25 Jul 2007 19:14:50 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050217 MIME-Version: 1.0 To: "Bruce M. Simpson" References: <46A766E3.1080605@incunabulum.net> In-Reply-To: <46A766E3.1080605@incunabulum.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: Call for testers: NetBSD IGMPv2 merge X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2007 17:14:52 -0000 Bruce M. Simpson wrote: > Hi, > > I have mostly merged NetBSD's IGMPv2 implementation with a few refinements. > This work is being funded by a secret santa. :-) > > This code is easier to read (and thus maintain), and fixes a minor > memory leak in the IPv4 stack. It is also a jumping off point for the > IGMPv3 work. KAME patch sets up to date have been against NetBSD, though > I don't intend to use their patches directly. > > Patch against -CURRENT, URL: > http://people.freebsd.org/~bms/dump/igmp-netbsd-sync.patch > > I have not merged the change which suppresses host membership reports > for the link-local multicast scope space 224.0.0.0/8, my concern is that > this breaks IGMP snooping switches on immediately attached layer 2 > networks, even though this range is not globally routable. (*) > > Testing and review much appreciated. If enough people are willing to > soak test this code before 7.0 point release is branched then it might > justify going in in time for 7.0. Looks good. Not tested though. -- Andre