Date: Wed, 28 Mar 2012 23:03:02 +0300 From: Aleksandr Rybalko <ray@dlink.ua> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-mips@freebsd.org Subject: Re: [patch] enable mdio port 1, remove phy mask hard coding Message-ID: <20120328230302.d8646559.ray@dlink.ua> In-Reply-To: <CAJ-Vmo=fFguXz3V0RdxM8bubi2_jnOWr1Qp-y-aKwaGJqjGhSw@mail.gmail.com> References: <CAJ-VmomfLdqv=5_wQmB%2BxNH6mKh6OieTAH4auS232ZFHKeHmzQ@mail.gmail.com> <20120328113218.e93fe3c5.ray@dlink.ua> <CAJ-Vmo=fFguXz3V0RdxM8bubi2_jnOWr1Qp-y-aKwaGJqjGhSw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 28 Mar 2012 11:24:35 -0700 Adrian Chadd <adrian@freebsd.org> wrote: > Hi, > > The point is that we're talking to MDIO bus 0 or 1. > > Why is that not clear? :) Because patched if_arge use it only with sc->arge_mac_unit, which is 0 for arge0, and 1 for arge1. So there is two ways: 1. Just remove unit argument. "ARGE_MII_READ(AR71XX_MAC_MII_INDICATOR)" instead of "ARGE_MII_READ(sc->arge_mac_unit,AR71XX_MAC_MII_INDICATOR)" 2. or remove it completely, since for that case ARGE_READ/ARGE_WRITE will do the same. But if you will use here another variable, (f.e. sc->arge_mdio_unit or sc->arge_mii_unit), then it would have sense. Then you will be able to set it from hints and default to sc->arge_mac_unit otherwise. > > > > Adrian -- Aleksandr Rybalko <ray@dlink.ua>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120328230302.d8646559.ray>