From owner-svn-src-all@freebsd.org Thu Jul 25 02:03:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B77CCC001F; Thu, 25 Jul 2019 02:03:21 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 65B008933A; Thu, 25 Jul 2019 02:03:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id qT6Dh4RqoSrVcqT6Eh8fyM; Wed, 24 Jul 2019 20:03:18 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=0o9FgrsRnhwA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=syWdyGADkbmwRjC54sMA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 8BD4E21C; Wed, 24 Jul 2019 19:03:16 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x6P23G2K076821; Wed, 24 Jul 2019 19:03:16 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x6P23GeQ076818; Wed, 24 Jul 2019 19:03:16 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201907250203.x6P23GeQ076818@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ed Maste cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350301 - head/lib/libsysdecode In-reply-to: <201907242106.x6OL6KaM068071@repo.freebsd.org> References: <201907242106.x6OL6KaM068071@repo.freebsd.org> Comments: In-reply-to Ed Maste message dated "Wed, 24 Jul 2019 21:06:20 -0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 24 Jul 2019 19:03:16 -0700 X-CMAE-Envelope: MS4wfIWkKP+oCORx6rJ2Kf9lt8Qc+4lSdlEtOSa0q6ncpWCarnvkwVfxLoSa7vqT3Y7ooVEZkxjauKYkgDujozD0D0I8qoR6JQhnBjvvBduaggnBNkQACwaU 7DvwmjqcsAAEbU2Fnhnv7Ba4rVOOAArcrZm9QbeusNXy3GvpcUXPsH9KjagmhvE9mvVh5nNauq2lm+Ozhe6BIfQbkfHjWDqIsGDgyO1uG4k6nBXxoYBnsKgv mf6WAMQKOE6KPykOHaHmLE1fn7xdYO4K1qTTCXf01cycp6jUL/eTXmzTPNL003fW X-Rspamd-Queue-Id: 65B008933A X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.92 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; IP_SCORE(-2.44)[ip: (-6.42), ipnet: 64.59.128.0/20(-3.21), asn: 6327(-2.50), country: CA(-0.09)]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.87)[-0.867,0]; RCVD_IN_DNSWL_NONE(0.00)[138.136.59.64.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 02:03:21 -0000 In message <201907242106.x6OL6KaM068071@repo.freebsd.org>, Ed Maste writes: > Author: emaste > Date: Wed Jul 24 21:06:19 2019 > New Revision: 350301 > URL: https://svnweb.freebsd.org/changeset/base/350301 > > Log: > libsysdecode: add explicit dependencies on recently changed headers > > r349369 removed IP_MIN_MEMBERSHIPS and IPV6_MIN_MEMBERSHIPS, and r349893 > removed TCP_RACK_SESS_CWV. libsysdecode lacked dependencies to trigger a > rebuild of tables.h. > > Add explicit dependencies as a workaround to address these specific > cases; a holistic solution is still needed. > > Sponsored by: The FreeBSD Foundation > > Modified: > head/lib/libsysdecode/Makefile > > Modified: head/lib/libsysdecode/Makefile > ============================================================================= > = > --- head/lib/libsysdecode/Makefile Wed Jul 24 20:17:39 2019 (r35030 > 0) > +++ head/lib/libsysdecode/Makefile Wed Jul 24 21:06:19 2019 (r35030 > 1) > @@ -123,7 +123,8 @@ CFLAGS.gcc.ioctl.c+= -Wno-redundant-decls > CFLAGS.gcc+= ${CFLAGS.gcc.${.IMPSRC}} > > DEPENDOBJS+= tables.h > -tables.h: mktables > +tables.h: mktables ${SYSROOT}/sys/netinet/in.h ${SYSROOT}/sys/netinet/tcp.h > \ > + ${SYSROOT}/sys/netinet6/in6.h > sh ${.CURDIR}/mktables ${SYSROOT:U${DESTDIR}}${INCLUDEDIR} ${.TARGET}.t > mp && \ > mv -f ${.TARGET}.tmp ${.TARGET} > > Hi Ed, This breaks 32-bit compatibility builds on amd64. --- all_subdir_lib/libsysdecode --- ===> lib/libsysdecode (all) make[5]: make[5]: don't know how to make /export/obj/opt/src/svn-current /amd64.amd64/obj-lib32/tmp/sys/netinet/in.h. Stop make[5]: stopped in /opt/src/svn-current/lib/libsysdecode -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.