From owner-svn-src-stable@freebsd.org Sun Feb 11 17:09:44 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8B4DF06086; Sun, 11 Feb 2018 17:09:44 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F56E8105D; Sun, 11 Feb 2018 17:09:43 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 80E3E1DFF8; Sun, 11 Feb 2018 18:09:42 +0100 (CET) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_B5CEA6CA-1D2A-4A47-AD7B-EA05B59FAFCB"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r328973 - in stable/11: include sys/sys Date: Sun, 11 Feb 2018 18:09:36 +0100 In-Reply-To: <28983217-7cbf-6ef8-8197-de122af9bf6f@FreeBSD.org> Cc: Hans Petter Selasky , Antoine Brodin , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org, re To: Pedro Giffuni References: <201802071506.w17F6s5l043163@repo.freebsd.org> <28983217-7cbf-6ef8-8197-de122af9bf6f@FreeBSD.org> X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Feb 2018 17:09:44 -0000 --Apple-Mail=_B5CEA6CA-1D2A-4A47-AD7B-EA05B59FAFCB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 11 Feb 2018, at 17:54, Pedro Giffuni wrote: ... > While the lint mode definition was missing, I didn't merge the = attribute uses (r328237) on purpose as I knew they could bring issues. = Some rather broken ports like to take the standard headers and "fix" = them. In essence, any port that requires an attribute defined in = sys/cdefs.h is doing something wrong. >=20 > The most notable offender was GCC but I think that was fixed: in any = case, the last time I merged an attribute change I had to wait for the = next release to start using it. The "fixincludes" feature you are referring to was finally removed by Gerald in r444860 for gcc5, and for other gcc ports in later revisions: https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D444860 so both the latest quarterly and the current package collection should have no more gcc's with mangled system headers. -Dimitry --Apple-Mail=_B5CEA6CA-1D2A-4A47-AD7B-EA05B59FAFCB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWoB40AAKCRCwXqMKLiCW o6ZpAJ0SRuI7Mi9X2FxDnEDCH0/DBsFjPQCfXuW3GXP3ZMs+E4oPdspPXtfJErM= =NG6F -----END PGP SIGNATURE----- --Apple-Mail=_B5CEA6CA-1D2A-4A47-AD7B-EA05B59FAFCB--