From owner-svn-src-head@freebsd.org Thu Feb 15 03:52:25 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C66FF1C3F9 for ; Thu, 15 Feb 2018 03:52:25 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x22c.google.com (mail-yw0-x22c.google.com [IPv6:2607:f8b0:4002:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 17708802E9 for ; Thu, 15 Feb 2018 03:52:24 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x22c.google.com with SMTP id f12so7514671ywb.8 for ; Wed, 14 Feb 2018 19:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=TPS7dD6g7UgUP1Cc8iRJ960Olx+NvONeaULq/mBB/xQ=; b=F5QXnbw39F/VNe/Tan5FEFCLwfVKB5OqGkvMKAQA0lrgEWvCVeRSeNOE7fc8ohp9Ip WQK9FUFrEm4asms2YE/nepDh+wDo00av50t0YsBkwx6wRiGKgKWiTmgqk+DswsTDFUY9 2dkggfyO1pGjftou7Pd3mFUbxpNojQLpZ1508= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=TPS7dD6g7UgUP1Cc8iRJ960Olx+NvONeaULq/mBB/xQ=; b=Sv25g+u7ZjF2xckUU7/EaPKysDmxp2svrOfSsYUFtsj2WxjzEWXu/LrIrheEfoLpDF XM3SFWxqTdw2rC4XWuV9QgURKKx5Vv8S52/tRQ97R1yOVDyU1rD5HNRTplAkAcaMbw4Q VoSzbOnDJ2bWKbk/pHrKTVCHR7xswKC4L86LV/e1hjjifhcM3qa3ht28XImPvJW0uPOe lDW6DmrFOPD8SEHPit43xRq5y/Dq8eRAzlCUBFdzRQw9uRFwZfSJt9K8b5mH3Rywry67 7SOLjjVCsMhmyde4jI7dmx/YDi4aN4nCKgXqE2QOlpVqfEVeUJ3ZkF08ClaTLMZyOJUB aopw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=TPS7dD6g7UgUP1Cc8iRJ960Olx+NvONeaULq/mBB/xQ=; b=tc/Iife7mRfmutSmMI5iw60K/kz8rTeTjNXFyff7BlRRHKD7OAGLOmMbH/LKUPuwuz nm6sY5cWV0EJI6ZYJu/Hmz3UOrqZaaBv6TcBRNrGtWNEOJUmTNMf86EbdQ/YR9XehImh 8kv7PGdYOq2jMcFvFBhn0g/lQwwl3QgaGfdNb7IF7e3P2fSuirYxLwqTOmfJt7YQA3za 2NpSjvlcJexBX+GwyK5aWp/M6vxiLP+u3Linhz7Gz71UuKf6/LOPfTGeoIpiFcLg1YQx nhvKAp/jFg9iNHENGfJAiDafIknMGy4HttNeFb+ifgvzB5ydt9RGOeUVBlQQAtUtGbQu tx3A== X-Gm-Message-State: APf1xPD9hO1RYOLnImO8fxU+u582/UrsHRuXpN+/xoO8PG22Ef76c06h IoMOSmyFZXdW/4gNZIdDNqzZZw25jV2lGHULsLCsEA== X-Google-Smtp-Source: AH8x2247r2B3oq8M+PSCdEc6iWOxDCfieLxy2BDeajzQlWxH/JeQOon58s9ii3MAmUOOBeLbtN2U0O5spymvmdIQWyQ= X-Received: by 10.37.37.18 with SMTP id l18mr89941ybl.277.1518666744379; Wed, 14 Feb 2018 19:52:24 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 2002:a25:7107:0:0:0:0:0 with HTTP; Wed, 14 Feb 2018 19:51:53 -0800 (PST) In-Reply-To: References: <201802150322.w1F3Mrie018786@repo.freebsd.org> From: Eitan Adler Date: Wed, 14 Feb 2018 19:51:53 -0800 X-Google-Sender-Auth: hQZOgaKuW6-k6HEUWGefzSTwT9Y Message-ID: Subject: Re: svn commit: r329296 - head/sbin/devd To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 03:52:25 -0000 On 14 February 2018 at 19:48, Warner Losh wrote: > > > On Wed, Feb 14, 2018 at 8:39 PM, Warner Losh wrote: >> >> >> >> On Feb 14, 2018 8:23 PM, "Eitan Adler" wrote: >> >> Author: eadler >> Date: Thu Feb 15 03:22:53 2018 >> New Revision: 329296 >> URL: https://svnweb.freebsd.org/changeset/base/329296 >> >> Log: >> devd: don't pass &fds in useless parameters to select(2) >> >> select(2) should be declared as restrict. In addition the only fd in >> the fdset is open O_RDONLY, and it's not a socket that can provide OOB >> notifications, >> >> Reviewed by: ian, imp, vangyzen >> >> >> Don't put my name on this. I specifically and clearly objected to the >> change anf tld yoy not to do it. > > > Stupid phone... > > I specifically objected to this change. I said not to make it because it > wasn't necessary. You did it any way. Don't put "reviewed by" for that. Put > "objected to but I did it anyway by: imp" hrm.. rereading the thread I think I missed your original email. Only comment I saw was "poll is a better interface". Sorry for mis-stating your opinion. FTR I'd like to fix the declaration of select(2) anyways. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams