From owner-svn-doc-head@FreeBSD.ORG  Tue Nov 27 19:34:45 2012
Return-Path: <owner-svn-doc-head@FreeBSD.ORG>
Delivered-To: svn-doc-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id DBCC8EF3;
 Tue, 27 Nov 2012 19:34:45 +0000 (UTC)
 (envelope-from eadler@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id A6F5E8FC13;
 Tue, 27 Nov 2012 19:34:45 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
 by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qARJYjKH041513;
 Tue, 27 Nov 2012 19:34:45 GMT (envelope-from eadler@svn.freebsd.org)
Received: (from eadler@localhost)
 by svn.freebsd.org (8.14.5/8.14.5/Submit) id qARJYjnj041512;
 Tue, 27 Nov 2012 19:34:45 GMT (envelope-from eadler@svn.freebsd.org)
Message-Id: <201211271934.qARJYjnj041512@svn.freebsd.org>
From: Eitan Adler <eadler@FreeBSD.org>
Date: Tue, 27 Nov 2012 19:34:45 +0000 (UTC)
To: doc-committers@freebsd.org, svn-doc-all@freebsd.org,
 svn-doc-head@freebsd.org
Subject: svn commit: r40171 -
 head/en_US.ISO8859-1/books/arch-handbook/driverbasics
X-SVN-Group: doc-head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-doc-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the doc tree for head
 <svn-doc-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-doc-head>,
 <mailto:svn-doc-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-doc-head>
List-Post: <mailto:svn-doc-head@freebsd.org>
List-Help: <mailto:svn-doc-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-doc-head>,
 <mailto:svn-doc-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2012 19:34:46 -0000

Author: eadler
Date: Tue Nov 27 19:34:45 2012
New Revision: 40171
URL: http://svnweb.freebsd.org/changeset/doc/40171

Log:
  Minor tweaks to the example code that I had forgotten to migrate
  from code to documentation.
  
  Submitted by:	gonzo
  Approved by:	bcr (mentor)

Modified:
  head/en_US.ISO8859-1/books/arch-handbook/driverbasics/chapter.xml

Modified: head/en_US.ISO8859-1/books/arch-handbook/driverbasics/chapter.xml
==============================================================================
--- head/en_US.ISO8859-1/books/arch-handbook/driverbasics/chapter.xml	Tue Nov 27 18:32:37 2012	(r40170)
+++ head/en_US.ISO8859-1/books/arch-handbook/driverbasics/chapter.xml	Tue Nov 27 19:34:45 2012	(r40171)
@@ -307,7 +307,7 @@ static int
 echo_close(struct cdev *dev __unused, int fflag __unused, int devtype __unused, struct thread *p __unused)
 {
 
-	uprintf("Closing device \"echo.\"\n");
+	uprintf("Closing device \"echo\".\n");
 	return (0);
 }
 
@@ -347,6 +347,10 @@ echo_write(struct cdev *dev __unused, st
 
 	/* Copy the string in from user memory to kernel memory */
 
+	/*
+	 * We either write from the beginning or are appending - do
+	 * not allow ranom access.
+	 */
 	if (uio-&lt;uio_offset != 0 && (uio-&lt;uio_offset != echomsg-&lt;len))
 		return (EINVAL);
 
@@ -369,7 +373,6 @@ echo_write(struct cdev *dev __unused, st
 	echomsg-&lt;len += amt + 1;
 	uio-&lt;uio_offset += amt + 1;
 	echomsg-&lt;msg[echomsg-&lt;len - 1] = 0;
-	//echomsg-&lt;msg[BUFFERSIZE - 1] = '\n';
 
 	if (error != 0)
 		uprintf("Write failed: bad address!\n");
@@ -386,7 +389,7 @@ DEV_MODULE(echo,echo_loader,NULL);</prog
 &prompt.root; <userinput>cat /dev/echo</userinput>
 Opened device "echo" successfully.
 Test Data
-Closing device "echo."</screen>
+Closing device "echo".</screen>
 
     <para>Real hardware devices are described in the next chapter.</para>
   </sect1>