From owner-p4-projects@FreeBSD.ORG Wed Jan 9 00:16:17 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B375616A41A; Wed, 9 Jan 2008 00:16:16 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 639D816A417 for ; Wed, 9 Jan 2008 00:16:16 +0000 (UTC) (envelope-from peter@wemm.org) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.240]) by mx1.freebsd.org (Postfix) with ESMTP id 352A613C442 for ; Wed, 9 Jan 2008 00:16:16 +0000 (UTC) (envelope-from peter@wemm.org) Received: by an-out-0708.google.com with SMTP id c14so8157anc.13 for ; Tue, 08 Jan 2008 16:16:15 -0800 (PST) Received: by 10.100.57.6 with SMTP id f6mr33482800ana.113.1199836034887; Tue, 08 Jan 2008 15:47:14 -0800 (PST) Received: by 10.100.153.12 with HTTP; Tue, 8 Jan 2008 15:47:14 -0800 (PST) Message-ID: Date: Tue, 8 Jan 2008 15:47:14 -0800 From: "Peter Wemm" To: "Robert Watson" In-Reply-To: <20080104012425.N42109@fledge.watson.org> MIME-Version: 1.0 References: <200801032225.m03MPHAE060675@repoman.freebsd.org> <20080104012425.N42109@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Perforce Change Reviews Subject: Re: PERFORCE change 132434 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2008 00:16:17 -0000 On Jan 3, 2008 5:25 PM, Robert Watson wrote: > On Thu, 3 Jan 2008, Peter Wemm wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=132434 > > > > Change 132434 by peter@peter_daintree on 2008/01/03 22:24:56 > > > > Export the build uuid to the dump header. Nothing interesting is > done > > with it at this point. > > > > While here, move all the mkdumpheader() copies into a MI place, as > > the (duplicated) comment suggested. Allow magic numbers to be > passed > > through so textdumps can share the code too. > > Currently, I duplicate the panic string and kernel version string from the > dump header in the textdump itself as data files. Any chance you want to > do > the same with the uuid? > > (Perhaps a better model would be to have savecore append another file to > the > textdump containing the header information, but the above seems to work > fine > for now, and has some advantages). > I was originally planning to put the uuid in the minidump header. But, I believe that savecore will store the uuid in the info.xxxx file. I have not actually tested this. Still, more copies is probably better than less. Granted, the version string is probably more than good enough given that it stores a build timestamp, but it wasn't really meant for that. The build uuid is meant to guarantee the ability to conclusively match between a kernel dump and the actual source kernel file. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5