From owner-svn-src-head@freebsd.org Thu Apr 6 00:18:32 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B925D30AA7; Thu, 6 Apr 2017 00:18:32 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D0939B8A; Thu, 6 Apr 2017 00:18:31 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id vv82c3IFOsa1kvv83c6k3q; Wed, 05 Apr 2017 18:18:24 -0600 X-Authority-Analysis: v=2.2 cv=W+NIbVek c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=8nJEP1OIZ-IA:10 a=AzvcPWV-tVgA:10 a=BWvPGDcYAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=RFjTbgNEwdGhDpzFgGUA:9 a=wPNLvfGTeEIA:10 a=pxhY87DP9d2VeQe4joPk:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 39A78A83; Wed, 5 Apr 2017 17:18:22 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v360IL31061110; Wed, 5 Apr 2017 17:18:21 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201704060018.v360IL31061110@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316487 - head/etc In-Reply-To: Message from =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= of "Thu, 06 Apr 2017 00:26:40 +0200." <861st64hjz.fsf@desk.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Wed, 05 Apr 2017 17:18:21 -0700 X-CMAE-Envelope: MS4wfEbm8R1IHSOSNfe+fhvay4b0z2+KcvMOsz+0t4k6E2NRglbqytncSw3WoBvO7V/dhz5/LTi0wl8uVJwytuguuArDK7zny6HPAMXO1UVlHsIxz2mwctJU wJa2JafT0AuNeJD10LGnI7R/fMZ/eIeDlHMF70hnsTz2WWV9WAkKpF48mXHWDSqc/t9qIuTFYetzi+jHQY3c1nwpEKKMKb0LnLT5ispIhAlBRvuJaPHsZF/l tEChhlC7COru6oqxHg1CEXXevyTC1/Fk7GdhcS44x4E= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 00:18:32 -0000 In message <861st64hjz.fsf@desk.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav? = w rites: > Cy Schubert writes: > > This patch caused some boot failures because the contents of rc_force were > > redefined from "yes" (for yes) and NULL (for no) to the words "yes" and > > "no". This in turn caused etc/rc.d/dhclient to assume force when $rc_force > > was not NULL (test -z failed). Interfaces with static IP addresses invoked > > rc.d/dhclient through devd. The attached patch should make all instances > > $rc_force consistent with your change. > > Yes, I just realized. I committed the wrong version of the patch. I > had a version in a different tree which added check_force > etc. functions. > > Could you please revert? I'd like to spend a little more time making > sure I get everything right. Sure, it's been reverted. People will need to remember to not run mergemaster or avoid updating rc.subr until the final version is committed or dhclient will *always* be started by devd regardless of rc.conf. Are you thinking of a more intrusive change like my first draft of the patch? ngie@ suggested that there be an UPDATING entry. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.