From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 11:45:34 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 52C76E9B; Tue, 19 Nov 2013 11:45:34 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CD9682A01; Tue, 19 Nov 2013 11:45:33 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rAJBjVrq068086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 19 Nov 2013 15:45:31 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rAJBjVAx068085; Tue, 19 Nov 2013 15:45:31 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 19 Nov 2013 15:45:31 +0400 From: Gleb Smirnoff To: Steve Kiernan Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131119114531.GF7577@glebius.int.ru> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> <20131116084919.GF7577@glebius.int.ru> <1DAF9090-08DA-404B-B86B-57E5D124D70D@xcllnt.net> <20131118164149.GV7577@glebius.int.ru> <20131118143508.0253e663@stevek-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131118143508.0253e663@stevek-ubuntu> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: freebsd-net@freebsd.org, luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org, Marcel Moolenaar X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 11:45:34 -0000 Steve, On Mon, Nov 18, 2013 at 02:35:08PM -0500, Steve Kiernan wrote: S> > Have you measured the performance impact on the loadable stack? I S> > suppose many functions, that are now called directly, with loadable S> > stack will be called via functon pointers. S> S> No, only a small number of functions were needed to be methods in a S> netstack kobj in the current implementation that we have. And some of S> those may need to change, as they revolve around NFS exports. S> S> Currently, we have four (4) methods that are needed: S> socreate S> vfs_export S> vfs_setpublicfs S> vfs_stdcheckexp S> S> When one is not dealing with NFS exports, only the socreate method is S> of interest. It is called just before mac_socket_create() would be S> called in socreate(). Sounds okay. Thank you. S> See http://people.freebsd.org/~marcel/Juniper/netstack-v2.diff, which S> is the full patch set that had been previously sent out. Some things S> have changed a bit since then, but if you look for curnetstack usage S> in the patch, you should be able to see the places where netsack S> methods are called. The patch is quite huge to understand it as a whole. :) -- Totus tuus, Glebius.