From owner-cvs-all@FreeBSD.ORG  Wed Jun 20 02:04:35 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C282E16A41F;
	Wed, 20 Jun 2007 02:04:35 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id A9FAD13C469;
	Wed, 20 Jun 2007 02:04:35 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 4083A1A4D80; Tue, 19 Jun 2007 19:03:44 -0700 (PDT)
Date: Tue, 19 Jun 2007 19:03:44 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Message-ID: <20070620020344.GI98795@elvis.mu.org>
References: <200706182249.l5IMnE4H099470@repoman.freebsd.org>
	<467863E0.2040906@FreeBSD.org>
	<20070619232125.GA750@rot13.obsecurity.org>
	<4678653B.8070409@FreeBSD.org>
	<20070619232451.GA872@rot13.obsecurity.org>
	<4678663E.2060204@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4678663E.2060204@FreeBSD.org>
User-Agent: Mutt/1.4.2.2i
Cc: cvs-src@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org, Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2007 02:04:35 -0000

* Maxim Sobolev <sobomax@FreeBSD.org> [070619 16:28] wrote:
> Kris Kennaway wrote:
> >On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote:
> >>Kris Kennaway wrote:
> >>>On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote:
> >>>>I have made the following patch to bring style(9) back and make code 
> >>>>more readable. Do you guys want to run it on bento or could I just 
> >>>>check it in?
> >>>>
> >>>>http://sobomax.homeunix.org/~sobomax/deps.c.diff
> >>>Is md5 checksum the same before/after?
> >>Well, it has some trivial non-whitespace changes.
> >
> >whitespace in source does not show up in the binary.
> 
> Please re-read my message. It has NON-whitespace changes as well.
> 
> -Maxim

lol.. he means does the resulting binary have the same md5?

if it's just style changes, then it should.

also, you missed a non-style conformant function.

 void list_deps(const char *pkgname, char **pkgs, char *listed, 

that should be:

void
list_deps

-- 
- Alfred Perlstein