From owner-svn-ports-head@FreeBSD.ORG Sat Jan 25 08:56:10 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 5A5E91B1; Sat, 25 Jan 2014 08:56:10 +0000 (UTC) Date: Sat, 25 Jan 2014 08:56:10 +0000 From: Alexey Dokuchaev To: Marcus von Appen Subject: Re: svn commit: r340996 - in head/lang: python python2 python3 Message-ID: <20140125085610.GA38716@FreeBSD.org> References: <201401250846.s0P8kBI1007669@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201401250846.s0P8kBI1007669@svn.freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 08:56:10 -0000 On Sat, Jan 25, 2014 at 08:46:11AM +0000, Marcus von Appen wrote: > New Revision: 340996 > URL: http://svnweb.freebsd.org/changeset/ports/340996 > QAT: https://qat.redports.org/buildarchive/r340996/ > > - ${LN} -sf ${PREFIX}/bin/${file}${PYTHON_MAJOR_VER} ${PREFIX}/bin/${file} > + ${LN} -sf ${PREFIX}/bin/${file}${PYTHON_MAJOR_VER} \ > + ${STAGEDIR}${PREFIX}/bin/${file} > [ ... lots of similar changes skipped ... ] Per our own wiki.freebsd.org/ports/StageDir: "When creating a symlink, prepend ${STAGEDIR} to the target path only (and generally try to avoid using absolute paths in source). [...] Note that source of ${PREFIX}/lib/libfoo.so.42, while seemingly okay, could be in fact incorrect, since absolute path can potentially point to a wrong location, e.g. when remote filesystem (with installed package) is mounted via NFS under non-root mount point. Relative paths are less fragile (and often much shorter)." ./danfe