Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Jan 2014 17:14:11 +0800
From:      Martin Wilke <miwi.fbsd@gmail.com>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r340970 - head/devel/premake
Message-ID:  <CAFY%2ByEnyBz0hb6y49iiHOjHSvy-WuoBuTW90%2Bvm_6z9voFcJSw@mail.gmail.com>
In-Reply-To: <20140125064631.GA96178@FreeBSD.org>
References:  <201401250043.s0P0h0RO021017@svn.freebsd.org> <20140125064631.GA96178@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
And your commenting about style worries maintainer and committers so better
reread last line in motd at freefall.

thanks ;)


On Sat, Jan 25, 2014 at 2:46 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Sat, Jan 25, 2014 at 12:43:00AM +0000, Baptiste Daroussin wrote:
> > New Revision: 340970
> > URL: http://svnweb.freebsd.org/changeset/ports/340970
> > QAT: https://qat.redports.org/buildarchive/r340970/
> >
> > @@ -7,28 +7,24 @@ PORTREVISION=       1
> >  CATEGORIES=  devel
> >  MASTER_SITES=        SF/${PORTNAME}/Premake/${PORTVERSION}
> >  DISTNAME=    ${PORTNAME}-src-${PORTVERSION}
> > +EXTRACT_SUFX=        .zip
> >
> >  MAINTAINER=  lippe@FreeBSD.org
> >  COMMENT=     Writes build scripts
> >
> > +OPTIONS_DEFINE=      DOCS
>
> This change was not reflected in commit log.
>
> > -USE_DOS2UNIX=        yes
> > -USE_ZIP=     yes
> > -USE_GMAKE=   yes
> > +USES=                gmake dos2unix
>
> Ditto.  Guys, I know some of you are working on stagifying the tree very
> actively these days, making tens to hundreds commits a day.  This is all
> much appreciated, cool, and awesome, but it does not mean commit messages
> can become sloppy.  Moreover, it gives a bad example for other people.
>
> ./danfe
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY%2ByEnyBz0hb6y49iiHOjHSvy-WuoBuTW90%2Bvm_6z9voFcJSw>