Date: Mon, 11 Aug 2014 14:12:55 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 190649] [MAINTAINER] net-mgmt/isic: Fix build in 9.1 Message-ID: <bug-190649-13-Z7LeFErvCy@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-190649-13@https.bugs.freebsd.org/bugzilla/> References: <bug-190649-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190649 --- Comment #6 from Thomas Zander <riggs@FreeBSD.org> --- Thanks for the extra info, appreciate it. I read through the code of isic a bit to learn what the fuzz with the RAND_MAX check in that include file is all about. Long story short: My suggestion would be to simply remove the utterly useless[1] test from the header file. I'd just remove this part of isic.h entirely: /* We want a random function that returns 0 to 0x7fff */ #if ( RAND_MAX != 2147483647 ) /* expect signed long */ #error Random IP generation broken: unexpected RAND_MAX. #endif or change the test to RAND_MAX != RAND_MAX if the patch should be minimal :-) Then you can remove the test for OSVERSION in the port Makefile as well, hence simplify it. Since there is already files/patch-isic.h , we can just append the removal of these lines to it. Let me know if you want me to commit this. Thanks again for your quick response. [1] rand() function is specifically not designed to produce high quality random numbers anyway. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-190649-13-Z7LeFErvCy>