From owner-freebsd-threads@FreeBSD.ORG Fri Jul 13 23:43:08 2012 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41792106566C; Fri, 13 Jul 2012 23:43:08 +0000 (UTC) (envelope-from listlog2011@gmail.com) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 115DE8FC0A; Fri, 13 Jul 2012 23:43:08 +0000 (UTC) Received: from xp5k.my.domain (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6DNh6jI074641; Fri, 13 Jul 2012 23:43:07 GMT (envelope-from listlog2011@gmail.com) Message-ID: <5000B280.3040107@gmail.com> Date: Sat, 14 Jul 2012 07:42:56 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120628 Thunderbird/13.0.1 MIME-Version: 1.0 To: Jilles Tjoelker References: <201207120800.q6C80ISC073892@freefall.freebsd.org> <20120713210547.GA67646@stack.nl> In-Reply-To: <20120713210547.GA67646@stack.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: David Xu , freebsd-threads@freebsd.org Subject: Re: threads/168417: pthread_getcpuclockid() does not work to specification X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: davidxu@freebsd.org List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 23:43:08 -0000 On 2012/07/14 05:05, Jilles Tjoelker wrote: > On Thu, Jul 12, 2012 at 08:00:18AM +0000, David Xu wrote: >> The following reply was made to PR threads/168417; it has been noted >> by GNATS. >> From: David Xu >> To: bug-followup@freebsd.org, chris.hall@highwayman.com >> Cc: >> Subject: Re: threads/168417: pthread_getcpuclockid() does not work to specification >> Date: Thu, 12 Jul 2012 15:51:02 +0800 >> I have worked out a patch trying to fix the problem: >> http://people.freebsd.org/~davidxu/patch/cputime_clockid.diff > Some comments: > > * Should clock_getcpuclockid() and clock_getthreadcpuclockid() be > syscalls or can the 2**31 reserved clock ids be hard-coded into libc > just like the other clock ids are? why should I hard-code it ? is syscall so horrible ? why can't you cache the thread's clock id if you want to frequently access it? it is not gettimeofday which returns different value each time. If it is hard-coded, how do I check if the pid is valid or I have permission to get its CPU time? should clock_getcpuclockid always return successfully ? > * Perhaps clock_getcpuclockid() should check if the pid is valid. Yes > * I think p_canwait() is not the right permission check. The p_canwait() > check is for wait4() and takes into account that denying at that point > completely breaks the process's tracking of its child processes. The > right permission check is probably p_cansee() because that's what the > kern.proc.* sysctls that return CPU time also check. The recently > added pget() function can perform pfind() and p_cansee() in one call. Yes, p_cansee seems to be more wide, while p_canwait has better granularity, it does seem not very right. > * Why can a thread's CPU clock only be read from the same process? The > kern.proc.* sysctls allow querying any thread whose process you > p_cansee. However, the POSIX APIs only allow accessing threads within > the process because there is no pthread_t for other threads. At the time, I am only programming for POSIX, and thread can not be seen by other processes.