From nobody Tue Jan 27 19:16:21 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f0w9y1x9xz6QHrf for ; Tue, 27 Jan 2026 19:16:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f0w9x3y0Zz3Dyq for ; Tue, 27 Jan 2026 19:16:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769541381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zWQJpOEbbfVXvzxEaXLMmnMve5cASiVW/D9qD517R5E=; b=iDBpqwM5NM/mWaU4nr2VyJ5iInsgwvvLowLUr8EeVvh76FrF5ZfqRrzRLrpt48gCeZYB4k 50YLrb+ElKUIlKmiBdgoPbuX/Om8FPLWlOE6t0VGbhy75O6uhXeJwn/GRmu4Uk9ETImK+y /TyardQfZFXbUgqZFpQuTZwYJpjbvVIvOQWZ7lrTg9m04vFvFR3TnwJssWZXHi4xZ76Pw8 ez3U39rIkusKtjGkFuU6zWlDrLDY1UB7xLr/EccPMAXaRoF1mCdXoj4T6+5B+PMPI5JHyt N1Qymcpu4iMf3GOG4nltCG2mVa+I77PbdVjCAbUklHblKcxwMzyXJZGji6gZJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769541381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zWQJpOEbbfVXvzxEaXLMmnMve5cASiVW/D9qD517R5E=; b=QADLBPE9TZuHP3aOx+x9WaBCLylrPngMjyyAvDmgnLylYp24hRN1osL8B8jeQBX1nEsx5I qQvJ7IuaPvpdPGTzNU3M7LpRMDguDiamTe9DDWEeRuDm76WvojfKiYD1TxrgBLk/5pRIKP M0ULEtnYrXuJpnrCjuLa+oDfjEPwNRN+XHOsnZQxQuxLLoR020VLzYlZoShDv+R1+Mb4M9 bR/GM3nwGYaoFTbULV97xBm8KR34v0NYH4lar6n+N6Kq2JSiISIlgdOfxXemVKfHi8Mztf q/7SYGHZY0VftNUsmNItf+zgwA0NbgLnIwgyJrGarc85EXVxPA8tu5HDjjbe0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769541381; a=rsa-sha256; cv=none; b=H8Hhdp/i6BzatYLdxJf+Zz6i26PBc5Wg8ZOxE0u4/6YTJDCuTz9zCnsyx2313bL+jHjhqk jRihlCkx5gpITliwT0eSNfqJREoBTp+0sGOMH3Rapy1nIXRKnSuqDczD7VFsqEAOoM/6sL 51Q/9ygOS/pfFjIHhFyN9xTsWuNPT6q0I16xRlWNuAKCCPZj/WOm/wNTEeR8G7W7C3E5Zv Ju6FTqcuq5qa0esumnSHBRHHzhrT3TXaS3XoxMwKDQQPV3egHIMohzoG0ShU01VvRAGR17 mFc5eFhs1htVfGcixbrEBv1Ex0EbACMIMDcibtizPzgPQ/RAmj6E/ggpWlCHaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f0w9x3Vswz4Th for ; Tue, 27 Jan 2026 19:16:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 210ea by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Jan 2026 19:16:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 403702f9ce6b - releng/14.3 - tests: Add a regression test for commit 7587f6d4840f8 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.3 X-Git-Reftype: branch X-Git-Commit: 403702f9ce6bdfa48115e6291df2f54e42cefec0 Auto-Submitted: auto-generated Date: Tue, 27 Jan 2026 19:16:21 +0000 Message-Id: <69790f05.210ea.289632db@gitrepo.freebsd.org> The branch releng/14.3 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=403702f9ce6bdfa48115e6291df2f54e42cefec0 commit 403702f9ce6bdfa48115e6291df2f54e42cefec0 Author: Mark Johnston AuthorDate: 2025-05-28 15:28:36 +0000 Commit: Mark Johnston CommitDate: 2026-01-26 16:49:29 +0000 tests: Add a regression test for commit 7587f6d4840f8 Approved by: so Reviewed by: kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D50533 (cherry picked from commit a5dac34f6e98c47bd7cb1946e39cc45432e167a8) (cherry picked from commit f56b66f1260a33e49c65bbc05213ec8267978a93) --- tests/sys/kern/Makefile | 2 + tests/sys/kern/jail_lookup_root.c | 171 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 173 insertions(+) diff --git a/tests/sys/kern/Makefile b/tests/sys/kern/Makefile index b6333c9f04f3..846ac3e4adc9 100644 --- a/tests/sys/kern/Makefile +++ b/tests/sys/kern/Makefile @@ -17,6 +17,7 @@ ATF_TESTS_C+= kcov ATF_TESTS_C+= kern_copyin ATF_TESTS_C+= kern_descrip_test ATF_TESTS_C+= fdgrowtable_test +ATF_TESTS_C+= jail_lookup_root ATF_TESTS_C+= kill_zombie .if ${MK_OPENSSL} != "no" ATF_TESTS_C+= ktls_test @@ -69,6 +70,7 @@ PROGS+= coredump_phnum_helper PROGS+= pdeathsig_helper PROGS+= sendfile_helper +LIBADD.jail_lookup_root+= jail util CFLAGS.sys_getrandom+= -I${SRCTOP}/sys/contrib/zstd/lib LIBADD.sys_getrandom+= zstd LIBADD.sys_getrandom+= c diff --git a/tests/sys/kern/jail_lookup_root.c b/tests/sys/kern/jail_lookup_root.c new file mode 100644 index 000000000000..609f86ac4c66 --- /dev/null +++ b/tests/sys/kern/jail_lookup_root.c @@ -0,0 +1,171 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2025 Mark Johnston + */ + +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +#include + +static void +build_iovec(struct iovec **iov, int *iovlen, const char *name, void *val, + size_t len) +{ + int i; + + if (*iovlen < 0) + return; + i = *iovlen; + *iov = realloc(*iov, sizeof **iov * (i + 2)); + if (*iov == NULL) { + *iovlen = -1; + return; + } + (*iov)[i].iov_base = strdup(name); + (*iov)[i].iov_len = strlen(name) + 1; + i++; + (*iov)[i].iov_base = val; + if (len == (size_t)-1) { + if (val != NULL) + len = strlen(val) + 1; + else + len = 0; + } + (*iov)[i].iov_len = (int)len; + *iovlen = ++i; +} + +static void +free_iovec(struct iovec **iov, int *iovlen) +{ + int i; + + for (i = 0; i < *iovlen; i += 2) + free((*iov)[i].iov_base); + free(*iov); +} + +static void +mkdir_checked(const char *dir, mode_t mode) +{ + int error; + + error = mkdir(dir, mode); + ATF_REQUIRE_MSG(error == 0 || errno == EEXIST, + "mkdir %s: %s", dir, strerror(errno)); +} + +static void __unused +mount_nullfs(const char *dir, const char *target) +{ + struct iovec *iov; + char errmsg[1024]; + int error, iovlen; + + iov = NULL; + iovlen = 0; + + build_iovec(&iov, &iovlen, __DECONST(char *, "fstype"), + __DECONST(char *, "nullfs"), (size_t)-1); + build_iovec(&iov, &iovlen, __DECONST(char *, "fspath"), + __DECONST(char *, target), (size_t)-1); + build_iovec(&iov, &iovlen, __DECONST(char *, "from"), + __DECONST(char *, dir), (size_t)-1); + build_iovec(&iov, &iovlen, __DECONST(char *, "errmsg"), + errmsg, sizeof(errmsg)); + + errmsg[0] = '\0'; + error = nmount(iov, iovlen, 0); + ATF_REQUIRE_MSG(error == 0, "nmount: %s", + errmsg[0] != '\0' ? errmsg : strerror(errno)); + + free_iovec(&iov, &iovlen); +} + +ATF_TC_WITH_CLEANUP(jail_root); +ATF_TC_HEAD(jail_root, tc) +{ + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(jail_root, tc) +{ + int error, fd, jid; + + mkdir_checked("./root", 0755); + mkdir_checked("./root/a", 0755); + mkdir_checked("./root/b", 0755); + mkdir_checked("./root/a/c", 0755); + + jid = jail_setv(JAIL_CREATE | JAIL_ATTACH, + "name", "nullfs_jail_root_test", + "allow.mount", "true", + "allow.mount.nullfs", "true", + "enforce_statfs", "1", + "path", "./root", + "persist", NULL, + NULL); + ATF_REQUIRE_MSG(jid >= 0, "jail_setv: %s", jail_errmsg); + + mount_nullfs("/a", "/b"); + + error = chdir("/b/c"); + ATF_REQUIRE(error == 0); + + error = rename("/a/c", "/c"); + ATF_REQUIRE(error == 0); + + /* Descending to the jail root should be ok. */ + error = chdir(".."); + ATF_REQUIRE(error == 0); + + /* Going beyond the root will trigger an error. */ + error = chdir(".."); + ATF_REQUIRE_ERRNO(ENOENT, error != 0); + fd = open("..", O_RDONLY | O_DIRECTORY); + ATF_REQUIRE_ERRNO(ENOENT, fd < 0); +} +ATF_TC_CLEANUP(jail_root, tc) +{ + struct statfs fs; + fsid_t fsid; + int error, jid; + + error = statfs("./root/b", &fs); + if (error != 0) + err(1, "statfs ./b"); + fsid = fs.f_fsid; + error = statfs("./root", &fs); + if (error != 0) + err(1, "statfs ./root"); + if (fsid.val[0] != fs.f_fsid.val[0] || + fsid.val[1] != fs.f_fsid.val[1]) { + error = unmount("./root/b", 0); + if (error != 0) + err(1, "unmount ./root/b"); + } + + jid = jail_getid("nullfs_jail_root_test"); + if (jid >= 0) { + error = jail_remove(jid); + if (error != 0) + err(1, "jail_remove"); + } +} + +ATF_TP_ADD_TCS(tp) +{ + ATF_TP_ADD_TC(tp, jail_root); + return (atf_no_error()); +}