From owner-freebsd-gnome@freebsd.org Tue Jun 6 02:03:39 2017 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BC81B943B2 for ; Tue, 6 Jun 2017 02:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 7FEF777C6B for ; Tue, 6 Jun 2017 02:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 7F601B943B1; Tue, 6 Jun 2017 02:03:39 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F095B943B0 for ; Tue, 6 Jun 2017 02:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B00277C65 for ; Tue, 6 Jun 2017 02:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5623dbQ055390 for ; Tue, 6 Jun 2017 02:03:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 219608] print/freetype2 produces incorrect line spacing for some fonts : [Attachment 183251] Proposed patch for print/freetype2 (since 441132) Date: Tue, 06 Jun 2017 02:03:38 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 02:03:39 -0000 lightside has asked gnome@FreeBSD.org for maintainer-approval: Bug 219608: print/freetype2 produces incorrect line spacing for some fonts https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219608 Attachment 183251: Proposed patch for print/freetype2 (since 441132) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183251&action=3Dedit --- Comment #18 from lightside --- Created attachment 183251 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183251&action= =3Dedit Proposed patch for print/freetype2 (since 441132) > I would like something to clarify the meaning of the TT_SIZE_METRICS_ALL > option, though. I don't think much of anyone will realize what it means > (not that I have a better idea. I'd really like "Restore traditional True= Type > line spacing", but that is not quite correct. It was "TT_SIZE_METRICS_ALT", but showed in terminal as "TT_SIZE_METRICS_AL= ". The _ALT postfix used as for "alternative" meaning. I decided to rename TT_SIZE_METRICS_ALT option to FIX_SIZE_METRICS with following description: "Fix metrics on size request for scalable fonts (alternative method)". The main part of description is used from following commit: "[truetype] Fix metrics on size request for scalable fonts." http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=3Db0962a= c34e66 052ccfee7996e5468f30d4bd5a72 Also created OPTIONS_RADIO (0 or 1 among N) for FIX_SIZE_METRICS and TT_SIZE_METRICS options, because they are alternative methods, in my opinio= n, but implemented in different places (TrueType driver (src/truetype/ttdriver= .c) or auto-hinter/auto-fitter code (src/autofit/afloader.c)).