From owner-freebsd-current@FreeBSD.ORG Thu Nov 10 17:15:16 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0516D106566C; Thu, 10 Nov 2011 17:15:16 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9A05F8FC0A; Thu, 10 Nov 2011 17:15:15 +0000 (UTC) Received: by vcbfo14 with SMTP id fo14so3808929vcb.13 for ; Thu, 10 Nov 2011 09:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Dk6mgFsgyIoLwD4/QqfOwIFPK5aONaZw7dELYp0BHck=; b=Bz2vf1RyIQvmV+HKCOdvnWwLvIefgrRJoAFrFO7pqt/by5e6eEwkAcULf2Df2GV4VI L/DJ0H8/6iW2Y0H8AAgGa80ezaRmJWlGQRYg3RUyfqJr5LC4jPMjUkxM1SGfMdD/iB9B B61+ov+W1lm4i3/QmLyM1VBH3JaS+QVO64Exg= MIME-Version: 1.0 Received: by 10.52.24.210 with SMTP id w18mr14279089vdf.21.1320945314817; Thu, 10 Nov 2011 09:15:14 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.29.198 with HTTP; Thu, 10 Nov 2011 09:15:14 -0800 (PST) In-Reply-To: References: <201111100705.pAA75eIT023291@freebsd-current.sentex.ca> <4EBB7A0A.20700@FreeBSD.org> Date: Thu, 10 Nov 2011 09:15:14 -0800 X-Google-Sender-Auth: 0jHeGJJLY2Jl2DFZotMx2FmXXuU Message-ID: From: Adrian Chadd To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Cc: current@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2011 17:15:16 -0000 Hi, The problem right now is that when the code is compiled as a module, it sucks in -all- of the chipset support rather than only a subset. So there are two problems: * AH_SUPPORT_AR5416 is still needed to build the driver and HAL, and * the module builds all chipset support, whether or not AH_SUPPORT_AR5416 is defined. I notice that some modules do check whether VIMAGE is defined (.if defined(VIMAGE)) - is there some equally evil way that I can propagate some build time options to the module build to specify which modules are built, based on the existance or not of AH_SUPPORT_AR5416? (It gets messier, as at least two wireless SoC modules just don't need to be built unless the user definitely wants them to be.) I still think the correct thing to do at the present time is to explicitly not build the ath modules unless the architecture can use it, and if it can use it, build them with explicit net80211/ath configuration. Otherwise you end up with modules/kernel being out of sync in terms of configuration. For example, a user reported (and this is why I "fixed" sys/modules/ath/Makefile) that they had added ATH_DEBUG and AH_DEBUG - but because the Makefile overrides opt_ah.h regardless of whether it exists or not, it didn't include the debugging code. Similar hilarity occurs with/without IEEE80211_TDMA and IEEE80211_DEBUG for example. Thanks, Adrian